mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-23 18:05:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

remote: let guess_remote_head() optionally return all matches

Browse Source 
Determining HEAD is ambiguous since it is done by comparing SHA1s.

In the case of multiple matches we return refs/heads/master if it
matches, else we return the first match we encounter. builtin-remote
needs all matches returned to it, so add a flag for it to request such.

To be simple and consistent, the return value is now a copy (including
peer_ref) of the matching refs.

Originally contributed by Jeff King along with the prior commit as a
single patch.

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jay Soffian 2009-02-27 14:10:05 -05:00 committed by Junio C Hamano
parent 7b3db095d5
commit 4229f1fa32
3 changed files with 28 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin-clone.c
View File

@ -510,7 +510,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
mapped_refs = write_remote_refs(refs, &refspec, reflog_msg.buf); mapped_refs = write_remote_refs(refs, &refspec, reflog_msg.buf);
remote_head = find_ref_by_name(refs, "HEAD"); remote_head = find_ref_by_name(refs, "HEAD");
head_points_at = guess_remote_head(remote_head, mapped_refs); head_points_at = guess_remote_head(remote_head, mapped_refs, 0);
} }
else { else {
warning("You appear to have cloned an empty repository."); warning("You appear to have cloned an empty repository.");

29
remote.c
View File

@ -1460,24 +1460,33 @@ struct ref *get_local_heads(void)
return local_refs; return local_refs;
} }
const struct ref *guess_remote_head(const struct ref *head, struct ref *guess_remote_head(const struct ref *head,
const struct ref *refs) const struct ref *refs,
int all)
{ {
const struct ref *r; const struct ref *r;
struct ref *list = NULL;
struct ref **tail = &list;
if (!head) if (!head)
return NULL; return NULL;
/* If refs/heads/master could be right, it is. */ /* If refs/heads/master could be right, it is. */
r = find_ref_by_name(refs, "refs/heads/master"); if (!all) {
if (r && !hashcmp(r->old_sha1, head->old_sha1)) r = find_ref_by_name(refs, "refs/heads/master");
return r; if (r && !hashcmp(r->old_sha1, head->old_sha1))
return copy_ref(r);
}
/* Look for another ref that points there */ /* Look for another ref that points there */
for (r = refs; r; r = r->next) for (r = refs; r; r = r->next) {
if (r != head && !hashcmp(r->old_sha1, head->old_sha1)) if (r != head && !hashcmp(r->old_sha1, head->old_sha1)) {
return r; *tail = copy_ref(r);
tail = &((*tail)->next);
if (!all)
break;
}
}
/* Nothing is the same */ return list;
return NULL;
} }

14
remote.h
View File

@ -139,12 +139,14 @@ int stat_tracking_info(struct branch *branch, int *num_ours, int *num_theirs);
int format_tracking_info(struct branch *branch, struct strbuf *sb); int format_tracking_info(struct branch *branch, struct strbuf *sb);
struct ref *get_local_heads(void); struct ref *get_local_heads(void);
/* /*
* Look for a ref in refs whose SHA1 matches head, first checking if * Find refs from a list which are likely to be pointed to by the given HEAD
* refs/heads/master matches. Return NULL if nothing matches or if head * ref. If 'all' is false, returns the most likely ref; otherwise, returns a
* is NULL. * list of all candidate refs. If no match is found (or 'head' is NULL),
* returns NULL. All returns are newly allocated and should be freed.
*/ */
const struct ref *guess_remote_head(const struct ref *head, struct ref *guess_remote_head(const struct ref *head,
const struct ref *refs); const struct ref *refs,
int all);
#endif #endif