mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-12-04 23:44:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

test framework: further deprecate test_i18ngrep

Browse Source 
As an attempt to come up with a useful mechanism to ensure that
certain messages are left untranslated [*], we earlier wrote
GIT_TEST_GETTEXT_POISON off as a failed experiment.

But the output from the test helper was easier to use while
debugging failed tests, compared to the same test writtein with the
plain-vanilla "grep".  Especially when a test that expects a certain
string to appear in the output (e.g. "this test must fail with this
message") fails, "grep message output" would just silently fail and
in a &&-chained sequence of commands, it is hard to tell which step
failed.  test_i18ngrep explicitly said "we wanted to see a line that
match this pattern but did not see a hit in this file".

What we have as test_i18ngrep in our tree still retains this verbose
output (even though we got rid of the "poison" support).  Let's
rename it to test_grep (because it is no longer about i18n at all)
and then make test_i18ngrep a thin wrapper around it.  Existing
callers of test_i18ngrep can be mechanically rewritten to instead
use test_grep over time, but it does not have to be done in this
commit.

[Footnote]

 * The idea was that human-facing messages are often translated, but
   there are messages that should never be translated.  We use
   "grep" only for the latter kind of messages, and then run tests
   in "poison" mode that spew garbage for translatable messages.  If
   such a test run fails, it means these messages tested with "grep"
   were marked for translation by mistake.  test_i18ngrep was to be
   used for other messages that are to be translated, and was to
   always "succeed" when runing under the "poison" mode.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2023-10-31 14:23:29 +09:00
parent 43c8a30d15
commit 2e87fca189
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
t/test-lib-functions.sh
View File

@ -1208,14 +1208,16 @@ test_cmp_bin () {
cmp "$@" cmp "$@"
} }
# Wrapper for grep which used to be used for # Deprecated - do not use this in new code
# GIT_TEST_GETTEXT_POISON=false. Only here as a shim for other
# in-flight changes. Should not be used and will be removed soon.
test_i18ngrep () { test_i18ngrep () {
test_grep "$@"
}
test_grep () {
eval "last_arg=\${$#}" eval "last_arg=\${$#}"
test -f "$last_arg" || test -f "$last_arg" ||
BUG "test_i18ngrep requires a file to read as the last parameter" BUG "test_grep requires a file to read as the last parameter"
if test $# -lt 2 || if test $# -lt 2 ||
{ test "x!" = "x$1" && test $# -lt 3 ; } { test "x!" = "x$1" && test $# -lt 3 ; }