mirrors/git
0
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-25 02:44:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

git branch: avoid unnecessary object lookups

Browse Source 
They can be expensive in the cold-cache case, so don't bother looking up
the commits for all branches unless we really need them for some reason.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Linus Torvalds 2009-07-23 12:05:34 -07:00 committed by Junio C Hamano
parent e6e4a47ba1
commit 191d1ac435
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
builtin-branch.c
View File

@ -191,7 +191,7 @@ struct ref_item {
struct ref_list { struct ref_list {
struct rev_info revs; struct rev_info revs;
int index, alloc, maxwidth; int index, alloc, maxwidth, verbose;
struct ref_item *list; struct ref_item *list;
struct commit_list *with_commit; struct commit_list *with_commit;
int kinds; int kinds;
@ -244,17 +244,20 @@ static int append_ref(const char *refname, const unsigned char *sha1, int flags,
if ((kind & ref_list->kinds) == 0) if ((kind & ref_list->kinds) == 0)
return 0; return 0;
commit = lookup_commit_reference_gently(sha1, 1); commit = NULL;
if (!commit) if (ref_list->verbose || ref_list->with_commit || merge_filter != NO_FILTER) {
return error("branch '%s' does not point at a commit", refname); commit = lookup_commit_reference_gently(sha1, 1);
if (!commit)
return error("branch '%s' does not point at a commit", refname);
/* Filter with with_commit if specified */ /* Filter with with_commit if specified */
if (!is_descendant_of(commit, ref_list->with_commit)) if (!is_descendant_of(commit, ref_list->with_commit))
return 0; return 0;
if (merge_filter != NO_FILTER) if (merge_filter != NO_FILTER)
add_pending_object(&ref_list->revs, add_pending_object(&ref_list->revs,
(struct object *)commit, refname); (struct object *)commit, refname);
}
/* Resize buffer */ /* Resize buffer */
if (ref_list->index >= ref_list->alloc) { if (ref_list->index >= ref_list->alloc) {
@ -423,6 +426,7 @@ static void print_ref_list(int kinds, int detached, int verbose, int abbrev, str
memset(&ref_list, 0, sizeof(ref_list)); memset(&ref_list, 0, sizeof(ref_list));
ref_list.kinds = kinds; ref_list.kinds = kinds;
ref_list.verbose = verbose;
ref_list.with_commit = with_commit; ref_list.with_commit = with_commit;
if (merge_filter != NO_FILTER) if (merge_filter != NO_FILTER)
init_revisions(&ref_list.revs, NULL); init_revisions(&ref_list.revs, NULL);