From 06f3549d7146179c5cafe8f76e8fcbc064eba2f7 Mon Sep 17 00:00:00 2001 From: Jonathan Nieder Date: Sat, 2 Oct 2010 03:36:52 -0500 Subject: [PATCH] setup: make sure git dir path is in a permanent buffer If setup_git_env() is run before the usual repository discovery sequence and .git is a file with the text gitdir: (with any string) then the in-core git_dir variable is set to the result of converting to an absolute path using make_absolute_path(). Unfortunately make_absolute_path() returns its result in a static buffer that is overwritten by later calls. Such a call could cause later accesses to git_dir (from git_pathdup(), for example) to read the wrong path, leaving git very confused. It is not obvious whether any existing code in git will trigger the problem, but in any case, it is worth a few dozen bytes to copy the return value from make_absolute_path() for some added peace of mind. Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- environment.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/environment.c b/environment.c index c44a30be3e..de5581fe51 100644 --- a/environment.c +++ b/environment.c @@ -87,8 +87,10 @@ const char * const local_repo_env[LOCAL_REPO_ENV_SIZE + 1] = { static void setup_git_env(void) { git_dir = getenv(GIT_DIR_ENVIRONMENT); - if (!git_dir) + if (!git_dir) { git_dir = read_gitfile_gently(DEFAULT_GIT_DIR_ENVIRONMENT); + git_dir = git_dir ? xstrdup(git_dir) : NULL; + } if (!git_dir) git_dir = DEFAULT_GIT_DIR_ENVIRONMENT; git_object_dir = getenv(DB_ENVIRONMENT);