2018-07-11 14:46:36 +08:00
|
|
|
(
|
|
|
|
|
# LINT: stitch together incomplete \-ending lines
|
|
|
|
|
# LINT: swallow here-doc to avoid false positives in content
|
|
|
|
|
echo wobba \
|
|
|
|
|
gorgo snoot \
|
|
|
|
|
wafta snurb <<-EOF &&
|
|
|
|
|
quoth the raven,
|
|
|
|
|
nevermore...
|
|
|
|
|
EOF
|
|
|
|
|
|
2021-12-13 14:30:46 +08:00
|
|
|
# LINT: missing "&&" on "cat"
|
2018-07-11 14:46:36 +08:00
|
|
|
cat <<EOF >bip
|
|
|
|
|
fish fly high
|
2021-12-13 14:30:45 +08:00
|
|
|
EOF
|
2018-07-11 14:46:36 +08:00
|
|
|
|
|
|
|
|
# LINT: swallow here-doc (EOF is last line of subshell)
|
|
|
|
|
echo <<-\EOF >bop
|
|
|
|
|
gomez
|
|
|
|
|
morticia
|
|
|
|
|
wednesday
|
|
|
|
|
pugsly
|
|
|
|
|
EOF
|
chainlint: match arbitrary here-docs tags rather than hard-coded names
chainlint.sed swallows top-level here-docs to avoid being fooled by
content which might look like start-of-subshell. It likewise swallows
here-docs in subshells to avoid marking content lines as breaking the
&&-chain, and to avoid being fooled by content which might look like
end-of-subshell, start-of-nested-subshell, or other specially-recognized
constructs.
At the time of implementation, it was believed that it was not possible
to support arbitrary here-doc tag names since 'sed' provides no way to
stash the opening tag name in a variable for later comparison against a
line signaling end-of-here-doc. Consequently, tag names are hard-coded,
with "EOF" being the only tag recognized at the top-level, and only
"EOF", "EOT", and "INPUT_END" being recognized within subshells. Also,
special care was taken to avoid being confused by here-docs nested
within other here-docs.
In practice, this limited number of hard-coded tag names has been "good
enough" for the 13000+ existing Git test, despite many of those tests
using tags other than the recognized ones, since the bodies of those
here-docs do not contain content which would fool the linter.
Nevertheless, the situation is not ideal since someone writing new
tests, and choosing a name not in the "blessed" set could potentially
trigger a false-positive.
To address this shortcoming, upgrade chainlint.sed to handle arbitrary
here-doc tag names, both at the top-level and within subshells.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-08-13 16:47:34 +08:00
|
|
|
) &&
|
|
|
|
|
(
|
|
|
|
|
# LINT: swallow here-doc with arbitrary tag
|
|
|
|
|
cat <<-\ARBITRARY >bup &&
|
|
|
|
|
glink
|
|
|
|
|
FIZZ
|
|
|
|
|
ARBITRARY
|
2018-08-29 17:45:32 +08:00
|
|
|
cat <<-"ARBITRARY3" >bup3 &&
|
|
|
|
|
glink
|
|
|
|
|
FIZZ
|
|
|
|
|
ARBITRARY3
|
chainlint: match arbitrary here-docs tags rather than hard-coded names
chainlint.sed swallows top-level here-docs to avoid being fooled by
content which might look like start-of-subshell. It likewise swallows
here-docs in subshells to avoid marking content lines as breaking the
&&-chain, and to avoid being fooled by content which might look like
end-of-subshell, start-of-nested-subshell, or other specially-recognized
constructs.
At the time of implementation, it was believed that it was not possible
to support arbitrary here-doc tag names since 'sed' provides no way to
stash the opening tag name in a variable for later comparison against a
line signaling end-of-here-doc. Consequently, tag names are hard-coded,
with "EOF" being the only tag recognized at the top-level, and only
"EOF", "EOT", and "INPUT_END" being recognized within subshells. Also,
special care was taken to avoid being confused by here-docs nested
within other here-docs.
In practice, this limited number of hard-coded tag names has been "good
enough" for the 13000+ existing Git test, despite many of those tests
using tags other than the recognized ones, since the bodies of those
here-docs do not contain content which would fool the linter.
Nevertheless, the situation is not ideal since someone writing new
tests, and choosing a name not in the "blessed" set could potentially
trigger a false-positive.
To address this shortcoming, upgrade chainlint.sed to handle arbitrary
here-doc tag names, both at the top-level and within subshells.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-08-13 16:47:34 +08:00
|
|
|
meep
|
2018-07-11 14:46:36 +08:00
|
|
|
)
|