2011-08-04 18:39:11 +08:00
|
|
|
#include "cache.h"
|
2014-10-01 18:28:42 +08:00
|
|
|
#include "lockfile.h"
|
2011-08-04 18:39:11 +08:00
|
|
|
#include "sequencer.h"
|
|
|
|
#include "dir.h"
|
2012-01-12 02:15:57 +08:00
|
|
|
#include "object.h"
|
|
|
|
#include "commit.h"
|
|
|
|
#include "tag.h"
|
|
|
|
#include "run-command.h"
|
|
|
|
#include "exec_cmd.h"
|
|
|
|
#include "utf8.h"
|
|
|
|
#include "cache-tree.h"
|
|
|
|
#include "diff.h"
|
|
|
|
#include "revision.h"
|
|
|
|
#include "rerere.h"
|
|
|
|
#include "merge-recursive.h"
|
|
|
|
#include "refs.h"
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
#include "argv-array.h"
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
#define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION"
|
2011-08-04 18:39:11 +08:00
|
|
|
|
2012-09-14 14:52:03 +08:00
|
|
|
const char sign_off_header[] = "Signed-off-by: ";
|
2013-02-12 18:17:32 +08:00
|
|
|
static const char cherry_picked_prefix[] = "(cherry picked from commit ";
|
2012-09-14 14:52:03 +08:00
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
static GIT_PATH_FUNC(git_path_todo_file, SEQ_TODO_FILE)
|
|
|
|
static GIT_PATH_FUNC(git_path_opts_file, SEQ_OPTS_FILE)
|
|
|
|
static GIT_PATH_FUNC(git_path_seq_dir, SEQ_DIR)
|
|
|
|
static GIT_PATH_FUNC(git_path_head_file, SEQ_HEAD_FILE)
|
|
|
|
|
2013-02-12 18:17:34 +08:00
|
|
|
static int is_rfc2822_line(const char *buf, int len)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < len; i++) {
|
|
|
|
int ch = buf[i];
|
|
|
|
if (ch == ':')
|
|
|
|
return 1;
|
|
|
|
if (!isalnum(ch) && ch != '-')
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int is_cherry_picked_from_line(const char *buf, int len)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* We only care that it looks roughly like (cherry picked from ...)
|
|
|
|
*/
|
|
|
|
return len > strlen(cherry_picked_prefix) + 1 &&
|
2013-12-01 04:55:40 +08:00
|
|
|
starts_with(buf, cherry_picked_prefix) && buf[len - 1] == ')';
|
2013-02-12 18:17:34 +08:00
|
|
|
}
|
|
|
|
|
2013-02-12 18:17:35 +08:00
|
|
|
/*
|
|
|
|
* Returns 0 for non-conforming footer
|
|
|
|
* Returns 1 for conforming footer
|
|
|
|
* Returns 2 when sob exists within conforming footer
|
|
|
|
* Returns 3 when sob exists within conforming footer as last entry
|
|
|
|
*/
|
|
|
|
static int has_conforming_footer(struct strbuf *sb, struct strbuf *sob,
|
|
|
|
int ignore_footer)
|
2013-02-12 18:17:34 +08:00
|
|
|
{
|
|
|
|
char prev;
|
|
|
|
int i, k;
|
|
|
|
int len = sb->len - ignore_footer;
|
|
|
|
const char *buf = sb->buf;
|
2013-02-12 18:17:35 +08:00
|
|
|
int found_sob = 0;
|
2013-02-12 18:17:34 +08:00
|
|
|
|
|
|
|
/* footer must end with newline */
|
|
|
|
if (!len || buf[len - 1] != '\n')
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
prev = '\0';
|
|
|
|
for (i = len - 1; i > 0; i--) {
|
|
|
|
char ch = buf[i];
|
|
|
|
if (prev == '\n' && ch == '\n') /* paragraph break */
|
|
|
|
break;
|
|
|
|
prev = ch;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* require at least one blank line */
|
|
|
|
if (prev != '\n' || buf[i] != '\n')
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* advance to start of last paragraph */
|
|
|
|
while (i < len - 1 && buf[i] == '\n')
|
|
|
|
i++;
|
|
|
|
|
|
|
|
for (; i < len; i = k) {
|
2013-02-12 18:17:35 +08:00
|
|
|
int found_rfc2822;
|
|
|
|
|
2013-02-12 18:17:34 +08:00
|
|
|
for (k = i; k < len && buf[k] != '\n'; k++)
|
|
|
|
; /* do nothing */
|
|
|
|
k++;
|
|
|
|
|
2013-02-12 18:17:35 +08:00
|
|
|
found_rfc2822 = is_rfc2822_line(buf + i, k - i - 1);
|
|
|
|
if (found_rfc2822 && sob &&
|
|
|
|
!strncmp(buf + i, sob->buf, sob->len))
|
|
|
|
found_sob = k;
|
|
|
|
|
|
|
|
if (!(found_rfc2822 ||
|
|
|
|
is_cherry_picked_from_line(buf + i, k - i - 1)))
|
2013-02-12 18:17:34 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2013-02-12 18:17:35 +08:00
|
|
|
if (found_sob == i)
|
|
|
|
return 3;
|
|
|
|
if (found_sob)
|
|
|
|
return 2;
|
2013-02-12 18:17:34 +08:00
|
|
|
return 1;
|
|
|
|
}
|
2012-09-14 14:52:03 +08:00
|
|
|
|
2012-09-16 14:20:40 +08:00
|
|
|
static void remove_sequencer_state(void)
|
2011-08-04 18:39:11 +08:00
|
|
|
{
|
|
|
|
struct strbuf seq_dir = STRBUF_INIT;
|
|
|
|
|
2016-08-06 04:37:11 +08:00
|
|
|
strbuf_addstr(&seq_dir, git_path(SEQ_DIR));
|
2011-12-10 21:06:12 +08:00
|
|
|
remove_dir_recursively(&seq_dir, 0);
|
2011-08-04 18:39:11 +08:00
|
|
|
strbuf_release(&seq_dir);
|
|
|
|
}
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
static const char *action_name(const struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
return opts->action == REPLAY_REVERT ? "revert" : "cherry-pick";
|
|
|
|
}
|
|
|
|
|
|
|
|
struct commit_message {
|
|
|
|
char *parent_label;
|
2016-02-23 06:44:57 +08:00
|
|
|
char *label;
|
|
|
|
char *subject;
|
2012-01-12 02:15:57 +08:00
|
|
|
const char *message;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int get_message(struct commit *commit, struct commit_message *out)
|
|
|
|
{
|
|
|
|
const char *abbrev, *subject;
|
2016-02-23 06:44:57 +08:00
|
|
|
int subject_len;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
2016-02-23 06:44:57 +08:00
|
|
|
out->message = logmsg_reencode(commit, NULL, get_commit_output_encoding());
|
2015-11-10 10:22:28 +08:00
|
|
|
abbrev = find_unique_abbrev(commit->object.oid.hash, DEFAULT_ABBREV);
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
subject_len = find_commit_subject(out->message, &subject);
|
|
|
|
|
2016-02-23 06:44:57 +08:00
|
|
|
out->subject = xmemdupz(subject, subject_len);
|
|
|
|
out->label = xstrfmt("%s... %s", abbrev, out->subject);
|
|
|
|
out->parent_label = xstrfmt("parent of %s", out->label);
|
|
|
|
|
2012-01-12 02:15:57 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-06-11 05:39:35 +08:00
|
|
|
static void free_message(struct commit *commit, struct commit_message *msg)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
|
|
|
free(msg->parent_label);
|
2016-02-23 06:44:57 +08:00
|
|
|
free(msg->label);
|
|
|
|
free(msg->subject);
|
2014-06-11 05:41:39 +08:00
|
|
|
unuse_commit_buffer(commit, msg->message);
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2012-02-22 08:44:17 +08:00
|
|
|
static void print_advice(int show_hint, struct replay_opts *opts)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
|
|
|
char *msg = getenv("GIT_CHERRY_PICK_HELP");
|
|
|
|
|
|
|
|
if (msg) {
|
|
|
|
fprintf(stderr, "%s\n", msg);
|
|
|
|
/*
|
2013-04-12 06:36:10 +08:00
|
|
|
* A conflict has occurred but the porcelain
|
2012-01-12 02:15:57 +08:00
|
|
|
* (typically rebase --interactive) wants to take care
|
|
|
|
* of the commit itself so remove CHERRY_PICK_HEAD
|
|
|
|
*/
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
unlink(git_path_cherry_pick_head());
|
2012-01-12 02:15:57 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-02-22 08:44:17 +08:00
|
|
|
if (show_hint) {
|
|
|
|
if (opts->no_commit)
|
|
|
|
advise(_("after resolving the conflicts, mark the corrected paths\n"
|
|
|
|
"with 'git add <paths>' or 'git rm <paths>'"));
|
|
|
|
else
|
|
|
|
advise(_("after resolving the conflicts, mark the corrected paths\n"
|
|
|
|
"with 'git add <paths>' or 'git rm <paths>'\n"
|
|
|
|
"and commit the result with 'git commit'"));
|
|
|
|
}
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:05 +08:00
|
|
|
static int write_message(struct strbuf *msgbuf, const char *filename)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
|
|
|
static struct lock_file msg_file;
|
|
|
|
|
2016-09-09 22:37:05 +08:00
|
|
|
int msg_fd = hold_lock_file_for_update(&msg_file, filename, 0);
|
|
|
|
if (msg_fd < 0)
|
|
|
|
return error_errno(_("Could not lock '%s'"), filename);
|
2012-01-12 02:15:57 +08:00
|
|
|
if (write_in_full(msg_fd, msgbuf->buf, msgbuf->len) < 0)
|
2016-09-09 22:37:05 +08:00
|
|
|
return error_errno(_("Could not write to %s"), filename);
|
2012-01-12 02:15:57 +08:00
|
|
|
strbuf_release(msgbuf);
|
|
|
|
if (commit_lock_file(&msg_file) < 0)
|
2016-09-09 22:37:05 +08:00
|
|
|
return error(_("Error wrapping up %s."), filename);
|
|
|
|
|
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct tree *empty_tree(void)
|
|
|
|
{
|
2012-03-23 02:53:24 +08:00
|
|
|
return lookup_tree(EMPTY_TREE_SHA1_BIN);
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int error_dirty_index(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
if (read_cache_unmerged())
|
|
|
|
return error_resolve_conflict(action_name(opts));
|
|
|
|
|
|
|
|
/* Different translation strings for cherry-pick and revert */
|
|
|
|
if (opts->action == REPLAY_PICK)
|
|
|
|
error(_("Your local changes would be overwritten by cherry-pick."));
|
|
|
|
else
|
|
|
|
error(_("Your local changes would be overwritten by revert."));
|
|
|
|
|
|
|
|
if (advice_commit_before_merge)
|
|
|
|
advise(_("Commit your changes or stash them to proceed."));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2012-12-22 03:10:11 +08:00
|
|
|
static int fast_forward_to(const unsigned char *to, const unsigned char *from,
|
2013-06-19 15:37:09 +08:00
|
|
|
int unborn, struct replay_opts *opts)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
2014-04-17 06:37:45 +08:00
|
|
|
struct ref_transaction *transaction;
|
2013-06-19 15:37:09 +08:00
|
|
|
struct strbuf sb = STRBUF_INIT;
|
2014-04-17 06:37:45 +08:00
|
|
|
struct strbuf err = STRBUF_INIT;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
read_cache();
|
2012-10-26 23:53:49 +08:00
|
|
|
if (checkout_fast_forward(from, to, 1))
|
2016-09-09 22:37:55 +08:00
|
|
|
return -1; /* the callee should have complained already */
|
2014-04-17 02:56:52 +08:00
|
|
|
|
2016-06-18 04:20:55 +08:00
|
|
|
strbuf_addf(&sb, _("%s: fast-forward"), action_name(opts));
|
2014-04-17 06:37:45 +08:00
|
|
|
|
|
|
|
transaction = ref_transaction_begin(&err);
|
|
|
|
if (!transaction ||
|
|
|
|
ref_transaction_update(transaction, "HEAD",
|
|
|
|
to, unborn ? null_sha1 : from,
|
2015-02-18 01:00:15 +08:00
|
|
|
0, sb.buf, &err) ||
|
2014-05-01 03:22:42 +08:00
|
|
|
ref_transaction_commit(transaction, &err)) {
|
2014-04-17 06:37:45 +08:00
|
|
|
ref_transaction_free(transaction);
|
|
|
|
error("%s", err.buf);
|
|
|
|
strbuf_release(&sb);
|
|
|
|
strbuf_release(&err);
|
|
|
|
return -1;
|
|
|
|
}
|
2014-04-17 02:56:52 +08:00
|
|
|
|
2013-06-19 15:37:09 +08:00
|
|
|
strbuf_release(&sb);
|
2014-04-17 06:37:45 +08:00
|
|
|
strbuf_release(&err);
|
|
|
|
ref_transaction_free(transaction);
|
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2014-10-25 02:34:59 +08:00
|
|
|
void append_conflicts_hint(struct strbuf *msgbuf)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2014-10-29 04:04:38 +08:00
|
|
|
strbuf_addch(msgbuf, '\n');
|
|
|
|
strbuf_commented_addf(msgbuf, "Conflicts:\n");
|
2014-10-25 02:34:59 +08:00
|
|
|
for (i = 0; i < active_nr;) {
|
|
|
|
const struct cache_entry *ce = active_cache[i++];
|
|
|
|
if (ce_stage(ce)) {
|
2014-10-29 04:04:38 +08:00
|
|
|
strbuf_commented_addf(msgbuf, "\t%s\n", ce->name);
|
2014-10-25 02:34:59 +08:00
|
|
|
while (i < active_nr && !strcmp(ce->name,
|
|
|
|
active_cache[i]->name))
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-01-12 02:15:57 +08:00
|
|
|
static int do_recursive_merge(struct commit *base, struct commit *next,
|
|
|
|
const char *base_label, const char *next_label,
|
|
|
|
unsigned char *head, struct strbuf *msgbuf,
|
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct merge_options o;
|
|
|
|
struct tree *result, *next_tree, *base_tree, *head_tree;
|
2014-06-13 20:19:23 +08:00
|
|
|
int clean;
|
2012-01-12 02:15:57 +08:00
|
|
|
const char **xopt;
|
|
|
|
static struct lock_file index_lock;
|
|
|
|
|
2014-06-13 20:19:23 +08:00
|
|
|
hold_locked_index(&index_lock, 1);
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
read_cache();
|
|
|
|
|
|
|
|
init_merge_options(&o);
|
|
|
|
o.ancestor = base ? base_label : "(empty tree)";
|
|
|
|
o.branch1 = "HEAD";
|
|
|
|
o.branch2 = next ? next_label : "(empty tree)";
|
|
|
|
|
|
|
|
head_tree = parse_tree_indirect(head);
|
|
|
|
next_tree = next ? next->tree : empty_tree();
|
|
|
|
base_tree = base ? base->tree : empty_tree();
|
|
|
|
|
|
|
|
for (xopt = opts->xopts; xopt != opts->xopts + opts->xopts_nr; xopt++)
|
|
|
|
parse_merge_opt(&o, *xopt);
|
|
|
|
|
|
|
|
clean = merge_trees(&o,
|
|
|
|
head_tree,
|
|
|
|
next_tree, base_tree, &result);
|
2016-08-01 19:44:53 +08:00
|
|
|
strbuf_release(&o.obuf);
|
prepare the builtins for a libified merge_recursive()
Previously, callers of merge_trees() or merge_recursive() expected that
code to die() with an error message. This used to be okay because we
called those commands from scripts, and had a chance to print out a
message in case the command failed fatally (read: with exit code 128).
As scripting incurs its own set of problems (portability, speed,
idiosyncrasies of different shells, limited data structures leading to
inefficient code), we are converting more and more of these scripts into
builtins, using library functions directly.
We already tried to use merge_recursive() directly in the builtin
git-am, for example. Unfortunately, we had to roll it back temporarily
because some of the code in merge-recursive.c still deemed it okay to
call die(), when the builtin am code really wanted to print out a useful
advice after the merge failed fatally. In the next commits, we want to
fix that.
The code touched by this commit expected merge_trees() to die() with
some useful message when there is an error condition, but merge_trees()
is going to be improved by converting all die() calls to return error()
instead (i.e. return value -1 after printing out the message as before),
so that the caller can react more flexibly.
This is a step to prepare for the version of merge_trees() that no
longer dies, even if we just imitate the previous behavior by calling
exit(128): this is what callers of e.g. `git merge` have come to expect.
Note that the callers of the sequencer (revert and cherry-pick) already
fail fast even for the return value -1; The only difference is that they
now get a chance to say "<command> failed".
A caller of merge_trees() might want handle error messages themselves
(or even suppress them). As this patch is already complex enough, we
leave that change for a later patch.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2016-07-27 00:06:02 +08:00
|
|
|
if (clean < 0)
|
|
|
|
return clean;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (active_cache_changed &&
|
2014-06-13 20:19:23 +08:00
|
|
|
write_locked_index(&the_index, &index_lock, COMMIT_LOCK))
|
2012-01-12 02:15:57 +08:00
|
|
|
/* TRANSLATORS: %s will be "revert" or "cherry-pick" */
|
2016-09-09 22:37:10 +08:00
|
|
|
return error(_("%s: Unable to write new index file"),
|
|
|
|
action_name(opts));
|
2012-01-12 02:15:57 +08:00
|
|
|
rollback_lock_file(&index_lock);
|
|
|
|
|
2012-09-14 14:52:03 +08:00
|
|
|
if (opts->signoff)
|
2013-02-12 18:17:35 +08:00
|
|
|
append_signoff(msgbuf, 0, 0);
|
2012-09-14 14:52:03 +08:00
|
|
|
|
2014-10-25 02:34:59 +08:00
|
|
|
if (!clean)
|
|
|
|
append_conflicts_hint(msgbuf);
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
return !clean;
|
|
|
|
}
|
|
|
|
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
static int is_index_unchanged(void)
|
|
|
|
{
|
|
|
|
unsigned char head_sha1[20];
|
|
|
|
struct commit *head_commit;
|
|
|
|
|
2014-07-16 03:59:36 +08:00
|
|
|
if (!resolve_ref_unsafe("HEAD", RESOLVE_REF_READING, head_sha1, NULL))
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
return error(_("Could not resolve HEAD commit\n"));
|
|
|
|
|
|
|
|
head_commit = lookup_commit(head_sha1);
|
2012-05-03 20:10:22 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If head_commit is NULL, check_commit, called from
|
|
|
|
* lookup_commit, would have indicated that head_commit is not
|
|
|
|
* a commit object already. parse_commit() will return failure
|
|
|
|
* without further complaints in such a case. Otherwise, if
|
|
|
|
* the commit is invalid, parse_commit() will complain. So
|
|
|
|
* there is nothing for us to say here. Just return failure.
|
|
|
|
*/
|
|
|
|
if (parse_commit(head_commit))
|
|
|
|
return -1;
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
|
|
|
|
if (!active_cache_tree)
|
|
|
|
active_cache_tree = cache_tree();
|
|
|
|
|
|
|
|
if (!cache_tree_fully_valid(active_cache_tree))
|
2014-06-13 20:19:32 +08:00
|
|
|
if (cache_tree_update(&the_index, 0))
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
return error(_("Unable to update cache tree\n"));
|
|
|
|
|
2015-11-10 10:22:29 +08:00
|
|
|
return !hashcmp(active_cache_tree->sha1, head_commit->tree->object.oid.hash);
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
}
|
|
|
|
|
2012-01-12 02:15:57 +08:00
|
|
|
/*
|
|
|
|
* If we are cherry-pick, and if the merge did not result in
|
|
|
|
* hand-editing, we will hit this commit and inherit the original
|
|
|
|
* author date and name.
|
|
|
|
* If we are revert, or if our cherry-pick results in a hand merge,
|
|
|
|
* we had better say that the current user is responsible for that.
|
|
|
|
*/
|
2012-05-30 08:14:41 +08:00
|
|
|
static int run_git_commit(const char *defmsg, struct replay_opts *opts,
|
|
|
|
int allow_empty)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
struct argv_array array;
|
|
|
|
int rc;
|
2015-03-06 21:55:32 +08:00
|
|
|
const char *value;
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
|
|
|
|
argv_array_init(&array);
|
|
|
|
argv_array_push(&array, "commit");
|
|
|
|
argv_array_push(&array, "-n");
|
2012-01-12 02:15:57 +08:00
|
|
|
|
2014-06-20 05:28:20 +08:00
|
|
|
if (opts->gpg_sign)
|
|
|
|
argv_array_pushf(&array, "-S%s", opts->gpg_sign);
|
2012-01-12 02:15:57 +08:00
|
|
|
if (opts->signoff)
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
argv_array_push(&array, "-s");
|
2012-01-12 02:15:57 +08:00
|
|
|
if (!opts->edit) {
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
argv_array_push(&array, "-F");
|
|
|
|
argv_array_push(&array, defmsg);
|
2015-03-06 21:55:32 +08:00
|
|
|
if (!opts->signoff &&
|
|
|
|
!opts->record_origin &&
|
|
|
|
git_config_get_value("commit.cleanup", &value))
|
|
|
|
argv_array_push(&array, "--cleanup=verbatim");
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
|
2012-05-30 08:14:41 +08:00
|
|
|
if (allow_empty)
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
argv_array_push(&array, "--allow-empty");
|
2012-04-12 04:21:53 +08:00
|
|
|
|
2012-08-02 18:38:51 +08:00
|
|
|
if (opts->allow_empty_message)
|
|
|
|
argv_array_push(&array, "--allow-empty-message");
|
|
|
|
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
rc = run_command_v_opt(array.argv, RUN_GIT_CMD);
|
|
|
|
argv_array_clear(&array);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int is_original_commit_empty(struct commit *commit)
|
|
|
|
{
|
|
|
|
const unsigned char *ptree_sha1;
|
|
|
|
|
|
|
|
if (parse_commit(commit))
|
|
|
|
return error(_("Could not parse commit %s\n"),
|
2015-11-10 10:22:28 +08:00
|
|
|
oid_to_hex(&commit->object.oid));
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
if (commit->parents) {
|
|
|
|
struct commit *parent = commit->parents->item;
|
|
|
|
if (parse_commit(parent))
|
|
|
|
return error(_("Could not parse parent commit %s\n"),
|
2015-11-10 10:22:28 +08:00
|
|
|
oid_to_hex(&parent->object.oid));
|
2015-11-10 10:22:29 +08:00
|
|
|
ptree_sha1 = parent->tree->object.oid.hash;
|
git-cherry-pick: Add keep-redundant-commits option
The git-cherry-pick --allow-empty command by default only preserves empty
commits that were originally empty, i.e only those commits for which
<commit>^{tree} and <commit>^^{tree} are equal. By default commits which are
non-empty, but were made empty by the inclusion of a prior commit on the current
history are filtered out. This option allows us to override that behavior and
include redundant commits as empty commits in the change history.
Note that this patch changes the default behavior of git cherry-pick slightly.
Prior to this patch all commits in a cherry-pick sequence were applied and git
commit was run. The implication here was that, if a commit was redundant, and
the commit did not trigger the fast forward logic, the git commit operation, and
therefore the git cherry-pick operation would fail, displaying the cherry pick
advice (i.e. run git commit --allow-empty). With this patch however, such
redundant commits are automatically skipped without stopping, unless
--keep-redundant-commits is specified, in which case, they are automatically
applied as empty commits.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-04-20 22:36:15 +08:00
|
|
|
} else {
|
|
|
|
ptree_sha1 = EMPTY_TREE_SHA1_BIN; /* commit is root */
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2015-11-10 10:22:29 +08:00
|
|
|
return !hashcmp(ptree_sha1, commit->tree->object.oid.hash);
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2012-05-30 08:14:41 +08:00
|
|
|
/*
|
|
|
|
* Do we run "git commit" with "--allow-empty"?
|
|
|
|
*/
|
|
|
|
static int allow_empty(struct replay_opts *opts, struct commit *commit)
|
|
|
|
{
|
|
|
|
int index_unchanged, empty_commit;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Three cases:
|
|
|
|
*
|
|
|
|
* (1) we do not allow empty at all and error out.
|
|
|
|
*
|
|
|
|
* (2) we allow ones that were initially empty, but
|
|
|
|
* forbid the ones that become empty;
|
|
|
|
*
|
|
|
|
* (3) we allow both.
|
|
|
|
*/
|
|
|
|
if (!opts->allow_empty)
|
|
|
|
return 0; /* let "git commit" barf as necessary */
|
|
|
|
|
|
|
|
index_unchanged = is_index_unchanged();
|
|
|
|
if (index_unchanged < 0)
|
|
|
|
return index_unchanged;
|
|
|
|
if (!index_unchanged)
|
|
|
|
return 0; /* we do not have to say --allow-empty */
|
|
|
|
|
|
|
|
if (opts->keep_redundant_commits)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
empty_commit = is_original_commit_empty(commit);
|
|
|
|
if (empty_commit < 0)
|
|
|
|
return empty_commit;
|
|
|
|
if (!empty_commit)
|
|
|
|
return 0;
|
|
|
|
else
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2012-01-12 02:15:57 +08:00
|
|
|
static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
unsigned char head[20];
|
|
|
|
struct commit *base, *next, *parent;
|
|
|
|
const char *base_label, *next_label;
|
2014-06-11 05:39:35 +08:00
|
|
|
struct commit_message msg = { NULL, NULL, NULL, NULL };
|
2012-01-12 02:15:57 +08:00
|
|
|
struct strbuf msgbuf = STRBUF_INIT;
|
2013-05-29 11:56:21 +08:00
|
|
|
int res, unborn = 0, allow;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (opts->no_commit) {
|
|
|
|
/*
|
|
|
|
* We do not intend to commit immediately. We just want to
|
|
|
|
* merge the differences in, so let's compute the tree
|
|
|
|
* that represents the "current" state for merge-recursive
|
|
|
|
* to work on.
|
|
|
|
*/
|
|
|
|
if (write_cache_as_tree(head, 0, NULL))
|
2016-09-09 22:37:12 +08:00
|
|
|
return error(_("Your index file is unmerged."));
|
2012-01-12 02:15:57 +08:00
|
|
|
} else {
|
2012-12-22 03:10:11 +08:00
|
|
|
unborn = get_sha1("HEAD", head);
|
|
|
|
if (unborn)
|
|
|
|
hashcpy(head, EMPTY_TREE_SHA1_BIN);
|
|
|
|
if (index_differs_from(unborn ? EMPTY_TREE_SHA1_HEX : "HEAD", 0))
|
2012-01-12 02:15:57 +08:00
|
|
|
return error_dirty_index(opts);
|
|
|
|
}
|
|
|
|
discard_cache();
|
|
|
|
|
|
|
|
if (!commit->parents) {
|
|
|
|
parent = NULL;
|
|
|
|
}
|
|
|
|
else if (commit->parents->next) {
|
|
|
|
/* Reverting or cherry-picking a merge commit */
|
|
|
|
int cnt;
|
|
|
|
struct commit_list *p;
|
|
|
|
|
|
|
|
if (!opts->mainline)
|
|
|
|
return error(_("Commit %s is a merge but no -m option was given."),
|
2015-11-10 10:22:28 +08:00
|
|
|
oid_to_hex(&commit->object.oid));
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
for (cnt = 1, p = commit->parents;
|
|
|
|
cnt != opts->mainline && p;
|
|
|
|
cnt++)
|
|
|
|
p = p->next;
|
|
|
|
if (cnt != opts->mainline || !p)
|
|
|
|
return error(_("Commit %s does not have parent %d"),
|
2015-11-10 10:22:28 +08:00
|
|
|
oid_to_hex(&commit->object.oid), opts->mainline);
|
2012-01-12 02:15:57 +08:00
|
|
|
parent = p->item;
|
|
|
|
} else if (0 < opts->mainline)
|
|
|
|
return error(_("Mainline was specified but commit %s is not a merge."),
|
2015-11-10 10:22:28 +08:00
|
|
|
oid_to_hex(&commit->object.oid));
|
2012-01-12 02:15:57 +08:00
|
|
|
else
|
|
|
|
parent = commit->parents->item;
|
|
|
|
|
2012-12-22 03:10:11 +08:00
|
|
|
if (opts->allow_ff &&
|
2015-11-10 10:22:29 +08:00
|
|
|
((parent && !hashcmp(parent->object.oid.hash, head)) ||
|
2012-12-22 03:10:11 +08:00
|
|
|
(!parent && unborn)))
|
2015-11-10 10:22:29 +08:00
|
|
|
return fast_forward_to(commit->object.oid.hash, head, unborn, opts);
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (parent && parse_commit(parent) < 0)
|
|
|
|
/* TRANSLATORS: The first %s will be "revert" or
|
|
|
|
"cherry-pick", the second %s a SHA1 */
|
|
|
|
return error(_("%s: cannot parse parent commit %s"),
|
2015-11-10 10:22:28 +08:00
|
|
|
action_name(opts), oid_to_hex(&parent->object.oid));
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (get_message(commit, &msg) != 0)
|
|
|
|
return error(_("Cannot get commit message for %s"),
|
2015-11-10 10:22:28 +08:00
|
|
|
oid_to_hex(&commit->object.oid));
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* "commit" is an existing commit. We would want to apply
|
|
|
|
* the difference it introduces since its first parent "prev"
|
|
|
|
* on top of the current HEAD if we are cherry-pick. Or the
|
|
|
|
* reverse of it if we are revert.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (opts->action == REPLAY_REVERT) {
|
|
|
|
base = commit;
|
|
|
|
base_label = msg.label;
|
|
|
|
next = parent;
|
|
|
|
next_label = msg.parent_label;
|
|
|
|
strbuf_addstr(&msgbuf, "Revert \"");
|
|
|
|
strbuf_addstr(&msgbuf, msg.subject);
|
|
|
|
strbuf_addstr(&msgbuf, "\"\n\nThis reverts commit ");
|
2015-11-10 10:22:28 +08:00
|
|
|
strbuf_addstr(&msgbuf, oid_to_hex(&commit->object.oid));
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (commit->parents && commit->parents->next) {
|
|
|
|
strbuf_addstr(&msgbuf, ", reversing\nchanges made to ");
|
2015-11-10 10:22:28 +08:00
|
|
|
strbuf_addstr(&msgbuf, oid_to_hex(&parent->object.oid));
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
strbuf_addstr(&msgbuf, ".\n");
|
|
|
|
} else {
|
|
|
|
const char *p;
|
|
|
|
|
|
|
|
base = parent;
|
|
|
|
base_label = msg.parent_label;
|
|
|
|
next = commit;
|
|
|
|
next_label = msg.label;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Append the commit log message to msgbuf; it starts
|
|
|
|
* after the tree, parent, author, committer
|
|
|
|
* information followed by "\n\n".
|
|
|
|
*/
|
|
|
|
p = strstr(msg.message, "\n\n");
|
2016-06-29 22:14:46 +08:00
|
|
|
if (p)
|
|
|
|
strbuf_addstr(&msgbuf, skip_blank_lines(p + 2));
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (opts->record_origin) {
|
2013-02-12 18:17:35 +08:00
|
|
|
if (!has_conforming_footer(&msgbuf, NULL, 0))
|
2013-02-12 18:17:34 +08:00
|
|
|
strbuf_addch(&msgbuf, '\n');
|
2013-02-12 18:17:32 +08:00
|
|
|
strbuf_addstr(&msgbuf, cherry_picked_prefix);
|
2015-11-10 10:22:28 +08:00
|
|
|
strbuf_addstr(&msgbuf, oid_to_hex(&commit->object.oid));
|
2012-01-12 02:15:57 +08:00
|
|
|
strbuf_addstr(&msgbuf, ")\n");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!opts->strategy || !strcmp(opts->strategy, "recursive") || opts->action == REPLAY_REVERT) {
|
|
|
|
res = do_recursive_merge(base, next, base_label, next_label,
|
|
|
|
head, &msgbuf, opts);
|
prepare the builtins for a libified merge_recursive()
Previously, callers of merge_trees() or merge_recursive() expected that
code to die() with an error message. This used to be okay because we
called those commands from scripts, and had a chance to print out a
message in case the command failed fatally (read: with exit code 128).
As scripting incurs its own set of problems (portability, speed,
idiosyncrasies of different shells, limited data structures leading to
inefficient code), we are converting more and more of these scripts into
builtins, using library functions directly.
We already tried to use merge_recursive() directly in the builtin
git-am, for example. Unfortunately, we had to roll it back temporarily
because some of the code in merge-recursive.c still deemed it okay to
call die(), when the builtin am code really wanted to print out a useful
advice after the merge failed fatally. In the next commits, we want to
fix that.
The code touched by this commit expected merge_trees() to die() with
some useful message when there is an error condition, but merge_trees()
is going to be improved by converting all die() calls to return error()
instead (i.e. return value -1 after printing out the message as before),
so that the caller can react more flexibly.
This is a step to prepare for the version of merge_trees() that no
longer dies, even if we just imitate the previous behavior by calling
exit(128): this is what callers of e.g. `git merge` have come to expect.
Note that the callers of the sequencer (revert and cherry-pick) already
fail fast even for the return value -1; The only difference is that they
now get a chance to say "<command> failed".
A caller of merge_trees() might want handle error messages themselves
(or even suppress them). As this patch is already complex enough, we
leave that change for a later patch.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2016-07-27 00:06:02 +08:00
|
|
|
if (res < 0)
|
|
|
|
return res;
|
2016-09-09 22:37:05 +08:00
|
|
|
res |= write_message(&msgbuf, git_path_merge_msg());
|
2012-01-12 02:15:57 +08:00
|
|
|
} else {
|
|
|
|
struct commit_list *common = NULL;
|
|
|
|
struct commit_list *remotes = NULL;
|
|
|
|
|
2016-09-09 22:37:05 +08:00
|
|
|
res = write_message(&msgbuf, git_path_merge_msg());
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
commit_list_insert(base, &common);
|
|
|
|
commit_list_insert(next, &remotes);
|
2016-09-09 22:37:05 +08:00
|
|
|
res |= try_merge_command(opts->strategy, opts->xopts_nr, opts->xopts,
|
2012-01-12 02:15:57 +08:00
|
|
|
common, sha1_to_hex(head), remotes);
|
|
|
|
free_commit_list(common);
|
|
|
|
free_commit_list(remotes);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the merge was clean or if it failed due to conflict, we write
|
|
|
|
* CHERRY_PICK_HEAD for the subsequent invocation of commit to use.
|
|
|
|
* However, if the merge did not even start, then we don't want to
|
|
|
|
* write it at all.
|
|
|
|
*/
|
2016-08-26 21:47:14 +08:00
|
|
|
if (opts->action == REPLAY_PICK && !opts->no_commit && (res == 0 || res == 1) &&
|
|
|
|
update_ref(NULL, "CHERRY_PICK_HEAD", commit->object.oid.hash, NULL,
|
|
|
|
REF_NODEREF, UPDATE_REFS_MSG_ON_ERR))
|
|
|
|
res = -1;
|
|
|
|
if (opts->action == REPLAY_REVERT && ((opts->no_commit && res == 0) || res == 1) &&
|
|
|
|
update_ref(NULL, "REVERT_HEAD", commit->object.oid.hash, NULL,
|
|
|
|
REF_NODEREF, UPDATE_REFS_MSG_ON_ERR))
|
|
|
|
res = -1;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (res) {
|
|
|
|
error(opts->action == REPLAY_REVERT
|
|
|
|
? _("could not revert %s... %s")
|
|
|
|
: _("could not apply %s... %s"),
|
2015-11-10 10:22:29 +08:00
|
|
|
find_unique_abbrev(commit->object.oid.hash, DEFAULT_ABBREV),
|
2012-01-12 02:15:57 +08:00
|
|
|
msg.subject);
|
2012-02-22 08:44:17 +08:00
|
|
|
print_advice(res == 1, opts);
|
2012-01-12 02:15:57 +08:00
|
|
|
rerere(opts->allow_rerere_auto);
|
2013-05-29 11:56:21 +08:00
|
|
|
goto leave;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2013-05-29 11:56:21 +08:00
|
|
|
allow = allow_empty(opts, commit);
|
2013-06-06 16:58:57 +08:00
|
|
|
if (allow < 0) {
|
|
|
|
res = allow;
|
|
|
|
goto leave;
|
|
|
|
}
|
2013-05-29 11:56:21 +08:00
|
|
|
if (!opts->no_commit)
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
res = run_git_commit(git_path_merge_msg(), opts, allow);
|
2013-05-29 11:56:21 +08:00
|
|
|
|
|
|
|
leave:
|
2014-06-11 05:39:35 +08:00
|
|
|
free_message(commit, &msg);
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:18 +08:00
|
|
|
static int prepare_revs(struct replay_opts *opts)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
2012-08-29 14:15:56 +08:00
|
|
|
/*
|
|
|
|
* picking (but not reverting) ranges (but not individual revisions)
|
|
|
|
* should be done in reverse
|
|
|
|
*/
|
|
|
|
if (opts->action == REPLAY_PICK && !opts->revs->no_walk)
|
2012-01-12 02:15:57 +08:00
|
|
|
opts->revs->reverse ^= 1;
|
|
|
|
|
|
|
|
if (prepare_revision_walk(opts->revs))
|
2016-09-09 22:37:18 +08:00
|
|
|
return error(_("revision walk setup failed"));
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (!opts->revs->commits)
|
2016-09-09 22:37:18 +08:00
|
|
|
return error(_("empty commit set passed"));
|
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:21 +08:00
|
|
|
static int read_and_refresh_cache(struct replay_opts *opts)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
|
|
|
static struct lock_file index_lock;
|
|
|
|
int index_fd = hold_locked_index(&index_lock, 0);
|
2016-09-09 22:38:20 +08:00
|
|
|
if (read_index_preload(&the_index, NULL) < 0) {
|
|
|
|
rollback_lock_file(&index_lock);
|
2016-09-09 22:37:21 +08:00
|
|
|
return error(_("git %s: failed to read the index"),
|
|
|
|
action_name(opts));
|
2016-09-09 22:38:20 +08:00
|
|
|
}
|
2012-01-12 02:15:57 +08:00
|
|
|
refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, NULL, NULL, NULL);
|
2014-04-28 18:55:24 +08:00
|
|
|
if (the_index.cache_changed && index_fd >= 0) {
|
2016-09-09 22:38:20 +08:00
|
|
|
if (write_locked_index(&the_index, &index_lock, COMMIT_LOCK)) {
|
|
|
|
rollback_lock_file(&index_lock);
|
2016-09-09 22:37:21 +08:00
|
|
|
return error(_("git %s: failed to refresh the index"),
|
|
|
|
action_name(opts));
|
2016-09-09 22:38:20 +08:00
|
|
|
}
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
rollback_lock_file(&index_lock);
|
2016-09-09 22:37:21 +08:00
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int format_todo(struct strbuf *buf, struct commit_list *todo_list,
|
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list *cur = NULL;
|
|
|
|
const char *sha1_abbrev = NULL;
|
|
|
|
const char *action_str = opts->action == REPLAY_REVERT ? "revert" : "pick";
|
|
|
|
const char *subject;
|
|
|
|
int subject_len;
|
|
|
|
|
|
|
|
for (cur = todo_list; cur; cur = cur->next) {
|
2014-06-11 05:44:13 +08:00
|
|
|
const char *commit_buffer = get_commit_buffer(cur->item, NULL);
|
2015-11-10 10:22:29 +08:00
|
|
|
sha1_abbrev = find_unique_abbrev(cur->item->object.oid.hash, DEFAULT_ABBREV);
|
2014-06-11 05:41:51 +08:00
|
|
|
subject_len = find_commit_subject(commit_buffer, &subject);
|
2012-01-12 02:15:57 +08:00
|
|
|
strbuf_addf(buf, "%s %s %.*s\n", action_str, sha1_abbrev,
|
|
|
|
subject_len, subject);
|
2014-06-11 05:41:51 +08:00
|
|
|
unuse_commit_buffer(cur->item, commit_buffer);
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct commit *parse_insn_line(char *bol, char *eol, struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
unsigned char commit_sha1[20];
|
|
|
|
enum replay_action action;
|
|
|
|
char *end_of_object_name;
|
|
|
|
int saved, status, padding;
|
|
|
|
|
2013-12-01 04:55:40 +08:00
|
|
|
if (starts_with(bol, "pick")) {
|
2012-01-12 02:15:57 +08:00
|
|
|
action = REPLAY_PICK;
|
|
|
|
bol += strlen("pick");
|
2013-12-01 04:55:40 +08:00
|
|
|
} else if (starts_with(bol, "revert")) {
|
2012-01-12 02:15:57 +08:00
|
|
|
action = REPLAY_REVERT;
|
|
|
|
bol += strlen("revert");
|
|
|
|
} else
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
/* Eat up extra spaces/ tabs before object name */
|
|
|
|
padding = strspn(bol, " \t");
|
|
|
|
if (!padding)
|
|
|
|
return NULL;
|
|
|
|
bol += padding;
|
|
|
|
|
|
|
|
end_of_object_name = bol + strcspn(bol, " \t\n");
|
|
|
|
saved = *end_of_object_name;
|
|
|
|
*end_of_object_name = '\0';
|
|
|
|
status = get_sha1(bol, commit_sha1);
|
|
|
|
*end_of_object_name = saved;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Verify that the action matches up with the one in
|
|
|
|
* opts; we don't support arbitrary instructions
|
|
|
|
*/
|
|
|
|
if (action != opts->action) {
|
2016-06-18 04:20:54 +08:00
|
|
|
if (action == REPLAY_REVERT)
|
|
|
|
error((opts->action == REPLAY_REVERT)
|
2016-08-21 22:50:37 +08:00
|
|
|
? _("Cannot revert during another revert.")
|
2016-06-18 04:20:54 +08:00
|
|
|
: _("Cannot revert during a cherry-pick."));
|
|
|
|
else
|
|
|
|
error((opts->action == REPLAY_REVERT)
|
|
|
|
? _("Cannot cherry-pick during a revert.")
|
|
|
|
: _("Cannot cherry-pick during another cherry-pick."));
|
2012-01-12 02:15:57 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (status < 0)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
return lookup_commit_reference(commit_sha1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_insn_buffer(char *buf, struct commit_list **todo_list,
|
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list **next = todo_list;
|
|
|
|
struct commit *commit;
|
|
|
|
char *p = buf;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 1; *p; i++) {
|
|
|
|
char *eol = strchrnul(p, '\n');
|
|
|
|
commit = parse_insn_line(p, eol, opts);
|
|
|
|
if (!commit)
|
|
|
|
return error(_("Could not parse line %d."), i);
|
|
|
|
next = commit_list_append(commit, next);
|
|
|
|
p = *eol ? eol + 1 : eol;
|
|
|
|
}
|
|
|
|
if (!*todo_list)
|
|
|
|
return error(_("No commits parsed."));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:24 +08:00
|
|
|
static int read_populate_todo(struct commit_list **todo_list,
|
2012-01-12 02:15:57 +08:00
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int fd, res;
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
fd = open(git_path_todo_file(), O_RDONLY);
|
2012-01-12 02:15:57 +08:00
|
|
|
if (fd < 0)
|
2016-09-09 22:37:24 +08:00
|
|
|
return error_errno(_("Could not open %s"),
|
|
|
|
git_path_todo_file());
|
2012-01-12 02:15:57 +08:00
|
|
|
if (strbuf_read(&buf, fd, 0) < 0) {
|
|
|
|
close(fd);
|
|
|
|
strbuf_release(&buf);
|
2016-09-09 22:37:24 +08:00
|
|
|
return error(_("Could not read %s."), git_path_todo_file());
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
close(fd);
|
|
|
|
|
|
|
|
res = parse_insn_buffer(buf.buf, todo_list, opts);
|
|
|
|
strbuf_release(&buf);
|
|
|
|
if (res)
|
2016-09-09 22:37:24 +08:00
|
|
|
return error(_("Unusable instruction sheet: %s"),
|
|
|
|
git_path_todo_file());
|
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int populate_opts_cb(const char *key, const char *value, void *data)
|
|
|
|
{
|
|
|
|
struct replay_opts *opts = data;
|
|
|
|
int error_flag = 1;
|
|
|
|
|
|
|
|
if (!value)
|
|
|
|
error_flag = 0;
|
|
|
|
else if (!strcmp(key, "options.no-commit"))
|
|
|
|
opts->no_commit = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.edit"))
|
|
|
|
opts->edit = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.signoff"))
|
|
|
|
opts->signoff = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.record-origin"))
|
|
|
|
opts->record_origin = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.allow-ff"))
|
|
|
|
opts->allow_ff = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.mainline"))
|
|
|
|
opts->mainline = git_config_int(key, value);
|
|
|
|
else if (!strcmp(key, "options.strategy"))
|
|
|
|
git_config_string(&opts->strategy, key, value);
|
2014-01-24 08:50:58 +08:00
|
|
|
else if (!strcmp(key, "options.gpg-sign"))
|
|
|
|
git_config_string(&opts->gpg_sign, key, value);
|
2012-01-12 02:15:57 +08:00
|
|
|
else if (!strcmp(key, "options.strategy-option")) {
|
|
|
|
ALLOC_GROW(opts->xopts, opts->xopts_nr + 1, opts->xopts_alloc);
|
|
|
|
opts->xopts[opts->xopts_nr++] = xstrdup(value);
|
|
|
|
} else
|
|
|
|
return error(_("Invalid key: %s"), key);
|
|
|
|
|
|
|
|
if (!error_flag)
|
|
|
|
return error(_("Invalid value for %s: %s"), key, value);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
sequencer: lib'ify read_populate_opts()
Instead of dying there, let the caller high up in the callchain notice
the error and handle it (by dying, still).
The only caller of read_populate_opts(), sequencer_continue() can
already return errors, so its caller must be already prepared to
handle error returns, and with this step, we make it notice an error
return from this function.
So this is a safe conversion to make read_populate_opts() callable
from new callers that want it not to die, without changing the
external behaviour of anything existing.
Note that the function git_config_from_file(), called from
read_populate_opts(), can currently still die() (in git_parse_source(),
because the do_config_from_file() function sets die_on_error = 1). We do
not try to fix that here, as it would have larger ramifications on the
config code, and we also assume that we write the opts file
programmatically, hence any parse errors would be bugs.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2016-09-09 22:37:27 +08:00
|
|
|
static int read_populate_opts(struct replay_opts **opts)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
if (!file_exists(git_path_opts_file()))
|
sequencer: lib'ify read_populate_opts()
Instead of dying there, let the caller high up in the callchain notice
the error and handle it (by dying, still).
The only caller of read_populate_opts(), sequencer_continue() can
already return errors, so its caller must be already prepared to
handle error returns, and with this step, we make it notice an error
return from this function.
So this is a safe conversion to make read_populate_opts() callable
from new callers that want it not to die, without changing the
external behaviour of anything existing.
Note that the function git_config_from_file(), called from
read_populate_opts(), can currently still die() (in git_parse_source(),
because the do_config_from_file() function sets die_on_error = 1). We do
not try to fix that here, as it would have larger ramifications on the
config code, and we also assume that we write the opts file
programmatically, hence any parse errors would be bugs.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2016-09-09 22:37:27 +08:00
|
|
|
return 0;
|
|
|
|
/*
|
|
|
|
* The function git_parse_source(), called from git_config_from_file(),
|
|
|
|
* may die() in case of a syntactically incorrect file. We do not care
|
|
|
|
* about this case, though, because we wrote that file ourselves, so we
|
|
|
|
* are pretty certain that it is syntactically correct.
|
|
|
|
*/
|
|
|
|
if (git_config_from_file(populate_opts_cb, git_path_opts_file(), *opts) < 0)
|
|
|
|
return error(_("Malformed options sheet: %s"),
|
|
|
|
git_path_opts_file());
|
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:15 +08:00
|
|
|
static int walk_revs_populate_todo(struct commit_list **todo_list,
|
2012-01-12 02:15:57 +08:00
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit *commit;
|
|
|
|
struct commit_list **next;
|
|
|
|
|
2016-09-09 22:37:15 +08:00
|
|
|
if (prepare_revs(opts))
|
|
|
|
return -1;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
next = todo_list;
|
|
|
|
while ((commit = get_revision(opts->revs)))
|
|
|
|
next = commit_list_append(commit, next);
|
2016-09-09 22:37:15 +08:00
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int create_seq_dir(void)
|
|
|
|
{
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
if (file_exists(git_path_seq_dir())) {
|
2012-01-12 02:15:57 +08:00
|
|
|
error(_("a cherry-pick or revert is already in progress"));
|
|
|
|
advise(_("try \"git cherry-pick (--continue | --quit | --abort)\""));
|
|
|
|
return -1;
|
|
|
|
}
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
else if (mkdir(git_path_seq_dir(), 0777) < 0)
|
2016-09-09 22:37:44 +08:00
|
|
|
return error_errno(_("Could not create sequencer directory %s"),
|
|
|
|
git_path_seq_dir());
|
2012-01-12 02:15:57 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:47 +08:00
|
|
|
static int save_head(const char *head)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
|
|
|
static struct lock_file head_lock;
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int fd;
|
|
|
|
|
2016-09-09 22:37:47 +08:00
|
|
|
fd = hold_lock_file_for_update(&head_lock, git_path_head_file(), 0);
|
|
|
|
if (fd < 0) {
|
|
|
|
rollback_lock_file(&head_lock);
|
|
|
|
return error_errno(_("Could not lock HEAD"));
|
|
|
|
}
|
2012-01-12 02:15:57 +08:00
|
|
|
strbuf_addf(&buf, "%s\n", head);
|
2016-09-09 22:37:47 +08:00
|
|
|
if (write_in_full(fd, buf.buf, buf.len) < 0) {
|
|
|
|
rollback_lock_file(&head_lock);
|
|
|
|
return error_errno(_("Could not write to %s"),
|
|
|
|
git_path_head_file());
|
|
|
|
}
|
|
|
|
if (commit_lock_file(&head_lock) < 0) {
|
|
|
|
rollback_lock_file(&head_lock);
|
|
|
|
return error(_("Error wrapping up %s."), git_path_head_file());
|
|
|
|
}
|
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int reset_for_rollback(const unsigned char *sha1)
|
|
|
|
{
|
|
|
|
const char *argv[4]; /* reset --merge <arg> + NULL */
|
|
|
|
argv[0] = "reset";
|
|
|
|
argv[1] = "--merge";
|
|
|
|
argv[2] = sha1_to_hex(sha1);
|
|
|
|
argv[3] = NULL;
|
|
|
|
return run_command_v_opt(argv, RUN_GIT_CMD);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rollback_single_pick(void)
|
|
|
|
{
|
|
|
|
unsigned char head_sha1[20];
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
if (!file_exists(git_path_cherry_pick_head()) &&
|
|
|
|
!file_exists(git_path_revert_head()))
|
2012-01-12 02:15:57 +08:00
|
|
|
return error(_("no cherry-pick or revert in progress"));
|
2014-07-16 03:59:36 +08:00
|
|
|
if (read_ref_full("HEAD", 0, head_sha1, NULL))
|
2012-01-12 02:15:57 +08:00
|
|
|
return error(_("cannot resolve HEAD"));
|
|
|
|
if (is_null_sha1(head_sha1))
|
|
|
|
return error(_("cannot abort from a branch yet to be born"));
|
|
|
|
return reset_for_rollback(head_sha1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sequencer_rollback(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
FILE *f;
|
|
|
|
unsigned char sha1[20];
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
f = fopen(git_path_head_file(), "r");
|
2012-01-12 02:15:57 +08:00
|
|
|
if (!f && errno == ENOENT) {
|
|
|
|
/*
|
|
|
|
* There is no multiple-cherry-pick in progress.
|
|
|
|
* If CHERRY_PICK_HEAD or REVERT_HEAD indicates
|
|
|
|
* a single-cherry-pick in progress, abort that.
|
|
|
|
*/
|
|
|
|
return rollback_single_pick();
|
|
|
|
}
|
|
|
|
if (!f)
|
2016-05-08 17:47:54 +08:00
|
|
|
return error_errno(_("cannot open %s"), git_path_head_file());
|
2016-01-14 07:31:17 +08:00
|
|
|
if (strbuf_getline_lf(&buf, f)) {
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
error(_("cannot read %s: %s"), git_path_head_file(),
|
|
|
|
ferror(f) ? strerror(errno) : _("unexpected end of file"));
|
2012-01-12 02:15:57 +08:00
|
|
|
fclose(f);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
fclose(f);
|
|
|
|
if (get_sha1_hex(buf.buf, sha1) || buf.buf[40] != '\0') {
|
|
|
|
error(_("stored pre-cherry-pick HEAD file '%s' is corrupt"),
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
git_path_head_file());
|
2012-01-12 02:15:57 +08:00
|
|
|
goto fail;
|
|
|
|
}
|
2016-06-06 21:23:54 +08:00
|
|
|
if (is_null_sha1(sha1)) {
|
|
|
|
error(_("cannot abort from a branch yet to be born"));
|
|
|
|
goto fail;
|
|
|
|
}
|
2012-01-12 02:15:57 +08:00
|
|
|
if (reset_for_rollback(sha1))
|
|
|
|
goto fail;
|
|
|
|
remove_sequencer_state();
|
|
|
|
strbuf_release(&buf);
|
|
|
|
return 0;
|
|
|
|
fail:
|
|
|
|
strbuf_release(&buf);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:50 +08:00
|
|
|
static int save_todo(struct commit_list *todo_list, struct replay_opts *opts)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
|
|
|
static struct lock_file todo_lock;
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int fd;
|
|
|
|
|
2016-09-09 22:37:50 +08:00
|
|
|
fd = hold_lock_file_for_update(&todo_lock, git_path_todo_file(), 0);
|
|
|
|
if (fd < 0)
|
|
|
|
return error_errno(_("Could not lock '%s'"),
|
|
|
|
git_path_todo_file());
|
|
|
|
if (format_todo(&buf, todo_list, opts) < 0) {
|
|
|
|
strbuf_release(&buf);
|
|
|
|
return error(_("Could not format %s."), git_path_todo_file());
|
|
|
|
}
|
2012-01-12 02:15:57 +08:00
|
|
|
if (write_in_full(fd, buf.buf, buf.len) < 0) {
|
|
|
|
strbuf_release(&buf);
|
2016-09-09 22:37:50 +08:00
|
|
|
return error_errno(_("Could not write to %s"),
|
|
|
|
git_path_todo_file());
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
if (commit_lock_file(&todo_lock) < 0) {
|
|
|
|
strbuf_release(&buf);
|
2016-09-09 22:37:50 +08:00
|
|
|
return error(_("Error wrapping up %s."), git_path_todo_file());
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
strbuf_release(&buf);
|
2016-09-09 22:37:50 +08:00
|
|
|
return 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
2016-09-09 22:37:53 +08:00
|
|
|
static int save_opts(struct replay_opts *opts)
|
2012-01-12 02:15:57 +08:00
|
|
|
{
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
const char *opts_file = git_path_opts_file();
|
2016-09-09 22:37:53 +08:00
|
|
|
int res = 0;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (opts->no_commit)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.no-commit", "true");
|
2012-01-12 02:15:57 +08:00
|
|
|
if (opts->edit)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.edit", "true");
|
2012-01-12 02:15:57 +08:00
|
|
|
if (opts->signoff)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.signoff", "true");
|
2012-01-12 02:15:57 +08:00
|
|
|
if (opts->record_origin)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.record-origin", "true");
|
2012-01-12 02:15:57 +08:00
|
|
|
if (opts->allow_ff)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.allow-ff", "true");
|
2012-01-12 02:15:57 +08:00
|
|
|
if (opts->mainline) {
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf, "%d", opts->mainline);
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.mainline", buf.buf);
|
2012-01-12 02:15:57 +08:00
|
|
|
strbuf_release(&buf);
|
|
|
|
}
|
|
|
|
if (opts->strategy)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.strategy", opts->strategy);
|
2014-01-24 08:50:58 +08:00
|
|
|
if (opts->gpg_sign)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_in_file_gently(opts_file, "options.gpg-sign", opts->gpg_sign);
|
2012-01-12 02:15:57 +08:00
|
|
|
if (opts->xopts) {
|
|
|
|
int i;
|
|
|
|
for (i = 0; i < opts->xopts_nr; i++)
|
2016-09-09 22:37:53 +08:00
|
|
|
res |= git_config_set_multivar_in_file_gently(opts_file,
|
2012-01-12 02:15:57 +08:00
|
|
|
"options.strategy-option",
|
|
|
|
opts->xopts[i], "^$", 0);
|
|
|
|
}
|
2016-09-09 22:37:53 +08:00
|
|
|
return res;
|
2012-01-12 02:15:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int pick_commits(struct commit_list *todo_list, struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list *cur;
|
|
|
|
int res;
|
|
|
|
|
|
|
|
setenv(GIT_REFLOG_ACTION, action_name(opts), 0);
|
|
|
|
if (opts->allow_ff)
|
|
|
|
assert(!(opts->signoff || opts->no_commit ||
|
|
|
|
opts->record_origin || opts->edit));
|
2016-09-09 22:37:21 +08:00
|
|
|
if (read_and_refresh_cache(opts))
|
|
|
|
return -1;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
for (cur = todo_list; cur; cur = cur->next) {
|
2016-09-09 22:37:50 +08:00
|
|
|
if (save_todo(cur, opts))
|
|
|
|
return -1;
|
2012-01-12 02:15:57 +08:00
|
|
|
res = do_pick_commit(cur->item, opts);
|
|
|
|
if (res)
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Sequence of picks finished successfully; cleanup by
|
|
|
|
* removing the .git/sequencer directory
|
|
|
|
*/
|
|
|
|
remove_sequencer_state();
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int continue_single_pick(void)
|
|
|
|
{
|
|
|
|
const char *argv[] = { "commit", NULL };
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
if (!file_exists(git_path_cherry_pick_head()) &&
|
|
|
|
!file_exists(git_path_revert_head()))
|
2012-01-12 02:15:57 +08:00
|
|
|
return error(_("no cherry-pick or revert in progress"));
|
|
|
|
return run_command_v_opt(argv, RUN_GIT_CMD);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sequencer_continue(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list *todo_list = NULL;
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
if (!file_exists(git_path_todo_file()))
|
2012-01-12 02:15:57 +08:00
|
|
|
return continue_single_pick();
|
sequencer: lib'ify read_populate_opts()
Instead of dying there, let the caller high up in the callchain notice
the error and handle it (by dying, still).
The only caller of read_populate_opts(), sequencer_continue() can
already return errors, so its caller must be already prepared to
handle error returns, and with this step, we make it notice an error
return from this function.
So this is a safe conversion to make read_populate_opts() callable
from new callers that want it not to die, without changing the
external behaviour of anything existing.
Note that the function git_config_from_file(), called from
read_populate_opts(), can currently still die() (in git_parse_source(),
because the do_config_from_file() function sets die_on_error = 1). We do
not try to fix that here, as it would have larger ramifications on the
config code, and we also assume that we write the opts file
programmatically, hence any parse errors would be bugs.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2016-09-09 22:37:27 +08:00
|
|
|
if (read_populate_opts(&opts) ||
|
|
|
|
read_populate_todo(&todo_list, opts))
|
2016-09-09 22:37:24 +08:00
|
|
|
return -1;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
/* Verify that the conflict has been resolved */
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 17:38:57 +08:00
|
|
|
if (file_exists(git_path_cherry_pick_head()) ||
|
|
|
|
file_exists(git_path_revert_head())) {
|
2012-01-12 02:15:57 +08:00
|
|
|
int ret = continue_single_pick();
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
if (index_differs_from("HEAD", 0))
|
|
|
|
return error_dirty_index(opts);
|
|
|
|
todo_list = todo_list->next;
|
|
|
|
return pick_commits(todo_list, opts);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int single_pick(struct commit *cmit, struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
setenv(GIT_REFLOG_ACTION, action_name(opts), 0);
|
|
|
|
return do_pick_commit(cmit, opts);
|
|
|
|
}
|
|
|
|
|
|
|
|
int sequencer_pick_revisions(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list *todo_list = NULL;
|
|
|
|
unsigned char sha1[20];
|
2013-04-11 21:06:52 +08:00
|
|
|
int i;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
if (opts->subcommand == REPLAY_NONE)
|
|
|
|
assert(opts->revs);
|
|
|
|
|
2016-09-09 22:37:21 +08:00
|
|
|
if (read_and_refresh_cache(opts))
|
|
|
|
return -1;
|
2012-01-12 02:15:57 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Decide what to do depending on the arguments; a fresh
|
|
|
|
* cherry-pick should be handled differently from an existing
|
|
|
|
* one that is being continued
|
|
|
|
*/
|
|
|
|
if (opts->subcommand == REPLAY_REMOVE_STATE) {
|
|
|
|
remove_sequencer_state();
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
if (opts->subcommand == REPLAY_ROLLBACK)
|
|
|
|
return sequencer_rollback(opts);
|
|
|
|
if (opts->subcommand == REPLAY_CONTINUE)
|
|
|
|
return sequencer_continue(opts);
|
|
|
|
|
2013-04-11 21:06:52 +08:00
|
|
|
for (i = 0; i < opts->revs->pending.nr; i++) {
|
|
|
|
unsigned char sha1[20];
|
|
|
|
const char *name = opts->revs->pending.objects[i].name;
|
|
|
|
|
|
|
|
/* This happens when using --stdin. */
|
|
|
|
if (!strlen(name))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!get_sha1(name, sha1)) {
|
2013-05-10 04:27:49 +08:00
|
|
|
if (!lookup_commit_reference_gently(sha1, 1)) {
|
|
|
|
enum object_type type = sha1_object_info(sha1, NULL);
|
2016-08-26 21:47:10 +08:00
|
|
|
return error(_("%s: can't cherry-pick a %s"),
|
|
|
|
name, typename(type));
|
2013-05-10 04:27:49 +08:00
|
|
|
}
|
2013-04-11 21:06:52 +08:00
|
|
|
} else
|
2016-08-26 21:47:10 +08:00
|
|
|
return error(_("%s: bad revision"), name);
|
2013-04-11 21:06:52 +08:00
|
|
|
}
|
|
|
|
|
2012-01-12 02:15:57 +08:00
|
|
|
/*
|
|
|
|
* If we were called as "git cherry-pick <commit>", just
|
|
|
|
* cherry-pick/revert it, set CHERRY_PICK_HEAD /
|
|
|
|
* REVERT_HEAD, and don't touch the sequencer state.
|
|
|
|
* This means it is possible to cherry-pick in the middle
|
|
|
|
* of a cherry-pick sequence.
|
|
|
|
*/
|
|
|
|
if (opts->revs->cmdline.nr == 1 &&
|
|
|
|
opts->revs->cmdline.rev->whence == REV_CMD_REV &&
|
|
|
|
opts->revs->no_walk &&
|
|
|
|
!opts->revs->cmdline.rev->flags) {
|
|
|
|
struct commit *cmit;
|
|
|
|
if (prepare_revision_walk(opts->revs))
|
2016-08-26 21:47:10 +08:00
|
|
|
return error(_("revision walk setup failed"));
|
2012-01-12 02:15:57 +08:00
|
|
|
cmit = get_revision(opts->revs);
|
|
|
|
if (!cmit || get_revision(opts->revs))
|
2016-08-26 21:47:10 +08:00
|
|
|
return error("BUG: expected exactly one commit from walk");
|
2012-01-12 02:15:57 +08:00
|
|
|
return single_pick(cmit, opts);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Start a new cherry-pick/ revert sequence; but
|
|
|
|
* first, make sure that an existing one isn't in
|
|
|
|
* progress
|
|
|
|
*/
|
|
|
|
|
2016-09-09 22:37:15 +08:00
|
|
|
if (walk_revs_populate_todo(&todo_list, opts) ||
|
|
|
|
create_seq_dir() < 0)
|
2012-01-12 02:15:57 +08:00
|
|
|
return -1;
|
2016-06-06 21:23:54 +08:00
|
|
|
if (get_sha1("HEAD", sha1) && (opts->action == REPLAY_REVERT))
|
|
|
|
return error(_("Can't revert as initial commit"));
|
2016-09-09 22:37:47 +08:00
|
|
|
if (save_head(sha1_to_hex(sha1)))
|
|
|
|
return -1;
|
2016-09-09 22:37:53 +08:00
|
|
|
if (save_opts(opts))
|
|
|
|
return -1;
|
2012-01-12 02:15:57 +08:00
|
|
|
return pick_commits(todo_list, opts);
|
|
|
|
}
|
2012-09-14 14:52:03 +08:00
|
|
|
|
2013-02-12 18:17:35 +08:00
|
|
|
void append_signoff(struct strbuf *msgbuf, int ignore_footer, unsigned flag)
|
2012-09-14 14:52:03 +08:00
|
|
|
{
|
2013-02-12 18:17:35 +08:00
|
|
|
unsigned no_dup_sob = flag & APPEND_SIGNOFF_DEDUP;
|
2012-09-14 14:52:03 +08:00
|
|
|
struct strbuf sob = STRBUF_INIT;
|
2013-02-12 18:17:35 +08:00
|
|
|
int has_footer;
|
2012-09-14 14:52:03 +08:00
|
|
|
|
|
|
|
strbuf_addstr(&sob, sign_off_header);
|
|
|
|
strbuf_addstr(&sob, fmt_name(getenv("GIT_COMMITTER_NAME"),
|
|
|
|
getenv("GIT_COMMITTER_EMAIL")));
|
|
|
|
strbuf_addch(&sob, '\n');
|
2013-02-12 18:17:35 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the whole message buffer is equal to the sob, pretend that we
|
|
|
|
* found a conforming footer with a matching sob
|
|
|
|
*/
|
|
|
|
if (msgbuf->len - ignore_footer == sob.len &&
|
|
|
|
!strncmp(msgbuf->buf, sob.buf, sob.len))
|
|
|
|
has_footer = 3;
|
|
|
|
else
|
|
|
|
has_footer = has_conforming_footer(msgbuf, &sob, ignore_footer);
|
|
|
|
|
2013-02-12 18:33:42 +08:00
|
|
|
if (!has_footer) {
|
|
|
|
const char *append_newlines = NULL;
|
|
|
|
size_t len = msgbuf->len - ignore_footer;
|
|
|
|
|
2013-02-23 06:05:27 +08:00
|
|
|
if (!len) {
|
|
|
|
/*
|
|
|
|
* The buffer is completely empty. Leave foom for
|
|
|
|
* the title and body to be filled in by the user.
|
|
|
|
*/
|
2013-02-12 18:33:42 +08:00
|
|
|
append_newlines = "\n\n";
|
2013-02-23 06:05:27 +08:00
|
|
|
} else if (msgbuf->buf[len - 1] != '\n') {
|
|
|
|
/*
|
|
|
|
* Incomplete line. Complete the line and add a
|
|
|
|
* blank one so that there is an empty line between
|
|
|
|
* the message body and the sob.
|
|
|
|
*/
|
|
|
|
append_newlines = "\n\n";
|
|
|
|
} else if (len == 1) {
|
|
|
|
/*
|
|
|
|
* Buffer contains a single newline. Add another
|
|
|
|
* so that we leave room for the title and body.
|
|
|
|
*/
|
|
|
|
append_newlines = "\n";
|
|
|
|
} else if (msgbuf->buf[len - 2] != '\n') {
|
|
|
|
/*
|
|
|
|
* Buffer ends with a single newline. Add another
|
|
|
|
* so that there is an empty line between the message
|
|
|
|
* body and the sob.
|
|
|
|
*/
|
2013-02-12 18:33:42 +08:00
|
|
|
append_newlines = "\n";
|
2013-02-23 06:05:27 +08:00
|
|
|
} /* else, the buffer already ends with two newlines. */
|
2013-02-12 18:33:42 +08:00
|
|
|
|
|
|
|
if (append_newlines)
|
|
|
|
strbuf_splice(msgbuf, msgbuf->len - ignore_footer, 0,
|
|
|
|
append_newlines, strlen(append_newlines));
|
2012-09-14 14:52:03 +08:00
|
|
|
}
|
2013-02-12 18:17:35 +08:00
|
|
|
|
|
|
|
if (has_footer != 3 && (!no_dup_sob || has_footer != 2))
|
|
|
|
strbuf_splice(msgbuf, msgbuf->len - ignore_footer, 0,
|
|
|
|
sob.buf, sob.len);
|
|
|
|
|
2012-09-14 14:52:03 +08:00
|
|
|
strbuf_release(&sob);
|
|
|
|
}
|