2009-01-12 08:51:11 +08:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
|
|
test_description='test that git handles an svn repository with empty symlinks'
|
|
|
|
|
|
revisions API: have release_revisions() release "cmdline"
Extend the the release_revisions() function so that it frees the
"cmdline" in the "struct rev_info". This in combination with a
preceding change to free "commits" and "mailmap" means that we can
whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true".
There was a proposal in [1] to do away with xstrdup()-ing this
add_rev_cmdline(), perhaps that would be worthwhile, but for now let's
just free() it.
We could also make that a "char *" in "struct rev_cmdline_entry"
itself, but since we own it let's expose it as a constant to outside
callers. I proposed that in [2] but have since changed my mind. See
14d30cdfc04 (ref-filter: fix memory leak in `free_array_item()`,
2019-07-10), c514c62a4fd (checkout: fix leak of non-existent branch
names, 2020-08-14) and other log history hits for "free((char *)" for
prior art.
This includes the tests we had false-positive passes on before my
6798b08e848 (perl Git.pm: don't ignore signalled failure in
_cmd_close(), 2022-02-01), now they pass for real.
Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to
list those that don't pass than to touch most of those 66. So let's
introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests
won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true.
This change also marks all the tests that we removed
"TEST_FAILS_SANITIZE_LEAK=true" from in an earlier commit due to
removing the UNLEAK() from cmd_format_patch(), we can now assert that
its API use doesn't leak any "struct rev_info" memory.
This change also made commit "t5503-tagfollow.sh" pass on current
master, but that would regress when combined with
ps/fetch-atomic-fixup's de004e848a9 (t5503: simplify setup of test
which exercises failure of backfill, 2022-03-03) (through no fault of
that topic, that change started using "git clone" in the test, which
has an outstanding leak). Let's leave that test out for now to avoid
in-flight semantic conflicts.
1. https://lore.kernel.org/git/YUj%2FgFRh6pwrZalY@carlos-mbp.lan/
2. https://lore.kernel.org/git/87o88obkb1.fsf@evledraar.gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2022-04-14 04:01:47 +08:00
|
|
|
TEST_FAILS_SANITIZE_LEAK=true
|
2009-01-12 08:51:11 +08:00
|
|
|
. ./lib-git-svn.sh
|
|
|
|
|
test_expect_success 'load svn dumpfile' '
|
|
|
|
|
svnadmin load "$rawsvnrepo" <<EOF
|
|
|
|
|
SVN-fs-dump-format-version: 2
|
|
|
|
|
|
|
|
|
|
UUID: 60780f9a-7df5-43b4-83ab-60e2c0673ef7
|
|
|
|
|
|
|
|
|
|
Revision-number: 0
|
|
|
|
|
Prop-content-length: 56
|
|
|
|
|
Content-length: 56
|
|
|
|
|
|
|
|
|
|
K 8
|
|
|
|
|
svn:date
|
|
|
|
|
V 27
|
|
|
|
|
2008-11-26T07:17:27.590577Z
|
|
|
|
|
PROPS-END
|
|
|
|
|
|
|
|
|
|
Revision-number: 1
|
|
|
|
|
Prop-content-length: 111
|
|
|
|
|
Content-length: 111
|
|
|
|
|
|
|
|
|
|
K 7
|
|
|
|
|
svn:log
|
|
|
|
|
V 4
|
|
|
|
|
test
|
|
|
|
|
K 10
|
|
|
|
|
svn:author
|
|
|
|
|
V 12
|
|
|
|
|
normalperson
|
|
|
|
|
K 8
|
|
|
|
|
svn:date
|
|
|
|
|
V 27
|
|
|
|
|
2008-11-26T07:18:03.511836Z
|
|
|
|
|
PROPS-END
|
|
|
|
|
|
|
|
|
|
Node-path: bar
|
|
|
|
|
Node-kind: file
|
|
|
|
|
Node-action: add
|
|
|
|
|
Prop-content-length: 33
|
|
|
|
|
Text-content-length: 4
|
|
|
|
|
Text-content-md5: 912ec803b2ce49e4a541068d495ab570
|
|
|
|
|
Content-length: 37
|
|
|
|
|
|
|
|
|
|
K 11
|
|
|
|
|
svn:special
|
|
|
|
|
V 1
|
|
|
|
|
*
|
|
|
|
|
PROPS-END
|
|
|
|
|
asdf
|
|
|
|
|
|
|
|
|
|
Revision-number: 2
|
|
|
|
|
Prop-content-length: 121
|
|
|
|
|
Content-length: 121
|
|
|
|
|
|
|
|
|
|
K 7
|
|
|
|
|
svn:log
|
|
|
|
|
V 13
|
|
|
|
|
bar => doink
|
|
|
|
|
|
|
|
|
|
K 10
|
|
|
|
|
svn:author
|
|
|
|
|
V 12
|
|
|
|
|
normalperson
|
|
|
|
|
K 8
|
|
|
|
|
svn:date
|
|
|
|
|
V 27
|
|
|
|
|
2008-11-27T03:55:31.601672Z
|
|
|
|
|
PROPS-END
|
|
|
|
|
|
|
|
|
|
Node-path: bar
|
|
|
|
|
Node-kind: file
|
|
|
|
|
Node-action: change
|
|
|
|
|
Text-content-length: 10
|
|
|
|
|
Text-content-md5: 92ca4fe7a9721f877f765c252dcd66c9
|
|
|
|
|
Content-length: 10
|
|
|
|
|
|
|
|
|
|
link doink
|
|
|
|
|
|
|
|
|
|
EOF
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'clone using git svn' 'git svn clone -r1 "$svnrepo" x'
|
|
|
|
|
|
2009-03-05 05:38:24 +08:00
|
|
|
test_expect_success SYMLINKS '"bar" is a symlink that points to "asdf"' '
|
2009-01-12 08:51:11 +08:00
|
|
|
test -L x/bar &&
|
2016-01-12 19:49:30 +08:00
|
|
|
(cd x && test xasdf = x"$(git cat-file blob HEAD:bar)")
|
2009-01-12 08:51:11 +08:00
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'get "bar" => symlink fix from svn' '
|
|
|
|
|
(cd x && git svn rebase)
|
|
|
|
|
'
|
|
|
|
|
|
2009-03-05 05:38:24 +08:00
|
|
|
test_expect_success SYMLINKS '"bar" remains a proper symlink' '
|
2009-01-12 08:51:11 +08:00
|
|
|
test -L x/bar &&
|
2016-01-12 19:49:30 +08:00
|
|
|
(cd x && test xdoink = x"$(git cat-file blob HEAD:bar)")
|
2009-01-12 08:51:11 +08:00
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_done
|
