2017-07-04 17:33:06 +08:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
test_description='git merge --signoff
|
|
|
|
|
|
|
|
This test runs git merge --signoff and makes sure that it works.
|
|
|
|
'
|
|
|
|
|
2020-11-19 07:44:40 +08:00
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
tests: mark tests relying on the current default for `init.defaultBranch`
In addition to the manual adjustment to let the `linux-gcc` CI job run
the test suite with `master` and then with `main`, this patch makes sure
that GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME is set in all test scripts
that currently rely on the initial branch name being `master by default.
To determine which test scripts to mark up, the first step was to
force-set the default branch name to `master` in
- all test scripts that contain the keyword `master`,
- t4211, which expects `t/t4211/history.export` with a hard-coded ref to
initialize the default branch,
- t5560 because it sources `t/t556x_common` which uses `master`,
- t8002 and t8012 because both source `t/annotate-tests.sh` which also
uses `master`)
This trick was performed by this command:
$ sed -i '/^ *\. \.\/\(test-lib\|lib-\(bash\|cvs\|git-svn\)\|gitweb-lib\)\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' $(git grep -l master t/t[0-9]*.sh) \
t/t4211*.sh t/t5560*.sh t/t8002*.sh t/t8012*.sh
After that, careful, manual inspection revealed that some of the test
scripts containing the needle `master` do not actually rely on a
specific default branch name: either they mention `master` only in a
comment, or they initialize that branch specificially, or they do not
actually refer to the current default branch. Therefore, the
aforementioned modification was undone in those test scripts thusly:
$ git checkout HEAD -- \
t/t0027-auto-crlf.sh t/t0060-path-utils.sh \
t/t1011-read-tree-sparse-checkout.sh \
t/t1305-config-include.sh t/t1309-early-config.sh \
t/t1402-check-ref-format.sh t/t1450-fsck.sh \
t/t2024-checkout-dwim.sh \
t/t2106-update-index-assume-unchanged.sh \
t/t3040-subprojects-basic.sh t/t3301-notes.sh \
t/t3308-notes-merge.sh t/t3423-rebase-reword.sh \
t/t3436-rebase-more-options.sh \
t/t4015-diff-whitespace.sh t/t4257-am-interactive.sh \
t/t5323-pack-redundant.sh t/t5401-update-hooks.sh \
t/t5511-refspec.sh t/t5526-fetch-submodules.sh \
t/t5529-push-errors.sh t/t5530-upload-pack-error.sh \
t/t5548-push-porcelain.sh \
t/t5552-skipping-fetch-negotiator.sh \
t/t5572-pull-submodule.sh t/t5608-clone-2gb.sh \
t/t5614-clone-submodules-shallow.sh \
t/t7508-status.sh t/t7606-merge-custom.sh \
t/t9302-fast-import-unpack-limit.sh
We excluded one set of test scripts in these commands, though: the range
of `git p4` tests. The reason? `git p4` stores the (foreign) remote
branch in the branch called `p4/master`, which is obviously not the
default branch. Manual analysis revealed that only five of these tests
actually require a specific default branch name to pass; They were
modified thusly:
$ sed -i '/^ *\. \.\/lib-git-p4\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' t/t980[0167]*.sh t/t9811*.sh
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-11-19 07:44:19 +08:00
|
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
|
2017-07-04 17:33:06 +08:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
# Setup test files
|
|
|
|
test_setup() {
|
|
|
|
# Expected commit message after merge --signoff
|
|
|
|
cat >expected-signed <<EOF &&
|
2020-11-19 07:44:40 +08:00
|
|
|
Merge branch 'main' into other-branch
|
2017-07-04 17:33:06 +08:00
|
|
|
|
|
|
|
Signed-off-by: $(git var GIT_COMMITTER_IDENT | sed -e "s/>.*/>/")
|
|
|
|
EOF
|
|
|
|
|
|
|
|
# Expected commit message after merge without --signoff (or with --no-signoff)
|
|
|
|
cat >expected-unsigned <<EOF &&
|
2020-11-19 07:44:40 +08:00
|
|
|
Merge branch 'main' into other-branch
|
2017-07-04 17:33:06 +08:00
|
|
|
EOF
|
|
|
|
|
2020-11-19 07:44:40 +08:00
|
|
|
# Initial commit and feature branch to merge main into it.
|
2017-07-04 17:33:06 +08:00
|
|
|
git commit --allow-empty -m "Initial empty commit" &&
|
|
|
|
git checkout -b other-branch &&
|
|
|
|
test_commit other-branch file1 1
|
|
|
|
}
|
|
|
|
|
|
|
|
# Setup repository, files & feature branch
|
|
|
|
# This step must be run if You want to test 2,3 or 4
|
|
|
|
# Order of 2,3,4 is not important, but 1 must be run before
|
|
|
|
# For example `-r 1,4` or `-r 1,4,2 -v` etc
|
|
|
|
# But not `-r 2` or `-r 4,3,2,1`
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
test_setup
|
|
|
|
'
|
|
|
|
|
|
|
|
# Test with --signoff flag
|
|
|
|
test_expect_success 'git merge --signoff adds a sign-off line' '
|
2020-11-19 07:44:40 +08:00
|
|
|
git checkout main &&
|
|
|
|
test_commit main-branch-2 file2 2 &&
|
2017-07-04 17:33:06 +08:00
|
|
|
git checkout other-branch &&
|
2020-11-19 07:44:40 +08:00
|
|
|
git merge main --signoff --no-edit &&
|
2017-07-04 17:33:06 +08:00
|
|
|
git cat-file commit HEAD | sed -e "1,/^\$/d" >actual &&
|
|
|
|
test_cmp expected-signed actual
|
|
|
|
'
|
|
|
|
|
|
|
|
# Test without --signoff flag
|
|
|
|
test_expect_success 'git merge does not add a sign-off line' '
|
2020-11-19 07:44:40 +08:00
|
|
|
git checkout main &&
|
|
|
|
test_commit main-branch-3 file3 3 &&
|
2017-07-04 17:33:06 +08:00
|
|
|
git checkout other-branch &&
|
2020-11-19 07:44:40 +08:00
|
|
|
git merge main --no-edit &&
|
2017-07-04 17:33:06 +08:00
|
|
|
git cat-file commit HEAD | sed -e "1,/^\$/d" >actual &&
|
|
|
|
test_cmp expected-unsigned actual
|
|
|
|
'
|
|
|
|
|
|
|
|
# Test for --no-signoff flag
|
|
|
|
test_expect_success 'git merge --no-signoff flag cancels --signoff flag' '
|
2020-11-19 07:44:40 +08:00
|
|
|
git checkout main &&
|
|
|
|
test_commit main-branch-4 file4 4 &&
|
2017-07-04 17:33:06 +08:00
|
|
|
git checkout other-branch &&
|
2020-11-19 07:44:40 +08:00
|
|
|
git merge main --no-edit --signoff --no-signoff &&
|
2017-07-04 17:33:06 +08:00
|
|
|
git cat-file commit HEAD | sed -e "1,/^\$/d" >actual &&
|
|
|
|
test_cmp expected-unsigned actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_done
|