ident: handle NULL email when complaining of empty name
If we see an empty name, we complain about and mention the
matching email in the error message (to give it some
context). However, the "email" pointer may be NULL here if
we were planning to fill it in later from ident_default_email().
This was broken by 59f929596 (fmt_ident: refactor strictness
checks, 2016-02-04). Prior to that commit, we would look up
the default name and email before doing any other actions.
So one solution would be to go back to that.
However, we can't just do so blindly. The logic for handling
the "!email" condition has grown since then. In particular,
looking up the default email can die if getpwuid() fails,
but there are other errors that should take precedence.
Commit 734c7789a (ident: check for useConfigOnly before
auto-detection of name/email, 2016-03-30) reordered the
checks so that we prefer the error message for
useConfigOnly.
Instead, we can observe that while the name-handling depends
on "email" being set, the reverse is not true. So we can
simply set up the email variable first.
This does mean that if both are bogus, we'll complain about
the email before the name. But between the two, there is no
reason to prefer one over the other.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-02-23 16:13:53 +08:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
|
|
test_description='corner cases in ident strings'
|
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
|
|
# confirm that we do not segfault _and_ that we do not say "(null)", as
|
|
|
|
|
# glibc systems will quietly handle our NULL pointer
|
|
|
|
|
#
|
|
|
|
|
# Note also that we can't use "env" here because we need to unset a variable,
|
|
|
|
|
# and "-u" is not portable.
|
|
|
|
|
test_expect_success 'empty name and missing email' '
|
|
|
|
|
(
|
|
|
|
|
sane_unset GIT_AUTHOR_EMAIL &&
|
|
|
|
|
GIT_AUTHOR_NAME= &&
|
|
|
|
|
test_must_fail git commit --allow-empty -m foo 2>err &&
|
2020-10-17 07:39:54 +08:00
|
|
|
test_i18ngrep ! "(null)" err
|
ident: handle NULL email when complaining of empty name
If we see an empty name, we complain about and mention the
matching email in the error message (to give it some
context). However, the "email" pointer may be NULL here if
we were planning to fill it in later from ident_default_email().
This was broken by 59f929596 (fmt_ident: refactor strictness
checks, 2016-02-04). Prior to that commit, we would look up
the default name and email before doing any other actions.
So one solution would be to go back to that.
However, we can't just do so blindly. The logic for handling
the "!email" condition has grown since then. In particular,
looking up the default email can die if getpwuid() fails,
but there are other errors that should take precedence.
Commit 734c7789a (ident: check for useConfigOnly before
auto-detection of name/email, 2016-03-30) reordered the
checks so that we prefer the error message for
useConfigOnly.
Instead, we can observe that while the name-handling depends
on "email" being set, the reverse is not true. So we can
simply set up the email variable first.
This does mean that if both are bogus, we'll complain about
the email before the name. But between the two, there is no
reason to prefer one over the other.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-02-23 16:13:53 +08:00
|
|
|
)
|
|
|
|
|
'
|
|
|
|
|
|
2017-02-23 16:15:55 +08:00
|
|
|
test_expect_success 'commit rejects all-crud name' '
|
|
|
|
|
test_must_fail env GIT_AUTHOR_NAME=" .;<>" \
|
|
|
|
|
git commit --allow-empty -m foo
|
|
|
|
|
'
|
|
|
|
|
|
2017-02-23 16:17:08 +08:00
|
|
|
# We must test the actual error message here, as an unwanted
|
|
|
|
|
# auto-detection could fail for other reasons.
|
|
|
|
|
test_expect_success 'empty configured name does not auto-detect' '
|
|
|
|
|
(
|
|
|
|
|
sane_unset GIT_AUTHOR_NAME &&
|
|
|
|
|
test_must_fail \
|
|
|
|
|
git -c user.name= commit --allow-empty -m foo 2>err &&
|
2020-08-22 04:36:28 +08:00
|
|
|
test_i18ngrep "empty ident name" err &&
|
|
|
|
|
test_i18ngrep "Author identity unknown" err
|
|
|
|
|
)
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty configured name does not auto-detect for committer' '
|
|
|
|
|
(
|
|
|
|
|
sane_unset GIT_COMMITTER_NAME &&
|
|
|
|
|
test_must_fail \
|
|
|
|
|
git -c user.name= commit --allow-empty -m foo 2>err &&
|
|
|
|
|
test_i18ngrep "empty ident name" err &&
|
|
|
|
|
test_i18ngrep "Committer identity unknown" err
|
2017-02-23 16:17:08 +08:00
|
|
|
)
|
|
|
|
|
'
|
|
|
|
|
|
ident: handle NULL email when complaining of empty name
If we see an empty name, we complain about and mention the
matching email in the error message (to give it some
context). However, the "email" pointer may be NULL here if
we were planning to fill it in later from ident_default_email().
This was broken by 59f929596 (fmt_ident: refactor strictness
checks, 2016-02-04). Prior to that commit, we would look up
the default name and email before doing any other actions.
So one solution would be to go back to that.
However, we can't just do so blindly. The logic for handling
the "!email" condition has grown since then. In particular,
looking up the default email can die if getpwuid() fails,
but there are other errors that should take precedence.
Commit 734c7789a (ident: check for useConfigOnly before
auto-detection of name/email, 2016-03-30) reordered the
checks so that we prefer the error message for
useConfigOnly.
Instead, we can observe that while the name-handling depends
on "email" being set, the reverse is not true. So we can
simply set up the email variable first.
This does mean that if both are bogus, we'll complain about
the email before the name. But between the two, there is no
reason to prefer one over the other.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-02-23 16:13:53 +08:00
|
|
|
test_done
|
