2006-01-07 17:33:54 +08:00
|
|
|
#include "cache.h"
|
2005-05-19 07:14:22 +08:00
|
|
|
#include "tag.h"
|
2005-04-19 02:39:48 +08:00
|
|
|
#include "commit.h"
|
2006-10-31 03:09:06 +08:00
|
|
|
#include "pkt-line.h"
|
2006-12-26 03:48:35 +08:00
|
|
|
#include "utf8.h"
|
2007-04-09 17:34:05 +08:00
|
|
|
#include "diff.h"
|
|
|
|
#include "revision.h"
|
2005-04-19 02:39:48 +08:00
|
|
|
|
[PATCH] Avoid wasting memory in git-rev-list
As pointed out on the list, git-rev-list can use a lot of memory.
One low-hanging fruit is to free the commit buffer for commits that we
parse. By default, parse_commit() will save away the buffer, since a lot
of cases do want it, and re-reading it continually would be unnecessary.
However, in many cases the buffer isn't actually necessary and saving it
just wastes memory.
We could just free the buffer ourselves, but especially in git-rev-list,
we actually end up using the helper functions that automatically add
parent commits to the commit lists, so we don't actually control the
commit parsing directly.
Instead, just make this behaviour of "parse_commit()" a global flag.
Maybe this is a bit tasteless, but it's very simple, and it makes a
noticable difference in memory usage.
Before the change:
[torvalds@g5 linux]$ /usr/bin/time git-rev-list v2.6.12..HEAD > /dev/null
0.26user 0.02system 0:00.28elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+3714minor)pagefaults 0swaps
after the change:
[torvalds@g5 linux]$ /usr/bin/time git-rev-list v2.6.12..HEAD > /dev/null
0.26user 0.00system 0:00.27elapsed 100%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+2433minor)pagefaults 0swaps
note how the minor faults have decreased from 3714 pages to 2433 pages.
That's all due to the fewer anonymous pages allocated to hold the comment
buffers and their metadata.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-09-16 05:43:17 +08:00
|
|
|
int save_commit_buffer = 1;
|
|
|
|
|
2005-04-19 02:39:48 +08:00
|
|
|
const char *commit_type = "commit";
|
|
|
|
|
2005-08-21 17:51:10 +08:00
|
|
|
static struct commit *check_commit(struct object *obj,
|
|
|
|
const unsigned char *sha1,
|
|
|
|
int quiet)
|
2005-05-19 07:14:22 +08:00
|
|
|
{
|
2006-07-12 11:45:31 +08:00
|
|
|
if (obj->type != OBJ_COMMIT) {
|
2005-08-21 17:51:10 +08:00
|
|
|
if (!quiet)
|
|
|
|
error("Object %s is a %s, not a commit",
|
Shrink "struct object" a bit
This shrinks "struct object" by a small amount, by getting rid of the
"struct type *" pointer and replacing it with a 3-bit bitfield instead.
In addition, we merge the bitfields and the "flags" field, which
incidentally should also remove a useless 4-byte padding from the object
when in 64-bit mode.
Now, our "struct object" is still too damn large, but it's now less
obviously bloated, and of the remaining fields, only the "util" (which is
not used by most things) is clearly something that should be eventually
discarded.
This shrinks the "git-rev-list --all" memory use by about 2.5% on the
kernel archive (and, perhaps more importantly, on the larger mozilla
archive). That may not sound like much, but I suspect it's more on a
64-bit platform.
There are other remaining inefficiencies (the parent lists, for example,
probably have horrible malloc overhead), but this was pretty obvious.
Most of the patch is just changing the comparison of the "type" pointer
from one of the constant string pointers to the appropriate new TYPE_xxx
small integer constant.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-06-15 07:45:13 +08:00
|
|
|
sha1_to_hex(sha1), typename(obj->type));
|
2005-05-19 07:14:22 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
return (struct commit *) obj;
|
|
|
|
}
|
|
|
|
|
2005-08-21 17:51:10 +08:00
|
|
|
struct commit *lookup_commit_reference_gently(const unsigned char *sha1,
|
|
|
|
int quiet)
|
2005-05-19 07:14:22 +08:00
|
|
|
{
|
2005-11-03 07:19:13 +08:00
|
|
|
struct object *obj = deref_tag(parse_object(sha1), NULL, 0);
|
2005-05-19 07:14:22 +08:00
|
|
|
|
|
|
|
if (!obj)
|
|
|
|
return NULL;
|
2005-08-21 17:51:10 +08:00
|
|
|
return check_commit(obj, sha1, quiet);
|
|
|
|
}
|
|
|
|
|
|
|
|
struct commit *lookup_commit_reference(const unsigned char *sha1)
|
|
|
|
{
|
|
|
|
return lookup_commit_reference_gently(sha1, 0);
|
2005-05-19 07:14:22 +08:00
|
|
|
}
|
|
|
|
|
2005-06-03 23:05:39 +08:00
|
|
|
struct commit *lookup_commit(const unsigned char *sha1)
|
2005-04-19 02:39:48 +08:00
|
|
|
{
|
|
|
|
struct object *obj = lookup_object(sha1);
|
2007-04-17 13:11:43 +08:00
|
|
|
if (!obj)
|
|
|
|
return create_object(sha1, OBJ_COMMIT, alloc_commit_node());
|
2005-05-21 04:59:17 +08:00
|
|
|
if (!obj->type)
|
2006-07-12 11:45:31 +08:00
|
|
|
obj->type = OBJ_COMMIT;
|
2005-08-21 17:51:10 +08:00
|
|
|
return check_commit(obj, sha1, 0);
|
2005-04-19 02:39:48 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned long parse_commit_date(const char *buf)
|
|
|
|
{
|
|
|
|
unsigned long date;
|
|
|
|
|
|
|
|
if (memcmp(buf, "author", 6))
|
|
|
|
return 0;
|
|
|
|
while (*buf++ != '\n')
|
|
|
|
/* nada */;
|
|
|
|
if (memcmp(buf, "committer", 9))
|
|
|
|
return 0;
|
|
|
|
while (*buf++ != '>')
|
|
|
|
/* nada */;
|
|
|
|
date = strtoul(buf, NULL, 10);
|
|
|
|
if (date == ULONG_MAX)
|
|
|
|
date = 0;
|
|
|
|
return date;
|
|
|
|
}
|
|
|
|
|
2006-04-07 14:58:51 +08:00
|
|
|
static struct commit_graft **commit_graft;
|
2005-07-30 15:58:28 +08:00
|
|
|
static int commit_graft_alloc, commit_graft_nr;
|
|
|
|
|
|
|
|
static int commit_graft_pos(const unsigned char *sha1)
|
|
|
|
{
|
|
|
|
int lo, hi;
|
|
|
|
lo = 0;
|
|
|
|
hi = commit_graft_nr;
|
|
|
|
while (lo < hi) {
|
|
|
|
int mi = (lo + hi) / 2;
|
|
|
|
struct commit_graft *graft = commit_graft[mi];
|
2006-08-18 02:54:57 +08:00
|
|
|
int cmp = hashcmp(sha1, graft->sha1);
|
2005-07-30 15:58:28 +08:00
|
|
|
if (!cmp)
|
|
|
|
return mi;
|
|
|
|
if (cmp < 0)
|
|
|
|
hi = mi;
|
|
|
|
else
|
|
|
|
lo = mi + 1;
|
|
|
|
}
|
|
|
|
return -lo - 1;
|
|
|
|
}
|
|
|
|
|
2006-04-07 14:58:51 +08:00
|
|
|
int register_commit_graft(struct commit_graft *graft, int ignore_dups)
|
|
|
|
{
|
|
|
|
int pos = commit_graft_pos(graft->sha1);
|
2007-06-07 15:04:01 +08:00
|
|
|
|
2006-04-07 14:58:51 +08:00
|
|
|
if (0 <= pos) {
|
|
|
|
if (ignore_dups)
|
|
|
|
free(graft);
|
|
|
|
else {
|
|
|
|
free(commit_graft[pos]);
|
|
|
|
commit_graft[pos] = graft;
|
|
|
|
}
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
pos = -pos - 1;
|
|
|
|
if (commit_graft_alloc <= ++commit_graft_nr) {
|
|
|
|
commit_graft_alloc = alloc_nr(commit_graft_alloc);
|
|
|
|
commit_graft = xrealloc(commit_graft,
|
|
|
|
sizeof(*commit_graft) *
|
|
|
|
commit_graft_alloc);
|
|
|
|
}
|
|
|
|
if (pos < commit_graft_nr)
|
|
|
|
memmove(commit_graft + pos + 1,
|
|
|
|
commit_graft + pos,
|
|
|
|
(commit_graft_nr - pos - 1) *
|
|
|
|
sizeof(*commit_graft));
|
|
|
|
commit_graft[pos] = graft;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct commit_graft *read_graft_line(char *buf, int len)
|
|
|
|
{
|
|
|
|
/* The format is just "Commit Parent1 Parent2 ...\n" */
|
|
|
|
int i;
|
|
|
|
struct commit_graft *graft = NULL;
|
|
|
|
|
|
|
|
if (buf[len-1] == '\n')
|
|
|
|
buf[--len] = 0;
|
2006-04-17 19:41:49 +08:00
|
|
|
if (buf[0] == '#' || buf[0] == '\0')
|
2006-04-17 05:24:56 +08:00
|
|
|
return NULL;
|
2006-04-07 14:58:51 +08:00
|
|
|
if ((len + 1) % 41) {
|
|
|
|
bad_graft_data:
|
|
|
|
error("bad graft data: %s", buf);
|
|
|
|
free(graft);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
i = (len + 1) / 41 - 1;
|
|
|
|
graft = xmalloc(sizeof(*graft) + 20 * i);
|
|
|
|
graft->nr_parent = i;
|
|
|
|
if (get_sha1_hex(buf, graft->sha1))
|
|
|
|
goto bad_graft_data;
|
|
|
|
for (i = 40; i < len; i += 41) {
|
|
|
|
if (buf[i] != ' ')
|
|
|
|
goto bad_graft_data;
|
|
|
|
if (get_sha1_hex(buf + i + 1, graft->parent[i/41]))
|
|
|
|
goto bad_graft_data;
|
|
|
|
}
|
|
|
|
return graft;
|
|
|
|
}
|
|
|
|
|
|
|
|
int read_graft_file(const char *graft_file)
|
2005-07-30 15:58:28 +08:00
|
|
|
{
|
|
|
|
FILE *fp = fopen(graft_file, "r");
|
|
|
|
char buf[1024];
|
2006-04-07 14:58:51 +08:00
|
|
|
if (!fp)
|
|
|
|
return -1;
|
2005-07-30 15:58:28 +08:00
|
|
|
while (fgets(buf, sizeof(buf), fp)) {
|
|
|
|
/* The format is just "Commit Parent1 Parent2 ...\n" */
|
|
|
|
int len = strlen(buf);
|
2006-04-07 14:58:51 +08:00
|
|
|
struct commit_graft *graft = read_graft_line(buf, len);
|
2006-04-17 05:24:56 +08:00
|
|
|
if (!graft)
|
|
|
|
continue;
|
2006-04-07 14:58:51 +08:00
|
|
|
if (register_commit_graft(graft, 1))
|
2005-07-30 15:58:28 +08:00
|
|
|
error("duplicate graft data: %s", buf);
|
|
|
|
}
|
|
|
|
fclose(fp);
|
2006-04-07 14:58:51 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void prepare_commit_graft(void)
|
|
|
|
{
|
|
|
|
static int commit_graft_prepared;
|
|
|
|
char *graft_file;
|
|
|
|
|
|
|
|
if (commit_graft_prepared)
|
|
|
|
return;
|
|
|
|
graft_file = get_graft_file();
|
|
|
|
read_graft_file(graft_file);
|
2006-10-31 03:09:06 +08:00
|
|
|
/* make sure shallows are read */
|
|
|
|
is_repository_shallow();
|
2006-04-07 14:58:51 +08:00
|
|
|
commit_graft_prepared = 1;
|
2005-07-30 15:58:28 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct commit_graft *lookup_commit_graft(const unsigned char *sha1)
|
|
|
|
{
|
|
|
|
int pos;
|
2006-04-07 14:58:51 +08:00
|
|
|
prepare_commit_graft();
|
2005-07-30 15:58:28 +08:00
|
|
|
pos = commit_graft_pos(sha1);
|
|
|
|
if (pos < 0)
|
|
|
|
return NULL;
|
|
|
|
return commit_graft[pos];
|
|
|
|
}
|
|
|
|
|
2006-10-31 03:09:06 +08:00
|
|
|
int write_shallow_commits(int fd, int use_pack_protocol)
|
|
|
|
{
|
|
|
|
int i, count = 0;
|
|
|
|
for (i = 0; i < commit_graft_nr; i++)
|
|
|
|
if (commit_graft[i]->nr_parent < 0) {
|
|
|
|
const char *hex =
|
|
|
|
sha1_to_hex(commit_graft[i]->sha1);
|
|
|
|
count++;
|
|
|
|
if (use_pack_protocol)
|
|
|
|
packet_write(fd, "shallow %s", hex);
|
|
|
|
else {
|
2007-01-08 23:58:23 +08:00
|
|
|
if (write_in_full(fd, hex, 40) != 40)
|
|
|
|
break;
|
|
|
|
if (write_in_full(fd, "\n", 1) != 1)
|
|
|
|
break;
|
2006-10-31 03:09:06 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2006-10-31 03:09:53 +08:00
|
|
|
int unregister_shallow(const unsigned char *sha1)
|
|
|
|
{
|
|
|
|
int pos = commit_graft_pos(sha1);
|
|
|
|
if (pos < 0)
|
|
|
|
return -1;
|
|
|
|
if (pos + 1 < commit_graft_nr)
|
|
|
|
memcpy(commit_graft + pos, commit_graft + pos + 1,
|
|
|
|
sizeof(struct commit_graft *)
|
|
|
|
* (commit_graft_nr - pos - 1));
|
|
|
|
commit_graft_nr--;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-07 01:48:34 +08:00
|
|
|
int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size)
|
2005-04-19 02:39:48 +08:00
|
|
|
{
|
2006-06-28 18:51:00 +08:00
|
|
|
char *tail = buffer;
|
2005-07-28 06:12:48 +08:00
|
|
|
char *bufptr = buffer;
|
2005-04-19 02:39:48 +08:00
|
|
|
unsigned char parent[20];
|
2005-06-21 11:26:03 +08:00
|
|
|
struct commit_list **pptr;
|
2005-07-30 15:58:28 +08:00
|
|
|
struct commit_graft *graft;
|
2005-11-17 13:32:44 +08:00
|
|
|
unsigned n_refs = 0;
|
2005-05-07 01:48:34 +08:00
|
|
|
|
2005-04-19 02:39:48 +08:00
|
|
|
if (item->object.parsed)
|
|
|
|
return 0;
|
|
|
|
item->object.parsed = 1;
|
2006-06-28 18:51:00 +08:00
|
|
|
tail += size;
|
|
|
|
if (tail <= bufptr + 5 || memcmp(bufptr, "tree ", 5))
|
2005-07-28 06:12:48 +08:00
|
|
|
return error("bogus commit object %s", sha1_to_hex(item->object.sha1));
|
2006-06-28 18:51:00 +08:00
|
|
|
if (tail <= bufptr + 45 || get_sha1_hex(bufptr + 5, parent) < 0)
|
2006-02-23 09:47:10 +08:00
|
|
|
return error("bad tree pointer in commit %s",
|
|
|
|
sha1_to_hex(item->object.sha1));
|
2005-04-19 02:39:48 +08:00
|
|
|
item->tree = lookup_tree(parent);
|
2005-04-25 05:31:57 +08:00
|
|
|
if (item->tree)
|
2005-11-17 13:32:44 +08:00
|
|
|
n_refs++;
|
2005-04-19 02:39:48 +08:00
|
|
|
bufptr += 46; /* "tree " + "hex sha1" + "\n" */
|
2005-06-21 11:26:03 +08:00
|
|
|
pptr = &item->parents;
|
2005-07-30 15:58:28 +08:00
|
|
|
|
|
|
|
graft = lookup_commit_graft(item->object.sha1);
|
2006-06-28 18:51:00 +08:00
|
|
|
while (bufptr + 48 < tail && !memcmp(bufptr, "parent ", 7)) {
|
2005-07-28 06:12:48 +08:00
|
|
|
struct commit *new_parent;
|
|
|
|
|
2006-06-28 18:51:00 +08:00
|
|
|
if (tail <= bufptr + 48 ||
|
|
|
|
get_sha1_hex(bufptr + 7, parent) ||
|
|
|
|
bufptr[47] != '\n')
|
2005-07-28 06:12:48 +08:00
|
|
|
return error("bad parents in commit %s", sha1_to_hex(item->object.sha1));
|
2005-07-30 15:58:28 +08:00
|
|
|
bufptr += 48;
|
|
|
|
if (graft)
|
|
|
|
continue;
|
2005-07-28 06:12:48 +08:00
|
|
|
new_parent = lookup_commit(parent);
|
2005-04-25 05:31:57 +08:00
|
|
|
if (new_parent) {
|
2005-06-21 11:26:03 +08:00
|
|
|
pptr = &commit_list_insert(new_parent, pptr)->next;
|
2005-11-17 13:32:44 +08:00
|
|
|
n_refs++;
|
2005-04-25 05:31:57 +08:00
|
|
|
}
|
2005-07-30 15:58:28 +08:00
|
|
|
}
|
|
|
|
if (graft) {
|
|
|
|
int i;
|
|
|
|
struct commit *new_parent;
|
|
|
|
for (i = 0; i < graft->nr_parent; i++) {
|
|
|
|
new_parent = lookup_commit(graft->parent[i]);
|
|
|
|
if (!new_parent)
|
|
|
|
continue;
|
|
|
|
pptr = &commit_list_insert(new_parent, pptr)->next;
|
2005-11-17 13:32:44 +08:00
|
|
|
n_refs++;
|
2005-07-30 15:58:28 +08:00
|
|
|
}
|
2005-04-19 02:39:48 +08:00
|
|
|
}
|
|
|
|
item->date = parse_commit_date(bufptr);
|
2005-11-17 13:32:44 +08:00
|
|
|
|
|
|
|
if (track_object_refs) {
|
|
|
|
unsigned i = 0;
|
|
|
|
struct commit_list *p;
|
|
|
|
struct object_refs *refs = alloc_object_refs(n_refs);
|
|
|
|
if (item->tree)
|
|
|
|
refs->ref[i++] = &item->tree->object;
|
|
|
|
for (p = item->parents; p; p = p->next)
|
|
|
|
refs->ref[i++] = &p->item->object;
|
|
|
|
set_object_refs(&item->object, refs);
|
|
|
|
}
|
|
|
|
|
2005-04-19 02:39:48 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-07 01:48:34 +08:00
|
|
|
int parse_commit(struct commit *item)
|
|
|
|
{
|
2007-02-27 03:55:59 +08:00
|
|
|
enum object_type type;
|
2005-05-07 01:48:34 +08:00
|
|
|
void *buffer;
|
|
|
|
unsigned long size;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (item->object.parsed)
|
|
|
|
return 0;
|
2007-02-27 03:55:59 +08:00
|
|
|
buffer = read_sha1_file(item->object.sha1, &type, &size);
|
2005-05-07 01:48:34 +08:00
|
|
|
if (!buffer)
|
|
|
|
return error("Could not read %s",
|
|
|
|
sha1_to_hex(item->object.sha1));
|
2007-02-27 03:55:59 +08:00
|
|
|
if (type != OBJ_COMMIT) {
|
2005-05-07 01:48:34 +08:00
|
|
|
free(buffer);
|
|
|
|
return error("Object %s not a commit",
|
|
|
|
sha1_to_hex(item->object.sha1));
|
|
|
|
}
|
|
|
|
ret = parse_commit_buffer(item, buffer, size);
|
[PATCH] Avoid wasting memory in git-rev-list
As pointed out on the list, git-rev-list can use a lot of memory.
One low-hanging fruit is to free the commit buffer for commits that we
parse. By default, parse_commit() will save away the buffer, since a lot
of cases do want it, and re-reading it continually would be unnecessary.
However, in many cases the buffer isn't actually necessary and saving it
just wastes memory.
We could just free the buffer ourselves, but especially in git-rev-list,
we actually end up using the helper functions that automatically add
parent commits to the commit lists, so we don't actually control the
commit parsing directly.
Instead, just make this behaviour of "parse_commit()" a global flag.
Maybe this is a bit tasteless, but it's very simple, and it makes a
noticable difference in memory usage.
Before the change:
[torvalds@g5 linux]$ /usr/bin/time git-rev-list v2.6.12..HEAD > /dev/null
0.26user 0.02system 0:00.28elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+3714minor)pagefaults 0swaps
after the change:
[torvalds@g5 linux]$ /usr/bin/time git-rev-list v2.6.12..HEAD > /dev/null
0.26user 0.00system 0:00.27elapsed 100%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+2433minor)pagefaults 0swaps
note how the minor faults have decreased from 3714 pages to 2433 pages.
That's all due to the fewer anonymous pages allocated to hold the comment
buffers and their metadata.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-09-16 05:43:17 +08:00
|
|
|
if (save_commit_buffer && !ret) {
|
2005-05-26 09:27:14 +08:00
|
|
|
item->buffer = buffer;
|
|
|
|
return 0;
|
|
|
|
}
|
2005-05-07 01:48:34 +08:00
|
|
|
free(buffer);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2005-05-31 09:44:02 +08:00
|
|
|
struct commit_list *commit_list_insert(struct commit *item, struct commit_list **list_p)
|
2005-04-24 09:47:23 +08:00
|
|
|
{
|
2005-04-27 03:00:58 +08:00
|
|
|
struct commit_list *new_list = xmalloc(sizeof(struct commit_list));
|
2005-04-24 09:47:23 +08:00
|
|
|
new_list->item = item;
|
|
|
|
new_list->next = *list_p;
|
|
|
|
*list_p = new_list;
|
2005-05-31 09:44:02 +08:00
|
|
|
return new_list;
|
2005-04-24 09:47:23 +08:00
|
|
|
}
|
|
|
|
|
2005-04-19 02:39:48 +08:00
|
|
|
void free_commit_list(struct commit_list *list)
|
|
|
|
{
|
|
|
|
while (list) {
|
|
|
|
struct commit_list *temp = list;
|
|
|
|
list = temp->next;
|
|
|
|
free(temp);
|
|
|
|
}
|
|
|
|
}
|
2005-04-24 09:47:23 +08:00
|
|
|
|
2005-07-07 00:31:17 +08:00
|
|
|
struct commit_list * insert_by_date(struct commit *item, struct commit_list **list)
|
2005-04-24 09:47:23 +08:00
|
|
|
{
|
|
|
|
struct commit_list **pp = list;
|
|
|
|
struct commit_list *p;
|
|
|
|
while ((p = *pp) != NULL) {
|
|
|
|
if (p->item->date < item->date) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
pp = &p->next;
|
|
|
|
}
|
2005-07-07 00:31:17 +08:00
|
|
|
return commit_list_insert(item, pp);
|
2005-04-24 09:47:23 +08:00
|
|
|
}
|
|
|
|
|
2007-06-07 15:04:01 +08:00
|
|
|
|
2005-04-24 09:47:23 +08:00
|
|
|
void sort_by_date(struct commit_list **list)
|
|
|
|
{
|
|
|
|
struct commit_list *ret = NULL;
|
|
|
|
while (*list) {
|
2005-07-07 00:31:17 +08:00
|
|
|
insert_by_date((*list)->item, &ret);
|
2005-04-24 09:47:23 +08:00
|
|
|
*list = (*list)->next;
|
|
|
|
}
|
|
|
|
*list = ret;
|
|
|
|
}
|
|
|
|
|
2005-04-24 11:29:22 +08:00
|
|
|
struct commit *pop_most_recent_commit(struct commit_list **list,
|
|
|
|
unsigned int mark)
|
2005-04-24 09:47:23 +08:00
|
|
|
{
|
|
|
|
struct commit *ret = (*list)->item;
|
|
|
|
struct commit_list *parents = ret->parents;
|
|
|
|
struct commit_list *old = *list;
|
|
|
|
|
|
|
|
*list = (*list)->next;
|
|
|
|
free(old);
|
|
|
|
|
|
|
|
while (parents) {
|
2005-04-24 10:21:28 +08:00
|
|
|
struct commit *commit = parents->item;
|
2005-04-24 11:29:22 +08:00
|
|
|
parse_commit(commit);
|
|
|
|
if (!(commit->object.flags & mark)) {
|
|
|
|
commit->object.flags |= mark;
|
2005-07-07 00:31:17 +08:00
|
|
|
insert_by_date(commit, list);
|
2005-04-24 10:21:28 +08:00
|
|
|
}
|
2005-04-24 09:47:23 +08:00
|
|
|
parents = parents->next;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
2005-06-01 23:34:23 +08:00
|
|
|
|
2006-01-08 10:52:42 +08:00
|
|
|
void clear_commit_marks(struct commit *commit, unsigned int mark)
|
|
|
|
{
|
2007-10-11 06:14:35 +08:00
|
|
|
while (commit) {
|
|
|
|
struct commit_list *parents;
|
2006-01-08 10:52:42 +08:00
|
|
|
|
2007-10-11 06:14:35 +08:00
|
|
|
if (!(mark & commit->object.flags))
|
|
|
|
return;
|
2006-07-05 08:45:22 +08:00
|
|
|
|
2007-10-11 06:14:35 +08:00
|
|
|
commit->object.flags &= ~mark;
|
|
|
|
|
|
|
|
parents = commit->parents;
|
|
|
|
if (!parents)
|
|
|
|
return;
|
|
|
|
|
|
|
|
while ((parents = parents->next))
|
|
|
|
clear_commit_marks(parents->item, mark);
|
|
|
|
|
|
|
|
commit = commit->parents->item;
|
2006-01-08 10:52:42 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-06-06 23:39:40 +08:00
|
|
|
struct commit *pop_commit(struct commit_list **stack)
|
|
|
|
{
|
|
|
|
struct commit_list *top = *stack;
|
|
|
|
struct commit *item = top ? top->item : NULL;
|
|
|
|
|
|
|
|
if (top) {
|
|
|
|
*stack = top->next;
|
|
|
|
free(top);
|
|
|
|
}
|
|
|
|
return item;
|
|
|
|
}
|
|
|
|
|
2005-07-07 00:39:34 +08:00
|
|
|
/*
|
|
|
|
* Performs an in-place topological sort on the list supplied.
|
|
|
|
*/
|
2006-02-16 14:05:33 +08:00
|
|
|
void sort_in_topological_order(struct commit_list ** list, int lifo)
|
2006-03-10 17:21:37 +08:00
|
|
|
{
|
2007-11-03 04:32:58 +08:00
|
|
|
struct commit_list *next, *orig = *list;
|
|
|
|
struct commit_list *work, **insert;
|
|
|
|
struct commit_list **pptr;
|
2007-06-07 15:04:01 +08:00
|
|
|
|
2007-11-03 04:32:58 +08:00
|
|
|
if (!orig)
|
2005-12-24 20:12:43 +08:00
|
|
|
return;
|
2007-11-03 04:32:58 +08:00
|
|
|
*list = NULL;
|
|
|
|
|
|
|
|
/* Mark them and clear the indegree */
|
|
|
|
for (next = orig; next; next = next->next) {
|
|
|
|
struct commit *commit = next->item;
|
|
|
|
commit->object.flags |= TOPOSORT;
|
|
|
|
commit->indegree = 0;
|
2005-07-07 00:39:34 +08:00
|
|
|
}
|
2007-11-03 04:32:58 +08:00
|
|
|
|
2005-07-07 00:39:34 +08:00
|
|
|
/* update the indegree */
|
2007-11-03 04:32:58 +08:00
|
|
|
for (next = orig; next; next = next->next) {
|
2005-07-07 00:39:34 +08:00
|
|
|
struct commit_list * parents = next->item->parents;
|
|
|
|
while (parents) {
|
2007-11-03 04:32:58 +08:00
|
|
|
struct commit *parent = parents->item;
|
2006-03-10 17:21:37 +08:00
|
|
|
|
2007-11-03 04:32:58 +08:00
|
|
|
if (parent->object.flags & TOPOSORT)
|
|
|
|
parent->indegree++;
|
|
|
|
parents = parents->next;
|
2005-07-07 00:39:34 +08:00
|
|
|
}
|
|
|
|
}
|
2007-11-03 04:32:58 +08:00
|
|
|
|
2007-06-07 15:04:01 +08:00
|
|
|
/*
|
2007-09-10 18:35:06 +08:00
|
|
|
* find the tips
|
|
|
|
*
|
|
|
|
* tips are nodes not reachable from any other node in the list
|
|
|
|
*
|
|
|
|
* the tips serve as a starting set for the work queue.
|
|
|
|
*/
|
2007-11-03 04:32:58 +08:00
|
|
|
work = NULL;
|
2005-11-15 02:01:26 +08:00
|
|
|
insert = &work;
|
2007-11-03 04:32:58 +08:00
|
|
|
for (next = orig; next; next = next->next) {
|
|
|
|
struct commit *commit = next->item;
|
2005-07-07 00:39:34 +08:00
|
|
|
|
2007-11-03 04:32:58 +08:00
|
|
|
if (!commit->indegree)
|
|
|
|
insert = &commit_list_insert(commit, insert)->next;
|
2005-07-07 00:39:34 +08:00
|
|
|
}
|
2006-02-16 14:05:33 +08:00
|
|
|
|
2005-07-07 00:39:34 +08:00
|
|
|
/* process the list in topological order */
|
2006-02-16 14:05:33 +08:00
|
|
|
if (!lifo)
|
|
|
|
sort_by_date(&work);
|
2007-11-03 04:32:58 +08:00
|
|
|
|
|
|
|
pptr = list;
|
|
|
|
*list = NULL;
|
2005-07-07 00:39:34 +08:00
|
|
|
while (work) {
|
2007-11-03 04:32:58 +08:00
|
|
|
struct commit *commit;
|
|
|
|
struct commit_list *parents, *work_item;
|
2005-07-07 00:39:34 +08:00
|
|
|
|
2007-11-03 04:32:58 +08:00
|
|
|
work_item = work;
|
|
|
|
work = work_item->next;
|
|
|
|
work_item->next = NULL;
|
|
|
|
|
|
|
|
commit = work_item->item;
|
|
|
|
for (parents = commit->parents; parents ; parents = parents->next) {
|
|
|
|
struct commit *parent=parents->item;
|
|
|
|
|
|
|
|
if (!(parent->object.flags & TOPOSORT))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* parents are only enqueued for emission
|
|
|
|
* when all their children have been emitted thereby
|
|
|
|
* guaranteeing topological order.
|
|
|
|
*/
|
|
|
|
if (!--parent->indegree) {
|
|
|
|
if (!lifo)
|
|
|
|
insert_by_date(parent, &work);
|
|
|
|
else
|
|
|
|
commit_list_insert(parent, &work);
|
2005-07-07 00:39:34 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
/*
|
2007-09-10 18:35:06 +08:00
|
|
|
* work_item is a commit all of whose children
|
|
|
|
* have already been emitted. we can emit it now.
|
|
|
|
*/
|
2007-11-03 04:32:58 +08:00
|
|
|
commit->object.flags &= ~TOPOSORT;
|
|
|
|
*pptr = work_item;
|
|
|
|
pptr = &work_item->next;
|
2005-07-07 00:39:34 +08:00
|
|
|
}
|
|
|
|
}
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2007-01-09 15:10:49 +08:00
|
|
|
/* merge-base stuff */
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2006-10-23 08:32:47 +08:00
|
|
|
/* bits #0..15 in revision.h */
|
|
|
|
#define PARENT1 (1u<<16)
|
|
|
|
#define PARENT2 (1u<<17)
|
|
|
|
#define STALE (1u<<18)
|
|
|
|
#define RESULT (1u<<19)
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2007-01-09 15:10:49 +08:00
|
|
|
static const unsigned all_flags = (PARENT1 | PARENT2 | STALE | RESULT);
|
|
|
|
|
2006-06-29 21:17:32 +08:00
|
|
|
static struct commit *interesting(struct commit_list *list)
|
|
|
|
{
|
|
|
|
while (list) {
|
|
|
|
struct commit *commit = list->item;
|
|
|
|
list = list->next;
|
2006-07-03 02:34:17 +08:00
|
|
|
if (commit->object.flags & STALE)
|
2006-06-29 21:17:32 +08:00
|
|
|
continue;
|
|
|
|
return commit;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
static struct commit_list *merge_bases(struct commit *one, struct commit *two)
|
2006-06-29 21:17:32 +08:00
|
|
|
{
|
|
|
|
struct commit_list *list = NULL;
|
|
|
|
struct commit_list *result = NULL;
|
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
if (one == two)
|
|
|
|
/* We do not mark this even with RESULT so we do not
|
|
|
|
* have to clean it up.
|
|
|
|
*/
|
|
|
|
return commit_list_insert(one, &result);
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
parse_commit(one);
|
|
|
|
parse_commit(two);
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
one->object.flags |= PARENT1;
|
|
|
|
two->object.flags |= PARENT2;
|
|
|
|
insert_by_date(one, &list);
|
|
|
|
insert_by_date(two, &list);
|
2006-06-29 21:17:32 +08:00
|
|
|
|
|
|
|
while (interesting(list)) {
|
2006-07-05 09:46:42 +08:00
|
|
|
struct commit *commit;
|
2006-06-29 21:17:32 +08:00
|
|
|
struct commit_list *parents;
|
2006-07-05 09:46:42 +08:00
|
|
|
struct commit_list *n;
|
|
|
|
int flags;
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
commit = list->item;
|
|
|
|
n = list->next;
|
|
|
|
free(list);
|
|
|
|
list = n;
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
flags = commit->object.flags & (PARENT1 | PARENT2 | STALE);
|
|
|
|
if (flags == (PARENT1 | PARENT2)) {
|
|
|
|
if (!(commit->object.flags & RESULT)) {
|
|
|
|
commit->object.flags |= RESULT;
|
|
|
|
insert_by_date(commit, &result);
|
|
|
|
}
|
2006-07-03 02:34:17 +08:00
|
|
|
/* Mark parents of a found merge stale */
|
|
|
|
flags |= STALE;
|
2006-06-29 21:17:32 +08:00
|
|
|
}
|
|
|
|
parents = commit->parents;
|
|
|
|
while (parents) {
|
|
|
|
struct commit *p = parents->item;
|
|
|
|
parents = parents->next;
|
|
|
|
if ((p->object.flags & flags) == flags)
|
|
|
|
continue;
|
|
|
|
parse_commit(p);
|
|
|
|
p->object.flags |= flags;
|
|
|
|
insert_by_date(p, &list);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
/* Clean up the result to remove stale ones */
|
2007-01-09 15:10:49 +08:00
|
|
|
free_commit_list(list);
|
2006-07-05 09:46:42 +08:00
|
|
|
list = result; result = NULL;
|
|
|
|
while (list) {
|
|
|
|
struct commit_list *n = list->next;
|
|
|
|
if (!(list->item->object.flags & STALE))
|
|
|
|
insert_by_date(list->item, &result);
|
|
|
|
free(list);
|
|
|
|
list = n;
|
|
|
|
}
|
|
|
|
return result;
|
|
|
|
}
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
struct commit_list *get_merge_bases(struct commit *one,
|
2007-09-10 18:35:06 +08:00
|
|
|
struct commit *two, int cleanup)
|
2006-07-05 09:46:42 +08:00
|
|
|
{
|
|
|
|
struct commit_list *list;
|
|
|
|
struct commit **rslt;
|
|
|
|
struct commit_list *result;
|
|
|
|
int cnt, i, j;
|
|
|
|
|
|
|
|
result = merge_bases(one, two);
|
|
|
|
if (one == two)
|
|
|
|
return result;
|
|
|
|
if (!result || !result->next) {
|
|
|
|
if (cleanup) {
|
|
|
|
clear_commit_marks(one, all_flags);
|
|
|
|
clear_commit_marks(two, all_flags);
|
2006-06-29 21:17:32 +08:00
|
|
|
}
|
2006-07-05 09:46:42 +08:00
|
|
|
return result;
|
2006-06-29 21:17:32 +08:00
|
|
|
}
|
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
/* There are more than one */
|
|
|
|
cnt = 0;
|
|
|
|
list = result;
|
|
|
|
while (list) {
|
|
|
|
list = list->next;
|
|
|
|
cnt++;
|
|
|
|
}
|
|
|
|
rslt = xcalloc(cnt, sizeof(*rslt));
|
|
|
|
for (list = result, i = 0; list; list = list->next)
|
|
|
|
rslt[i++] = list->item;
|
|
|
|
free_commit_list(result);
|
|
|
|
|
|
|
|
clear_commit_marks(one, all_flags);
|
|
|
|
clear_commit_marks(two, all_flags);
|
|
|
|
for (i = 0; i < cnt - 1; i++) {
|
|
|
|
for (j = i+1; j < cnt; j++) {
|
|
|
|
if (!rslt[i] || !rslt[j])
|
|
|
|
continue;
|
|
|
|
result = merge_bases(rslt[i], rslt[j]);
|
|
|
|
clear_commit_marks(rslt[i], all_flags);
|
|
|
|
clear_commit_marks(rslt[j], all_flags);
|
|
|
|
for (list = result; list; list = list->next) {
|
|
|
|
if (rslt[i] == list->item)
|
|
|
|
rslt[i] = NULL;
|
|
|
|
if (rslt[j] == list->item)
|
|
|
|
rslt[j] = NULL;
|
|
|
|
}
|
|
|
|
}
|
2006-07-05 08:45:22 +08:00
|
|
|
}
|
2006-06-29 21:17:32 +08:00
|
|
|
|
2006-07-05 09:46:42 +08:00
|
|
|
/* Surviving ones in rslt[] are the independent results */
|
|
|
|
result = NULL;
|
|
|
|
for (i = 0; i < cnt; i++) {
|
|
|
|
if (rslt[i])
|
|
|
|
insert_by_date(rslt[i], &result);
|
|
|
|
}
|
|
|
|
free(rslt);
|
2006-06-29 21:17:32 +08:00
|
|
|
return result;
|
|
|
|
}
|
2006-12-19 16:14:04 +08:00
|
|
|
|
2007-01-09 15:22:31 +08:00
|
|
|
int in_merge_bases(struct commit *commit, struct commit **reference, int num)
|
2006-12-19 16:14:04 +08:00
|
|
|
{
|
|
|
|
struct commit_list *bases, *b;
|
|
|
|
int ret = 0;
|
|
|
|
|
2007-01-09 15:22:31 +08:00
|
|
|
if (num == 1)
|
|
|
|
bases = get_merge_bases(commit, *reference, 1);
|
|
|
|
else
|
|
|
|
die("not yet");
|
2006-12-19 16:14:04 +08:00
|
|
|
for (b = bases; b; b = b->next) {
|
2007-01-09 15:22:31 +08:00
|
|
|
if (!hashcmp(commit->object.sha1, b->item->object.sha1)) {
|
2006-12-19 16:14:04 +08:00
|
|
|
ret = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
free_commit_list(bases);
|
|
|
|
return ret;
|
|
|
|
}
|