2005-07-13 02:49:27 +08:00
|
|
|
/*
|
|
|
|
* ident.c
|
|
|
|
*
|
|
|
|
* create git identifier lines of the form "name <email> date"
|
|
|
|
*
|
|
|
|
* Copyright (C) 2005 Linus Torvalds
|
|
|
|
*/
|
|
|
|
#include "cache.h"
|
|
|
|
|
2012-05-22 07:09:57 +08:00
|
|
|
#define MAX_GITNAME (1000)
|
|
|
|
static char git_default_name[MAX_GITNAME];
|
|
|
|
static char git_default_email[MAX_GITNAME];
|
2005-10-12 09:47:34 +08:00
|
|
|
static char git_default_date[50];
|
2012-05-22 07:09:57 +08:00
|
|
|
int user_ident_explicitly_given;
|
2005-07-13 02:49:27 +08:00
|
|
|
|
2011-05-19 19:37:55 +08:00
|
|
|
#ifdef NO_GECOS_IN_PWENT
|
|
|
|
#define get_gecos(ignored) "&"
|
|
|
|
#else
|
|
|
|
#define get_gecos(struct_passwd) ((struct_passwd)->pw_gecos)
|
|
|
|
#endif
|
|
|
|
|
2007-04-16 02:51:29 +08:00
|
|
|
static void copy_gecos(const struct passwd *w, char *name, size_t sz)
|
2005-09-20 07:06:56 +08:00
|
|
|
{
|
|
|
|
char *src, *dst;
|
2007-04-16 02:51:29 +08:00
|
|
|
size_t len, nlen;
|
2005-09-20 07:06:56 +08:00
|
|
|
|
|
|
|
nlen = strlen(w->pw_name);
|
|
|
|
|
|
|
|
/* Traditionally GECOS field had office phone numbers etc, separated
|
|
|
|
* with commas. Also & stands for capitalized form of the login name.
|
|
|
|
*/
|
|
|
|
|
2011-05-19 19:37:55 +08:00
|
|
|
for (len = 0, dst = name, src = get_gecos(w); len < sz; src++) {
|
2005-09-20 07:06:56 +08:00
|
|
|
int ch = *src;
|
|
|
|
if (ch != '&') {
|
|
|
|
*dst++ = ch;
|
|
|
|
if (ch == 0 || ch == ',')
|
|
|
|
break;
|
|
|
|
len++;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (len + nlen < sz) {
|
|
|
|
/* Sorry, Mr. McDonald... */
|
|
|
|
*dst++ = toupper(*w->pw_name);
|
|
|
|
memcpy(dst, w->pw_name + 1, nlen - 1);
|
|
|
|
dst += nlen - 1;
|
2011-05-17 04:08:21 +08:00
|
|
|
len += nlen;
|
2005-09-20 07:06:56 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
if (len < sz)
|
|
|
|
name[len] = 0;
|
|
|
|
else
|
|
|
|
die("Your parents must have hated you!");
|
|
|
|
|
|
|
|
}
|
|
|
|
|
ident: check /etc/mailname if email is unknown
Before falling back to gethostname(), check /etc/mailname if
GIT_AUTHOR_EMAIL is not set in the environment or through config
files. Only fall back if /etc/mailname cannot be opened or read.
The /etc/mailname convention comes from Debian policy section 11.6
("mail transport, delivery and user agents"), though maybe it could be
useful sometimes on other machines, too. The lack of this support was
noticed by various people in different ways:
- Ian observed that git was choosing the address
'ian@anarres.relativity.greenend.org.uk' rather than
'ian@davenant.greenend.org.uk' as it should have done.
- Jonathan noticed that operations like "git commit" were needlessly
slow when using a resolver that was slow to handle reverse DNS
lookups.
Alas, after this patch, if /etc/mailname is set up and the [user] name
and email configuration aren't, the committer email will not provide a
charming reminder of which machine commits were made on any more. But
I think it's worth it.
Mechanics: the functionality of reading mailname goes in its own
function, so people who care about other distros can easily add an
implementation to a similar location without making copy_email() too
long and losing clarity. While at it, we split out the fallback
default logic that does gethostname(), too (rearranging it a little
and adding a check for errors from gethostname while at it).
Based on a patch by Gerrit Pape <pape@smarden.org>.
Requested-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-10-03 14:16:33 +08:00
|
|
|
static int add_mailname_host(char *buf, size_t len)
|
|
|
|
{
|
|
|
|
FILE *mailname;
|
|
|
|
|
|
|
|
mailname = fopen("/etc/mailname", "r");
|
|
|
|
if (!mailname) {
|
|
|
|
if (errno != ENOENT)
|
|
|
|
warning("cannot open /etc/mailname: %s",
|
|
|
|
strerror(errno));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
if (!fgets(buf, len, mailname)) {
|
|
|
|
if (ferror(mailname))
|
|
|
|
warning("cannot read /etc/mailname: %s",
|
|
|
|
strerror(errno));
|
|
|
|
fclose(mailname);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
/* success! */
|
|
|
|
fclose(mailname);
|
2012-05-22 07:10:02 +08:00
|
|
|
|
|
|
|
len = strlen(buf);
|
|
|
|
if (len && buf[len-1] == '\n')
|
|
|
|
buf[len-1] = '\0';
|
ident: check /etc/mailname if email is unknown
Before falling back to gethostname(), check /etc/mailname if
GIT_AUTHOR_EMAIL is not set in the environment or through config
files. Only fall back if /etc/mailname cannot be opened or read.
The /etc/mailname convention comes from Debian policy section 11.6
("mail transport, delivery and user agents"), though maybe it could be
useful sometimes on other machines, too. The lack of this support was
noticed by various people in different ways:
- Ian observed that git was choosing the address
'ian@anarres.relativity.greenend.org.uk' rather than
'ian@davenant.greenend.org.uk' as it should have done.
- Jonathan noticed that operations like "git commit" were needlessly
slow when using a resolver that was slow to handle reverse DNS
lookups.
Alas, after this patch, if /etc/mailname is set up and the [user] name
and email configuration aren't, the committer email will not provide a
charming reminder of which machine commits were made on any more. But
I think it's worth it.
Mechanics: the functionality of reading mailname goes in its own
function, so people who care about other distros can easily add an
implementation to a similar location without making copy_email() too
long and losing clarity. While at it, we split out the fallback
default logic that does gethostname(), too (rearranging it a little
and adding a check for errors from gethostname while at it).
Based on a patch by Gerrit Pape <pape@smarden.org>.
Requested-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-10-03 14:16:33 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void add_domainname(char *buf, size_t len)
|
|
|
|
{
|
|
|
|
struct hostent *he;
|
|
|
|
size_t namelen;
|
|
|
|
const char *domainname;
|
|
|
|
|
|
|
|
if (gethostname(buf, len)) {
|
|
|
|
warning("cannot get host name: %s", strerror(errno));
|
|
|
|
strlcpy(buf, "(none)", len);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
namelen = strlen(buf);
|
|
|
|
if (memchr(buf, '.', namelen))
|
|
|
|
return;
|
|
|
|
|
|
|
|
he = gethostbyname(buf);
|
|
|
|
buf[namelen++] = '.';
|
|
|
|
buf += namelen;
|
|
|
|
len -= namelen;
|
|
|
|
if (he && (domainname = strchr(he->h_name, '.')))
|
|
|
|
strlcpy(buf, domainname + 1, len);
|
|
|
|
else
|
|
|
|
strlcpy(buf, "(none)", len);
|
|
|
|
}
|
|
|
|
|
2007-04-16 05:40:31 +08:00
|
|
|
static void copy_email(const struct passwd *pw)
|
2005-07-13 02:49:27 +08:00
|
|
|
{
|
2007-01-28 16:50:53 +08:00
|
|
|
/*
|
|
|
|
* Make up a fake email address
|
|
|
|
* (name + '@' + hostname [+ '.' + domainname])
|
|
|
|
*/
|
2007-04-16 02:51:29 +08:00
|
|
|
size_t len = strlen(pw->pw_name);
|
2005-10-12 09:47:34 +08:00
|
|
|
if (len > sizeof(git_default_email)/2)
|
2005-07-15 08:52:31 +08:00
|
|
|
die("Your sysadmin must hate you!");
|
2005-10-12 09:47:34 +08:00
|
|
|
memcpy(git_default_email, pw->pw_name, len);
|
|
|
|
git_default_email[len++] = '@';
|
ident: check /etc/mailname if email is unknown
Before falling back to gethostname(), check /etc/mailname if
GIT_AUTHOR_EMAIL is not set in the environment or through config
files. Only fall back if /etc/mailname cannot be opened or read.
The /etc/mailname convention comes from Debian policy section 11.6
("mail transport, delivery and user agents"), though maybe it could be
useful sometimes on other machines, too. The lack of this support was
noticed by various people in different ways:
- Ian observed that git was choosing the address
'ian@anarres.relativity.greenend.org.uk' rather than
'ian@davenant.greenend.org.uk' as it should have done.
- Jonathan noticed that operations like "git commit" were needlessly
slow when using a resolver that was slow to handle reverse DNS
lookups.
Alas, after this patch, if /etc/mailname is set up and the [user] name
and email configuration aren't, the committer email will not provide a
charming reminder of which machine commits were made on any more. But
I think it's worth it.
Mechanics: the functionality of reading mailname goes in its own
function, so people who care about other distros can easily add an
implementation to a similar location without making copy_email() too
long and losing clarity. While at it, we split out the fallback
default logic that does gethostname(), too (rearranging it a little
and adding a check for errors from gethostname while at it).
Based on a patch by Gerrit Pape <pape@smarden.org>.
Requested-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-10-03 14:16:33 +08:00
|
|
|
|
|
|
|
if (!add_mailname_host(git_default_email + len,
|
|
|
|
sizeof(git_default_email) - len))
|
|
|
|
return; /* read from "/etc/mailname" (Debian) */
|
|
|
|
add_domainname(git_default_email + len,
|
|
|
|
sizeof(git_default_email) - len);
|
2007-01-28 16:50:53 +08:00
|
|
|
}
|
|
|
|
|
2012-05-22 07:09:43 +08:00
|
|
|
const char *ident_default_name(void)
|
2007-01-28 16:50:53 +08:00
|
|
|
{
|
2012-05-22 07:09:43 +08:00
|
|
|
if (!git_default_name[0]) {
|
|
|
|
struct passwd *pw = getpwuid(getuid());
|
2007-01-28 16:50:53 +08:00
|
|
|
if (!pw)
|
|
|
|
die("You don't exist. Go away!");
|
|
|
|
copy_gecos(pw, git_default_name, sizeof(git_default_name));
|
|
|
|
}
|
2012-05-22 07:09:43 +08:00
|
|
|
return git_default_name;
|
|
|
|
}
|
2007-01-28 16:50:53 +08:00
|
|
|
|
2012-05-22 07:09:43 +08:00
|
|
|
const char *ident_default_email(void)
|
|
|
|
{
|
|
|
|
if (!git_default_email[0]) {
|
2007-07-06 08:29:41 +08:00
|
|
|
const char *email = getenv("EMAIL");
|
|
|
|
|
2010-01-09 00:01:10 +08:00
|
|
|
if (email && email[0]) {
|
2007-07-06 08:29:41 +08:00
|
|
|
strlcpy(git_default_email, email,
|
|
|
|
sizeof(git_default_email));
|
2010-01-09 00:01:10 +08:00
|
|
|
user_ident_explicitly_given |= IDENT_MAIL_GIVEN;
|
|
|
|
} else {
|
2012-05-22 07:09:43 +08:00
|
|
|
struct passwd *pw = getpwuid(getuid());
|
2007-07-06 08:29:41 +08:00
|
|
|
if (!pw)
|
|
|
|
die("You don't exist. Go away!");
|
|
|
|
copy_email(pw);
|
|
|
|
}
|
2007-01-28 16:50:53 +08:00
|
|
|
}
|
2012-05-22 07:09:43 +08:00
|
|
|
return git_default_email;
|
|
|
|
}
|
2007-01-28 16:50:53 +08:00
|
|
|
|
2012-05-22 07:09:43 +08:00
|
|
|
const char *ident_default_date(void)
|
|
|
|
{
|
2007-01-28 16:50:53 +08:00
|
|
|
if (!git_default_date[0])
|
|
|
|
datestamp(git_default_date, sizeof(git_default_date));
|
2012-05-22 07:09:43 +08:00
|
|
|
return git_default_date;
|
2005-07-13 02:49:27 +08:00
|
|
|
}
|
|
|
|
|
2007-04-16 02:51:29 +08:00
|
|
|
static int add_raw(char *buf, size_t size, int offset, const char *str)
|
2005-07-13 02:49:27 +08:00
|
|
|
{
|
2007-04-16 02:51:29 +08:00
|
|
|
size_t len = strlen(str);
|
2005-07-13 02:49:27 +08:00
|
|
|
if (offset + len > size)
|
|
|
|
return size;
|
|
|
|
memcpy(buf + offset, str, len);
|
|
|
|
return offset + len;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int crud(unsigned char c)
|
|
|
|
{
|
2007-12-04 03:11:43 +08:00
|
|
|
return c <= 32 ||
|
|
|
|
c == '.' ||
|
|
|
|
c == ',' ||
|
|
|
|
c == ':' ||
|
|
|
|
c == ';' ||
|
|
|
|
c == '<' ||
|
|
|
|
c == '>' ||
|
|
|
|
c == '"' ||
|
2008-12-02 00:41:50 +08:00
|
|
|
c == '\\' ||
|
2007-12-04 03:11:43 +08:00
|
|
|
c == '\'';
|
2005-07-13 02:49:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy over a string to the destination, but avoid special
|
|
|
|
* characters ('\n', '<' and '>') and remove crud at the end
|
|
|
|
*/
|
2007-04-16 02:51:29 +08:00
|
|
|
static int copy(char *buf, size_t size, int offset, const char *src)
|
2005-07-13 02:49:27 +08:00
|
|
|
{
|
2007-04-16 02:51:29 +08:00
|
|
|
size_t i, len;
|
2005-07-13 02:49:27 +08:00
|
|
|
unsigned char c;
|
|
|
|
|
|
|
|
/* Remove crud from the beginning.. */
|
|
|
|
while ((c = *src) != 0) {
|
|
|
|
if (!crud(c))
|
|
|
|
break;
|
|
|
|
src++;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Remove crud from the end.. */
|
|
|
|
len = strlen(src);
|
|
|
|
while (len > 0) {
|
|
|
|
c = src[len-1];
|
|
|
|
if (!crud(c))
|
|
|
|
break;
|
|
|
|
--len;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the rest to the buffer, but avoid the special
|
2005-12-29 17:30:08 +08:00
|
|
|
* characters '\n' '<' and '>' that act as delimiters on
|
2008-01-03 22:18:07 +08:00
|
|
|
* an identification line
|
2005-07-13 02:49:27 +08:00
|
|
|
*/
|
|
|
|
for (i = 0; i < len; i++) {
|
|
|
|
c = *src++;
|
|
|
|
switch (c) {
|
|
|
|
case '\n': case '<': case '>':
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (offset >= size)
|
|
|
|
return size;
|
|
|
|
buf[offset++] = c;
|
|
|
|
}
|
|
|
|
return offset;
|
|
|
|
}
|
|
|
|
|
2012-03-11 17:25:43 +08:00
|
|
|
/*
|
|
|
|
* Reverse of fmt_ident(); given an ident line, split the fields
|
|
|
|
* to allow the caller to parse it.
|
|
|
|
* Signal a success by returning 0, but date/tz fields of the result
|
|
|
|
* can still be NULL if the input line only has the name/email part
|
|
|
|
* (e.g. reading from a reflog entry).
|
|
|
|
*/
|
|
|
|
int split_ident_line(struct ident_split *split, const char *line, int len)
|
|
|
|
{
|
|
|
|
const char *cp;
|
|
|
|
size_t span;
|
|
|
|
int status = -1;
|
|
|
|
|
|
|
|
memset(split, 0, sizeof(*split));
|
|
|
|
|
|
|
|
split->name_begin = line;
|
|
|
|
for (cp = line; *cp && cp < line + len; cp++)
|
|
|
|
if (*cp == '<') {
|
|
|
|
split->mail_begin = cp + 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (!split->mail_begin)
|
|
|
|
return status;
|
|
|
|
|
|
|
|
for (cp = split->mail_begin - 2; line < cp; cp--)
|
|
|
|
if (!isspace(*cp)) {
|
|
|
|
split->name_end = cp + 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (!split->name_end)
|
|
|
|
return status;
|
|
|
|
|
|
|
|
for (cp = split->mail_begin; cp < line + len; cp++)
|
|
|
|
if (*cp == '>') {
|
|
|
|
split->mail_end = cp;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (!split->mail_end)
|
|
|
|
return status;
|
|
|
|
|
|
|
|
for (cp = split->mail_end + 1; cp < line + len && isspace(*cp); cp++)
|
|
|
|
;
|
|
|
|
if (line + len <= cp)
|
|
|
|
goto person_only;
|
|
|
|
split->date_begin = cp;
|
|
|
|
span = strspn(cp, "0123456789");
|
|
|
|
if (!span)
|
|
|
|
goto person_only;
|
|
|
|
split->date_end = split->date_begin + span;
|
|
|
|
for (cp = split->date_end; cp < line + len && isspace(*cp); cp++)
|
|
|
|
;
|
|
|
|
if (line + len <= cp || (*cp != '+' && *cp != '-'))
|
|
|
|
goto person_only;
|
|
|
|
split->tz_begin = cp;
|
|
|
|
span = strspn(cp + 1, "0123456789");
|
|
|
|
if (!span)
|
|
|
|
goto person_only;
|
|
|
|
split->tz_end = split->tz_begin + 1 + span;
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
person_only:
|
|
|
|
split->date_begin = NULL;
|
|
|
|
split->date_end = NULL;
|
|
|
|
split->tz_begin = NULL;
|
|
|
|
split->tz_end = NULL;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-02-19 12:31:05 +08:00
|
|
|
static const char *env_hint =
|
2006-11-28 18:27:39 +08:00
|
|
|
"\n"
|
2008-03-08 19:30:04 +08:00
|
|
|
"*** Please tell me who you are.\n"
|
2006-11-28 18:27:39 +08:00
|
|
|
"\n"
|
|
|
|
"Run\n"
|
|
|
|
"\n"
|
2007-12-07 07:36:45 +08:00
|
|
|
" git config --global user.email \"you@example.com\"\n"
|
2007-08-14 06:05:50 +08:00
|
|
|
" git config --global user.name \"Your Name\"\n"
|
2006-11-28 18:27:39 +08:00
|
|
|
"\n"
|
2007-08-14 06:05:50 +08:00
|
|
|
"to set your account\'s default identity.\n"
|
|
|
|
"Omit --global to set the identity only in this repository.\n"
|
2006-11-28 18:27:39 +08:00
|
|
|
"\n";
|
2006-02-19 12:31:05 +08:00
|
|
|
|
2007-12-09 09:32:08 +08:00
|
|
|
const char *fmt_ident(const char *name, const char *email,
|
|
|
|
const char *date_str, int flag)
|
2005-07-13 02:49:27 +08:00
|
|
|
{
|
|
|
|
static char buffer[1000];
|
|
|
|
char date[50];
|
|
|
|
int i;
|
2007-12-09 09:32:08 +08:00
|
|
|
int error_on_no_name = (flag & IDENT_ERROR_ON_NO_NAME);
|
|
|
|
int warn_on_no_name = (flag & IDENT_WARN_ON_NO_NAME);
|
|
|
|
int name_addr_only = (flag & IDENT_NO_DATE);
|
2005-07-13 02:49:27 +08:00
|
|
|
|
2012-05-22 07:09:43 +08:00
|
|
|
if (!name)
|
|
|
|
name = ident_default_name();
|
|
|
|
if (!email)
|
|
|
|
email = ident_default_email();
|
2006-02-08 05:19:10 +08:00
|
|
|
|
2006-02-19 12:31:05 +08:00
|
|
|
if (!*name) {
|
Allow non-developer to clone, checkout and fetch more easily.
The code that uses committer_info() in reflog can barf and die
whenever it is asked to update a ref. And I do not think
calling ignore_missing_committer_name() upfront like recent
receive-pack did in the aplication is a reasonable workaround.
What the patch does.
- git_committer_info() takes one parameter. It used to be "if
this is true, then die() if the name is not available due to
bad GECOS, otherwise issue a warning once but leave the name
empty". The reason was because we wanted to prevent bad
commits from being made by git-commit-tree (and its
callers). The value 0 is only used by "git var -l".
Now it takes -1, 0 or 1. When set to -1, it does not
complain but uses the pw->pw_name when name is not
available. Existing 0 and 1 values mean the same thing as
they used to mean before. 0 means issue warnings and leave
it empty, 1 means barf and die.
- ignore_missing_committer_name() and its existing caller
(receive-pack, to set the reflog) have been removed.
- git-format-patch, to come up with the phoney message ID when
asked to thread, now passes -1 to git_committer_info(). This
codepath uses only the e-mail part, ignoring the name. It
used to barf and die. The other call in the same program
when asked to add signed-off-by line based on committer
identity still passes 1 to make sure it barfs instead of
adding a bogus s-o-b line.
- log_ref_write in refs.c, to come up with the name to record
who initiated the ref update in the reflog, passes -1. It
used to barf and die.
The last change means that git-update-ref, git-branch, and
commit walker backends can now be used in a repository with
reflog by somebody who does not have the user identity required
to make a commit. They all used to barf and die.
I've run tests and all of them seem to pass, and also tried "git
clone" as a user whose GECOS is empty -- git clone works again
now (it was broken when reflog was enabled by default).
But this definitely needs extra sets of eyeballs.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-01-26 11:05:01 +08:00
|
|
|
struct passwd *pw;
|
|
|
|
|
2007-12-09 09:32:08 +08:00
|
|
|
if ((warn_on_no_name || error_on_no_name) &&
|
Allow non-developer to clone, checkout and fetch more easily.
The code that uses committer_info() in reflog can barf and die
whenever it is asked to update a ref. And I do not think
calling ignore_missing_committer_name() upfront like recent
receive-pack did in the aplication is a reasonable workaround.
What the patch does.
- git_committer_info() takes one parameter. It used to be "if
this is true, then die() if the name is not available due to
bad GECOS, otherwise issue a warning once but leave the name
empty". The reason was because we wanted to prevent bad
commits from being made by git-commit-tree (and its
callers). The value 0 is only used by "git var -l".
Now it takes -1, 0 or 1. When set to -1, it does not
complain but uses the pw->pw_name when name is not
available. Existing 0 and 1 values mean the same thing as
they used to mean before. 0 means issue warnings and leave
it empty, 1 means barf and die.
- ignore_missing_committer_name() and its existing caller
(receive-pack, to set the reflog) have been removed.
- git-format-patch, to come up with the phoney message ID when
asked to thread, now passes -1 to git_committer_info(). This
codepath uses only the e-mail part, ignoring the name. It
used to barf and die. The other call in the same program
when asked to add signed-off-by line based on committer
identity still passes 1 to make sure it barfs instead of
adding a bogus s-o-b line.
- log_ref_write in refs.c, to come up with the name to record
who initiated the ref update in the reflog, passes -1. It
used to barf and die.
The last change means that git-update-ref, git-branch, and
commit walker backends can now be used in a repository with
reflog by somebody who does not have the user identity required
to make a commit. They all used to barf and die.
I've run tests and all of them seem to pass, and also tried "git
clone" as a user whose GECOS is empty -- git clone works again
now (it was broken when reflog was enabled by default).
But this definitely needs extra sets of eyeballs.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-01-26 11:05:01 +08:00
|
|
|
name == git_default_name && env_hint) {
|
2010-01-17 16:19:24 +08:00
|
|
|
fputs(env_hint, stderr);
|
2009-11-12 07:57:36 +08:00
|
|
|
env_hint = NULL; /* warn only once */
|
2006-02-19 12:31:05 +08:00
|
|
|
}
|
2007-12-09 09:32:08 +08:00
|
|
|
if (error_on_no_name)
|
2006-02-19 12:31:05 +08:00
|
|
|
die("empty ident %s <%s> not allowed", name, email);
|
Allow non-developer to clone, checkout and fetch more easily.
The code that uses committer_info() in reflog can barf and die
whenever it is asked to update a ref. And I do not think
calling ignore_missing_committer_name() upfront like recent
receive-pack did in the aplication is a reasonable workaround.
What the patch does.
- git_committer_info() takes one parameter. It used to be "if
this is true, then die() if the name is not available due to
bad GECOS, otherwise issue a warning once but leave the name
empty". The reason was because we wanted to prevent bad
commits from being made by git-commit-tree (and its
callers). The value 0 is only used by "git var -l".
Now it takes -1, 0 or 1. When set to -1, it does not
complain but uses the pw->pw_name when name is not
available. Existing 0 and 1 values mean the same thing as
they used to mean before. 0 means issue warnings and leave
it empty, 1 means barf and die.
- ignore_missing_committer_name() and its existing caller
(receive-pack, to set the reflog) have been removed.
- git-format-patch, to come up with the phoney message ID when
asked to thread, now passes -1 to git_committer_info(). This
codepath uses only the e-mail part, ignoring the name. It
used to barf and die. The other call in the same program
when asked to add signed-off-by line based on committer
identity still passes 1 to make sure it barfs instead of
adding a bogus s-o-b line.
- log_ref_write in refs.c, to come up with the name to record
who initiated the ref update in the reflog, passes -1. It
used to barf and die.
The last change means that git-update-ref, git-branch, and
commit walker backends can now be used in a repository with
reflog by somebody who does not have the user identity required
to make a commit. They all used to barf and die.
I've run tests and all of them seem to pass, and also tried "git
clone" as a user whose GECOS is empty -- git clone works again
now (it was broken when reflog was enabled by default).
But this definitely needs extra sets of eyeballs.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-01-26 11:05:01 +08:00
|
|
|
pw = getpwuid(getuid());
|
|
|
|
if (!pw)
|
|
|
|
die("You don't exist. Go away!");
|
|
|
|
strlcpy(git_default_name, pw->pw_name,
|
|
|
|
sizeof(git_default_name));
|
|
|
|
name = git_default_name;
|
2006-02-19 12:31:05 +08:00
|
|
|
}
|
2006-02-08 05:19:10 +08:00
|
|
|
|
2012-05-22 07:09:43 +08:00
|
|
|
strcpy(date, ident_default_date());
|
2010-12-14 01:02:25 +08:00
|
|
|
if (!name_addr_only && date_str && date_str[0]) {
|
|
|
|
if (parse_date(date_str, date, sizeof(date)) < 0)
|
|
|
|
die("invalid date format: %s", date_str);
|
|
|
|
}
|
2005-07-13 02:49:27 +08:00
|
|
|
|
|
|
|
i = copy(buffer, sizeof(buffer), 0, name);
|
|
|
|
i = add_raw(buffer, sizeof(buffer), i, " <");
|
|
|
|
i = copy(buffer, sizeof(buffer), i, email);
|
2007-12-03 05:43:34 +08:00
|
|
|
if (!name_addr_only) {
|
|
|
|
i = add_raw(buffer, sizeof(buffer), i, "> ");
|
|
|
|
i = copy(buffer, sizeof(buffer), i, date);
|
|
|
|
} else {
|
|
|
|
i = add_raw(buffer, sizeof(buffer), i, ">");
|
|
|
|
}
|
2005-07-13 02:49:27 +08:00
|
|
|
if (i >= sizeof(buffer))
|
|
|
|
die("Impossibly long personal identifier");
|
|
|
|
buffer[i] = 0;
|
|
|
|
return buffer;
|
|
|
|
}
|
2005-07-15 08:50:33 +08:00
|
|
|
|
2007-12-03 05:43:34 +08:00
|
|
|
const char *fmt_name(const char *name, const char *email)
|
|
|
|
{
|
2007-12-09 09:32:08 +08:00
|
|
|
return fmt_ident(name, email, NULL, IDENT_ERROR_ON_NO_NAME | IDENT_NO_DATE);
|
2007-12-03 05:43:34 +08:00
|
|
|
}
|
|
|
|
|
2007-12-09 09:32:08 +08:00
|
|
|
const char *git_author_info(int flag)
|
2005-07-15 08:50:33 +08:00
|
|
|
{
|
2007-02-05 09:50:14 +08:00
|
|
|
return fmt_ident(getenv("GIT_AUTHOR_NAME"),
|
2005-11-22 15:44:35 +08:00
|
|
|
getenv("GIT_AUTHOR_EMAIL"),
|
2006-02-19 12:31:05 +08:00
|
|
|
getenv("GIT_AUTHOR_DATE"),
|
2007-12-09 09:32:08 +08:00
|
|
|
flag);
|
2005-07-15 08:50:33 +08:00
|
|
|
}
|
|
|
|
|
2007-12-09 09:32:08 +08:00
|
|
|
const char *git_committer_info(int flag)
|
2005-07-15 08:50:33 +08:00
|
|
|
{
|
2010-01-08 23:39:11 +08:00
|
|
|
if (getenv("GIT_COMMITTER_NAME"))
|
|
|
|
user_ident_explicitly_given |= IDENT_NAME_GIVEN;
|
|
|
|
if (getenv("GIT_COMMITTER_EMAIL"))
|
|
|
|
user_ident_explicitly_given |= IDENT_MAIL_GIVEN;
|
2007-02-05 09:50:14 +08:00
|
|
|
return fmt_ident(getenv("GIT_COMMITTER_NAME"),
|
2005-11-22 15:44:35 +08:00
|
|
|
getenv("GIT_COMMITTER_EMAIL"),
|
2006-02-19 12:31:05 +08:00
|
|
|
getenv("GIT_COMMITTER_DATE"),
|
2007-12-09 09:32:08 +08:00
|
|
|
flag);
|
2005-07-15 08:50:33 +08:00
|
|
|
}
|
2010-01-18 05:54:28 +08:00
|
|
|
|
|
|
|
int user_ident_sufficiently_given(void)
|
|
|
|
{
|
|
|
|
#ifndef WINDOWS
|
|
|
|
return (user_ident_explicitly_given & IDENT_MAIL_GIVEN);
|
|
|
|
#else
|
|
|
|
return (user_ident_explicitly_given == IDENT_ALL_GIVEN);
|
|
|
|
#endif
|
|
|
|
}
|
2012-05-22 07:09:54 +08:00
|
|
|
|
|
|
|
int git_ident_config(const char *var, const char *value, void *data)
|
|
|
|
{
|
|
|
|
if (!strcmp(var, "user.name")) {
|
|
|
|
if (!value)
|
|
|
|
return config_error_nonbool(var);
|
|
|
|
strlcpy(git_default_name, value, sizeof(git_default_name));
|
|
|
|
user_ident_explicitly_given |= IDENT_NAME_GIVEN;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!strcmp(var, "user.email")) {
|
|
|
|
if (!value)
|
|
|
|
return config_error_nonbool(var);
|
|
|
|
strlcpy(git_default_email, value, sizeof(git_default_email));
|
|
|
|
user_ident_explicitly_given |= IDENT_MAIL_GIVEN;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|