2006-10-24 05:27:45 +08:00
|
|
|
/*
|
|
|
|
|
* Builtin "git branch"
|
|
|
|
|
*
|
2007-07-12 13:52:45 +08:00
|
|
|
* Copyright (c) 2006 Kristian Høgsberg <krh@redhat.com>
|
2006-10-24 05:27:45 +08:00
|
|
|
* Based on git-branch.sh by Junio C Hamano.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include "cache.h"
|
2017-06-15 02:07:36 +08:00
|
|
|
#include "config.h"
|
2006-12-20 06:34:12 +08:00
|
|
|
#include "color.h"
|
2006-10-24 05:27:45 +08:00
|
|
|
#include "refs.h"
|
|
|
|
|
#include "commit.h"
|
|
|
|
|
#include "builtin.h"
|
2007-07-11 01:50:44 +08:00
|
|
|
#include "remote.h"
|
2007-10-08 00:26:21 +08:00
|
|
|
#include "parse-options.h"
|
2008-02-08 00:40:08 +08:00
|
|
|
#include "branch.h"
|
2008-07-24 06:13:41 +08:00
|
|
|
#include "diff.h"
|
|
|
|
|
#include "revision.h"
|
2012-04-13 18:54:38 +08:00
|
|
|
#include "string-list.h"
|
|
|
|
|
#include "column.h"
|
2012-08-26 02:17:12 +08:00
|
|
|
#include "utf8.h"
|
2013-03-13 19:42:53 +08:00
|
|
|
#include "wt-status.h"
|
2015-09-24 02:11:11 +08:00
|
|
|
#include "ref-filter.h"
|
2016-03-29 17:38:39 +08:00
|
|
|
#include "worktree.h"
|
2007-10-08 00:26:21 +08:00
|
|
|
|
|
|
|
|
static const char * const builtin_branch_usage[] = {
|
2015-01-13 15:44:47 +08:00
|
|
|
N_("git branch [<options>] [-r | -a] [--merged | --no-merged]"),
|
|
|
|
|
N_("git branch [<options>] [-l] [-f] <branch-name> [<start-point>]"),
|
|
|
|
|
N_("git branch [<options>] [-r] (-d | -D) <branch-name>..."),
|
|
|
|
|
N_("git branch [<options>] (-m | -M) [<old-branch>] <new-branch>"),
|
2015-09-24 02:11:13 +08:00
|
|
|
N_("git branch [<options>] [-r | -a] [--points-at]"),
|
2017-01-10 16:49:53 +08:00
|
|
|
N_("git branch [<options>] [-r | -a] [--format]"),
|
2007-10-08 00:26:21 +08:00
|
|
|
NULL
|
|
|
|
|
};
|
2006-10-24 05:27:45 +08:00
|
|
|
|
|
|
|
|
static const char *head;
|
2017-02-22 07:47:26 +08:00
|
|
|
static struct object_id head_oid;
|
2006-10-24 05:27:45 +08:00
|
|
|
|
2008-02-18 15:26:03 +08:00
|
|
|
static int branch_use_color = -1;
|
2006-12-12 14:41:52 +08:00
|
|
|
static char branch_colors[][COLOR_MAXLEN] = {
|
2009-02-14 05:53:40 +08:00
|
|
|
GIT_COLOR_RESET,
|
2017-01-10 16:49:52 +08:00
|
|
|
GIT_COLOR_NORMAL, /* PLAIN */
|
|
|
|
|
GIT_COLOR_RED, /* REMOTE */
|
|
|
|
|
GIT_COLOR_NORMAL, /* LOCAL */
|
|
|
|
|
GIT_COLOR_GREEN, /* CURRENT */
|
|
|
|
|
GIT_COLOR_BLUE, /* UPSTREAM */
|
2006-12-12 14:41:52 +08:00
|
|
|
};
|
|
|
|
|
enum color_branch {
|
2009-02-14 05:53:41 +08:00
|
|
|
BRANCH_COLOR_RESET = 0,
|
|
|
|
|
BRANCH_COLOR_PLAIN = 1,
|
|
|
|
|
BRANCH_COLOR_REMOTE = 2,
|
|
|
|
|
BRANCH_COLOR_LOCAL = 3,
|
2013-04-15 10:37:49 +08:00
|
|
|
BRANCH_COLOR_CURRENT = 4,
|
|
|
|
|
BRANCH_COLOR_UPSTREAM = 5
|
2006-12-12 14:41:52 +08:00
|
|
|
};
|
|
|
|
|
|
2012-04-13 18:54:38 +08:00
|
|
|
static struct string_list output = STRING_LIST_INIT_DUP;
|
|
|
|
|
static unsigned int colopts;
|
|
|
|
|
|
2014-10-08 03:16:57 +08:00
|
|
|
static int parse_branch_color_slot(const char *slot)
|
2006-12-12 14:41:52 +08:00
|
|
|
{
|
2014-10-08 03:16:57 +08:00
|
|
|
if (!strcasecmp(slot, "plain"))
|
2009-02-14 05:53:41 +08:00
|
|
|
return BRANCH_COLOR_PLAIN;
|
2014-10-08 03:16:57 +08:00
|
|
|
if (!strcasecmp(slot, "reset"))
|
2009-02-14 05:53:41 +08:00
|
|
|
return BRANCH_COLOR_RESET;
|
2014-10-08 03:16:57 +08:00
|
|
|
if (!strcasecmp(slot, "remote"))
|
2009-02-14 05:53:41 +08:00
|
|
|
return BRANCH_COLOR_REMOTE;
|
2014-10-08 03:16:57 +08:00
|
|
|
if (!strcasecmp(slot, "local"))
|
2009-02-14 05:53:41 +08:00
|
|
|
return BRANCH_COLOR_LOCAL;
|
2014-10-08 03:16:57 +08:00
|
|
|
if (!strcasecmp(slot, "current"))
|
2009-02-14 05:53:41 +08:00
|
|
|
return BRANCH_COLOR_CURRENT;
|
2014-10-08 03:16:57 +08:00
|
|
|
if (!strcasecmp(slot, "upstream"))
|
2013-04-15 10:37:49 +08:00
|
|
|
return BRANCH_COLOR_UPSTREAM;
|
ignore unknown color configuration
When parsing the config file, if there is a value that is
syntactically correct but unused, we generally ignore it.
This lets non-core porcelains store arbitrary information in
the config file, and it means that configuration files can
be shared between new and old versions of git (the old
versions might simply ignore certain configuration).
The one exception to this is color configuration; if we
encounter a color.{diff,branch,status}.$slot variable, we
die if it is not one of the recognized slots (presumably as
a safety valve for user misconfiguration). This behavior
has existed since 801235c (diff --color: use
$GIT_DIR/config, 2006-06-24), but hasn't yet caused a
problem. No porcelain has wanted to store extra colors, and
we once a color area (like color.diff) has been introduced,
we've never changed the set of color slots.
However, that changed recently with the addition of
color.diff.func. Now a user with color.diff.func in their
config can no longer freely switch between v1.6.6 and older
versions; the old versions will complain about the existence
of the variable.
This patch loosens the check to match the rest of
git-config; unknown color slots are simply ignored. This
doesn't fix this particular problem, as the older version
(without this patch) is the problem, but it at least
prevents it from happening again in the future.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-12-12 20:25:24 +08:00
|
|
|
return -1;
|
2006-12-12 14:41:52 +08:00
|
|
|
}
|
|
|
|
|
|
2008-05-15 01:46:53 +08:00
|
|
|
static int git_branch_config(const char *var, const char *value, void *cb)
|
2006-12-12 14:41:52 +08:00
|
|
|
{
|
2014-10-05 02:54:50 +08:00
|
|
|
const char *slot_name;
|
|
|
|
|
|
2013-12-01 04:55:40 +08:00
|
|
|
if (starts_with(var, "column."))
|
2012-04-13 18:54:38 +08:00
|
|
|
return git_column_config(var, value, "branch", &colopts);
|
2006-12-12 14:41:52 +08:00
|
|
|
if (!strcmp(var, "color.branch")) {
|
2011-08-18 13:03:48 +08:00
|
|
|
branch_use_color = git_config_colorbool(var, value);
|
2006-12-12 14:41:52 +08:00
|
|
|
return 0;
|
|
|
|
|
}
|
2014-10-05 02:54:50 +08:00
|
|
|
if (skip_prefix(var, "color.branch.", &slot_name)) {
|
2014-10-21 03:23:48 +08:00
|
|
|
int slot = parse_branch_color_slot(slot_name);
|
ignore unknown color configuration
When parsing the config file, if there is a value that is
syntactically correct but unused, we generally ignore it.
This lets non-core porcelains store arbitrary information in
the config file, and it means that configuration files can
be shared between new and old versions of git (the old
versions might simply ignore certain configuration).
The one exception to this is color configuration; if we
encounter a color.{diff,branch,status}.$slot variable, we
die if it is not one of the recognized slots (presumably as
a safety valve for user misconfiguration). This behavior
has existed since 801235c (diff --color: use
$GIT_DIR/config, 2006-06-24), but hasn't yet caused a
problem. No porcelain has wanted to store extra colors, and
we once a color area (like color.diff) has been introduced,
we've never changed the set of color slots.
However, that changed recently with the addition of
color.diff.func. Now a user with color.diff.func in their
config can no longer freely switch between v1.6.6 and older
versions; the old versions will complain about the existence
of the variable.
This patch loosens the check to match the rest of
git-config; unknown color slots are simply ignored. This
doesn't fix this particular problem, as the older version
(without this patch) is the problem, but it at least
prevents it from happening again in the future.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-12-12 20:25:24 +08:00
|
|
|
if (slot < 0)
|
|
|
|
|
return 0;
|
2008-02-12 02:45:50 +08:00
|
|
|
if (!value)
|
|
|
|
|
return config_error_nonbool(var);
|
2014-10-08 03:33:09 +08:00
|
|
|
return color_parse(value, branch_colors[slot]);
|
2006-12-12 14:41:52 +08:00
|
|
|
}
|
color: check color.ui in git_default_config()
Back in prehistoric times, our decision on whether or not to
show color by default relied on using a config callback that
either did or didn't load color config like color.diff.
When we introduced color.ui, we put it in the same boat:
commands had to manually respect it by using git_color_config()
or its git_color_default_config() convenience wrapper.
But in 4c7f1819b (make color.ui default to 'auto',
2013-06-10), that changed. Since then, we default color.ui
to auto in all programs, meaning that even plumbing commands
like "git diff-tree --pretty" might colorize the output.
Nobody seems to have complained in the intervening years,
presumably because the "is stdout a tty" check does a good
job of catching the right cases.
But that leaves an interesting curiosity: color.ui defaults
to auto even in plumbing, but you can't actually _disable_
the color via config. So if you really hate color and set
"color.ui" to false, diff-tree will still show color (but
porcelain like git-diff won't). Nobody noticed that either,
probably because very few people disable color.
One could argue that the plumbing should _always_ disable
color unless an explicit --color option is given on the
command line. But in practice, this creates a lot of
complications for scripts which do want plumbing to show
user-visible output. They can't just pass "--color" blindly;
they need to check the user's config and decide what to
send.
Given that nobody has complained about the current behavior,
let's assume it's a good path, and follow it to its
conclusion: supporting color.ui everywhere.
Note that you can create havoc by setting color.ui=always in
your config, but that's more or less already the case. We
could disallow it entirely, but it is handy for one-offs
like:
git -c color.ui=always foo >not-a-tty
when "foo" does not take a --color option itself.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-07-13 23:07:03 +08:00
|
|
|
return git_default_config(var, value, cb);
|
2006-12-12 14:41:52 +08:00
|
|
|
}
|
|
|
|
|
|
2007-06-08 04:45:00 +08:00
|
|
|
static const char *branch_get_color(enum color_branch ix)
|
2006-12-12 14:41:52 +08:00
|
|
|
{
|
color: delay auto-color decision until point of use
When we read a color value either from a config file or from
the command line, we use git_config_colorbool to convert it
from the tristate always/never/auto into a single yes/no
boolean value.
This has some timing implications with respect to starting
a pager.
If we start (or decide not to start) the pager before
checking the colorbool, everything is fine. Either isatty(1)
will give us the right information, or we will properly
check for pager_in_use().
However, if we decide to start a pager after we have checked
the colorbool, things are not so simple. If stdout is a tty,
then we will have already decided to use color. However, the
user may also have configured color.pager not to use color
with the pager. In this case, we need to actually turn off
color. Unfortunately, the pager code has no idea which color
variables were turned on (and there are many of them
throughout the code, and they may even have been manipulated
after the colorbool selection by something like "--color" on
the command line).
This bug can be seen any time a pager is started after
config and command line options are checked. This has
affected "git diff" since 89d07f7 (diff: don't run pager if
user asked for a diff style exit code, 2007-08-12). It has
also affect the log family since 1fda91b (Fix 'git log'
early pager startup error case, 2010-08-24).
This patch splits the notion of parsing a colorbool and
actually checking the configuration. The "use_color"
variables now have an additional possible value,
GIT_COLOR_AUTO. Users of the variable should use the new
"want_color()" wrapper, which will lazily determine and
cache the auto-color decision.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-18 13:04:23 +08:00
|
|
|
if (want_color(branch_use_color))
|
2006-12-12 14:41:52 +08:00
|
|
|
return branch_colors[ix];
|
|
|
|
|
return "";
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-30 14:43:04 +08:00
|
|
|
static int branch_merged(int kind, const char *name,
|
|
|
|
|
struct commit *rev, struct commit *head_rev)
|
|
|
|
|
{
|
|
|
|
|
/*
|
|
|
|
|
* This checks whether the merge bases of branch and HEAD (or
|
|
|
|
|
* the other branch this branch builds upon) contains the
|
|
|
|
|
* branch, which means that the branch has already been merged
|
|
|
|
|
* safely to HEAD (or the other branch).
|
|
|
|
|
*/
|
|
|
|
|
struct commit *reference_rev = NULL;
|
|
|
|
|
const char *reference_name = NULL;
|
2011-12-13 22:17:48 +08:00
|
|
|
void *reference_name_to_free = NULL;
|
2009-12-30 14:43:04 +08:00
|
|
|
int merged;
|
|
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
if (kind == FILTER_REFS_BRANCHES) {
|
2009-12-30 14:43:04 +08:00
|
|
|
struct branch *branch = branch_get(name);
|
2015-05-21 12:45:32 +08:00
|
|
|
const char *upstream = branch_get_upstream(branch, NULL);
|
2017-02-22 07:47:26 +08:00
|
|
|
struct object_id oid;
|
2009-12-30 14:43:04 +08:00
|
|
|
|
2015-05-21 12:45:28 +08:00
|
|
|
if (upstream &&
|
2011-12-13 22:17:48 +08:00
|
|
|
(reference_name = reference_name_to_free =
|
2015-05-21 12:45:28 +08:00
|
|
|
resolve_refdup(upstream, RESOLVE_REF_READING,
|
2017-02-22 07:47:26 +08:00
|
|
|
oid.hash, NULL)) != NULL)
|
Convert lookup_commit* to struct object_id
Convert lookup_commit, lookup_commit_or_die,
lookup_commit_reference, and lookup_commit_reference_gently to take
struct object_id arguments.
Introduce a temporary in parse_object buffer in order to convert this
function. This is required since in order to convert parse_object and
parse_object_buffer, lookup_commit_reference_gently and
lookup_commit_or_die would need to be converted. Not introducing a
temporary would therefore require that lookup_commit_or_die take a
struct object_id *, but lookup_commit would take unsigned char *,
leaving a confusing and hard-to-use interface.
parse_object_buffer will lose this temporary in a later patch.
This commit was created with manual changes to commit.c, commit.h, and
object.c, plus the following semantic patch:
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1.hash, E2)
+ lookup_commit_reference_gently(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1->hash, E2)
+ lookup_commit_reference_gently(E1, E2)
@@
expression E1;
@@
- lookup_commit_reference(E1.hash)
+ lookup_commit_reference(&E1)
@@
expression E1;
@@
- lookup_commit_reference(E1->hash)
+ lookup_commit_reference(E1)
@@
expression E1;
@@
- lookup_commit(E1.hash)
+ lookup_commit(&E1)
@@
expression E1;
@@
- lookup_commit(E1->hash)
+ lookup_commit(E1)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1.hash, E2)
+ lookup_commit_or_die(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1->hash, E2)
+ lookup_commit_or_die(E1, E2)
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-07 06:10:10 +08:00
|
|
|
reference_rev = lookup_commit_reference(&oid);
|
2009-12-30 14:43:04 +08:00
|
|
|
}
|
|
|
|
|
if (!reference_rev)
|
|
|
|
|
reference_rev = head_rev;
|
|
|
|
|
|
2012-08-28 05:46:01 +08:00
|
|
|
merged = in_merge_bases(rev, reference_rev);
|
2009-12-30 14:43:04 +08:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* After the safety valve is fully redefined to "check with
|
|
|
|
|
* upstream, if any, otherwise with HEAD", we should just
|
|
|
|
|
* return the result of the in_merge_bases() above without
|
|
|
|
|
* any of the following code, but during the transition period,
|
|
|
|
|
* a gentle reminder is in order.
|
|
|
|
|
*/
|
|
|
|
|
if ((head_rev != reference_rev) &&
|
2012-08-28 05:46:01 +08:00
|
|
|
in_merge_bases(rev, head_rev) != merged) {
|
2009-12-30 14:43:04 +08:00
|
|
|
if (merged)
|
2011-02-23 07:41:34 +08:00
|
|
|
warning(_("deleting branch '%s' that has been merged to\n"
|
2011-04-02 08:55:55 +08:00
|
|
|
" '%s', but not yet merged to HEAD."),
|
2009-12-30 14:43:04 +08:00
|
|
|
name, reference_name);
|
|
|
|
|
else
|
2011-02-23 07:41:34 +08:00
|
|
|
warning(_("not deleting branch '%s' that is not yet merged to\n"
|
|
|
|
|
" '%s', even though it is merged to HEAD."),
|
2009-12-30 14:43:04 +08:00
|
|
|
name, reference_name);
|
|
|
|
|
}
|
2011-12-13 22:17:48 +08:00
|
|
|
free(reference_name_to_free);
|
2009-12-30 14:43:04 +08:00
|
|
|
return merged;
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-18 20:02:51 +08:00
|
|
|
static int check_branch_commit(const char *branchname, const char *refname,
|
2017-02-22 07:47:26 +08:00
|
|
|
const struct object_id *oid, struct commit *head_rev,
|
2012-10-18 20:02:51 +08:00
|
|
|
int kinds, int force)
|
|
|
|
|
{
|
Convert lookup_commit* to struct object_id
Convert lookup_commit, lookup_commit_or_die,
lookup_commit_reference, and lookup_commit_reference_gently to take
struct object_id arguments.
Introduce a temporary in parse_object buffer in order to convert this
function. This is required since in order to convert parse_object and
parse_object_buffer, lookup_commit_reference_gently and
lookup_commit_or_die would need to be converted. Not introducing a
temporary would therefore require that lookup_commit_or_die take a
struct object_id *, but lookup_commit would take unsigned char *,
leaving a confusing and hard-to-use interface.
parse_object_buffer will lose this temporary in a later patch.
This commit was created with manual changes to commit.c, commit.h, and
object.c, plus the following semantic patch:
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1.hash, E2)
+ lookup_commit_reference_gently(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1->hash, E2)
+ lookup_commit_reference_gently(E1, E2)
@@
expression E1;
@@
- lookup_commit_reference(E1.hash)
+ lookup_commit_reference(&E1)
@@
expression E1;
@@
- lookup_commit_reference(E1->hash)
+ lookup_commit_reference(E1)
@@
expression E1;
@@
- lookup_commit(E1.hash)
+ lookup_commit(&E1)
@@
expression E1;
@@
- lookup_commit(E1->hash)
+ lookup_commit(E1)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1.hash, E2)
+ lookup_commit_or_die(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1->hash, E2)
+ lookup_commit_or_die(E1, E2)
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-07 06:10:10 +08:00
|
|
|
struct commit *rev = lookup_commit_reference(oid);
|
2012-10-18 20:02:51 +08:00
|
|
|
if (!rev) {
|
|
|
|
|
error(_("Couldn't look up commit object for '%s'"), refname);
|
|
|
|
|
return -1;
|
|
|
|
|
}
|
|
|
|
|
if (!force && !branch_merged(kinds, branchname, rev, head_rev)) {
|
|
|
|
|
error(_("The branch '%s' is not fully merged.\n"
|
|
|
|
|
"If you are sure you want to delete it, "
|
|
|
|
|
"run 'git branch -D %s'."), branchname, branchname);
|
|
|
|
|
return -1;
|
|
|
|
|
}
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-18 20:04:08 +08:00
|
|
|
static void delete_branch_config(const char *branchname)
|
|
|
|
|
{
|
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
strbuf_addf(&buf, "branch.%s", branchname);
|
|
|
|
|
if (git_config_rename_section(buf.buf, NULL) < 0)
|
|
|
|
|
warning(_("Update of config-file failed"));
|
|
|
|
|
strbuf_release(&buf);
|
|
|
|
|
}
|
|
|
|
|
|
2012-03-27 07:51:06 +08:00
|
|
|
static int delete_branches(int argc, const char **argv, int force, int kinds,
|
|
|
|
|
int quiet)
|
2006-10-24 05:27:45 +08:00
|
|
|
{
|
2012-10-18 20:02:51 +08:00
|
|
|
struct commit *head_rev = NULL;
|
2017-02-22 07:47:26 +08:00
|
|
|
struct object_id oid;
|
2006-12-19 06:42:16 +08:00
|
|
|
char *name = NULL;
|
2012-04-30 23:33:12 +08:00
|
|
|
const char *fmt;
|
2006-10-24 05:27:45 +08:00
|
|
|
int i;
|
2006-12-19 06:42:16 +08:00
|
|
|
int ret = 0;
|
2012-04-30 23:33:12 +08:00
|
|
|
int remote_branch = 0;
|
2009-02-14 15:08:05 +08:00
|
|
|
struct strbuf bname = STRBUF_INIT;
|
2017-03-02 16:23:10 +08:00
|
|
|
unsigned allowed_interpret;
|
2006-10-24 05:27:45 +08:00
|
|
|
|
2006-12-18 15:58:16 +08:00
|
|
|
switch (kinds) {
|
2015-09-24 02:11:11 +08:00
|
|
|
case FILTER_REFS_REMOTES:
|
2006-12-18 15:58:16 +08:00
|
|
|
fmt = "refs/remotes/%s";
|
2012-04-30 23:33:12 +08:00
|
|
|
/* For subsequent UI messages */
|
|
|
|
|
remote_branch = 1;
|
2017-03-02 16:23:10 +08:00
|
|
|
allowed_interpret = INTERPRET_BRANCH_REMOTE;
|
2012-04-30 23:33:12 +08:00
|
|
|
|
2006-12-18 15:58:16 +08:00
|
|
|
force = 1;
|
|
|
|
|
break;
|
2015-09-24 02:11:11 +08:00
|
|
|
case FILTER_REFS_BRANCHES:
|
2006-12-18 15:58:16 +08:00
|
|
|
fmt = "refs/heads/%s";
|
2017-03-02 16:23:10 +08:00
|
|
|
allowed_interpret = INTERPRET_BRANCH_LOCAL;
|
2006-12-18 15:58:16 +08:00
|
|
|
break;
|
|
|
|
|
default:
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("cannot use -a with -d"));
|
2006-12-18 15:58:16 +08:00
|
|
|
}
|
2006-10-24 05:27:45 +08:00
|
|
|
|
2006-11-25 15:10:23 +08:00
|
|
|
if (!force) {
|
Convert lookup_commit* to struct object_id
Convert lookup_commit, lookup_commit_or_die,
lookup_commit_reference, and lookup_commit_reference_gently to take
struct object_id arguments.
Introduce a temporary in parse_object buffer in order to convert this
function. This is required since in order to convert parse_object and
parse_object_buffer, lookup_commit_reference_gently and
lookup_commit_or_die would need to be converted. Not introducing a
temporary would therefore require that lookup_commit_or_die take a
struct object_id *, but lookup_commit would take unsigned char *,
leaving a confusing and hard-to-use interface.
parse_object_buffer will lose this temporary in a later patch.
This commit was created with manual changes to commit.c, commit.h, and
object.c, plus the following semantic patch:
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1.hash, E2)
+ lookup_commit_reference_gently(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1->hash, E2)
+ lookup_commit_reference_gently(E1, E2)
@@
expression E1;
@@
- lookup_commit_reference(E1.hash)
+ lookup_commit_reference(&E1)
@@
expression E1;
@@
- lookup_commit_reference(E1->hash)
+ lookup_commit_reference(E1)
@@
expression E1;
@@
- lookup_commit(E1.hash)
+ lookup_commit(&E1)
@@
expression E1;
@@
- lookup_commit(E1->hash)
+ lookup_commit(E1)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1.hash, E2)
+ lookup_commit_or_die(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1->hash, E2)
+ lookup_commit_or_die(E1, E2)
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-07 06:10:10 +08:00
|
|
|
head_rev = lookup_commit_reference(&head_oid);
|
2006-11-25 15:10:23 +08:00
|
|
|
if (!head_rev)
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("Couldn't look up commit object for HEAD"));
|
2006-11-25 15:10:23 +08:00
|
|
|
}
|
2009-02-14 15:08:05 +08:00
|
|
|
for (i = 0; i < argc; i++, strbuf_release(&bname)) {
|
2016-04-25 16:42:19 +08:00
|
|
|
char *target = NULL;
|
2012-10-18 20:07:11 +08:00
|
|
|
int flags = 0;
|
|
|
|
|
|
2017-03-02 16:23:10 +08:00
|
|
|
strbuf_branchname(&bname, argv[i], allowed_interpret);
|
Avoid unnecessary "if-before-free" tests.
This change removes all obvious useless if-before-free tests.
E.g., it replaces code like this:
if (some_expression)
free (some_expression);
with the now-equivalent:
free (some_expression);
It is equivalent not just because POSIX has required free(NULL)
to work for a long time, but simply because it has worked for
so long that no reasonable porting target fails the test.
Here's some evidence from nearly 1.5 years ago:
http://www.winehq.org/pipermail/wine-patches/2006-October/031544.html
FYI, the change below was prepared by running the following:
git ls-files -z | xargs -0 \
perl -0x3b -pi -e \
's/\bif\s*\(\s*(\S+?)(?:\s*!=\s*NULL)?\s*\)\s+(free\s*\(\s*\1\s*\))/$2/s'
Note however, that it doesn't handle brace-enclosed blocks like
"if (x) { free (x); }". But that's ok, since there were none like
that in git sources.
Beware: if you do use the above snippet, note that it can
produce syntactically invalid C code. That happens when the
affected "if"-statement has a matching "else".
E.g., it would transform this
if (x)
free (x);
else
foo ();
into this:
free (x);
else
foo ();
There were none of those here, either.
If you're interested in automating detection of the useless
tests, you might like the useless-if-before-free script in gnulib:
[it *does* detect brace-enclosed free statements, and has a --name=S
option to make it detect free-like functions with different names]
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob;f=build-aux/useless-if-before-free
Addendum:
Remove one more (in imap-send.c), spotted by Jean-Luc Herren <jlh@gmx.ch>.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-02-01 01:26:32 +08:00
|
|
|
free(name);
|
2012-09-05 01:31:14 +08:00
|
|
|
name = mkpathdup(fmt, bname.buf);
|
2016-03-29 17:38:39 +08:00
|
|
|
|
|
|
|
|
if (kinds == FILTER_REFS_BRANCHES) {
|
2016-04-22 21:01:27 +08:00
|
|
|
const struct worktree *wt =
|
|
|
|
|
find_shared_symref("HEAD", name);
|
|
|
|
|
if (wt) {
|
2016-03-29 17:38:39 +08:00
|
|
|
error(_("Cannot delete branch '%s' "
|
|
|
|
|
"checked out at '%s'"),
|
2016-04-22 21:01:27 +08:00
|
|
|
bname.buf, wt->path);
|
2016-03-29 17:38:39 +08:00
|
|
|
ret = 1;
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-04-25 16:42:19 +08:00
|
|
|
target = resolve_refdup(name,
|
|
|
|
|
RESOLVE_REF_READING
|
|
|
|
|
| RESOLVE_REF_NO_RECURSE
|
|
|
|
|
| RESOLVE_REF_ALLOW_BAD_NAME,
|
2017-02-22 07:47:26 +08:00
|
|
|
oid.hash, &flags);
|
2014-09-12 01:34:36 +08:00
|
|
|
if (!target) {
|
2012-04-30 23:33:12 +08:00
|
|
|
error(remote_branch
|
2015-05-07 03:01:55 +08:00
|
|
|
? _("remote-tracking branch '%s' not found.")
|
2012-04-30 23:33:12 +08:00
|
|
|
: _("branch '%s' not found."), bname.buf);
|
2006-12-19 06:42:16 +08:00
|
|
|
ret = 1;
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2006-10-24 05:27:45 +08:00
|
|
|
|
refs.c: allow listing and deleting badly named refs
We currently do not handle badly named refs well:
$ cp .git/refs/heads/master .git/refs/heads/master.....@\*@\\.
$ git branch
fatal: Reference has invalid format: 'refs/heads/master.....@*@\.'
$ git branch -D master.....@\*@\\.
error: branch 'master.....@*@\.' not found.
Users cannot recover from a badly named ref without manually finding
and deleting the loose ref file or appropriate line in packed-refs.
Making that easier will make it easier to tweak the ref naming rules
in the future, for example to forbid shell metacharacters like '`'
and '"', without putting people in a state that is hard to get out of.
So allow "branch --list" to show these refs and allow "branch -d/-D"
and "update-ref -d" to delete them. Other commands (for example to
rename refs) will continue to not handle these refs but can be changed
in later patches.
Details:
In resolving functions, refuse to resolve refs that don't pass the
git-check-ref-format(1) check unless the new RESOLVE_REF_ALLOW_BAD_NAME
flag is passed. Even with RESOLVE_REF_ALLOW_BAD_NAME, refuse to
resolve refs that escape the refs/ directory and do not match the
pattern [A-Z_]* (think "HEAD" and "MERGE_HEAD").
In locking functions, refuse to act on badly named refs unless they
are being deleted and either are in the refs/ directory or match [A-Z_]*.
Just like other invalid refs, flag resolved, badly named refs with the
REF_ISBROKEN flag, treat them as resolving to null_sha1, and skip them
in all iteration functions except for for_each_rawref.
Flag badly named refs (but not symrefs pointing to badly named refs)
with a REF_BAD_NAME flag to make it easier for future callers to
notice and handle them specially. For example, in a later patch
for-each-ref will use this flag to detect refs whose names can confuse
callers parsing for-each-ref output.
In the transaction API, refuse to create or update badly named refs,
but allow deleting them (unless they try to escape refs/ and don't match
[A-Z_]*).
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2014-09-04 02:45:43 +08:00
|
|
|
if (!(flags & (REF_ISSYMREF|REF_ISBROKEN)) &&
|
2017-02-22 07:47:26 +08:00
|
|
|
check_branch_commit(bname.buf, name, &oid, head_rev, kinds,
|
2012-10-18 20:02:51 +08:00
|
|
|
force)) {
|
2006-12-19 06:42:16 +08:00
|
|
|
ret = 1;
|
2016-04-25 16:42:19 +08:00
|
|
|
goto next;
|
2006-10-24 05:27:45 +08:00
|
|
|
}
|
|
|
|
|
|
2017-03-18 04:50:24 +08:00
|
|
|
if (delete_ref(NULL, name, is_null_oid(&oid) ? NULL : oid.hash,
|
2015-06-22 22:03:10 +08:00
|
|
|
REF_NODEREF)) {
|
2012-04-30 23:33:12 +08:00
|
|
|
error(remote_branch
|
2015-05-07 03:01:55 +08:00
|
|
|
? _("Error deleting remote-tracking branch '%s'")
|
2012-04-30 23:33:12 +08:00
|
|
|
: _("Error deleting branch '%s'"),
|
2009-02-14 15:08:05 +08:00
|
|
|
bname.buf);
|
2006-12-19 06:42:16 +08:00
|
|
|
ret = 1;
|
2016-04-25 16:42:19 +08:00
|
|
|
goto next;
|
2012-10-18 20:08:03 +08:00
|
|
|
}
|
|
|
|
|
if (!quiet) {
|
|
|
|
|
printf(remote_branch
|
2015-05-07 03:01:55 +08:00
|
|
|
? _("Deleted remote-tracking branch %s (was %s).\n")
|
2012-10-18 20:08:03 +08:00
|
|
|
: _("Deleted branch %s (was %s).\n"),
|
|
|
|
|
bname.buf,
|
refs.c: allow listing and deleting badly named refs
We currently do not handle badly named refs well:
$ cp .git/refs/heads/master .git/refs/heads/master.....@\*@\\.
$ git branch
fatal: Reference has invalid format: 'refs/heads/master.....@*@\.'
$ git branch -D master.....@\*@\\.
error: branch 'master.....@*@\.' not found.
Users cannot recover from a badly named ref without manually finding
and deleting the loose ref file or appropriate line in packed-refs.
Making that easier will make it easier to tweak the ref naming rules
in the future, for example to forbid shell metacharacters like '`'
and '"', without putting people in a state that is hard to get out of.
So allow "branch --list" to show these refs and allow "branch -d/-D"
and "update-ref -d" to delete them. Other commands (for example to
rename refs) will continue to not handle these refs but can be changed
in later patches.
Details:
In resolving functions, refuse to resolve refs that don't pass the
git-check-ref-format(1) check unless the new RESOLVE_REF_ALLOW_BAD_NAME
flag is passed. Even with RESOLVE_REF_ALLOW_BAD_NAME, refuse to
resolve refs that escape the refs/ directory and do not match the
pattern [A-Z_]* (think "HEAD" and "MERGE_HEAD").
In locking functions, refuse to act on badly named refs unless they
are being deleted and either are in the refs/ directory or match [A-Z_]*.
Just like other invalid refs, flag resolved, badly named refs with the
REF_ISBROKEN flag, treat them as resolving to null_sha1, and skip them
in all iteration functions except for for_each_rawref.
Flag badly named refs (but not symrefs pointing to badly named refs)
with a REF_BAD_NAME flag to make it easier for future callers to
notice and handle them specially. For example, in a later patch
for-each-ref will use this flag to detect refs whose names can confuse
callers parsing for-each-ref output.
In the transaction API, refuse to create or update badly named refs,
but allow deleting them (unless they try to escape refs/ and don't match
[A-Z_]*).
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2014-09-04 02:45:43 +08:00
|
|
|
(flags & REF_ISBROKEN) ? "broken"
|
|
|
|
|
: (flags & REF_ISSYMREF) ? target
|
2017-02-22 07:47:26 +08:00
|
|
|
: find_unique_abbrev(oid.hash, DEFAULT_ABBREV));
|
2007-06-09 20:40:35 +08:00
|
|
|
}
|
2012-10-18 20:08:03 +08:00
|
|
|
delete_branch_config(bname.buf);
|
2016-04-25 16:42:19 +08:00
|
|
|
|
|
|
|
|
next:
|
|
|
|
|
free(target);
|
2006-10-24 05:27:45 +08:00
|
|
|
}
|
|
|
|
|
|
Avoid unnecessary "if-before-free" tests.
This change removes all obvious useless if-before-free tests.
E.g., it replaces code like this:
if (some_expression)
free (some_expression);
with the now-equivalent:
free (some_expression);
It is equivalent not just because POSIX has required free(NULL)
to work for a long time, but simply because it has worked for
so long that no reasonable porting target fails the test.
Here's some evidence from nearly 1.5 years ago:
http://www.winehq.org/pipermail/wine-patches/2006-October/031544.html
FYI, the change below was prepared by running the following:
git ls-files -z | xargs -0 \
perl -0x3b -pi -e \
's/\bif\s*\(\s*(\S+?)(?:\s*!=\s*NULL)?\s*\)\s+(free\s*\(\s*\1\s*\))/$2/s'
Note however, that it doesn't handle brace-enclosed blocks like
"if (x) { free (x); }". But that's ok, since there were none like
that in git sources.
Beware: if you do use the above snippet, note that it can
produce syntactically invalid C code. That happens when the
affected "if"-statement has a matching "else".
E.g., it would transform this
if (x)
free (x);
else
foo ();
into this:
free (x);
else
foo ();
There were none of those here, either.
If you're interested in automating detection of the useless
tests, you might like the useless-if-before-free script in gnulib:
[it *does* detect brace-enclosed free statements, and has a --name=S
option to make it detect free-like functions with different names]
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob;f=build-aux/useless-if-before-free
Addendum:
Remove one more (in imap-send.c), spotted by Jean-Luc Herren <jlh@gmx.ch>.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-02-01 01:26:32 +08:00
|
|
|
free(name);
|
2006-12-19 06:42:16 +08:00
|
|
|
|
|
|
|
|
return(ret);
|
2006-10-24 05:27:45 +08:00
|
|
|
}
|
|
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
static int calc_maxwidth(struct ref_array *refs, int remote_bonus)
|
2008-07-02 15:52:41 +08:00
|
|
|
{
|
2017-01-10 16:49:52 +08:00
|
|
|
int i, max = 0;
|
|
|
|
|
for (i = 0; i < refs->nr; i++) {
|
|
|
|
|
struct ref_array_item *it = refs->items[i];
|
|
|
|
|
const char *desc = it->refname;
|
|
|
|
|
int w;
|
2013-04-15 10:37:49 +08:00
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
skip_prefix(it->refname, "refs/heads/", &desc);
|
|
|
|
|
skip_prefix(it->refname, "refs/remotes/", &desc);
|
|
|
|
|
if (it->kind == FILTER_REFS_DETACHED_HEAD) {
|
|
|
|
|
char *head_desc = get_head_description();
|
|
|
|
|
w = utf8_strwidth(head_desc);
|
|
|
|
|
free(head_desc);
|
|
|
|
|
} else
|
|
|
|
|
w = utf8_strwidth(desc);
|
2012-05-03 21:12:00 +08:00
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
if (it->kind == FILTER_REFS_REMOTES)
|
|
|
|
|
w += remote_bonus;
|
|
|
|
|
if (w > max)
|
|
|
|
|
max = w;
|
2012-05-03 21:12:00 +08:00
|
|
|
}
|
2017-01-10 16:49:52 +08:00
|
|
|
return max;
|
2008-07-02 15:52:41 +08:00
|
|
|
}
|
|
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
static const char *quote_literal_for_format(const char *s)
|
2011-03-16 15:10:14 +08:00
|
|
|
{
|
2017-01-10 16:49:52 +08:00
|
|
|
static struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
|
|
|
|
strbuf_reset(&buf);
|
|
|
|
|
while (*s) {
|
|
|
|
|
const char *ep = strchrnul(s, '%');
|
|
|
|
|
if (s < ep)
|
|
|
|
|
strbuf_add(&buf, s, ep - s);
|
|
|
|
|
if (*ep == '%') {
|
|
|
|
|
strbuf_addstr(&buf, "%%");
|
|
|
|
|
s = ep + 1;
|
|
|
|
|
} else {
|
|
|
|
|
s = ep;
|
|
|
|
|
}
|
2011-03-16 15:10:14 +08:00
|
|
|
}
|
2017-01-10 16:49:52 +08:00
|
|
|
return buf.buf;
|
2011-03-16 15:10:14 +08:00
|
|
|
}
|
|
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
static char *build_format(struct ref_filter *filter, int maxwidth, const char *remote_prefix)
|
2006-11-24 21:45:10 +08:00
|
|
|
{
|
2017-01-10 16:49:52 +08:00
|
|
|
struct strbuf fmt = STRBUF_INIT;
|
|
|
|
|
struct strbuf local = STRBUF_INIT;
|
|
|
|
|
struct strbuf remote = STRBUF_INIT;
|
2006-11-24 21:45:10 +08:00
|
|
|
|
2017-07-09 17:59:33 +08:00
|
|
|
strbuf_addf(&local, "%%(if)%%(HEAD)%%(then)* %s%%(else) %s%%(end)",
|
|
|
|
|
branch_get_color(BRANCH_COLOR_CURRENT),
|
|
|
|
|
branch_get_color(BRANCH_COLOR_LOCAL));
|
2017-07-09 18:00:45 +08:00
|
|
|
strbuf_addf(&remote, " %s",
|
|
|
|
|
branch_get_color(BRANCH_COLOR_REMOTE));
|
2006-11-24 21:45:10 +08:00
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
if (filter->verbose) {
|
2017-03-09 06:13:09 +08:00
|
|
|
struct strbuf obname = STRBUF_INIT;
|
|
|
|
|
|
|
|
|
|
if (filter->abbrev < 0)
|
|
|
|
|
strbuf_addf(&obname, "%%(objectname:short)");
|
|
|
|
|
else if (!filter->abbrev)
|
|
|
|
|
strbuf_addf(&obname, "%%(objectname)");
|
|
|
|
|
else
|
|
|
|
|
strbuf_addf(&obname, "%%(objectname:short=%d)", filter->abbrev);
|
|
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
strbuf_addf(&local, "%%(align:%d,left)%%(refname:lstrip=2)%%(end)", maxwidth);
|
|
|
|
|
strbuf_addf(&local, "%s", branch_get_color(BRANCH_COLOR_RESET));
|
2017-03-09 06:13:09 +08:00
|
|
|
strbuf_addf(&local, " %s ", obname.buf);
|
2017-01-10 16:49:52 +08:00
|
|
|
|
|
|
|
|
if (filter->verbose > 1)
|
|
|
|
|
strbuf_addf(&local, "%%(if)%%(upstream)%%(then)[%s%%(upstream:short)%s%%(if)%%(upstream:track)"
|
|
|
|
|
"%%(then): %%(upstream:track,nobracket)%%(end)] %%(end)%%(contents:subject)",
|
|
|
|
|
branch_get_color(BRANCH_COLOR_UPSTREAM), branch_get_color(BRANCH_COLOR_RESET));
|
|
|
|
|
else
|
|
|
|
|
strbuf_addf(&local, "%%(if)%%(upstream:track)%%(then)%%(upstream:track) %%(end)%%(contents:subject)");
|
|
|
|
|
|
2017-07-09 18:00:45 +08:00
|
|
|
strbuf_addf(&remote, "%%(align:%d,left)%s%%(refname:lstrip=2)%%(end)%s"
|
2017-03-09 06:13:09 +08:00
|
|
|
"%%(if)%%(symref)%%(then) -> %%(symref:short)"
|
|
|
|
|
"%%(else) %s %%(contents:subject)%%(end)",
|
2017-07-09 18:00:45 +08:00
|
|
|
maxwidth, quote_literal_for_format(remote_prefix),
|
2017-03-09 06:13:09 +08:00
|
|
|
branch_get_color(BRANCH_COLOR_RESET), obname.buf);
|
|
|
|
|
strbuf_release(&obname);
|
2012-04-13 18:54:38 +08:00
|
|
|
} else {
|
2017-01-10 16:49:52 +08:00
|
|
|
strbuf_addf(&local, "%%(refname:lstrip=2)%s%%(if)%%(symref)%%(then) -> %%(symref:short)%%(end)",
|
|
|
|
|
branch_get_color(BRANCH_COLOR_RESET));
|
2017-07-09 18:00:45 +08:00
|
|
|
strbuf_addf(&remote, "%s%%(refname:lstrip=2)%s%%(if)%%(symref)%%(then) -> %%(symref:short)%%(end)",
|
|
|
|
|
quote_literal_for_format(remote_prefix),
|
2017-01-10 16:49:52 +08:00
|
|
|
branch_get_color(BRANCH_COLOR_RESET));
|
2012-04-13 18:54:38 +08:00
|
|
|
}
|
2006-11-24 21:45:10 +08:00
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
strbuf_addf(&fmt, "%%(if:notequals=refs/remotes)%%(refname:rstrip=-2)%%(then)%s%%(else)%s%%(end)", local.buf, remote.buf);
|
2015-09-24 02:11:12 +08:00
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
strbuf_release(&local);
|
|
|
|
|
strbuf_release(&remote);
|
|
|
|
|
return strbuf_detach(&fmt, NULL);
|
2009-07-24 03:13:48 +08:00
|
|
|
}
|
|
|
|
|
|
2017-07-13 23:01:18 +08:00
|
|
|
static void print_ref_list(struct ref_filter *filter, struct ref_sorting *sorting, struct ref_format *format)
|
2006-10-24 05:27:45 +08:00
|
|
|
{
|
|
|
|
|
int i;
|
2015-09-24 02:11:11 +08:00
|
|
|
struct ref_array array;
|
2015-09-24 02:11:06 +08:00
|
|
|
int maxwidth = 0;
|
|
|
|
|
const char *remote_prefix = "";
|
2017-01-10 16:49:52 +08:00
|
|
|
struct strbuf out = STRBUF_INIT;
|
2017-01-10 16:49:53 +08:00
|
|
|
char *to_free = NULL;
|
2015-09-24 02:11:06 +08:00
|
|
|
|
2015-07-08 00:06:12 +08:00
|
|
|
/*
|
2015-09-24 02:11:06 +08:00
|
|
|
* If we are listing more than just remote branches,
|
|
|
|
|
* then remote branches will have a "remotes/" prefix.
|
|
|
|
|
* We need to account for this in the width.
|
2015-07-08 00:06:12 +08:00
|
|
|
*/
|
2015-09-24 02:11:11 +08:00
|
|
|
if (filter->kind != FILTER_REFS_REMOTES)
|
2015-09-24 02:11:06 +08:00
|
|
|
remote_prefix = "remotes/";
|
2014-09-18 18:49:43 +08:00
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
memset(&array, 0, sizeof(array));
|
2014-09-18 18:49:43 +08:00
|
|
|
|
2015-09-24 02:11:12 +08:00
|
|
|
filter_refs(&array, filter, filter->kind | FILTER_REFS_INCLUDE_BROKEN);
|
2006-10-24 05:27:45 +08:00
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
if (filter->verbose)
|
|
|
|
|
maxwidth = calc_maxwidth(&array, strlen(remote_prefix));
|
2006-11-22 03:31:24 +08:00
|
|
|
|
2017-07-13 23:01:18 +08:00
|
|
|
if (!format->format)
|
|
|
|
|
format->format = to_free = build_format(filter, maxwidth, remote_prefix);
|
2017-07-13 22:56:10 +08:00
|
|
|
|
|
|
|
|
if (verify_ref_format(format))
|
|
|
|
|
die(_("unable to parse format string"));
|
2017-01-10 16:49:52 +08:00
|
|
|
|
2015-09-24 02:11:12 +08:00
|
|
|
ref_array_sort(sorting, &array);
|
2010-06-04 17:50:10 +08:00
|
|
|
|
2017-01-10 16:49:52 +08:00
|
|
|
for (i = 0; i < array.nr; i++) {
|
2017-07-13 23:01:18 +08:00
|
|
|
format_ref_array_item(array.items[i], format, &out);
|
2017-01-10 16:49:52 +08:00
|
|
|
if (column_active(colopts)) {
|
|
|
|
|
assert(!filter->verbose && "--column and --verbose are incompatible");
|
|
|
|
|
/* format to a string_list to let print_columns() do its job */
|
|
|
|
|
string_list_append(&output, out.buf);
|
|
|
|
|
} else {
|
|
|
|
|
fwrite(out.buf, 1, out.len, stdout);
|
|
|
|
|
putchar('\n');
|
|
|
|
|
}
|
|
|
|
|
strbuf_release(&out);
|
|
|
|
|
}
|
2010-06-04 17:50:11 +08:00
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
ref_array_clear(&array);
|
2017-01-10 16:49:53 +08:00
|
|
|
free(to_free);
|
2006-10-24 05:27:45 +08:00
|
|
|
}
|
|
|
|
|
|
2016-04-22 21:01:36 +08:00
|
|
|
static void reject_rebase_or_bisect_branch(const char *target)
|
|
|
|
|
{
|
2016-11-28 17:36:55 +08:00
|
|
|
struct worktree **worktrees = get_worktrees(0);
|
2016-04-22 21:01:36 +08:00
|
|
|
int i;
|
|
|
|
|
|
|
|
|
|
for (i = 0; worktrees[i]; i++) {
|
|
|
|
|
struct worktree *wt = worktrees[i];
|
|
|
|
|
|
|
|
|
|
if (!wt->is_detached)
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
if (is_worktree_being_rebased(wt, target))
|
|
|
|
|
die(_("Branch %s is being rebased at %s"),
|
|
|
|
|
target, wt->path);
|
|
|
|
|
|
|
|
|
|
if (is_worktree_being_bisected(wt, target))
|
|
|
|
|
die(_("Branch %s is being bisected at %s"),
|
|
|
|
|
target, wt->path);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
free_worktrees(worktrees);
|
|
|
|
|
}
|
|
|
|
|
|
2006-11-28 22:47:40 +08:00
|
|
|
static void rename_branch(const char *oldname, const char *newname, int force)
|
|
|
|
|
{
|
2008-11-18 04:48:37 +08:00
|
|
|
struct strbuf oldref = STRBUF_INIT, newref = STRBUF_INIT, logmsg = STRBUF_INIT;
|
|
|
|
|
struct strbuf oldsection = STRBUF_INIT, newsection = STRBUF_INIT;
|
check_ref_format(): tighten refname rules
This changes the rules for refnames to forbid:
(1) a refname that contains "@{" in it.
Some people and foreign SCM converter may have named their branches
as frotz@24 and we still want to keep supporting it.
However, "git branch frotz@{24}" is a disaster. It cannot even
checked out because "git checkout frotz@{24}" will interpret it as
"detach the HEAD at twenty-fourth reflog entry of the frotz branch".
(2) a refname that ends with a dot.
We already reject a path component that begins with a dot, primarily
to avoid ambiguous range interpretation. If we allowed ".B" as a
valid ref, it is unclear if "A...B" means "in dot-B but not in A" or
"either in A or B but not in both".
But for this to be complete, we need also to forbid "A." to avoid "in
B but not in A-dot". This was not a problem in the original range
notation, but we should have added this restriction when three-dot
notation was introduced.
Unlike "no dot at the beginning of any path component" rule, this
rule does not have to be "no dot at the end of any path component",
because you cannot abbreviate the tail end away, similar to you can
say "dot-B" to mean "refs/heads/dot-B".
For these reasons, it is not likely people created branches with these
names on purpose, but we have allowed such names to be used for quite some
time, and it is possible that people created such branches by mistake or
by accident.
To help people with branches with such unfortunate names to recover,
we still allow "branch -d 'bad.'" to delete such branches, and also allow
"branch -m bad. good" to rename them.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-03-22 04:27:31 +08:00
|
|
|
int recovery = 0;
|
2011-11-26 10:30:02 +08:00
|
|
|
int clobber_head_ok;
|
2006-11-28 22:47:40 +08:00
|
|
|
|
2007-01-02 15:31:08 +08:00
|
|
|
if (!oldname)
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("cannot rename the current branch while not on any."));
|
2007-01-02 15:31:08 +08:00
|
|
|
|
check_ref_format(): tighten refname rules
This changes the rules for refnames to forbid:
(1) a refname that contains "@{" in it.
Some people and foreign SCM converter may have named their branches
as frotz@24 and we still want to keep supporting it.
However, "git branch frotz@{24}" is a disaster. It cannot even
checked out because "git checkout frotz@{24}" will interpret it as
"detach the HEAD at twenty-fourth reflog entry of the frotz branch".
(2) a refname that ends with a dot.
We already reject a path component that begins with a dot, primarily
to avoid ambiguous range interpretation. If we allowed ".B" as a
valid ref, it is unclear if "A...B" means "in dot-B but not in A" or
"either in A or B but not in both".
But for this to be complete, we need also to forbid "A." to avoid "in
B but not in A-dot". This was not a problem in the original range
notation, but we should have added this restriction when three-dot
notation was introduced.
Unlike "no dot at the beginning of any path component" rule, this
rule does not have to be "no dot at the end of any path component",
because you cannot abbreviate the tail end away, similar to you can
say "dot-B" to mean "refs/heads/dot-B".
For these reasons, it is not likely people created branches with these
names on purpose, but we have allowed such names to be used for quite some
time, and it is possible that people created such branches by mistake or
by accident.
To help people with branches with such unfortunate names to recover,
we still allow "branch -d 'bad.'" to delete such branches, and also allow
"branch -m bad. good" to rename them.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-03-22 04:27:31 +08:00
|
|
|
if (strbuf_check_branch_ref(&oldref, oldname)) {
|
|
|
|
|
/*
|
|
|
|
|
* Bad name --- this could be an attempt to rename a
|
|
|
|
|
* ref that we used to allow to be created by accident.
|
|
|
|
|
*/
|
2011-11-13 18:22:14 +08:00
|
|
|
if (ref_exists(oldref.buf))
|
check_ref_format(): tighten refname rules
This changes the rules for refnames to forbid:
(1) a refname that contains "@{" in it.
Some people and foreign SCM converter may have named their branches
as frotz@24 and we still want to keep supporting it.
However, "git branch frotz@{24}" is a disaster. It cannot even
checked out because "git checkout frotz@{24}" will interpret it as
"detach the HEAD at twenty-fourth reflog entry of the frotz branch".
(2) a refname that ends with a dot.
We already reject a path component that begins with a dot, primarily
to avoid ambiguous range interpretation. If we allowed ".B" as a
valid ref, it is unclear if "A...B" means "in dot-B but not in A" or
"either in A or B but not in both".
But for this to be complete, we need also to forbid "A." to avoid "in
B but not in A-dot". This was not a problem in the original range
notation, but we should have added this restriction when three-dot
notation was introduced.
Unlike "no dot at the beginning of any path component" rule, this
rule does not have to be "no dot at the end of any path component",
because you cannot abbreviate the tail end away, similar to you can
say "dot-B" to mean "refs/heads/dot-B".
For these reasons, it is not likely people created branches with these
names on purpose, but we have allowed such names to be used for quite some
time, and it is possible that people created such branches by mistake or
by accident.
To help people with branches with such unfortunate names to recover,
we still allow "branch -d 'bad.'" to delete such branches, and also allow
"branch -m bad. good" to rename them.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-03-22 04:27:31 +08:00
|
|
|
recovery = 1;
|
|
|
|
|
else
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("Invalid branch name: '%s'"), oldname);
|
check_ref_format(): tighten refname rules
This changes the rules for refnames to forbid:
(1) a refname that contains "@{" in it.
Some people and foreign SCM converter may have named their branches
as frotz@24 and we still want to keep supporting it.
However, "git branch frotz@{24}" is a disaster. It cannot even
checked out because "git checkout frotz@{24}" will interpret it as
"detach the HEAD at twenty-fourth reflog entry of the frotz branch".
(2) a refname that ends with a dot.
We already reject a path component that begins with a dot, primarily
to avoid ambiguous range interpretation. If we allowed ".B" as a
valid ref, it is unclear if "A...B" means "in dot-B but not in A" or
"either in A or B but not in both".
But for this to be complete, we need also to forbid "A." to avoid "in
B but not in A-dot". This was not a problem in the original range
notation, but we should have added this restriction when three-dot
notation was introduced.
Unlike "no dot at the beginning of any path component" rule, this
rule does not have to be "no dot at the end of any path component",
because you cannot abbreviate the tail end away, similar to you can
say "dot-B" to mean "refs/heads/dot-B".
For these reasons, it is not likely people created branches with these
names on purpose, but we have allowed such names to be used for quite some
time, and it is possible that people created such branches by mistake or
by accident.
To help people with branches with such unfortunate names to recover,
we still allow "branch -d 'bad.'" to delete such branches, and also allow
"branch -m bad. good" to rename them.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-03-22 04:27:31 +08:00
|
|
|
}
|
2006-11-28 22:47:40 +08:00
|
|
|
|
2011-11-26 10:30:02 +08:00
|
|
|
/*
|
|
|
|
|
* A command like "git branch -M currentbranch currentbranch" cannot
|
|
|
|
|
* cause the worktree to become inconsistent with HEAD, so allow it.
|
|
|
|
|
*/
|
|
|
|
|
clobber_head_ok = !strcmp(oldname, newname);
|
|
|
|
|
|
|
|
|
|
validate_new_branchname(newname, &newref, force, clobber_head_ok);
|
2006-11-28 22:47:40 +08:00
|
|
|
|
2016-04-22 21:01:36 +08:00
|
|
|
reject_rebase_or_bisect_branch(oldref.buf);
|
|
|
|
|
|
2008-11-18 04:48:37 +08:00
|
|
|
strbuf_addf(&logmsg, "Branch: renamed %s to %s",
|
|
|
|
|
oldref.buf, newref.buf);
|
2006-11-30 10:16:56 +08:00
|
|
|
|
2008-11-18 04:48:37 +08:00
|
|
|
if (rename_ref(oldref.buf, newref.buf, logmsg.buf))
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("Branch rename failed"));
|
2006-11-28 22:47:40 +08:00
|
|
|
|
check_ref_format(): tighten refname rules
This changes the rules for refnames to forbid:
(1) a refname that contains "@{" in it.
Some people and foreign SCM converter may have named their branches
as frotz@24 and we still want to keep supporting it.
However, "git branch frotz@{24}" is a disaster. It cannot even
checked out because "git checkout frotz@{24}" will interpret it as
"detach the HEAD at twenty-fourth reflog entry of the frotz branch".
(2) a refname that ends with a dot.
We already reject a path component that begins with a dot, primarily
to avoid ambiguous range interpretation. If we allowed ".B" as a
valid ref, it is unclear if "A...B" means "in dot-B but not in A" or
"either in A or B but not in both".
But for this to be complete, we need also to forbid "A." to avoid "in
B but not in A-dot". This was not a problem in the original range
notation, but we should have added this restriction when three-dot
notation was introduced.
Unlike "no dot at the beginning of any path component" rule, this
rule does not have to be "no dot at the end of any path component",
because you cannot abbreviate the tail end away, similar to you can
say "dot-B" to mean "refs/heads/dot-B".
For these reasons, it is not likely people created branches with these
names on purpose, but we have allowed such names to be used for quite some
time, and it is possible that people created such branches by mistake or
by accident.
To help people with branches with such unfortunate names to recover,
we still allow "branch -d 'bad.'" to delete such branches, and also allow
"branch -m bad. good" to rename them.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-03-22 04:27:31 +08:00
|
|
|
if (recovery)
|
2011-02-23 07:41:34 +08:00
|
|
|
warning(_("Renamed a misnamed branch '%s' away"), oldref.buf + 11);
|
check_ref_format(): tighten refname rules
This changes the rules for refnames to forbid:
(1) a refname that contains "@{" in it.
Some people and foreign SCM converter may have named their branches
as frotz@24 and we still want to keep supporting it.
However, "git branch frotz@{24}" is a disaster. It cannot even
checked out because "git checkout frotz@{24}" will interpret it as
"detach the HEAD at twenty-fourth reflog entry of the frotz branch".
(2) a refname that ends with a dot.
We already reject a path component that begins with a dot, primarily
to avoid ambiguous range interpretation. If we allowed ".B" as a
valid ref, it is unclear if "A...B" means "in dot-B but not in A" or
"either in A or B but not in both".
But for this to be complete, we need also to forbid "A." to avoid "in
B but not in A-dot". This was not a problem in the original range
notation, but we should have added this restriction when three-dot
notation was introduced.
Unlike "no dot at the beginning of any path component" rule, this
rule does not have to be "no dot at the end of any path component",
because you cannot abbreviate the tail end away, similar to you can
say "dot-B" to mean "refs/heads/dot-B".
For these reasons, it is not likely people created branches with these
names on purpose, but we have allowed such names to be used for quite some
time, and it is possible that people created such branches by mistake or
by accident.
To help people with branches with such unfortunate names to recover,
we still allow "branch -d 'bad.'" to delete such branches, and also allow
"branch -m bad. good" to rename them.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-03-22 04:27:31 +08:00
|
|
|
|
2017-02-21 09:10:35 +08:00
|
|
|
if (replace_each_worktree_head_symref(oldref.buf, newref.buf, logmsg.buf))
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("Branch renamed to %s, but HEAD is not updated!"), newname);
|
2007-04-06 20:13:00 +08:00
|
|
|
|
2017-02-21 09:10:35 +08:00
|
|
|
strbuf_release(&logmsg);
|
|
|
|
|
|
2008-11-18 04:48:37 +08:00
|
|
|
strbuf_addf(&oldsection, "branch.%s", oldref.buf + 11);
|
|
|
|
|
strbuf_release(&oldref);
|
|
|
|
|
strbuf_addf(&newsection, "branch.%s", newref.buf + 11);
|
|
|
|
|
strbuf_release(&newref);
|
|
|
|
|
if (git_config_rename_section(oldsection.buf, newsection.buf) < 0)
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("Branch is renamed, but update of config-file failed"));
|
2008-11-18 04:48:37 +08:00
|
|
|
strbuf_release(&oldsection);
|
|
|
|
|
strbuf_release(&newsection);
|
2006-11-28 22:47:40 +08:00
|
|
|
}
|
|
|
|
|
|
2017-04-21 05:08:41 +08:00
|
|
|
static GIT_PATH_FUNC(edit_description, "EDIT_DESCRIPTION")
|
2011-09-21 06:10:08 +08:00
|
|
|
|
|
|
|
|
static int edit_branch_description(const char *branch_name)
|
|
|
|
|
{
|
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
struct strbuf name = STRBUF_INIT;
|
|
|
|
|
|
|
|
|
|
read_branch_desc(&buf, branch_name);
|
|
|
|
|
if (!buf.len || buf.buf[buf.len-1] != '\n')
|
|
|
|
|
strbuf_addch(&buf, '\n');
|
2013-01-17 03:18:48 +08:00
|
|
|
strbuf_commented_addf(&buf,
|
2016-06-18 05:54:15 +08:00
|
|
|
_("Please edit the description for the branch\n"
|
|
|
|
|
" %s\n"
|
|
|
|
|
"Lines starting with '%c' will be stripped.\n"),
|
2013-01-17 03:18:48 +08:00
|
|
|
branch_name, comment_line_char);
|
2017-04-21 05:08:41 +08:00
|
|
|
write_file_buf(edit_description(), buf.buf, buf.len);
|
2011-09-21 06:10:08 +08:00
|
|
|
strbuf_reset(&buf);
|
2017-04-21 05:08:41 +08:00
|
|
|
if (launch_editor(edit_description(), &buf, NULL)) {
|
2011-09-21 06:10:08 +08:00
|
|
|
strbuf_release(&buf);
|
|
|
|
|
return -1;
|
|
|
|
|
}
|
2015-10-16 23:16:42 +08:00
|
|
|
strbuf_stripspace(&buf, 1);
|
2011-09-21 06:10:08 +08:00
|
|
|
|
|
|
|
|
strbuf_addf(&name, "branch.%s.description", branch_name);
|
2016-02-22 19:23:36 +08:00
|
|
|
git_config_set(name.buf, buf.len ? buf.buf : NULL);
|
2011-09-21 06:10:08 +08:00
|
|
|
strbuf_release(&name);
|
|
|
|
|
strbuf_release(&buf);
|
|
|
|
|
|
2016-02-22 19:23:25 +08:00
|
|
|
return 0;
|
2011-09-21 06:10:08 +08:00
|
|
|
}
|
|
|
|
|
|
2006-10-24 05:27:45 +08:00
|
|
|
int cmd_branch(int argc, const char **argv, const char *prefix)
|
|
|
|
|
{
|
2014-12-09 00:28:45 +08:00
|
|
|
int delete = 0, rename = 0, force = 0, list = 0;
|
2011-09-21 06:10:08 +08:00
|
|
|
int reflog = 0, edit_description = 0;
|
2012-08-31 01:23:12 +08:00
|
|
|
int quiet = 0, unset_upstream = 0;
|
2012-08-20 21:47:38 +08:00
|
|
|
const char *new_upstream = NULL;
|
2008-02-20 00:24:37 +08:00
|
|
|
enum branch_track track;
|
2015-09-24 02:11:11 +08:00
|
|
|
struct ref_filter filter;
|
2016-12-04 10:52:25 +08:00
|
|
|
int icase = 0;
|
2015-09-24 02:11:12 +08:00
|
|
|
static struct ref_sorting *sorting = NULL, **sorting_tail = &sorting;
|
2017-07-13 23:01:18 +08:00
|
|
|
struct ref_format format = REF_FORMAT_INIT;
|
2007-10-08 00:26:21 +08:00
|
|
|
|
|
|
|
|
struct option options[] = {
|
2012-08-20 20:31:55 +08:00
|
|
|
OPT_GROUP(N_("Generic options")),
|
2015-09-24 02:11:11 +08:00
|
|
|
OPT__VERBOSE(&filter.verbose,
|
2012-08-20 20:31:55 +08:00
|
|
|
N_("show hash and subject, give twice for upstream branch")),
|
|
|
|
|
OPT__QUIET(&quiet, N_("suppress informational messages")),
|
|
|
|
|
OPT_SET_INT('t', "track", &track, N_("set up tracking mode (see git-pull(1))"),
|
2008-02-20 00:24:37 +08:00
|
|
|
BRANCH_TRACK_EXPLICIT),
|
2012-08-20 20:31:55 +08:00
|
|
|
OPT_SET_INT( 0, "set-upstream", &track, N_("change upstream info"),
|
2010-01-19 04:44:11 +08:00
|
|
|
BRANCH_TRACK_OVERRIDE),
|
2016-04-09 04:02:45 +08:00
|
|
|
OPT_STRING('u', "set-upstream-to", &new_upstream, N_("upstream"), N_("change the upstream info")),
|
2016-09-15 22:58:59 +08:00
|
|
|
OPT_BOOL(0, "unset-upstream", &unset_upstream, N_("Unset the upstream info")),
|
2012-08-20 20:31:55 +08:00
|
|
|
OPT__COLOR(&branch_use_color, N_("use colored output")),
|
2015-09-24 02:11:11 +08:00
|
|
|
OPT_SET_INT('r', "remotes", &filter.kind, N_("act on remote-tracking branches"),
|
|
|
|
|
FILTER_REFS_REMOTES),
|
|
|
|
|
OPT_CONTAINS(&filter.with_commit, N_("print only branches that contain the commit")),
|
ref-filter: add --no-contains option to tag/branch/for-each-ref
Change the tag, branch & for-each-ref commands to have a --no-contains
option in addition to their longstanding --contains options.
This allows for finding the last-good rollout tag given a known-bad
<commit>. Given a hypothetically bad commit cf5c7253e0, the git
version to revert to can be found with this hacky two-liner:
(git tag -l 'v[0-9]*'; git tag -l --contains cf5c7253e0 'v[0-9]*') |
sort | uniq -c | grep -E '^ *1 ' | awk '{print $2}' | tail -n 10
With this new --no-contains option the same can be achieved with:
git tag -l --no-contains cf5c7253e0 'v[0-9]*' | sort | tail -n 10
As the filtering machinery is shared between the tag, branch &
for-each-ref commands, implement this for those commands too. A
practical use for this with "branch" is e.g. finding branches which
were branched off between v2.8.0 and v2.10.0:
git branch --contains v2.8.0 --no-contains v2.10.0
The "describe" command also has a --contains option, but its semantics
are unrelated to what tag/branch/for-each-ref use --contains for. A
--no-contains option for "describe" wouldn't make any sense, other
than being exactly equivalent to not supplying --contains at all,
which would be confusing at best.
Add a --without option to "tag" as an alias for --no-contains, for
consistency with --with and --contains. The --with option is
undocumented, and possibly the only user of it is
Junio (<xmqqefy71iej.fsf@gitster.mtv.corp.google.com>). But it's
trivial to support, so let's do that.
The additions to the the test suite are inverse copies of the
corresponding --contains tests. With this change --no-contains for
tag, branch & for-each-ref is just as well tested as the existing
--contains option.
In addition to those tests, add a test for "tag" which asserts that
--no-contains won't find tree/blob tags, which is slightly
unintuitive, but consistent with how --contains works & is documented.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-03-25 02:40:57 +08:00
|
|
|
OPT_NO_CONTAINS(&filter.no_commit, N_("print only branches that don't contain the commit")),
|
2015-09-24 02:11:11 +08:00
|
|
|
OPT_WITH(&filter.with_commit, N_("print only branches that contain the commit")),
|
ref-filter: add --no-contains option to tag/branch/for-each-ref
Change the tag, branch & for-each-ref commands to have a --no-contains
option in addition to their longstanding --contains options.
This allows for finding the last-good rollout tag given a known-bad
<commit>. Given a hypothetically bad commit cf5c7253e0, the git
version to revert to can be found with this hacky two-liner:
(git tag -l 'v[0-9]*'; git tag -l --contains cf5c7253e0 'v[0-9]*') |
sort | uniq -c | grep -E '^ *1 ' | awk '{print $2}' | tail -n 10
With this new --no-contains option the same can be achieved with:
git tag -l --no-contains cf5c7253e0 'v[0-9]*' | sort | tail -n 10
As the filtering machinery is shared between the tag, branch &
for-each-ref commands, implement this for those commands too. A
practical use for this with "branch" is e.g. finding branches which
were branched off between v2.8.0 and v2.10.0:
git branch --contains v2.8.0 --no-contains v2.10.0
The "describe" command also has a --contains option, but its semantics
are unrelated to what tag/branch/for-each-ref use --contains for. A
--no-contains option for "describe" wouldn't make any sense, other
than being exactly equivalent to not supplying --contains at all,
which would be confusing at best.
Add a --without option to "tag" as an alias for --no-contains, for
consistency with --with and --contains. The --with option is
undocumented, and possibly the only user of it is
Junio (<xmqqefy71iej.fsf@gitster.mtv.corp.google.com>). But it's
trivial to support, so let's do that.
The additions to the the test suite are inverse copies of the
corresponding --contains tests. With this change --no-contains for
tag, branch & for-each-ref is just as well tested as the existing
--contains option.
In addition to those tests, add a test for "tag" which asserts that
--no-contains won't find tree/blob tags, which is slightly
unintuitive, but consistent with how --contains works & is documented.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-03-25 02:40:57 +08:00
|
|
|
OPT_WITHOUT(&filter.no_commit, N_("print only branches that don't contain the commit")),
|
2015-09-24 02:11:11 +08:00
|
|
|
OPT__ABBREV(&filter.abbrev),
|
2007-10-08 00:26:21 +08:00
|
|
|
|
2012-08-20 20:31:55 +08:00
|
|
|
OPT_GROUP(N_("Specific git-branch actions:")),
|
2015-09-24 02:11:11 +08:00
|
|
|
OPT_SET_INT('a', "all", &filter.kind, N_("list both remote-tracking and local branches"),
|
|
|
|
|
FILTER_REFS_REMOTES | FILTER_REFS_BRANCHES),
|
2012-08-20 20:31:55 +08:00
|
|
|
OPT_BIT('d', "delete", &delete, N_("delete fully merged branch"), 1),
|
|
|
|
|
OPT_BIT('D', NULL, &delete, N_("delete branch (even if not merged)"), 2),
|
|
|
|
|
OPT_BIT('m', "move", &rename, N_("move/rename a branch and its reflog"), 1),
|
|
|
|
|
OPT_BIT('M', NULL, &rename, N_("move/rename a branch, even if target exists"), 2),
|
2013-08-03 19:51:19 +08:00
|
|
|
OPT_BOOL(0, "list", &list, N_("list branch names")),
|
|
|
|
|
OPT_BOOL('l', "create-reflog", &reflog, N_("create the branch's reflog")),
|
|
|
|
|
OPT_BOOL(0, "edit-description", &edit_description,
|
|
|
|
|
N_("edit the description for the branch")),
|
2014-12-09 00:28:45 +08:00
|
|
|
OPT__FORCE(&force, N_("force creation, move/rename, deletion")),
|
2015-09-24 02:11:11 +08:00
|
|
|
OPT_MERGED(&filter, N_("print only branches that are merged")),
|
|
|
|
|
OPT_NO_MERGED(&filter, N_("print only branches that are not merged")),
|
2012-08-20 20:31:55 +08:00
|
|
|
OPT_COLUMN(0, "column", &colopts, N_("list branches in columns")),
|
2015-09-24 02:11:12 +08:00
|
|
|
OPT_CALLBACK(0 , "sort", sorting_tail, N_("key"),
|
|
|
|
|
N_("field name to sort on"), &parse_opt_ref_sorting),
|
2008-07-09 08:55:47 +08:00
|
|
|
{
|
2015-09-24 02:11:13 +08:00
|
|
|
OPTION_CALLBACK, 0, "points-at", &filter.points_at, N_("object"),
|
|
|
|
|
N_("print only branches of the object"), 0, parse_opt_object_name
|
2008-07-09 08:55:47 +08:00
|
|
|
},
|
2016-12-04 10:52:25 +08:00
|
|
|
OPT_BOOL('i', "ignore-case", &icase, N_("sorting and filtering are case insensitive")),
|
2017-07-13 23:01:18 +08:00
|
|
|
OPT_STRING( 0 , "format", &format.format, N_("format"), N_("format to use for the output")),
|
2007-10-08 00:26:21 +08:00
|
|
|
OPT_END(),
|
|
|
|
|
};
|
2006-10-24 05:27:45 +08:00
|
|
|
|
2017-01-10 16:49:51 +08:00
|
|
|
setup_ref_filter_porcelain_msg();
|
|
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
memset(&filter, 0, sizeof(filter));
|
|
|
|
|
filter.kind = FILTER_REFS_BRANCHES;
|
|
|
|
|
filter.abbrev = -1;
|
|
|
|
|
|
2010-10-22 14:42:58 +08:00
|
|
|
if (argc == 2 && !strcmp(argv[1], "-h"))
|
|
|
|
|
usage_with_options(builtin_branch_usage, options);
|
|
|
|
|
|
2008-05-15 01:46:53 +08:00
|
|
|
git_config(git_branch_config, NULL);
|
2008-02-18 15:26:03 +08:00
|
|
|
|
2008-02-20 00:24:37 +08:00
|
|
|
track = git_branch_track;
|
2006-11-28 22:47:40 +08:00
|
|
|
|
2017-02-22 07:47:26 +08:00
|
|
|
head = resolve_refdup("HEAD", 0, head_oid.hash, NULL);
|
2006-10-24 05:27:45 +08:00
|
|
|
if (!head)
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("Failed to resolve HEAD as a valid ref."));
|
2014-10-05 02:54:50 +08:00
|
|
|
if (!strcmp(head, "HEAD"))
|
2015-09-24 02:11:11 +08:00
|
|
|
filter.detached = 1;
|
2014-10-05 02:54:50 +08:00
|
|
|
else if (!skip_prefix(head, "refs/heads/", &head))
|
|
|
|
|
die(_("HEAD not found below refs/heads!"));
|
2012-04-13 18:54:38 +08:00
|
|
|
|
2009-05-24 02:53:12 +08:00
|
|
|
argc = parse_options(argc, argv, prefix, options, builtin_branch_usage,
|
|
|
|
|
0);
|
2011-08-28 22:54:31 +08:00
|
|
|
|
2012-08-31 01:23:12 +08:00
|
|
|
if (!delete && !rename && !edit_description && !new_upstream && !unset_upstream && argc == 0)
|
2011-08-28 22:54:31 +08:00
|
|
|
list = 1;
|
|
|
|
|
|
ref-filter: add --no-contains option to tag/branch/for-each-ref
Change the tag, branch & for-each-ref commands to have a --no-contains
option in addition to their longstanding --contains options.
This allows for finding the last-good rollout tag given a known-bad
<commit>. Given a hypothetically bad commit cf5c7253e0, the git
version to revert to can be found with this hacky two-liner:
(git tag -l 'v[0-9]*'; git tag -l --contains cf5c7253e0 'v[0-9]*') |
sort | uniq -c | grep -E '^ *1 ' | awk '{print $2}' | tail -n 10
With this new --no-contains option the same can be achieved with:
git tag -l --no-contains cf5c7253e0 'v[0-9]*' | sort | tail -n 10
As the filtering machinery is shared between the tag, branch &
for-each-ref commands, implement this for those commands too. A
practical use for this with "branch" is e.g. finding branches which
were branched off between v2.8.0 and v2.10.0:
git branch --contains v2.8.0 --no-contains v2.10.0
The "describe" command also has a --contains option, but its semantics
are unrelated to what tag/branch/for-each-ref use --contains for. A
--no-contains option for "describe" wouldn't make any sense, other
than being exactly equivalent to not supplying --contains at all,
which would be confusing at best.
Add a --without option to "tag" as an alias for --no-contains, for
consistency with --with and --contains. The --with option is
undocumented, and possibly the only user of it is
Junio (<xmqqefy71iej.fsf@gitster.mtv.corp.google.com>). But it's
trivial to support, so let's do that.
The additions to the the test suite are inverse copies of the
corresponding --contains tests. With this change --no-contains for
tag, branch & for-each-ref is just as well tested as the existing
--contains option.
In addition to those tests, add a test for "tag" which asserts that
--no-contains won't find tree/blob tags, which is slightly
unintuitive, but consistent with how --contains works & is documented.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-03-25 02:40:57 +08:00
|
|
|
if (filter.with_commit || filter.merge != REF_FILTER_MERGED_NONE || filter.points_at.nr ||
|
|
|
|
|
filter.no_commit)
|
2013-01-31 14:46:11 +08:00
|
|
|
list = 1;
|
|
|
|
|
|
2014-12-09 00:28:45 +08:00
|
|
|
if (!!delete + !!rename + !!new_upstream +
|
2013-08-07 15:32:25 +08:00
|
|
|
list + unset_upstream > 1)
|
2008-07-09 08:55:47 +08:00
|
|
|
usage_with_options(builtin_branch_usage, options);
|
2006-10-24 05:27:45 +08:00
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
if (filter.abbrev == -1)
|
|
|
|
|
filter.abbrev = DEFAULT_ABBREV;
|
2016-12-04 10:52:25 +08:00
|
|
|
filter.ignore_case = icase;
|
|
|
|
|
|
2012-04-13 18:54:38 +08:00
|
|
|
finalize_colopts(&colopts, -1);
|
2015-09-24 02:11:11 +08:00
|
|
|
if (filter.verbose) {
|
2012-04-13 18:54:38 +08:00
|
|
|
if (explicitly_enable_column(colopts))
|
|
|
|
|
die(_("--column and --verbose are incompatible"));
|
|
|
|
|
colopts = 0;
|
|
|
|
|
}
|
2011-07-01 14:06:08 +08:00
|
|
|
|
2014-12-09 00:28:45 +08:00
|
|
|
if (force) {
|
|
|
|
|
delete *= 2;
|
|
|
|
|
rename *= 2;
|
|
|
|
|
}
|
|
|
|
|
|
2013-01-28 09:18:14 +08:00
|
|
|
if (delete) {
|
|
|
|
|
if (!argc)
|
|
|
|
|
die(_("branch name required"));
|
2015-09-24 02:11:11 +08:00
|
|
|
return delete_branches(argc, argv, delete > 1, filter.kind, quiet);
|
2013-01-28 09:18:14 +08:00
|
|
|
} else if (list) {
|
2015-09-24 02:11:08 +08:00
|
|
|
/* git branch --local also shows HEAD when it is detached */
|
2015-09-24 02:11:11 +08:00
|
|
|
if ((filter.kind & FILTER_REFS_BRANCHES) && filter.detached)
|
|
|
|
|
filter.kind |= FILTER_REFS_DETACHED_HEAD;
|
|
|
|
|
filter.name_patterns = argv;
|
2016-12-04 10:52:25 +08:00
|
|
|
/*
|
|
|
|
|
* If no sorting parameter is given then we default to sorting
|
|
|
|
|
* by 'refname'. This would give us an alphabetically sorted
|
|
|
|
|
* array with the 'HEAD' ref at the beginning followed by
|
|
|
|
|
* local branches 'refs/heads/...' and finally remote-tacking
|
|
|
|
|
* branches 'refs/remotes/...'.
|
|
|
|
|
*/
|
|
|
|
|
if (!sorting)
|
|
|
|
|
sorting = ref_default_sorting();
|
|
|
|
|
sorting->ignore_case = icase;
|
2017-07-13 23:01:18 +08:00
|
|
|
print_ref_list(&filter, sorting, &format);
|
2012-04-13 18:54:38 +08:00
|
|
|
print_columns(&output, colopts, NULL);
|
|
|
|
|
string_list_clear(&output, 0);
|
2015-09-25 02:09:08 +08:00
|
|
|
return 0;
|
2012-04-13 18:54:38 +08:00
|
|
|
}
|
2011-09-21 06:10:08 +08:00
|
|
|
else if (edit_description) {
|
|
|
|
|
const char *branch_name;
|
2012-02-06 09:13:36 +08:00
|
|
|
struct strbuf branch_ref = STRBUF_INIT;
|
|
|
|
|
|
2013-01-28 09:18:13 +08:00
|
|
|
if (!argc) {
|
2015-09-24 02:11:11 +08:00
|
|
|
if (filter.detached)
|
2013-01-28 09:18:16 +08:00
|
|
|
die(_("Cannot give description to detached HEAD"));
|
2011-09-21 06:10:08 +08:00
|
|
|
branch_name = head;
|
2013-01-28 09:18:13 +08:00
|
|
|
} else if (argc == 1)
|
2011-09-21 06:10:08 +08:00
|
|
|
branch_name = argv[0];
|
|
|
|
|
else
|
2013-01-28 09:18:15 +08:00
|
|
|
die(_("cannot edit description of more than one branch"));
|
2012-02-06 09:13:36 +08:00
|
|
|
|
|
|
|
|
strbuf_addf(&branch_ref, "refs/heads/%s", branch_name);
|
|
|
|
|
if (!ref_exists(branch_ref.buf)) {
|
|
|
|
|
strbuf_release(&branch_ref);
|
|
|
|
|
|
|
|
|
|
if (!argc)
|
2013-01-28 09:18:16 +08:00
|
|
|
return error(_("No commit on branch '%s' yet."),
|
2012-02-06 09:13:36 +08:00
|
|
|
branch_name);
|
|
|
|
|
else
|
2013-01-28 09:18:16 +08:00
|
|
|
return error(_("No branch named '%s'."),
|
|
|
|
|
branch_name);
|
2012-02-06 09:13:36 +08:00
|
|
|
}
|
|
|
|
|
strbuf_release(&branch_ref);
|
|
|
|
|
|
2011-09-21 06:10:08 +08:00
|
|
|
if (edit_branch_description(branch_name))
|
|
|
|
|
return 1;
|
2011-12-10 05:37:05 +08:00
|
|
|
} else if (rename) {
|
2013-03-31 09:27:44 +08:00
|
|
|
if (!argc)
|
|
|
|
|
die(_("branch name required"));
|
|
|
|
|
else if (argc == 1)
|
2011-11-03 00:17:12 +08:00
|
|
|
rename_branch(head, argv[0], rename > 1);
|
|
|
|
|
else if (argc == 2)
|
|
|
|
|
rename_branch(argv[0], argv[1], rename > 1);
|
|
|
|
|
else
|
2013-01-28 09:18:15 +08:00
|
|
|
die(_("too many branches for a rename operation"));
|
2012-08-20 21:47:38 +08:00
|
|
|
} else if (new_upstream) {
|
|
|
|
|
struct branch *branch = branch_get(argv[0]);
|
|
|
|
|
|
2013-02-23 20:22:27 +08:00
|
|
|
if (argc > 1)
|
|
|
|
|
die(_("too many branches to set new upstream"));
|
|
|
|
|
|
|
|
|
|
if (!branch) {
|
|
|
|
|
if (!argc || !strcmp(argv[0], "HEAD"))
|
|
|
|
|
die(_("could not set upstream of HEAD to %s when "
|
|
|
|
|
"it does not point to any branch."),
|
|
|
|
|
new_upstream);
|
|
|
|
|
die(_("no such branch '%s'"), argv[0]);
|
|
|
|
|
}
|
|
|
|
|
|
2012-08-20 21:47:38 +08:00
|
|
|
if (!ref_exists(branch->refname))
|
|
|
|
|
die(_("branch '%s' does not exist"), branch->name);
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* create_branch takes care of setting up the tracking
|
|
|
|
|
* info and making sure new_upstream is correct
|
|
|
|
|
*/
|
2016-11-05 00:30:12 +08:00
|
|
|
create_branch(branch->name, new_upstream, 0, 0, 0, quiet, BRANCH_TRACK_OVERRIDE);
|
2012-08-31 01:23:12 +08:00
|
|
|
} else if (unset_upstream) {
|
|
|
|
|
struct branch *branch = branch_get(argv[0]);
|
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
2013-02-23 20:22:27 +08:00
|
|
|
if (argc > 1)
|
|
|
|
|
die(_("too many branches to unset upstream"));
|
|
|
|
|
|
|
|
|
|
if (!branch) {
|
|
|
|
|
if (!argc || !strcmp(argv[0], "HEAD"))
|
|
|
|
|
die(_("could not unset upstream of HEAD when "
|
|
|
|
|
"it does not point to any branch."));
|
|
|
|
|
die(_("no such branch '%s'"), argv[0]);
|
|
|
|
|
}
|
|
|
|
|
|
2013-10-31 17:25:38 +08:00
|
|
|
if (!branch_has_merge_config(branch))
|
2012-08-31 01:23:12 +08:00
|
|
|
die(_("Branch '%s' has no upstream information"), branch->name);
|
|
|
|
|
|
|
|
|
|
strbuf_addf(&buf, "branch.%s.remote", branch->name);
|
2016-02-22 19:23:36 +08:00
|
|
|
git_config_set_multivar(buf.buf, NULL, NULL, 1);
|
2012-08-31 01:23:12 +08:00
|
|
|
strbuf_reset(&buf);
|
|
|
|
|
strbuf_addf(&buf, "branch.%s.merge", branch->name);
|
2016-02-22 19:23:36 +08:00
|
|
|
git_config_set_multivar(buf.buf, NULL, NULL, 1);
|
2012-08-31 01:23:12 +08:00
|
|
|
strbuf_release(&buf);
|
2011-11-23 14:31:55 +08:00
|
|
|
} else if (argc > 0 && argc <= 2) {
|
2012-08-31 01:23:13 +08:00
|
|
|
struct branch *branch = branch_get(argv[0]);
|
|
|
|
|
int branch_existed = 0, remote_tracking = 0;
|
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
2013-02-23 20:22:27 +08:00
|
|
|
if (!strcmp(argv[0], "HEAD"))
|
|
|
|
|
die(_("it does not make sense to create 'HEAD' manually"));
|
|
|
|
|
|
|
|
|
|
if (!branch)
|
|
|
|
|
die(_("no such branch '%s'"), argv[0]);
|
|
|
|
|
|
2015-09-24 02:11:11 +08:00
|
|
|
if (filter.kind != FILTER_REFS_BRANCHES)
|
2011-02-23 07:41:34 +08:00
|
|
|
die(_("-a and -r options to 'git branch' do not make sense with a branch name"));
|
2012-08-31 01:23:13 +08:00
|
|
|
|
|
|
|
|
if (track == BRANCH_TRACK_OVERRIDE)
|
|
|
|
|
fprintf(stderr, _("The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to\n"));
|
|
|
|
|
|
|
|
|
|
strbuf_addf(&buf, "refs/remotes/%s", branch->name);
|
|
|
|
|
remote_tracking = ref_exists(buf.buf);
|
|
|
|
|
strbuf_release(&buf);
|
|
|
|
|
|
|
|
|
|
branch_existed = ref_exists(branch->refname);
|
2016-11-05 00:30:12 +08:00
|
|
|
create_branch(argv[0], (argc == 2) ? argv[1] : head,
|
2014-12-09 00:28:45 +08:00
|
|
|
force, reflog, 0, quiet, track);
|
2012-08-31 01:23:13 +08:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* We only show the instructions if the user gave us
|
|
|
|
|
* one branch which doesn't exist locally, but is the
|
|
|
|
|
* name of a remote-tracking branch.
|
|
|
|
|
*/
|
|
|
|
|
if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
|
|
|
|
|
!branch_existed && remote_tracking) {
|
|
|
|
|
fprintf(stderr, _("\nIf you wanted to make '%s' track '%s', do this:\n\n"), head, branch->name);
|
2016-04-13 18:29:53 +08:00
|
|
|
fprintf(stderr, " git branch -d %s\n", branch->name);
|
|
|
|
|
fprintf(stderr, " git branch --set-upstream-to %s\n", branch->name);
|
2012-08-31 01:23:13 +08:00
|
|
|
}
|
|
|
|
|
|
2009-12-30 22:45:31 +08:00
|
|
|
} else
|
2007-10-08 00:26:21 +08:00
|
|
|
usage_with_options(builtin_branch_usage, options);
|
2006-10-24 05:27:45 +08:00
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
