Alan Modra fff56ce438 ubsan: d-demangle.c:214 signed integer overflow ... Running the libiberty testsuite ./test-demangle < libiberty/testsuite/d-demangle-expected libiberty/d-demangle.c:214:14: runtime error: signed integer overflow: 922337203 * 10 cannot be represented in type 'long int' On looking at silencing ubsan, I found a real bug in dlang_number. For a 32-bit long, some overflows won't be detected. For example, 21474836480. Why? Well 214748364 * 10 is 0x7FFFFFF8 (no overflow so far). Adding 8 gives 0x80000000 (which does overflow but there is no test for that overflow in the code). Then multiplying 0x80000000 * 10 = 0x500000000 = 0 won't be caught by the multiplication overflow test. The same holds for a 64-bit long using similarly crafted digit sequences. * d-demangle.c: Include limits.h. (ULONG_MAX, UINT_MAX): Provide fall-back definition. (dlang_number): Simplify and correct overflow test. Only write *ret on returning non-NULL. Make "ret" an unsigned long*. Only succeed for result of [0,UINT_MAX]. (dlang_decode_backref): Simplify and correct overflow test. Only write *ret on returning non-NULL. Only succeed for result [1,MAX_LONG]. (dlang_backref): Remove now unnecessary range check. (dlang_symbol_name_p): Likewise. (string_need): Take a size_t n arg, and use size_t tem. (string_append): Use size_t n. (string_appendn, string_prependn): Take a size_t n arg. (TEMPLATE_LENGTH_UNKNOWN): Define as -1UL. (dlang_lname, dlang_parse_template): Take an unsigned long len arg. (dlang_symbol_backref, dlang_identifier, dlang_parse_integer), (dlang_parse_integer, dlang_parse_string), (dlang_parse_arrayliteral, dlang_parse_assocarray), (dlang_parse_structlit, dlang_parse_tuple), (dlang_template_symbol_param, dlang_template_args): Use unsigned long variables. * testsuite/d-demangle-expected: Add new tests.		2020-09-08 10:45:15 +09:30
..
d-demangle-expected	ubsan: d-demangle.c:214 signed integer overflow	2020-09-08 10:45:15 +09:30
demangle-expected	demangler: don't treat lambda as a substitution candidate	2020-07-14 10:25:48 -07:00
demangler-fuzzer.c	Update copyright years.	2020-01-01 12:51:42 +01:00
Makefile.in	Update copyright years.	2020-01-01 12:51:42 +01:00
rust-demangle-expected	rust-demangle.c (looks_like_rust): Remove.	2019-10-03 15:54:47 -06:00
test-demangle.c	Update copyright years.	2020-01-01 12:51:42 +01:00
test-expandargv.c	Update copyright years.	2020-01-01 12:51:42 +01:00
test-pexecute.c	Update copyright years.	2020-01-01 12:51:42 +01:00
test-strtol.c	Update copyright years.	2020-01-01 12:51:42 +01:00