mirrors/gcc
1
0
Fork 0
mirror of https://gcc.gnu.org/git/gcc.git synced 2024-11-23 10:54:07 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

i386: Call get_available_features for all CPUs with max_level >= 1 [PR100758]

Browse Source 
get_available_features doesn't depend on cpu_model2->__cpu_{family,model}
and just sets stuff up based on CPUID leaf 1, or some extended ones,
so I wonder why are we calling it separately for Intel, AMD and Zhaoxin
and not for all other CPUs too?  I think various programs in the wild
which aren't using __builtin_cpu_{is,supports} just check the various CPUID
leafs and query bits in there, without blacklisting unknown CPU vendors,
so I think even __builtin_cpu_supports ("sse2") etc. should be reliable
if those VENDOR_{CENTAUR,CYRIX,NSC,OTHER} CPUs set those bits in CPUID leaf
1 or some extended ones.  Calling it for all CPUs also means it can be
inlined because there will be just a single caller.

I have tested it on Intel and Martin tested it on AMD, but can't test it
on non-Intel/AMD; for Intel/AMD/Zhaoxin it should be really no change in
behavior.

2023-02-09  Jakub Jelinek  <jakub@redhat.com>

	PR target/100758
	* config/i386/cpuinfo.c (cpu_indicator_init): Call
	get_available_features for all CPUs with max_level >= 1, rather
	than just Intel or AMD.

(cherry picked from commit b24e9c0830)
This commit is contained in:
Jakub Jelinek 2023-02-09 17:43:19 +01:00
parent 8776316329
commit be80a2e64a
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libgcc/config/i386/cpuinfo.c
View File

@ -474,6 +474,9 @@ __cpu_indicator_init (void)
extended_model = (eax >> 12) & 0xf0;
extended_family = (eax >> 20) & 0xff;
/* Find available features. */
get_available_features (ecx, edx, max_level);
if (vendor == signature_INTEL_ebx)
{
/* Adjust model and family for Intel CPUS. */
@ -487,8 +490,6 @@ __cpu_indicator_init (void)
/* Get CPU type. */
get_intel_cpu (family, model, brand_id);
/* Find available features. */
get_available_features (ecx, edx, max_level);
__cpu_model.__cpu_vendor = VENDOR_INTEL;
}
else if (vendor == signature_AMD_ebx)
@ -502,8 +503,6 @@ __cpu_indicator_init (void)
/* Get CPU type. */
get_amd_cpu (family, model);
/* Find available features. */
get_available_features (ecx, edx, max_level);
__cpu_model.__cpu_vendor = VENDOR_AMD;
}
else