mirrors/gcc
0
0
Fork 0
mirror of https://gcc.gnu.org/git/gcc.git synced 2025-01-01 16:34:06 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

d: Drop any field or parameter types that got cached before conversion failed.

Browse Source 
This ensures there are no dangling references to AST members that have
been freed, either explcitly or by the garbage collector.

gcc/d/ChangeLog:

	* d-builtins.cc (build_frontend_type): Restore builtin_converted_decls
	length on conversion failure.
This commit is contained in:
Iain Buclaw 2021-07-26 15:38:15 +02:00
parent 55303957de
commit bafda27537
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gcc/d/d-builtins.cc
View File

@ -80,7 +80,8 @@ build_frontend_type (tree type)
mod |= MODshared;
/* If we've seen the type before, re-use the converted decl. */
for (size_t i = 0; i < builtin_converted_decls.length (); ++i)
unsigned saved_builtin_decls_length = builtin_converted_decls.length ();
for (size_t i = 0; i < saved_builtin_decls_length; ++i)
{
tree t = builtin_converted_decls[i].ctype;
if (TYPE_MAIN_VARIANT (t) == TYPE_MAIN_VARIANT (type))
@ -249,6 +250,9 @@ build_frontend_type (tree type)
Type *ftype = build_frontend_type (TREE_TYPE (field));
if (!ftype)
{
/* Drop any field types that got cached before the conversion
of this record type failed. */
builtin_converted_decls.truncate (saved_builtin_decls_length);
delete sdecl->members;
return NULL;
}
@ -307,6 +311,9 @@ build_frontend_type (tree type)
Type *targ = build_frontend_type (argtype);
if (!targ)
{
/* Drop any parameter types that got cached before the
conversion of this function type failed. */
builtin_converted_decls.truncate (saved_builtin_decls_length);
delete args;
return NULL;
}