Fix TOP N counter update.

PR tree-optimization/92924
	* libgcov-profiler.c (__gcov_topn_values_profiler_body): First
	try to find an existing value, then find an empty slot
	if not found.
This commit is contained in:
Martin Liska 2020-01-22 13:40:12 +01:00
parent 9c4fb56578
commit 7491c17fe0
No known key found for this signature in database
GPG Key ID: 4DC182DC0FA73785
2 changed files with 31 additions and 22 deletions

View File

@ -1,3 +1,10 @@
2020-01-22 Martin Liska <mliska@suse.cz>
PR tree-optimization/92924
* libgcov-profiler.c (__gcov_topn_values_profiler_body): First
try to find an existing value, then find an empty slot
if not found.
2020-01-22 Martin Liska <mliska@suse.cz>
PR tree-optimization/92924

View File

@ -119,35 +119,37 @@ __gcov_topn_values_profiler_body (gcov_type *counters, gcov_type value,
++counters;
/* First try to find an existing value. */
int empty_counter = -1;
for (unsigned i = 0; i < GCOV_TOPN_VALUES; i++)
if (value == counters[2 * i])
{
if (use_atomic)
__atomic_fetch_add (&counters[2 * i + 1], GCOV_TOPN_VALUES,
__ATOMIC_RELAXED);
else
counters[2 * i + 1] += GCOV_TOPN_VALUES;
return;
}
else if (counters[2 * i + 1] <= 0)
empty_counter = i;
/* Find an empty slot for a new value. */
if (empty_counter != -1)
{
if (value == counters[2 * i])
{
if (use_atomic)
__atomic_fetch_add (&counters[2 * i + 1], GCOV_TOPN_VALUES,
__ATOMIC_RELAXED);
else
counters[2 * i + 1] += GCOV_TOPN_VALUES;
return;
}
else if (counters[2 * i + 1] <= 0)
{
/* We found an empty slot. */
counters[2 * i] = value;
counters[2 * i + 1] = GCOV_TOPN_VALUES;
return;
}
counters[2 * empty_counter] = value;
counters[2 * empty_counter + 1] = GCOV_TOPN_VALUES;
return;
}
/* We haven't found an empty slot, then decrement all
counter values by one. */
for (unsigned i = 0; i < GCOV_TOPN_VALUES; i++)
{
if (use_atomic)
__atomic_fetch_sub (&counters[2 * i + 1], 1, __ATOMIC_RELAXED);
else
counters[2 * i + 1]--;
}
if (use_atomic)
__atomic_fetch_sub (&counters[2 * i + 1], 1, __ATOMIC_RELAXED);
else
counters[2 * i + 1]--;
}
#ifdef L_gcov_topn_values_profiler