mirrors/gcc
0
0
Fork 0
mirror of https://gcc.gnu.org/git/gcc.git synced 2024-12-21 01:55:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

rs6000: Fix signed integer overflows

Browse Source 
bootstrap-ubsan on gcc112 shows a couple of signed integer overflows:

config/rs6000/constraints.md:143:33: runtime error: signed integer overflow: 9223372036854775807 + 32768 cannot be represented in type 'long int'
config/rs6000/predicates.md:396:22: runtime error: signed integer overflow: 9223372036854775807 + 2147516416 cannot be represented in type 'long int'
config/rs6000/predicates.md:856:11: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:862:12: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:865:11: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:868:12: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:914:11: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:917:12: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:940:11: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:946:12: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:949:11: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself
config/rs6000/predicates.md:955:12: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself

2014-11-19  Markus Trippelsdorf  <markus@trippelsdorf.de>

	* config/rs6000/constraints.md: Avoid signed integer overflows.
	* config/rs6000/predicates.md: Likewise.

From-SVN: r217785
This commit is contained in:
Markus Trippelsdorf 2014-11-19 16:28:23 +00:00 committed by Markus Trippelsdorf
parent 31b0bf51d6
commit 2d302f47a0
3 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2014-11-19 Markus Trippelsdorf <markus@trippelsdorf.de>
* config/rs6000/constraints.md: Avoid signed integer overflows.
* config/rs6000/predicates.md: Likewise.
2014-11-19 Renlin Li <Renlin.Li@arm.com> 2014-11-19 Renlin Li <Renlin.Li@arm.com>
PR middle-end/63762 PR middle-end/63762

2
gcc/config/rs6000/constraints.md
View File

@ -140,7 +140,7 @@
(define_constraint "I" (define_constraint "I"
"A signed 16-bit constant" "A signed 16-bit constant"
(and (match_code "const_int") (and (match_code "const_int")
(match_test "(unsigned HOST_WIDE_INT) (ival + 0x8000) < 0x10000"))) (match_test "((unsigned HOST_WIDE_INT) ival + 0x8000) < 0x10000")))
(define_constraint "J" (define_constraint "J"
"high-order 16 bits nonzero" "high-order 16 bits nonzero"

12
gcc/config/rs6000/predicates.md
View File

@ -392,8 +392,8 @@
;; Return 1 if op is a constant integer valid for addition with addis, addi. ;; Return 1 if op is a constant integer valid for addition with addis, addi.
(define_predicate "add_cint_operand" (define_predicate "add_cint_operand"
(and (match_code "const_int") (and (match_code "const_int")
(match_test "(unsigned HOST_WIDE_INT) (match_test "((unsigned HOST_WIDE_INT) INTVAL (op)
(INTVAL (op) + (mode == SImode ? 0x80000000 : 0x80008000)) + (mode == SImode ? 0x80000000 : 0x80008000))
< (unsigned HOST_WIDE_INT) 0x100000000ll"))) < (unsigned HOST_WIDE_INT) 0x100000000ll")))
;; Return 1 if op is a constant integer valid for addition ;; Return 1 if op is a constant integer valid for addition
@ -827,7 +827,7 @@
(define_predicate "mask_operand" (define_predicate "mask_operand"
(match_code "const_int") (match_code "const_int")
{ {
HOST_WIDE_INT c, lsb; unsigned HOST_WIDE_INT c, lsb;
c = INTVAL (op); c = INTVAL (op);
@ -872,7 +872,7 @@
(define_predicate "mask_operand_wrap" (define_predicate "mask_operand_wrap"
(match_code "const_int") (match_code "const_int")
{ {
HOST_WIDE_INT c, lsb; unsigned HOST_WIDE_INT c, lsb;
c = INTVAL (op); c = INTVAL (op);
@ -897,7 +897,7 @@
(define_predicate "mask64_operand" (define_predicate "mask64_operand"
(match_code "const_int") (match_code "const_int")
{ {
HOST_WIDE_INT c, lsb; unsigned HOST_WIDE_INT c, lsb;
c = INTVAL (op); c = INTVAL (op);
@ -923,7 +923,7 @@
(define_predicate "mask64_2_operand" (define_predicate "mask64_2_operand"
(match_code "const_int") (match_code "const_int")
{ {
HOST_WIDE_INT c, lsb; unsigned HOST_WIDE_INT c, lsb;
c = INTVAL (op); c = INTVAL (op);