mirrors/gcc
1
0
Fork 0
mirror of https://gcc.gnu.org/git/gcc.git synced 2024-11-23 19:03:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

strub: avoid lto inlining

Browse Source 
The strub builtins are not suited for cross-unit inlining, they should
only be inlined by the builtin expanders, if at all.  While testing on
sparc64, it occurred to me that, if libgcc was built with LTO enabled,
lto1 might inline them, and that would likely break things.  So, make
sure they're clearly marked as not inlinable.


for  libgcc/ChangeLog

	* strub.c (ATTRIBUTE_NOINLINE): New.
	(ATTRIBUTE_STRUB_CALLABLE): Add it.
	(__strub_dummy_force_no_leaf): Drop it.
This commit is contained in:
Alexandre Oliva 2023-12-19 21:06:22 -03:00 committed by Alexandre Oliva
parent 66c8b0f695
commit 1b83fce7df
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libgcc/strub.c
View File

@ -36,7 +36,12 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
# define TOPS <
#endif
#define ATTRIBUTE_STRUB_CALLABLE __attribute__ ((__strub__ ("callable")))
/* Make sure these builtins won't be inlined, even with LTO. */
#define ATTRIBUTE_NOINLINE \
__attribute__ ((__noinline__, __noclone__, __noipa__))
#define ATTRIBUTE_STRUB_CALLABLE \
__attribute__ ((__strub__ ("callable"))) ATTRIBUTE_NOINLINE
/* Enter a stack scrubbing context, initializing the watermark to the caller's
stack address. */
@ -72,7 +77,6 @@ __strub_update (void **watermark)
/* Dummy function, called to force the caller to not be a leaf function, so
that it can't use the red zone. */
static void ATTRIBUTE_STRUB_CALLABLE
__attribute__ ((__noinline__, __noipa__))
__strub_dummy_force_no_leaf (void)
{
}