Commit Graph

40 Commits

Author SHA1 Message Date
Nick Coghlan
aad0ea0b59 Merge fix for #18805 from 3.3 2014-02-08 23:20:58 +10:00
Nick Coghlan
932346f572 Issue #18805: better netmask validation in ipaddress 2014-02-08 23:17:36 +10:00
Peter Moody
e5019d5183 #17400: correct handling of 100.64.0.0/10, fixing the docs and updating NEWS 2013-10-24 09:47:10 -07:00
Peter Moody
be9c1b133b #17400: fix documentation, add cache to is_global and correctly handle 100.64.0.0/10 2013-10-22 12:36:21 -07:00
Peter Moody
22c3176426 #17400; ipaddress should make it easy to identify rfc6598 addresses 2013-10-21 13:58:06 -07:00
Ezio Melotti
30b9d5d3af #18705: fix a number of typos. Patch by Févry Thibault. 2013-08-17 15:50:46 +03:00
Ezio Melotti
3f5db3940f Fix a few typos and a double semicolon. Patch by Eitan Adler. 2013-01-27 06:20:14 +02:00
Eli Bendersky
948af23a77 Issue #15888: fixing problems in ipaddress doctests. Patch by Chris Jerdonek 2012-10-07 07:23:50 -07:00
Nick Coghlan
db7920b978 Close #14814: Avoid depending on struct by using newer features. Also use enumerate where appropriate (patch by Serhiy Storchaka). Declaring PEP 3144 final at this point - any further changes to code or docs can go in new issues. 2012-08-20 10:19:12 +10:00
Nick Coghlan
a8517ad3d9 Issue #14814: document the Interface APIs and fix various problems with the string representations (initial patch by Eli Bendersky). 2012-08-20 10:04:26 +10:00
Nick Coghlan
e3ded955f3 Issue #14814: Remove redundant property from interface objects - prefixlen can be accessed via the associated network object 2012-08-05 22:45:22 +10:00
Nick Coghlan
730f67f2fa Issue 14814: Docs work showed some more cases of networks pretending to be addresses and highlighted the weird approach to implementing the 'is_whatever' properties. Impl now illustrates far more clearly that networks have a property if both their network and broadcast addresses have that property 2012-08-05 22:02:18 +10:00
Nick Coghlan
e0c3f5edc0 Close #15559: Implementing __index__ creates a nasty interaction with the bytes constructor. At least for 3.3, ipaddress objects must now be explicitly converted with int() and thus can't be passed directly to the hex() builtin. 2012-08-05 18:20:17 +10:00
Nick Coghlan
07c4e33c07 Issue 14814: The new systematic tests aren't just about error reporting any more - change names accordingly. Added and tweaked some example to ensure they were covering the intended code paths 2012-07-08 23:06:45 +10:00
Nick Coghlan
27396a1807 Issue 14814: Remove dead function (noticed by Serhiy Storchaka) 2012-07-08 21:38:12 +10:00
Nick Coghlan
297b143c6d Issue 14814: Further error case testing coverage and cleanups 2012-07-08 17:11:04 +10:00
Nick Coghlan
3008ec070f Issue 14814: Ensure ordering semantics across all 3 entity types in ipaddress are consistent and well-defined 2012-07-08 00:45:33 +10:00
Nick Coghlan
9a9c28ce7a Issue 14814: Correctly return NotImplemented from ipaddress._BaseNetwork.__eq__ 2012-07-07 23:05:59 +10:00
Nick Coghlan
b582ecc562 Issue 14814: Explain how to get more error detail in the ipaddress tutorial, and tweak the display for octet errors in IPv4 (noticed the formatting problem when adding to the docs) 2012-07-07 22:15:22 +10:00
Nick Coghlan
7319f69f49 Issue 14814: Make the ipaddress code easier to follow by using newer language features (patch by Serhiy Storchaka) 2012-07-07 21:43:30 +10:00
Nick Coghlan
36f8dcde06 Issue 14814: Provide more informative error messages in ipaddress, and ensure that errors are caught as expected 2012-07-07 19:23:53 +10:00
Nick Coghlan
912238e3ac Issue 14814: %s implies coercion with str() - remove a lot of redundant str() calls from the ipaddress implementation 2012-07-07 13:34:50 +10:00
Nick Coghlan
5cf896fea8 Issue 14814: Eliminate bytes warnings from ipaddress by correctly throwing an exception early when given bytes data of the wrong length. Also removes 2.x backwards compatibility code from associated tests. 2012-07-07 01:43:31 +10:00
Nick Coghlan
3c2570caf2 Issue 14814: Better handling of cases where octet/hextet parsing fails, including ensuring that tracebacks are still clean even when calling class constructors directly 2012-07-07 01:13:55 +10:00
Nick Coghlan
d972265df8 Improve an internal ipaddress test, add a comment explaining why treating networks as containers of interfaces rather than addresses would prove confusing 2012-06-17 16:33:00 +10:00
Hynek Schlawack
ed36b2e55b #14814: Remove redundant code from ipaddress.IPv6Network
The strict checks and netmask computing don't make sense if constructed with
a ALL_ONES mask based on addresses. Also fix a bug due to mis-indentation of
a return statement in the same code block.
2012-06-08 15:21:21 +02:00
Hynek Schlawack
91c5a34613 #14814: ipaddress: refactor dup code, minor janitoring, bump coverage
- remove duplicate netmask/hostmask code
- make two ifs more pythonic
- remove packed property for networks
- some minor pep8 stuff
- Test coverage is now at 97%, the rest are mostly unreachable safeguards.
2012-06-05 11:55:58 +02:00
Hynek Schlawack
454a74df23 #14814: Remove dead code from ipaddress
_BaseNetwork contained (faulty) methods for creating string representations.
I've fixed them and put them to use by eliminating identical overrides.
2012-06-04 18:14:02 +02:00
Hynek Schlawack
bcd304480f #14814: Use correct comparison for IP addresses
ipaddress._BaseV4.is_unspecified() compared IP addresses using "in" which
fails.
2012-06-04 14:19:39 +02:00
Sandro Tosi
b4386d36f1 Issue #14814: minor spelling fixes 2012-06-02 17:14:22 +02:00
Hynek Schlawack
35db513187 #14814: Fix errror message creation in ipaddress.collapse_addresses 2012-06-01 20:12:17 +02:00
Hynek Schlawack
c4b78a3e15 #14814: Remove 2.x's new-style classes syntax from ipaddress 2012-06-01 11:48:32 +02:00
Hynek Schlawack
7e0229e90d #14814: Remove stale __hex__ method from ipaddress
Obsolete 2.x method.
2012-06-01 00:20:13 +02:00
Nick Coghlan
2c58910d3d Issue #14814: Clean out an obsolete property and method from ipaddress Network objects 2012-05-27 01:03:25 +10:00
Nick Coghlan
aff73f91cc Issue #14814: Cleanup ipaddress header comments 2012-05-27 00:57:25 +10:00
Nick Coghlan
51c3067551 Issue #14814: In the spirit of TOOWTDI, ditch the redundant version parameter to the factory functions by using the appropriate direct class references instead 2012-05-27 00:25:58 +10:00
Hynek Schlawack
072b1e1485 #14814: Some PEP8 adjustments and dead code weeding 2012-05-26 12:04:56 +02:00
Sandro Tosi
b95c63413d Issue #14814: minor improvements as suggested by Hynek Schlawack 2012-05-23 23:17:22 +02:00
Sandro Tosi
876ecad9f5 Issue #14814: improve docstrings and arguments value handling, as per Terry J. Reedy's comments 2012-05-23 22:26:55 +02:00
Nick Coghlan
dc9b2555a8 Issue #14814: addition of the ipaddress module (stage 1 - code and tests) 2012-05-20 21:01:57 +10:00