Jeroen Demeyer
7f41c8e0dd
bpo-37493: use _PyObject_CallNoArg in more places (GH-14575)
2019-07-04 19:35:31 +09:00
Jeroen Demeyer
196a530e00
bpo-37483: add _PyObject_CallOneArg() function ( #14558 )
2019-07-04 19:31:34 +09:00
Raymond Hettinger
e985804207
bpo-37165: Convert _count_elements to the argument clinic (GH-13848)
2019-06-05 16:05:25 -07:00
Jeroen Demeyer
530f506ac9
bpo-36974: tp_print -> tp_vectorcall_offset and tp_reserved -> tp_as_async (GH-13464)
...
Automatically replace
tp_print -> tp_vectorcall_offset
tp_compare -> tp_as_async
tp_reserved -> tp_as_async
2019-05-30 19:13:39 -07:00
Serhiy Storchaka
d53fe5f407
bpo-36254: Fix invalid uses of %d in format strings in C. (GH-12264)
2019-03-13 22:59:55 +02:00
Serhiy Storchaka
adfffc7343
Fix the C function signature for _collections._tuplegetter.__reduce__. (GH-12180)
...
Correctly fixes bpo-36197.
2019-03-05 18:41:09 +02:00
Stéphane Wirtel
359a2f3dab
bpo-33012: Fix compilation warnings in memoryobject.c and _collectionsmodule.c (GH-12179)
...
Cast function pointers to (void(*)(void)) before casting to (PyCFunction)
to make "warning: cast between incompatible function types" false alarm quiet.
2019-03-05 16:10:53 +01:00
Joe Jevnik
f36f89257b
bpo-36068: Make _tuplegetter objects serializable (GH-11981)
2019-02-21 13:00:40 -08:00
Raymond Hettinger
05f1b93f58
Speed-up argument parsing for common cases in deque.__init__()(GH-11717)
2019-01-31 22:13:43 -08:00
Serhiy Storchaka
052b2dfdc9
bpo-32492: Tweak _collections._tuplegetter. (GH-11367)
...
* Replace the docstrings cache with sys.intern().
* Improve tests.
* Unify names of tp_descr_get and tp_descr_set functions.
2018-12-31 14:15:16 +02:00
Pablo Galindo
3f5fc70c62
bpo-32492: 1.6x speed up in namedtuple attribute access using C fast-path ( #10495 )
...
* bpo-32492: 2.5x speed up in namedtuple attribute access using C fast path
* Add News entry
* fixup! bpo-32492: 2.5x speed up in namedtuple attribute access using C fast path
* Check for tuple in the __get__ of the new descriptor and don't cache the descriptor itself
* Don't inherit from property. Implement GC methods to handle __doc__
* Add a test for the docstring substitution in descriptors
* Update NEWS entry to reflect time against 3.7 branch
* Simplify implementation with argument clinic, better error messages, only __new__
* Use positional-only parameters for the __new__
* Use PyTuple_GET_SIZE and PyTuple_GET_ITEM to tighter the implementation of tuplegetterdescr_get
* Implement __set__ to make tuplegetter a data descriptor
* Use Py_INCREF now that we inline PyTuple_GetItem
* Apply the valid_index() function, saving one test
* Move Py_None test out of the critical path.
2018-12-30 01:24:03 -08:00
Serhiy Storchaka
d4f9cf5545
bpo-33029: Fix signatures of getter and setter functions. (GH-10746)
...
Fix also return type for few other functions (clear, releasebuffer).
2018-11-27 19:34:35 +02:00
Serhiy Storchaka
62be74290a
bpo-33012: Fix invalid function cast warnings with gcc 8. (GH-6749)
...
Fix invalid function cast warnings with gcc 8
for method conventions different from METH_NOARGS, METH_O and
METH_VARARGS excluding Argument Clinic generated code.
2018-11-27 13:27:31 +02:00
Serhiy Storchaka
81524022d0
bpo-33012: Fix signatures of METH_NOARGS funstions. (GH-10736)
2018-11-27 13:05:02 +02:00
Raymond Hettinger
b46ad5431d
Minor performance tweak for deque.index() with a start argument (GH-9440)
2018-09-21 01:46:41 -07:00
Oren Milman
24bd50bdcc
closes bpo-31608: Fix a crash in methods of a subclass of _collections.deque with a bad __new__(). (GH-3788)
2018-09-11 11:46:55 -07:00
Raymond Hettinger
66953f0ec6
Factor-out two substantially identical code blocks. (GH-8219)
2018-07-10 04:17:40 -07:00
Serhiy Storchaka
a5c42284e6
bpo-33677: Fix signatures of tp_clear handlers for AST and deque. (GH-7196)
2018-05-31 07:34:34 +03:00
Siddhesh Poyarekar
55edd0c185
bpo-33012: Fix invalid function cast warnings with gcc 8 for METH_NOARGS. (GH-6030)
...
METH_NOARGS functions need only a single argument but they are cast
into a PyCFunction, which takes two arguments. This triggers an
invalid function cast warning in gcc8 due to the argument mismatch.
Fix this by adding a dummy unused argument.
2018-04-29 21:59:33 +03:00
Serhiy Storchaka
f320be77ff
bpo-32571: Avoid raising unneeded AttributeError and silencing it in C code (GH-5222)
...
Add two new private APIs: _PyObject_LookupAttr() and _PyObject_LookupAttrId()
2018-01-25 17:49:40 +09:00
Serhiy Storchaka
a5552f023e
bpo-32240: Add the const qualifier to declarations of PyObject* array arguments. ( #4746 )
2017-12-15 13:11:11 +02:00
Oren Milman
31aca4bf79
bpo-31586: Use _count_element fast path for real dicts.
2017-09-26 20:18:21 -07:00
Serhiy Storchaka
b3a77964ea
bpo-27541: Reprs of subclasses of some classes now contain actual type name. ( #3631 )
...
Affected classes are bytearray, array, deque, defaultdict, count and repeat.
2017-09-21 14:24:13 +03:00
Raymond Hettinger
e1b0287c04
Code clean-up. Remove unnecessary pre-increment before the loop starts. ( #3312 )
2017-09-04 16:07:06 -07:00
INADA Naoki
a6296d34a4
bpo-31095: fix potential crash during GC (GH-2974)
2017-08-24 14:55:17 +09:00
Serhiy Storchaka
6969eaf468
bpo-29464: Rename METH_FASTCALL to METH_FASTCALL|METH_KEYWORDS and make ( #1955 )
...
the bare METH_FASTCALL be used for functions with positional-only
parameters.
2017-07-03 21:20:15 +03:00
Serhiy Storchaka
d4edfc9abf
bpo-29935: Fixed error messages in the index() method of tuple, list and deque ( #887 )
...
when pass indices of wrong type.
2017-03-30 18:29:23 +03:00
Serhiy Storchaka
ba85d69a3e
bpo-29878: Add global instances of int for 0 and 1. ( #852 )
2017-03-30 09:09:41 +03:00
Louie Lu
357bad7101
bpo-29634: Reduce deque repeat execution when maxlen exist and size is not 1 ( #255 ) ( #255 )
2017-02-23 22:59:49 -05:00
Victor Stinner
dd407d5006
Optimize deque index, insert and rotate() methods
...
Issue #29452 : Use METH_FASTCALL calling convention for index(), insert() and
rotate() methods of collections.deque to avoid the creation a temporary tuple
to pass position arguments. Speedup on deque methods:
* d.rotate(): 1.10x faster
* d.rotate(1): 1.24x faster
* d.insert(): 1.18x faster
* d.index(): 1.24x faster
2017-02-06 16:06:49 +01:00
Raymond Hettinger
a24dca6a90
Fix typo
2017-01-12 22:25:25 -08:00
Victor Stinner
7bfb42d5b7
Issue #28858 : Remove _PyObject_CallArg1() macro
...
Replace
_PyObject_CallArg1(func, arg)
with
PyObject_CallFunctionObjArgs(func, arg, NULL)
Using the _PyObject_CallArg1() macro increases the usage of the C stack, which
was unexpected and unwanted. PyObject_CallFunctionObjArgs() doesn't have this
issue.
2016-12-05 17:04:32 +01:00
Victor Stinner
4778eab1f2
Replace PyObject_CallFunction() with fastcall
...
Replace
PyObject_CallFunction(func, "O", arg)
and
PyObject_CallFunction(func, "O", arg, NULL)
with
_PyObject_CallArg1(func, arg)
Replace
PyObject_CallFunction(func, NULL)
with
_PyObject_CallNoArg(func)
_PyObject_CallNoArg() and _PyObject_CallArg1() are simpler and don't allocate
memory on the C stack.
2016-12-01 14:51:04 +01:00
Serhiy Storchaka
f0b311bd73
Issue #28123 : _PyDict_GetItem_KnownHash() now can raise an exception as
...
PyDict_GetItemWithError(). Patch by Xiang Zhang.
2016-11-06 13:18:24 +02:00
Raymond Hettinger
88057171f0
Revert part of 3471a3515827 that caused a performance regression
2016-09-11 22:45:53 -07:00
Victor Stinner
ad8c83ad6b
Avoid inefficient way to call functions without argument
...
Don't pass "()" format to PyObject_CallXXX() to call a function without
argument: pass NULL as the format string instead. It avoids to have to parse a
string to produce 0 argument.
2016-09-05 17:53:15 -07:00
doko@ubuntu.com
17f0e61891
- Modules/_collectionsmodule.c: Mark one more internal symbol as static.
2016-06-14 07:27:58 +02:00
doko@ubuntu.com
bc7315068f
- make some internal symbols static
2016-05-18 01:06:01 +02:00
Serhiy Storchaka
a0d416f0d1
Issue #26482 : Allowed pickling recursive dequeues.
2016-03-06 08:55:21 +02:00
Raymond Hettinger
d79d5b1a50
More logicial order. Move space saving step to just before it is used.
2016-03-04 09:55:07 -08:00
Raymond Hettinger
6f86a3308a
Factor-out common subexpression.
2016-03-02 00:30:58 -08:00
Raymond Hettinger
589106b206
Put block length computations in a more logical order.
2016-03-02 00:06:21 -08:00
Raymond Hettinger
38418662e0
Issue #26200 : The SETREF macro adds unnecessary work in some cases.
2016-02-08 20:34:49 -08:00
Raymond Hettinger
a63897164e
merge
2016-02-01 21:21:19 -08:00
Raymond Hettinger
0ef0423cb2
merge
2016-01-26 21:46:03 -08:00
Raymond Hettinger
3743432302
Issue #26194 : Fix undefined behavior for deque.insert() when len(d) == maxlen
2016-01-26 21:44:16 -08:00
Raymond Hettinger
306d6b1ea6
Convert another post-decrement while-loop to pre-decrement for consistency
...
and better generated code (on both GCC and CLang).
2016-01-24 12:40:42 -08:00
Raymond Hettinger
165eee214b
Convert two other post-decrement while-loops to pre-decrements for consistency
...
and for better code generation.
2016-01-24 11:32:07 -08:00
Raymond Hettinger
d84ec225bd
Miscellaneous refactorings
...
* Add comment to the maxlen structure entry about the meaning of maxlen == -1
* Factor-out code common to deque_append(left) and deque_extend(left)
* Factor inner-loop in deque_clear() to use only 1 test per loop instead of 2
* Tighten inner-loops for deque_item() and deque_ass_item() so that the
compiler can combine the decrement and test into a single step.
2016-01-24 09:12:06 -08:00
Benjamin Peterson
3e47a1337c
merge 3.5
2016-01-01 11:56:35 -06:00
Benjamin Peterson
4e3dd51396
merge 3.4
2016-01-01 11:56:16 -06:00
Benjamin Peterson
630329e4ea
merge 3.3
2016-01-01 11:55:47 -06:00
Benjamin Peterson
0e617e22f0
remove some copyright notices supserseded by the toplevel ones
2016-01-01 11:53:47 -06:00
Serhiy Storchaka
1ed017ae92
Issue #20440 : Cleaning up the code by using Py_SETREF and Py_CLEAR.
...
Old code is correct, but with Py_SETREF and Py_CLEAR it can be cleaner.
This patch doesn't fix bugs and hence there is no need to backport it.
2015-12-27 15:51:32 +02:00
Serhiy Storchaka
a9406e77fa
Issue #25421 : __sizeof__ methods of builtin types now use dynamic basic size.
...
This allows sys.getsize() to work correctly with their subclasses with
__slots__ defined.
2015-12-19 20:07:11 +02:00
Serhiy Storchaka
5c4064e8bd
Issue #25421 : __sizeof__ methods of builtin types now use dynamic basic size.
...
This allows sys.getsize() to work correctly with their subclasses with
__slots__ defined.
2015-12-19 20:05:25 +02:00
Raymond Hettinger
4a91d21381
Neaten-up the inner-loop logic.
2015-11-03 22:00:26 -05:00
Raymond Hettinger
df8f5b56c9
Minor cleanup.
2015-11-02 07:27:40 -05:00
Raymond Hettinger
0bdf9ea136
merge
2015-11-02 00:04:46 -05:00
Raymond Hettinger
67b97b8f8d
Move the initial start-search out of the main loop so it can be factored-out later.
2015-11-01 23:57:37 -05:00
Martin Panter
e56a919100
Issue #25523 : Merge a-to-an corrections from 3.5
2015-11-02 04:27:17 +00:00
Martin Panter
d2ad5718ad
Issue #25523 : Further a-to-an corrections new in 3.5
2015-11-02 04:20:33 +00:00
Raymond Hettinger
db41fd43cf
Removed unused parameter
2015-10-22 22:48:16 -07:00
Raymond Hettinger
0f43bb160e
Only update the state variable once per iteration.
2015-10-20 00:03:33 -07:00
Raymond Hettinger
20151f50f6
Issue #25414 : Remove unnecessary tests that can never succeed.
2015-10-16 22:47:29 -07:00
Raymond Hettinger
1eca237c2f
Remove old Todo entry that isn't going to happen.
2015-10-15 23:25:53 -07:00
Raymond Hettinger
a4b13d0020
Rewrap comment.
2015-10-15 08:05:31 -07:00
Raymond Hettinger
bc00341105
Use unsigned division
2015-10-14 23:33:23 -07:00
Raymond Hettinger
1286d14500
Improve variable names and constant expressions
2015-10-14 23:16:57 -07:00
Raymond Hettinger
965362e92d
Minor fixup. maxlen is already known.
2015-10-11 22:52:54 -07:00
Raymond Hettinger
d96db09b57
Refactor the deque trim logic to eliminate the two separate trim functions.
2015-10-11 22:34:48 -07:00
Raymond Hettinger
6b1e113f9f
Hoist the deque->maxlen lookup out of the inner-loop.
2015-10-11 09:43:50 -07:00
Raymond Hettinger
a7f63009d6
Minor tweak. Make the maxlen comparisons a little more clear and consistent.
2015-10-10 23:56:02 -04:00
Raymond Hettinger
848f2b595d
Backport early-out 91259f061cfb to reduce the cost of bb1a2944bcb6
2015-10-06 23:06:17 -04:00
Raymond Hettinger
0443ac2860
Eliminate unnecessary test
2015-10-05 22:52:37 -04:00
Raymond Hettinger
fd265f4a18
Factor out common iterator finalization code
2015-10-02 23:17:33 -07:00
Raymond Hettinger
0d30940dd2
Add fast paths to deque_init() for the common cases
2015-09-30 23:15:02 -07:00
Raymond Hettinger
38031143fb
Add an early-out for deque_clear()
2015-09-29 22:45:05 -07:00
Raymond Hettinger
8299e9b59e
Move the copy and clear functions upwards to eliminate unnecessary forward references.
2015-09-26 21:31:23 -07:00
Raymond Hettinger
7c0b70f419
Minor tweak to the order of variable updates.
2015-09-26 21:11:05 -07:00
Raymond Hettinger
f2b02ced7e
Bump up the maximum number of freeblocks
2015-09-26 17:47:02 -07:00
Raymond Hettinger
c22eee6b59
Precomputing the number iterations allows the inner-loop to be vectorizable.
2015-09-26 02:14:50 -07:00
Raymond Hettinger
7a84552c84
Hoist constant expression out of an inner loop.
2015-09-26 01:30:51 -07:00
Raymond Hettinger
e055b88937
merge
2015-09-26 00:15:46 -07:00
Raymond Hettinger
bf49fee125
Issue #25135 : Avoid possible reentrancy issues in deque_clear.
2015-09-26 00:14:59 -07:00
Raymond Hettinger
2b0d646b75
Replace an unpredictable branch with a simple addition.
2015-09-23 19:15:44 -07:00
Raymond Hettinger
3a1a8d0424
Eliminate unnecessary variables
2015-09-23 02:42:02 -07:00
Raymond Hettinger
7a237230d1
Eliminate unnecessary variable
2015-09-22 01:20:36 -07:00
Raymond Hettinger
d3d2b2c50c
Minor consistency improvements to negative value comparisons.
2015-09-21 23:41:56 -07:00
Raymond Hettinger
aed8830af3
Add a fast path (no iterator creation) for a common case for repeating deques of size 1
2015-09-19 09:05:42 -07:00
Raymond Hettinger
0e14e6610b
Hoist constant expression out of an inner loop
2015-09-19 00:21:33 -06:00
Raymond Hettinger
ad26225e1a
Tighten inner-loop for deque_inplace_repeat().
2015-09-14 01:03:04 -04:00
Raymond Hettinger
e4f3467df1
Add an exact type match fast path for deque_copy().
2015-09-13 19:27:01 -04:00
Raymond Hettinger
95e2cc5d12
Fix refcount.
2015-09-13 02:41:18 -04:00
Raymond Hettinger
67c78b5421
In-line the append operations inside deque_inplace_repeat().
2015-09-12 11:00:20 -04:00
Raymond Hettinger
f5d72f35e8
Simply deque repeat by reusing code in in-line repeat. Avoid unnecessary division.
2015-09-09 22:39:44 -04:00
Raymond Hettinger
318c5aef0e
merge
2015-09-05 17:06:18 -07:00
Raymond Hettinger
2b2b75374e
Prevent reentrant badness by deferring the decrefs as long as possible.
2015-09-05 17:05:52 -07:00
Raymond Hettinger
7a1a0bbbf1
merge
2015-08-26 08:09:50 -07:00
Raymond Hettinger
87674ec7d5
Issue #24913 : Fix overrun error in deque.index().
2015-08-26 08:08:38 -07:00