From cb3319f61e94af8794a51f51730dce4a9d512af3 Mon Sep 17 00:00:00 2001 From: Neal Norwitz Date: Sun, 9 Feb 2003 01:10:02 +0000 Subject: [PATCH] SF patch #683187, fix universal newline problems on error --- Objects/fileobject.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Objects/fileobject.c b/Objects/fileobject.c index fb8ec90cfeb..5b2267b417d 100644 --- a/Objects/fileobject.c +++ b/Objects/fileobject.c @@ -2278,7 +2278,7 @@ Py_UniversalNewlineFread(char *buf, size_t n, if (!fobj || !PyFile_Check(fobj)) { errno = ENXIO; /* What can you do... */ - return -1; + return 0; } if (!f->f_univ_newline) return fread(buf, 1, n, stream); @@ -2294,6 +2294,9 @@ Py_UniversalNewlineFread(char *buf, size_t n, nread = fread(dst, 1, n, stream); assert(nread <= n); + if (nread == 0) + break; + n -= nread; /* assuming 1 byte out for each in; will adjust */ shortread = n != 0; /* true iff EOF or error */ while (nread--) {