gh-117865: Defer import of re in ast (#119546)

This is used only by ast.get_source_segment(), so it seems sensible to avoid importing it.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This commit is contained in:
Jelle Zijlstra 2024-05-28 11:04:08 -07:00 committed by GitHub
parent a89fc26f4a
commit ae11d68ab9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions

View File

@ -25,7 +25,6 @@
:license: Python License. :license: Python License.
""" """
import sys import sys
import re
from _ast import * from _ast import *
from contextlib import contextmanager, nullcontext from contextlib import contextmanager, nullcontext
from enum import IntEnum, auto, _simple_enum from enum import IntEnum, auto, _simple_enum
@ -325,12 +324,18 @@ def get_docstring(node, clean=True):
return text return text
_line_pattern = re.compile(r"(.*?(?:\r\n|\n|\r|$))") _line_pattern = None
def _splitlines_no_ff(source, maxlines=None): def _splitlines_no_ff(source, maxlines=None):
"""Split a string into lines ignoring form feed and other chars. """Split a string into lines ignoring form feed and other chars.
This mimics how the Python parser splits source code. This mimics how the Python parser splits source code.
""" """
global _line_pattern
if _line_pattern is None:
# lazily computed to speedup import time of `ast`
import re
_line_pattern = re.compile(r"(.*?(?:\r\n|\n|\r|$))")
lines = [] lines = []
for lineno, match in enumerate(_line_pattern.finditer(source), 1): for lineno, match in enumerate(_line_pattern.finditer(source), 1):
if maxlines is not None and lineno > maxlines: if maxlines is not None and lineno > maxlines:

View File

@ -0,0 +1,2 @@
Improve the import time of the :mod:`ast` module by deferring the import of
:mod:`re`. Patch by Jelle Zijlstra.