mirror of
https://github.com/python/cpython.git
synced 2024-11-24 02:15:30 +08:00
bpo-32517: fix test_read_pty_output() hangs on macOS 10.13.2+ (GH-6037) (GH-6113)
test_asyncio hangs indefinitely on macOS 10.13.2+ on `read_pty_output()`
using the KqueueSelector. Closing `proto.transport` (as is done in
`write_pty_output()`) seems to fix it.
(cherry picked from commit 12f74d8608
)
Co-authored-by: Nathan Henrie <n8henrie@users.noreply.github.com>
Also, re-enable test_read_pty_output on macOS.
This commit is contained in:
parent
30e507dff4
commit
8534d53333
@ -1475,7 +1475,6 @@ class EventLoopTestsMixin:
|
||||
|
||||
@unittest.skipUnless(sys.platform != 'win32',
|
||||
"Don't support pipes for Windows")
|
||||
@unittest.skipIf(sys.platform == 'darwin', 'test hangs on MacOS')
|
||||
def test_read_pty_output(self):
|
||||
proto = MyReadPipeProto(loop=self.loop)
|
||||
|
||||
@ -1502,6 +1501,7 @@ class EventLoopTestsMixin:
|
||||
self.assertEqual(5, proto.nbytes)
|
||||
|
||||
os.close(slave)
|
||||
proto.transport.close()
|
||||
self.loop.run_until_complete(proto.done)
|
||||
self.assertEqual(
|
||||
['INITIAL', 'CONNECTED', 'EOF', 'CLOSED'], proto.state)
|
||||
|
@ -631,6 +631,7 @@ Thomas Heller
|
||||
Malte Helmert
|
||||
Lance Finn Helsten
|
||||
Jonathan Hendry
|
||||
Nathan Henrie
|
||||
Michael Henry
|
||||
James Henstridge
|
||||
Kasun Herath
|
||||
|
@ -0,0 +1,2 @@
|
||||
Fix failing ``test_asyncio`` on macOS 10.12.2+ due to transport of
|
||||
``KqueueSelector`` loop was not being closed.
|
Loading…
Reference in New Issue
Block a user