mirrors/cpython
0
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2024-11-26 03:14:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

gen_iternext(): repair subtle refcount problem.

Browse Source 
NeilS, please check!  This came from staring at your genbug.py, but I'm
not sure it plugs all possible holes.  Without this, I caught a
frameobject refcount going negative, and it was also the cause (in debug
build) of _Py_ForgetReference's attempt to forget an object with already-
NULL _ob_prev and _ob_next pointers -- although I'm still not entirely
sure how!  Part of the difficulty is that frameobjects are stored on a
free list that gets recycled very quickly, so if there's a stray pointer
to one of them it never looks like an insane frameobject (never goes
trough the free() mangling MS debug forces, etc).
This commit is contained in:
Tim Peters 2001-06-20 06:57:32 +00:00
parent 43afb24c30
commit 6302ec63fc
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Python/ceval.c
View File

@ -152,6 +152,11 @@ gen_iternext(genobject *gen)
gen->running = 1; gen->running = 1;
result = eval_frame(f); result = eval_frame(f);
gen->running = 0; gen->running = 0;
/* The connection between this frame and its parent is over now, so
must NULL out f_back lest it get decref'ed when gen dies (note
that eval_frame sets f->f_back without bumping its refcount: we
never had a fully legit reference to it). */
f->f_back = NULL;
return result; return result;
} }