From 4e6bf41934de08f62b22b90cda2e331eb4641dea Mon Sep 17 00:00:00 2001
From: Raymond Hettinger <python@rcn.com>
Date: Sat, 5 Nov 2011 13:35:26 -0700
Subject: [PATCH] Improve Counter.__repr__() to not fail with unorderable
 values

---
 Lib/collections.py           | 8 ++++++--
 Lib/test/test_collections.py | 6 ++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/Lib/collections.py b/Lib/collections.py
index 2b6abd879fc..d2625fe03e3 100644
--- a/Lib/collections.py
+++ b/Lib/collections.py
@@ -583,8 +583,12 @@ class Counter(dict):
     def __repr__(self):
         if not self:
             return '%s()' % self.__class__.__name__
-        items = ', '.join(map('%r: %r'.__mod__, self.most_common()))
-        return '%s({%s})' % (self.__class__.__name__, items)
+        try:
+            items = ', '.join(map('%r: %r'.__mod__, self.most_common()))
+            return '%s({%s})' % (self.__class__.__name__, items)
+        except TypeError:
+            # handle case where values are not orderable
+            return '{0}({1!r})'.format(self.__class__.__name__, dict(self))
 
     # Multiset-style mathematical operations discussed in:
     #       Knuth TAOCP Volume II section 4.6.3 exercise 19
diff --git a/Lib/test/test_collections.py b/Lib/test/test_collections.py
index ccf93c51c17..8dc5559cae3 100644
--- a/Lib/test/test_collections.py
+++ b/Lib/test/test_collections.py
@@ -893,6 +893,12 @@ class TestCounter(unittest.TestCase):
         c.subtract('aaaabbcce')
         self.assertEqual(c, Counter(a=-1, b=0, c=-1, d=1, e=-1))
 
+    def test_repr_nonsortable(self):
+        c = Counter(a=2, b=None)
+        r = repr(c)
+        self.assertIn("'a': 2", r)
+        self.assertIn("'b': None", r)
+
     def test_helper_function(self):
         # two paths, one for real dicts and one for other mappings
         elems = list('abracadabra')