mirrors/cpython
0
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2024-11-25 19:03:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

The bufsize argument to Popen() should accept None meaning the default (0).

Browse Source
This commit is contained in:
Guido van Rossum 2007-06-07 21:56:45 +00:00
parent ad5b9de288
commit 46a05a7db5
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/subprocess.py
View File

@ -465,6 +465,8 @@ class Popen(object):
_cleanup()
self._child_created = False
if bufsize is None:
bufsize = 0 # Restore default
if not isinstance(bufsize, int):
raise TypeError("bufsize must be an integer")

8
Lib/test/test_subprocess.py
View File

@ -455,6 +455,14 @@ class ProcessTestCase(unittest.TestCase):
else:
self.fail("Expected TypeError")
def test_bufsize_is_none(self):
# bufsize=None should be the same as bufsize=0.
p = subprocess.Popen([sys.executable, "-c", "pass"], None)
self.assertEqual(p.wait(), 0)
# Again with keyword arg
p = subprocess.Popen([sys.executable, "-c", "pass"], bufsize=None)
self.assertEqual(p.wait(), 0)
#
# POSIX tests
#