#5548: do return the new module from PyMODINIT_FUNC functions.

This commit is contained in:
Georg Brandl 2009-03-31 15:52:41 +00:00
parent 5081f7e976
commit 21151760d9
2 changed files with 5 additions and 3 deletions

View File

@ -1266,12 +1266,13 @@ All that a client module must do in order to have access to the function
{
PyObject *m;
m = Py_InitModule("client", ClientMethods);
m = PyModule_Create(&clientmodule);
if (m == NULL)
return;
return NULL;
if (import_spam() < 0)
return;
return NULL;
/* additional initialization can happen here */
return m;
}
The main disadvantage of this approach is that the file :file:`spammodule.h` is

View File

@ -871,6 +871,7 @@ the module's :cfunc:`init` function. ::
Py_INCREF(&ShoddyType);
PyModule_AddObject(m, "Shoddy", (PyObject *) &ShoddyType);
return m;
}
Before calling :cfunc:`PyType_Ready`, the type structure must have the