mirrors/cpython
0
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2024-11-25 19:03:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

SF bug 924242: socket._fileobject._getclosed() returns wrong value

Browse Source 
The .closed property always returned the wrong result.

Bugfix candidate!
This commit is contained in:
Tim Peters 2004-03-28 02:20:45 +00:00
parent 165163f245
commit 116d83ce71
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/socket.py
View File

@ -217,7 +217,7 @@ class _fileobject(object):
self._wbuf = [] # A list of strings
def _getclosed(self):
return self._sock is not None
return self._sock is None
closed = property(_getclosed, doc="True if the file is closed")
def close(self):

8
Lib/test/test_socket.py
View File

@ -590,6 +590,7 @@ class FileObjectClassTestCase(SocketConnectedTest):
def tearDown(self):
self.serv_file.close()
self.assert_(self.serv_file.closed)
self.serv_file = None
SocketConnectedTest.tearDown(self)
@ -599,6 +600,7 @@ class FileObjectClassTestCase(SocketConnectedTest):
def clientTearDown(self):
self.cli_file.close()
self.assert_(self.cli_file.closed)
self.cli_file = None
SocketConnectedTest.clientTearDown(self)
@ -645,6 +647,12 @@ class FileObjectClassTestCase(SocketConnectedTest):
self.cli_file.write(MSG)
self.cli_file.flush()
def testClosedAttr(self):
self.assert_(not self.serv_file.closed)
def _testClosedAttr(self):
self.assert_(not self.cli_file.closed)
class UnbufferedFileObjectClassTestCase(FileObjectClassTestCase):
"""Repeat the tests from FileObjectClassTestCase with bufsize==0.