From 098f6943c041f3d6ac42f1eb9b178df3bf43a383 Mon Sep 17 00:00:00 2001 From: Thomas Wouters Date: Tue, 7 Mar 2006 14:13:17 +0000 Subject: [PATCH] Coverity found bug: test result of PyTuple_New() against NULL before use. Will backport. --- Modules/_bsddb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Modules/_bsddb.c b/Modules/_bsddb.c index 8f8eab24c34..f938ff044cb 100644 --- a/Modules/_bsddb.c +++ b/Modules/_bsddb.c @@ -1084,12 +1084,12 @@ _db_associateCallback(DB* db, const DBT* priKey, const DBT* priData, } data = PyString_FromStringAndSize(priData->data, priData->size); args = PyTuple_New(2); - PyTuple_SET_ITEM(args, 0, key); /* steals reference */ - PyTuple_SET_ITEM(args, 1, data); /* steals reference */ - - result = PyEval_CallObject(callback, args); - - if (result == NULL) { + if (args != NULL) { + PyTuple_SET_ITEM(args, 0, key); /* steals reference */ + PyTuple_SET_ITEM(args, 1, data); /* steals reference */ + result = PyEval_CallObject(callback, args); + } + if (args == NULL || result == NULL) { PyErr_Print(); } else if (result == Py_None) {