mirrors/coreutils
0
0
Fork 0
mirror of https://github.com/coreutils/coreutils.git synced 2024-11-24 18:33:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

dd: warn when we disable oflag=direct not at EOF

Browse Source 
An alternative to this is to auto enable iflag=fullblock
when oflag=direct and bs= is specified.
It was thought better though, to warn about the specific issue,
and give full control of dd's options to the user.

* src/dd.c (iwrite): Warn, when we write after having
disabled O_DIRECT.
See https://bugzilla.redhat.com/show_bug.cgi?id=614605
This commit is contained in:
Pádraig Brady 2011-02-25 12:27:25 +00:00
parent caaf2899f6
commit e1788d9ed9
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dd.c
View File

@ -837,6 +837,12 @@ iwrite (int fd, char const *buf, size_t size)
{
size_t total_written = 0;
if ((output_flags & O_DIRECT) && w_partial == 1)
{
error (0, 0, _("dd: warning: partial read; oflag=direct disabled; "
"suggest iflag=fullblock"));
}
if ((output_flags & O_DIRECT) && size < output_blocksize)
{
int old_flags = fcntl (STDOUT_FILENO, F_GETFL);