Commit Graph

25 Commits

Author SHA1 Message Date
Joshua Watt
35dd3cf94f Update .gitignore
Updates the .gitignore file to ignore many build artifacts
2019-07-03 21:26:49 +02:00
Mark Wielaard
f319b98aad Prepare for 1.0.7 release. 2019-06-27 20:10:07 +02:00
Mark Wielaard
f1e937776c Add prepare-release.sh script.
Script to run to prepare a new release.
It will update the release number and tell you to update the
CHANGES file and to double check everything looks before doing
the release commit and tagging.

Afterwards you probably want to run release-update.sh to upload
the release and update the website at https://sourceware.org/bzip2/

There are embedded version strings and dates in a couple of places.
To keep the script simple remove some that aren't absolutely necessary.

README now just points to CHANGES.
README.COMPILATION.PROBLEMS only mentions the version once at the top.
bzip2.c only mentions the version once when doing --version.
manual.xml now doesn't have any embedded versions, just uses &bz-version;
everywhere.
2019-06-25 19:30:27 +02:00
Federico Mena Quintero
ff98685015 Change a magic number (6) for a constant (BZ_N_GROUPS).
decompress.c (BZ2_decompress): Check nGroups against BZ_N_GROUPS.
2019-06-24 15:41:58 +02:00
Albert Astals Cid
7ed62bfb46 Make sure nSelectors is not out of range
nSelectors is used in a loop from 0 to nSelectors to access selectorMtf
which is
	UChar    selectorMtf[BZ_MAX_SELECTORS];
so if nSelectors is bigger than BZ_MAX_SELECTORS it'll do an invalid memory
access

Fixes out of bounds access discovered while fuzzying karchive

This was reported as CVE-2019-12900
BZ2_decompress in decompress.c in bzip2 through 1.0.6 has an
out-of-bounds write when there are many selectors.
2019-06-24 15:34:05 +02:00
Paul Kehrer
16f2c753f9 Fix undefined behavior in the macros SET_BH, CLEAR_BH, & ISSET_BH
These macros contain this pattern:
1 << ((Int32_value) & 31

This causes the undefined behavior sanitizers in clang and gcc to
complain because the shift, while ultimately stored to an unsigned
variable, is done as a signed value. Adding a cast to unsigned for
the int32 value resolves this issue.
2019-06-24 15:24:21 +02:00
Mark Wielaard
f51f164df0 bzip2: Fix return value when combining --test,-t and -q.
When passing -q to get quiet output --test would not display an error
message, but would also suppress the exit 2 code to indicate the file
was corrupt. Only suppress the error message with -q, not the exit value.

This patch comes from Debian.
"bunzip2 -qt returns 0 for corrupt archives"
https://bugs.debian.org/279025
2019-06-24 09:31:16 +02:00
Mark Wielaard
c1cdd98db3 bzip2recover: Fix use after free issue with outFile.
bzip2recover.c (main): Make sure to set outFile to NULL when done.

This was reported as CVE-2016-3189 and found in multiple distributions.
https://seclists.org/oss-sec/2016/q2/568

Some more analysis can be found in:
https://bugzilla.redhat.com/show_bug.cgi?id=1319648
2019-06-24 00:58:47 +02:00
Mark Wielaard
833548edc0 bzip2recover: Fix buffer overflow for large argv[0].
bzip2recover.c (main) copies argv[0] to a statically sized buffer
without checking whether argv[0] might be too big (> 2000 chars).

This patch comes from Fedora and was originally reported at
https://bugzilla.redhat.com/show_bug.cgi?id=226979
2019-06-24 00:14:06 +02:00
Mark Wielaard
02fe3ca234 bzip2.c (testStream): Remove set, but not used nread variable.
Modern GCC warns:

bzip2.c: In function ‘testStream’:
bzip2.c:557:37: warning: variable ‘nread’ set but not used
[-Wunused-but-set-variable]
    Int32   bzerr, bzerr_dummy, ret, nread, streamNo, i;
                                     ^~~~~

GCC is correct. In testStream we don't care about the number of bytes
read by BZ2_bzRead. So just remove the variable and the assignment.
2019-06-23 23:52:03 +02:00
Mark Wielaard
32db5b677a Add release-update.sh script.
Script to run after a release has been tagged, signed and pushed
to git.  Will do a fresh checkout, verify the git tag, do fresh
build/dist, sign the dist with gpg, create a backup copy in HOME,
upload the tar.gz and sig to sourceware, checkout bzip2-htdocs,
copy over the new changes, manual, etc. and git push that to update
https://sourceware.org/bzip2/
2019-06-23 22:18:58 +02:00
Mark Wielaard
ac9b384740 Use UTF-8 encoding and include bzip.css as link for HTML manual. 2019-06-23 02:14:23 +02:00
Mark Wielaard
ddd8bae9d5 Adjust bzip.css images to new https://sourceware.org/bzip2/ location. 2019-06-23 00:47:20 +02:00
Mark Wielaard
032a25eee8 Change all bzip.org URLs to sourceware.org/bzip2 2019-03-30 22:56:16 +01:00
Mark Wielaard
5b923861db Change Julian's email address to jseward@acm.org 2019-03-30 22:56:16 +01:00
Julian Seward
962d60610c bzip2-1.0.6 2010-09-06 22:13:13 +02:00
Julian Seward
a1d78c5501 bzip2-1.0.5 2007-12-10 22:13:13 +01:00
Julian Seward
f10a33538e bzip2-1.0.4 2006-12-20 22:13:13 +01:00
Julian Seward
4d540bfc95 bzip2-1.0.3 2005-02-15 22:13:13 +01:00
Julian Seward
099d844292 bzip2-1.0.2 2001-12-30 22:13:13 +01:00
Julian Seward
795b859eee bzip2-1.0.1 2000-06-24 22:13:13 +02:00
Julian Seward
f93cd82a9a bzip2-0.9.5d 1999-09-04 22:13:13 +02:00
Julian Seward
977101ad5f bzip2-0.9.0c 1998-08-23 22:13:13 +02:00
Julian Seward
1eb67a9d8f bzip2-0.1pl2 1997-08-29 22:13:13 +02:00
Julian Seward
33d1340302 bzip2-0.1 1997-08-07 22:13:13 +02:00