mirror of
https://git.busybox.net/busybox.git
synced 2024-12-03 18:43:26 +08:00
ca96022d6e
The memcpy invocations in the subCommand function, modified by this commit, previously used memcpy with overlapping memory regions. This is undefined behavior. On Alpine Linux, it causes BusyBox ed to crash since we compile BusyBox with -D_FORTIFY_SOURCE=2 and our fortify-headers implementation catches this source of undefined behavior [0]. The issue can only be triggered if the replacement string is the same size or shorter than the old string. Looking at the code, it seems to me that a memmove(3) is what was actually intended here, this commit modifies the code accordingly. [0]: https://gitlab.alpinelinux.org/alpine/aports/-/issues/13504 Signed-off-by: Sören Tempel <soeren+git@soeren-tempel.net> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> |
||
|---|---|---|
| .. | ||
| awk.c | ||
| cmp.c | ||
| Config.src | ||
| diff.c | ||
| ed.c | ||
| Kbuild.src | ||
| patch_bbox.c | ||
| patch_toybox.c | ||
| patch.c | ||
| sed1line.txt | ||
| sed_summary.htm | ||
| sed.c | ||
| vi.c | ||