buildroot/boot
Julien Olivain 44af6938fb boot/edk2: unset MAKEFLAGS in build environment
Yann reported in [1] that edk2 build could sometimes fail. The issue
can be reproduced when per-package directories is enabled, or also
when building on a system with GNU Make >= 4.4 using the
"--shuffle=reverse" option (such as Fedora 39). Those are pointing
toward a Makefile dependency issue.

The issue can be reproduced with commands:

    cat > .config <<EOF
    BR2_riscv=y
    BR2_RISCV_64=y
    BR2_TOOLCHAIN_EXTERNAL=y
    BR2_TARGET_EDK2=y
    EOF
    make olddefconfig

Then, building either with:

    make --shuffle=reverse

Or:

    utils/config -e BR2_PER_PACKAGE_DIRECTORIES
    make olddefconfig
    make -j$(nproc)

It is interesting to mention that when using "make --shuffle=reverse"
to build, the build can be completed if restarted only with "make". It
will not pull any other Buildroot package. This fact hints toward a
Makefile dependency issue internal to the EDK2 build system, rather
than in the Buildroot recipe.

The EDK2 build system is quite unique. See [2]. It generates files,
makefiles and internally uses GNU Make to compile code. This system is
likely not tested as being a sub-Make process in a complex Makefile
such as Buildroot.

In order to prevent Buildroot to pass unexpected Make flags to the
EDK2 sub-Make, this commit unset the MAKEFLAGS variable in the EDK2
build environment. This will put the EDK2 build script in a more
common and tested state. See GNU Make documentation about recursive use
of Make, more specifically [3].

Note: as mentioned, the build failure is likely due to an internal
issue of the EDK2 build system. The failure points to a missing
dependency in the EDK2 generator itself. This commit does not fix this
issue, but rather put the EDK2 build system in a normalized
environment, avoiding Buildroot flags being passed to the internal
EDK2 sub-Make invocation. The upstream EDK2 build system most likely
need a fix too.

Fixes:

    make[2]: *** No rule to make target '/buildroot/output/build/edk2-edk2-stable202308/Build/RiscVVirtQemu/RELEASE_GCC5/RISCV64/MdeModulePkg/Application/UiApp/UiApp/DEBUG/UiApp.efi', needed by '/buildroot/output/build/edk2-edk2-stable202308/Build/RiscVVirtQemu/RELEASE_GCC5/FV/Ffs/462CAA21-7614-4503-836E-8AB6F4662331UiApp/UiApp.offset'.  Stop.

    build.py...
     : error 7000: Failed to execute command
	    make tbuild [/buildroot/output/build/edk2-edk2-stable202308/Build/RiscVVirtQemu/RELEASE_GCC5/RISCV64/MdeModulePkg/Application/UiApp/UiApp]

    build.py...
     : error F002: Failed to build module
	    /buildroot/output/build/edk2-edk2-stable202308/MdeModulePkg/Application/UiApp/UiApp.inf [RISCV64, GCC5, RELEASE]

[1] https://lists.buildroot.org/pipermail/buildroot/2023-December/681507.html
[2] https://tianocore-docs.github.io/edk2-BuildSpecification/draft/4_edk_ii_build_process_overview/42_build_process_overview.html
[3] https://www.gnu.org/software/make/manual/make.html#Options_002fRecursion

Reported-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Julien Olivain <ju.o@free.fr>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
2024-01-01 22:23:59 +01:00
..
afboot-stm32 boot/afboot-stm32: disable stack-protector 2023-02-08 16:54:35 +01:00
arm-trusted-firmware boot/arm-trusted-firmware: fix the RPATH of fiptool 2023-12-08 22:24:18 +01:00
at91bootstrap boot/at91bootstrap: disable PIE and stack-protector build flags 2023-10-01 11:02:03 +02:00
at91bootstrap3 boot/at91bootstrap3: add svn repository method 2021-12-30 17:36:45 +01:00
at91dataflashboot boot/at91dataflashboot: force arm mode instead of Thumb mode 2023-08-06 14:12:34 +02:00
barebox boot/barebox: add optional dependencies on host-openssl and host-libusb 2023-07-28 22:40:39 +02:00
beaglev-ddrinit package/beaglev-ddrinit: update to latest 8d6318 2022-07-25 22:52:20 +02:00
beaglev-secondboot package/beaglev-secondboot: bump to version e17302 2022-07-26 00:11:13 +02:00
binaries-marvell boot, package, support, toolchain: switch to 2 spaces for the hash file 2022-07-28 23:05:23 +02:00
boot-wrapper-aarch64 boot/boot-wrapper-aarch64: bump version 2023-02-23 23:43:32 +01:00
edk2 boot/edk2: unset MAKEFLAGS in build environment 2024-01-01 22:23:59 +01:00
grub2 boot/grub2: add RISC-V 64bit EFI support 2023-12-24 17:55:23 +01:00
mv-ddr-marvell boot/mv-ddr-marvell: fix build with gcc 12 2023-08-12 16:23:21 +02:00
mxs-bootlets boot/mxs-bootlets: fix build without any bootstream 2023-02-27 17:03:15 +01:00
opensbi boot/opensbi: Bump to version 1.3 2023-06-26 19:02:49 +02:00
optee-os boot/optee-os: bump to version 4.0.0 2023-11-01 11:32:58 +01:00
s500-bootloader boot, package, support, toolchain: switch to 2 spaces for the hash file 2022-07-28 23:05:23 +02:00
shim boot, package, support, toolchain: switch to 2 spaces for the hash file 2022-07-28 23:05:23 +02:00
syslinux package/syslinux: disable documentation 2022-08-14 22:42:50 +02:00
ti-k3-boot-firmware boot/ti-k3-boot-firmware: new package 2023-08-22 11:53:55 +02:00
ti-k3-image-gen boot/ti-k3-image-gen: new package 2023-08-22 12:01:08 +02:00
ti-k3-r5-loader boot/ti-k3-r5-loader: allow for full build source customization 2023-08-22 11:53:54 +02:00
uboot boot/uboot: add support for building the TI K3 DM into U-Boot 2023-08-22 12:01:38 +02:00
vexpress-firmware support/download: change format of archives generated from git 2021-01-10 22:06:58 +01:00
common.mk Fix build reproducibility in Make 3.82 2013-09-06 23:27:42 +02:00
Config.in boot/ti-k3-image-gen: new package 2023-08-22 12:01:08 +02:00