mirror of
https://git.busybox.net/buildroot.git
synced 2024-12-12 06:43:43 +08:00
d721c95b8b
A recent update of flake8 in CI introduced a new check E741. It basically checks that variables are at least 3 characters long. Up to now, however, we have used shorter names in some places - all of them turn out to be "l" for a line of text. Replace all those "l" variables with "line". Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1687009829 partially: support/scripts/boot-qemu-image.py:47:21: E741 ambiguous variable name 'l' support/scripts/check-dotconfig.py:20:38: E741 ambiguous variable name 'l' support/scripts/size-stats:76:13: E741 ambiguous variable name 'l' support/testing/tests/core/test_bad_arch.py:17:32: E741 ambiguous variable name 'l' support/testing/tests/package/test_python_treq.py:10:30: E741 ambiguous variable name 'l' support/testing/tests/toolchain/test_external.py:30:42: E741 ambiguous variable name 'l' Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
43 lines
1.2 KiB
Python
Executable File
43 lines
1.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
# This scripts check that all lines present in the defconfig are
|
|
# still present in the .config
|
|
|
|
import sys
|
|
|
|
|
|
def main():
|
|
if not (len(sys.argv) == 3):
|
|
print("Error: incorrect number of arguments")
|
|
print("""Usage: check-dotconfig <configfile> <defconfig>""")
|
|
sys.exit(1)
|
|
|
|
configfile = sys.argv[1]
|
|
defconfig = sys.argv[2]
|
|
|
|
# strip() to get rid of trailing \n
|
|
with open(configfile) as configf:
|
|
configlines = [line.strip() for line in configf.readlines()]
|
|
|
|
defconfiglines = []
|
|
with open(defconfig) as defconfigf:
|
|
# strip() to get rid of trailing \n
|
|
for line in (line.strip() for line in defconfigf.readlines()):
|
|
if line.startswith("BR2_"):
|
|
defconfiglines.append(line)
|
|
elif line.startswith('# BR2_') and line.endswith(' is not set'):
|
|
defconfiglines.append(line)
|
|
|
|
# Check that all the defconfig lines are still present
|
|
missing = [line for line in defconfiglines if line not in configlines]
|
|
|
|
if missing:
|
|
print("WARN: defconfig {} can't be used:".format(defconfig))
|
|
for m in missing:
|
|
print(" Missing: {}".format(m))
|
|
sys.exit(1)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|