mirror of
https://git.busybox.net/buildroot.git
synced 2024-12-04 02:43:30 +08:00
ce7363524c
sortGrid()'s handling of git hashes and other large hex numbers has been inconsistent, they can be detected as strings or numbers depending on what type of character they start with. This patch fixes the behaviour by using a regex to capture everything that looks like a big hex number and treat it as a string. This means when you sort by current version ascending all the version strings with big hex numbers should show up first, sorted 0-9,a-f. First we check for a string length >= 39, and then apply a regex to return an array with every char from that string that matched the regex. If the length of this array is still >= 39 we can assume we are looking at something containing a git hash. The reason why the length is defined as ">= 39" and not "40" or "39 or 40" is twofold: Firstly, 39 was chosen as a minimum to match stuff with 39 char git hashes, like the rockchip-mali package. Secondly, there is no max because we actually want to catch not just explicitly git hashes, but any verson string with big gnarly hex numbers in it. Stuff like: "1.4.2-168-ged3039cdbeeb28fc0011c3585d8f7dfb91038292" Why? Well, the idea is less about git hashes and sorting and more about grouping similarly formatted version strings. It would be impossble (or at least annoyingly complicated) and of dubious utility to get a real sequential sort out of the current version column, so the attempt here is to at the very least collect all the similarly formatted things together. This isn't perfect, but it's a (arguably) more useful sorted output than before. A demo is available here: https://sen-h.codeberg.page/pkg-stats-demos/@pages/fix-improve-git-hash-sorting.html Signed-off-by: Sen Hastings <sen@hastings.org> Signed-off-by: Arnout Vandecappelle <arnout@mind.be> |
||
|---|---|---|
| .. | ||
| apply-patches.sh | ||
| boot-qemu-image.py | ||
| br2-external | ||
| brpkgutil.py | ||
| check-bin-arch | ||
| check-dotconfig.py | ||
| check-host-rpath | ||
| check-kernel-headers.sh | ||
| check-merged-usr.sh | ||
| cve.py | ||
| expunge-gconv-modules | ||
| fix-configure-powerpc64.sh | ||
| fix-rpath | ||
| gen-bootlin-toolchains | ||
| generate-gitlab-ci-yml | ||
| genimage.sh | ||
| graph-build-time | ||
| graph-depends | ||
| hardlink-or-copy | ||
| mkmakefile | ||
| mkusers | ||
| pkg-stats | ||
| pyinstaller.py | ||
| setlocalversion | ||
| size-stats | ||