mirror of
https://git.busybox.net/buildroot.git
synced 2024-12-19 02:03:41 +08:00
97703978ac
After switching TARGET_LDFLAGS from --static to -static, one issue appears: from the point of view of libtool, -static only means to link statically against the 'uninstalled libtool libraries' (i.e the libraries that libtool has built in the current package), but otherwise links dynamically with the other libraries. To really get a completely static build, you need to pass -all-static to libtool. Unfortunately, -all-static is only a valid option for libtool, not as a general LDFLAGS, so we cannot to TARGET_LDFLAGS = -all-static without breaking virtually all packages. As pointed out 10 years ago on the libtool mailing list, the current naming of the options is very confusing and the source of issues, and there was a proposal to change -static to have the behavior of -all-static, and instead introduce a separate -lt-static to have the current behavior of -static. But that never got merged, because it was breaking the current behavior. See: http://lists.gnu.org/archive/html/libtool/2004-11/msg00017.html However, in Buildroot, when we pass -static, we really mean it, and we want a completely static build. Therefore, this patch adapts our ltmain.sh patches so that they alter the behavior of -static to make it work like -all-static. The changes are small and quite easy to understand, and have been tested to work fine with a small selection of packages. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
90 lines
3.1 KiB
Diff
90 lines
3.1 KiB
Diff
--- a/ltmain.sh 2014-07-30 22:21:24.664684143 +0200
|
|
+++ b/ltmain.sh 2014-07-30 22:23:02.440687625 +0200
|
|
@@ -1417,8 +1417,8 @@
|
|
# was found and let the user know that the "--tag" command
|
|
# line option must be used.
|
|
if test -z "$tagname"; then
|
|
- func_echo "unable to infer tagged configuration"
|
|
- func_fatal_error "specify a tag with \`--tag'"
|
|
+ func_echo "defaulting to \`CC'"
|
|
+ func_echo "if this is not correct, specify a tag with \`--tag'"
|
|
# else
|
|
# func_verbose "using $tagname tagged configuration"
|
|
fi
|
|
@@ -2963,8 +2963,11 @@
|
|
# At present, this check doesn't affect windows .dll's that
|
|
# are installed into $libdir/../bin (currently, that works fine)
|
|
# but it's something to keep an eye on.
|
|
- test "$inst_prefix_dir" = "$destdir" && \
|
|
- func_fatal_error "error: cannot install \`$file' to a directory not ending in $libdir"
|
|
+ #
|
|
+ # This breaks install into our staging area. -PB
|
|
+ #
|
|
+ # test "$inst_prefix_dir" = "$destdir" && \
|
|
+ # func_fatal_error "error: cannot install \`$file' to a directory not ending in $libdir"
|
|
|
|
if test -n "$inst_prefix_dir"; then
|
|
# Stick the inst_prefix_dir data into the link command.
|
|
@@ -5176,7 +5179,8 @@
|
|
;;
|
|
-all-static | -static | -static-libtool-libs)
|
|
case $arg in
|
|
- -all-static)
|
|
+ # Make -static behave like -all-static
|
|
+ -all-static | -static)
|
|
if test "$build_libtool_libs" = yes && test -z "$link_static_flag"; then
|
|
func_warning "complete static linking is impossible in this configuration"
|
|
fi
|
|
@@ -5185,12 +5189,6 @@
|
|
fi
|
|
prefer_static_libs=yes
|
|
;;
|
|
- -static)
|
|
- if test -z "$pic_flag" && test -n "$link_static_flag"; then
|
|
- dlopen_self=$dlopen_self_static
|
|
- fi
|
|
- prefer_static_libs=built
|
|
- ;;
|
|
-static-libtool-libs)
|
|
if test -z "$pic_flag" && test -n "$link_static_flag"; then
|
|
dlopen_self=$dlopen_self_static
|
|
@@ -5473,7 +5471,8 @@
|
|
prevarg="$arg"
|
|
|
|
case $arg in
|
|
- -all-static)
|
|
+ # Make -static behave like -all-static
|
|
+ -all-static | -static)
|
|
if test -n "$link_static_flag"; then
|
|
# See comment for -static flag below, for more details.
|
|
func_append compile_command " $link_static_flag"
|
|
@@ -5754,7 +5753,7 @@
|
|
continue
|
|
;;
|
|
|
|
- -static | -static-libtool-libs)
|
|
+ -static-libtool-libs)
|
|
# The effects of -static are defined in a previous loop.
|
|
# We used to do the same as -all-static on platforms that
|
|
# didn't have a PIC flag, but the assumption that the effects
|
|
@@ -6697,7 +6696,7 @@
|
|
*)
|
|
if test "$installed" = no; then
|
|
func_append notinst_deplibs " $lib"
|
|
- need_relink=yes
|
|
+ need_relink=no
|
|
fi
|
|
;;
|
|
esac
|
|
@@ -9275,6 +9274,10 @@
|
|
# Replace all uninstalled libtool libraries with the installed ones
|
|
newdependency_libs=
|
|
for deplib in $dependency_libs; do
|
|
+ # Replacing uninstalled with installed can easily break crosscompilation,
|
|
+ # since the installed path is generally the wrong architecture. -CL
|
|
+ newdependency_libs="$newdependency_libs $deplib"
|
|
+ continue
|
|
case $deplib in
|
|
*.la)
|
|
func_basename "$deplib"
|