mirror of
https://git.busybox.net/buildroot.git
synced 2024-12-01 01:13:29 +08:00
54456cc698
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
82 lines
3.0 KiB
Makefile
82 lines
3.0 KiB
Makefile
################################################################################
|
|
# LuaRocks package infrastructure
|
|
# see http://luarocks.org/
|
|
#
|
|
# This file implements an infrastructure that eases development of
|
|
# package .mk files for LuaRocks packages.
|
|
# LuaRocks supports various build.type : builtin, make, cmake.
|
|
# This luarocks infrastructure supports only the builtin mode,
|
|
# the make & cmake modes could be directly handled by generic & cmake infrastructure.
|
|
#
|
|
# See the Buildroot documentation for details on the usage of this
|
|
# infrastructure
|
|
#
|
|
# In terms of implementation, this LuaRocks infrastructure requires
|
|
# the .mk file to only specify metadata informations about the
|
|
# package: name, version, etc.
|
|
#
|
|
################################################################################
|
|
|
|
################################################################################
|
|
# inner-luarocks-package -- defines how the configuration, compilation and
|
|
# installation of a LuaRocks package should be done, implements a few hooks to
|
|
# tune the build process and calls the generic package infrastructure to
|
|
# generate the necessary make targets
|
|
#
|
|
# argument 1 is the lowercase package name
|
|
# argument 2 is the uppercase package name, including an HOST_ prefix
|
|
# for host packages
|
|
# argument 3 is the uppercase package name, without the HOST_ prefix
|
|
# for host packages
|
|
# argument 4 is the type (target or host)
|
|
################################################################################
|
|
|
|
define inner-luarocks-package
|
|
|
|
$(2)_BUILD_OPT ?=
|
|
$(2)_SUBDIR ?= $(1)-$$(shell echo "$$($(3)_VERSION)" | sed -e "s/-[0-9]$$$$//")
|
|
$(2)_ROCKSPEC ?= $(1)-$$($(3)_VERSION).rockspec
|
|
$(2)_SOURCE ?= $(1)-$$($(3)_VERSION).src.rock
|
|
$(2)_SITE ?= $$(call qstrip,$$(BR2_LUAROCKS_MIRROR))
|
|
|
|
# Since we do not support host-luarocks-package, we know this is
|
|
# a target package, and can just add the required dependencies
|
|
$(2)_DEPENDENCIES += host-luarocks luainterpreter
|
|
|
|
#
|
|
# Extract step
|
|
#
|
|
ifndef $(2)_EXTRACT_CMDS
|
|
define $(2)_EXTRACT_CMDS
|
|
cd $$($(2)_DIR)/.. && \
|
|
$$(LUAROCKS_RUN) unpack --force $$(DL_DIR)/$$($(2)_SOURCE)
|
|
endef
|
|
endif
|
|
|
|
#
|
|
# Build/install step.
|
|
#
|
|
ifndef $(2)_INSTALL_TARGET_CMDS
|
|
define $(2)_INSTALL_TARGET_CMDS
|
|
cd $$($(2)_SRCDIR) && \
|
|
$$(LUAROCKS_RUN) make --deps-mode=none --keep $$($(2)_ROCKSPEC) $$($(2)_BUILD_OPT)
|
|
endef
|
|
endif
|
|
|
|
# Call the generic package infrastructure to generate the necessary
|
|
# make targets
|
|
$(call inner-generic-package,$(1),$(2),$(3),$(4))
|
|
|
|
# $(2)_DEPENDENCIES are handled for configure step (too late)
|
|
# but host-luarocks is required to do the extract
|
|
$$($(2)_TARGET_EXTRACT): | host-luarocks
|
|
|
|
endef
|
|
|
|
################################################################################
|
|
# luarocks-package -- the target generator macro for LuaRocks packages
|
|
################################################################################
|
|
|
|
luarocks-package = $(call inner-luarocks-package,$(pkgname),$(call UPPERCASE,$(pkgname)),$(call UPPERCASE,$(pkgname)),target)
|
|
# host-luarocks-package not supported
|