mirror of
https://git.busybox.net/buildroot.git
synced 2024-11-23 13:33:28 +08:00
7d74283309
libcgroup up to and including 0.41 creates /var/log/cgred with mode 0666 regardless of the configured umask, leading to disclosure of information Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
34 lines
1.2 KiB
Diff
34 lines
1.2 KiB
Diff
From 0d88b73d189ea3440ccaab00418d6469f76fa590 Mon Sep 17 00:00:00 2001
|
|
From: Michal Hocko <mhocko@suse.com>
|
|
Date: Wed, 18 Jul 2018 11:24:29 +0200
|
|
Subject: [PATCH] cgrulesengd: remove umask(0)
|
|
|
|
One of our partners has noticed that cgred daemon is creating a log file
|
|
(/var/log/cgred) with too wide permissions (0666) and that is seen as
|
|
a security bug because an untrusted user can write to otherwise
|
|
restricted area. CVE-2018-14348 has been assigned to this issue.
|
|
|
|
Signed-off-by: Michal Hocko <mhocko@suse.com>
|
|
Acked-by: Balbir Singh <bsingharora@gmail.com>
|
|
[Retrieved from:
|
|
https://github.com/libcgroup/libcgroup/commit/0d88b73d189ea3440ccaab00418d6469f76fa590]
|
|
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
|
---
|
|
src/daemon/cgrulesengd.c | 3 ---
|
|
1 file changed, 3 deletions(-)
|
|
|
|
diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c
|
|
index ea51f11..0d288f3 100644
|
|
--- a/src/daemon/cgrulesengd.c
|
|
+++ b/src/daemon/cgrulesengd.c
|
|
@@ -889,9 +889,6 @@ int cgre_start_daemon(const char *logp, const int logf,
|
|
} else if (pid > 0) {
|
|
exit(EXIT_SUCCESS);
|
|
}
|
|
-
|
|
- /* Change the file mode mask. */
|
|
- umask(0);
|
|
} else {
|
|
flog(LOG_DEBUG, "Not using daemon mode\n");
|
|
pid = getpid();
|