From 1b968093045dec4256a90f5ca2c533e8e4a38347 Mon Sep 17 00:00:00 2001 From: Romain Naour Date: Fri, 1 Nov 2024 18:10:43 +0100 Subject: [PATCH] package/python-twisted: add missing python3-xml dependency Currently the test TestPythonTwisted is not broken [1] since it doesn't test all modules provided by python-twisted package. But TestPythonTwisted should have failed due to missing xml in twisted/web module. Due to this, TestPythonPy3MagicWormhole runtime test is currently broken. Add missing python3-xml dependency and update sample_python_twisted.py to load twisted/web that uses xml module. Fixes (partially due to missing python setuptool in python-magic-wormhole-mailbox-server): https://gitlab.com/buildroot.org/buildroot/-/jobs/8199992646 Signed-off-by: Romain Naour Signed-off-by: Julien Olivain --- package/python-twisted/Config.in | 1 + support/testing/tests/package/sample_python_twisted.py | 1 + 2 files changed, 2 insertions(+) diff --git a/package/python-twisted/Config.in b/package/python-twisted/Config.in index 2d2bc30972..3254278fe9 100644 --- a/package/python-twisted/Config.in +++ b/package/python-twisted/Config.in @@ -7,6 +7,7 @@ config BR2_PACKAGE_PYTHON_TWISTED select BR2_PACKAGE_PYTHON_HYPERLINK # runtime select BR2_PACKAGE_PYTHON_ZOPE_INTERFACE # runtime select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS # runtime + select BR2_PACKAGE_PYTHON3_PYEXPAT # runtime select BR2_PACKAGE_PYTHON3_ZLIB # runtime help Twisted is an event-driven networking engine written in diff --git a/support/testing/tests/package/sample_python_twisted.py b/support/testing/tests/package/sample_python_twisted.py index b5540522fc..ec5ce2a31c 100644 --- a/support/testing/tests/package/sample_python_twisted.py +++ b/support/testing/tests/package/sample_python_twisted.py @@ -1,5 +1,6 @@ from twisted.internet import protocol, reactor, endpoints from twisted.web.client import readBody # noqa: F401 +from twisted.web import xmlrpc, server # noqa: F401 class F(protocol.Factory):