2012-04-17 22:45:22 +08:00
|
|
|
################################################################################
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-12 03:12:24 +08:00
|
|
|
#
|
2014-10-04 01:01:46 +08:00
|
|
|
# The Buildroot manual
|
2014-10-04 01:01:51 +08:00
|
|
|
#
|
2014-10-04 01:01:46 +08:00
|
|
|
################################################################################
|
|
|
|
|
|
2014-10-04 01:01:49 +08:00
|
|
|
MANUAL_SOURCES = $(sort $(wildcard docs/manual/*.txt) $(wildcard docs/images/*))
|
|
|
|
|
MANUAL_RESOURCES = $(TOPDIR)/docs/images
|
2014-10-04 01:01:46 +08:00
|
|
|
|
2014-10-04 01:01:49 +08:00
|
|
|
# Our manual needs to generate lists
|
|
|
|
|
define MANUAL_GEN_LISTS
|
2014-10-04 01:01:46 +08:00
|
|
|
$(Q)$(call MESSAGE,"Updating the manual lists...")
|
2015-05-02 00:35:34 +08:00
|
|
|
$(Q)$(COMMON_CONFIG_ENV) \
|
|
|
|
|
BR2_DEFCONFIG="" \
|
|
|
|
|
TOPDIR=$(TOPDIR) \
|
|
|
|
|
O=$(@D) \
|
2014-10-04 01:01:46 +08:00
|
|
|
python -B $(TOPDIR)/support/scripts/gen-manual-lists.py
|
2014-10-04 01:01:49 +08:00
|
|
|
endef
|
|
|
|
|
MANUAL_POST_RSYNC_HOOKS += MANUAL_GEN_LISTS
|
2014-10-04 01:01:46 +08:00
|
|
|
|
2014-10-04 01:01:49 +08:00
|
|
|
# Our list-generating script requires argparse
|
|
|
|
|
define MANUAL_CHECK_LISTS_DEPS
|
2014-10-04 01:01:46 +08:00
|
|
|
$(Q)if ! python -c "import argparse" >/dev/null 2>&1 ; then \
|
|
|
|
|
echo "You need python with argparse on your host to generate" \
|
|
|
|
|
"the list of packages in the manual"; \
|
|
|
|
|
exit 1; \
|
|
|
|
|
fi
|
2014-10-04 01:01:49 +08:00
|
|
|
endef
|
|
|
|
|
MANUAL_CHECK_DEPENDENCIES_HOOKS += MANUAL_CHECK_LISTS_DEPS
|
2014-10-04 01:01:46 +08:00
|
|
|
|
2014-10-04 01:01:52 +08:00
|
|
|
$(eval $(call asciidoc-document))
|
