mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-02 23:04:09 +08:00
6dc42492b6
Fix frame off-by-one bug. * frame-unwind.h (frame_this_id_ftype): Replace frame_unwind_id_ftype. (frame_prev_register_ftype): Replace frame_unwind_reg_ftype. (struct frame_unwind): Replace "id" with "this_id". Replace "reg" with "prev_register". * frame-unwind.c (frame_unwind_find_by_pc): Return legacy_saved_regs_unwind instead of trad_frame_unwind. Update comment. * dummy-frame.c (cached_find_dummy_frame): Delete function. (dummy_frame_this_id): Replace dummy_frame_id_unwind. (dummy_frame_prev_register): Replace dummy_frame_register_unwind. (dummy_frame_unwind): Update. * sentinel-frame.c (sentinel_frame_prev_register): Replace sentinel_frame_register_unwind. (sentinel_frame_this_id): Replace sentinel_frame_id_unwind. (sentinel_frame_unwinder): Update. * frame.h (legacy_saved_regs_unwind): Replace trad_frame_unwind. (struct frame_info): Rename "unwind_cache" to "prologue_cache". * frame.c (create_sentinel_frame): Update. Initialize "prologue_cache" instead of "unwind_cache". (frame_register_unwind): Call this frame's prev_register with the next frame and this frame's prologue cache. (get_prev_frame): Simplify. Always call prev frame's this_id with this frame and prev frame's prologue cache. Document that this call is shifted one to the left when compared to the frame_register_unwind call. (legacy_saved_regs_prev_register): Replace frame_saved_regs_register_unwind. (legacy_saved_regs_this_id): Replace frame_saved_regs_id_unwind. (legacy_saved_regs_unwinder): Replace trad_frame_unwinder. (legacy_saved_regs_unwind): Replace trad_frame_unwind. * d10v-tdep.c (d10v_frame_this_id): Replace d10v_frame_id_unwind. (d10v_frame_unwind): Update. (d10v_frame_prev_register): Replace d10v_frame_register_unwind. (d10v_frame_unwind_cache): Replace this "fi" with "next_frame". (saved_regs_unwinder): Replace this "frame" with "next_frame", and "saved_regs" with "this_saved_regs".
107 lines
3.0 KiB
C
107 lines
3.0 KiB
C
/* Definitions for frame unwinder, for GDB, the GNU debugger.
|
|
|
|
Copyright 2003 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place - Suite 330,
|
|
Boston, MA 02111-1307, USA. */
|
|
|
|
#include "defs.h"
|
|
#include "frame.h"
|
|
#include "frame-unwind.h"
|
|
#include "gdb_assert.h"
|
|
#include "dummy-frame.h"
|
|
|
|
static struct gdbarch_data *frame_unwind_data;
|
|
|
|
struct frame_unwind_table
|
|
{
|
|
frame_unwind_p_ftype **p;
|
|
int middle;
|
|
int nr;
|
|
};
|
|
|
|
/* Append a predicate to the end of the table. */
|
|
static void
|
|
append_predicate (struct frame_unwind_table *table, frame_unwind_p_ftype *p)
|
|
{
|
|
table->p = xrealloc (table->p, ((table->nr + 1)
|
|
* sizeof (frame_unwind_p_ftype *)));
|
|
table->p[table->nr] = p;
|
|
table->nr++;
|
|
}
|
|
|
|
static void *
|
|
frame_unwind_init (struct gdbarch *gdbarch)
|
|
{
|
|
struct frame_unwind_table *table = XCALLOC (1, struct frame_unwind_table);
|
|
append_predicate (table, dummy_frame_p);
|
|
return table;
|
|
}
|
|
|
|
static void
|
|
frame_unwind_free (struct gdbarch *gdbarch, void *data)
|
|
{
|
|
struct frame_unwind_table *table =
|
|
gdbarch_data (gdbarch, frame_unwind_data);
|
|
xfree (table->p);
|
|
xfree (table);
|
|
}
|
|
|
|
void
|
|
frame_unwind_append_predicate (struct gdbarch *gdbarch,
|
|
frame_unwind_p_ftype *p)
|
|
{
|
|
struct frame_unwind_table *table =
|
|
gdbarch_data (gdbarch, frame_unwind_data);
|
|
if (table == NULL)
|
|
{
|
|
/* ULGH, called during architecture initialization. Patch
|
|
things up. */
|
|
table = frame_unwind_init (gdbarch);
|
|
set_gdbarch_data (gdbarch, frame_unwind_data, table);
|
|
}
|
|
append_predicate (table, p);
|
|
}
|
|
|
|
const struct frame_unwind *
|
|
frame_unwind_find_by_pc (struct gdbarch *gdbarch, CORE_ADDR pc)
|
|
{
|
|
int i;
|
|
struct frame_unwind_table *table =
|
|
gdbarch_data (gdbarch, frame_unwind_data);
|
|
if (!DEPRECATED_USE_GENERIC_DUMMY_FRAMES)
|
|
/* Seriously old code. Don't even try to use this new mechanism.
|
|
(Note: The variable USE_GENERIC_DUMMY_FRAMES is deprecated, not
|
|
the dummy frame mechanism. All architectures should be using
|
|
generic dummy frames). */
|
|
return legacy_saved_regs_unwind;
|
|
for (i = 0; i < table->nr; i++)
|
|
{
|
|
const struct frame_unwind *desc = table->p[i] (pc);
|
|
if (desc != NULL)
|
|
return desc;
|
|
}
|
|
return legacy_saved_regs_unwind;
|
|
}
|
|
|
|
void
|
|
_initialize_frame_unwind (void)
|
|
{
|
|
frame_unwind_data = register_gdbarch_data (frame_unwind_init,
|
|
frame_unwind_free);
|
|
}
|