mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-25 11:04:18 +08:00
f81d112039
Currently, several commands take "0" or "-1" to mean "unlimited". "show" knows when to print "unlimited": (gdb) show height Number of lines gdb thinks are in a page is 45. (gdb) set height 0 (gdb) show height Number of lines gdb thinks are in a page is unlimited. However, the user can't herself specify "unlimited" directly: (gdb) set height unlimited No symbol table is loaded. Use the "file" command. (gdb) This patch addresses that, by adjusting the set handler for all integer/uinteger/zuinteger_unlimited commands to accept literal "unlimited". It also installs a completer. Presently, we complete on symbols by default, and at <http://sourceware.org/ml/gdb-patches/2013-03/msg00864.html> I've shown a WIP prototype that tried to keep that half working in these commands. In the end, it turned out to be more complicated than justifiable, IMO. It's super rare to want to pass the value of a variable/symbol in the program to a GDB set/show knob. That'll still work, it's just that we won't assist with completion anymore. This patch just sticks with the simple, and completes on "unlimited", and nothing else. This simplification means that "set he<tab><tab>" is all it takes to get to: "set height unlimited" The patch then goes through all integer/uinteger/zuinteger_unlimited commands in the tree, and updates both the online help and the manual to mention that "unlimited" is accepted in addition to 0/-1. In the cases where the command had no online help text at all, this adds it. I've tried to make the texts read in a way that "unlimited" is suggested before "0" or "-1" is. Tested on x86_64 Fedora 17. gdb/ 2013-04-10 Pedro Alves <palves@redhat.com> * cli/cli-decode.c (integer_unlimited_completer): New function. (add_setshow_integer_cmd, add_setshow_uinteger_cmd) (add_setshow_zuinteger_unlimited_cmd): Install the "unlimited" completer. * cli/cli-setshow.c: Include "cli/cli-utils.h". (is_unlimited_literal): New function. (do_set_command): Handle literal "unlimited" arguments. * frame.c (_initialize_frame) <set backtrace limit>: Document "unlimited". * printcmd.c (_initialize_printcmd) <set print max-symbolic-offset>: Add help text. * record-full.c (_initialize_record_full) <set record full insn-number-max>: Likewise. * record.c (_initialize_record) <set record instruction-history-size, set record function-call-history-size>: Add help text. * ser-tcp.c (_initialize_ser_tcp) <set tcp connect-timeout>: Add help text. * tracepoint.c (_initialize_tracepoint) <set trace-buffer-size>: Likewise. * source.c (_initialize_source) <set listsize>: Add help text. * utils.c (initialize_utils) <set height, set width>: Likewise. <set pagination>: Mention "set height unlimited". * valprint.c (_initialize_valprint) <set print elements, set print repeats>: Document "unlimited". gdb/doc/ 2013-04-10 Pedro Alves <palves@redhat.com> * gdb.texinfo (Process Record and Replay): Document that "set record full insn-number-max", "set record instruction-history-size" and "set record function-call-history-size" accept "unlimited". (Backtrace): Document that "set backtrace limit" accepts "unlimited". (List): Document that "set listsize" accepts "unlimited". (Print Settings)" Document that "set print max-symbolic-offset", "set print elements" and "set print repeats" accept "unlimited". (Starting and Stopping Trace Experiments): Document that "set trace-buffer-size" accepts "unlimited". (Remote Configuration): Document that "set tcp connect-timeout" accepts "unlimited". (Command History): Document that "set history size" accepts "unlimited". (Screen Size): Document that "set height" and "set width" accepts "unlimited". Adjust "set pagination"'s description to suggest "set height unlimited" instead of "set height 0". gdb/testsuite/ 2013-04-10 Pedro Alves <palves@redhat.com> * gdb.base/completion.exp: Test "set height", "set listsize" and "set trace-buffer-size" completion. * gdb.base/setshow.exp: Test "set height unlimited". * gdb.trace/trace-buffer-size.exp: Test "set trace-buffer-size unlimited".
435 lines
10 KiB
C
435 lines
10 KiB
C
/* Serial interface for raw TCP connections on Un*x like systems.
|
|
|
|
Copyright (C) 1992-2013 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "serial.h"
|
|
#include "ser-base.h"
|
|
#include "ser-tcp.h"
|
|
#include "gdbcmd.h"
|
|
#include "cli/cli-decode.h"
|
|
#include "cli/cli-setshow.h"
|
|
|
|
#include <sys/types.h>
|
|
|
|
#ifdef HAVE_SYS_FILIO_H
|
|
#include <sys/filio.h> /* For FIONBIO. */
|
|
#endif
|
|
#ifdef HAVE_SYS_IOCTL_H
|
|
#include <sys/ioctl.h> /* For FIONBIO. */
|
|
#endif
|
|
|
|
#include <sys/time.h>
|
|
|
|
#ifdef USE_WIN32API
|
|
#include <winsock2.h>
|
|
#ifndef ETIMEDOUT
|
|
#define ETIMEDOUT WSAETIMEDOUT
|
|
#endif
|
|
#define close(fd) closesocket (fd)
|
|
#define ioctl ioctlsocket
|
|
#else
|
|
#include <netinet/in.h>
|
|
#include <arpa/inet.h>
|
|
#include <netdb.h>
|
|
#include <sys/socket.h>
|
|
#include <netinet/tcp.h>
|
|
#endif
|
|
|
|
#include <signal.h>
|
|
#include "gdb_string.h"
|
|
#include "gdb_select.h"
|
|
|
|
#ifndef HAVE_SOCKLEN_T
|
|
typedef int socklen_t;
|
|
#endif
|
|
|
|
void _initialize_ser_tcp (void);
|
|
|
|
/* For "set tcp" and "show tcp". */
|
|
|
|
static struct cmd_list_element *tcp_set_cmdlist;
|
|
static struct cmd_list_element *tcp_show_cmdlist;
|
|
|
|
/* Whether to auto-retry refused connections. */
|
|
|
|
static int tcp_auto_retry = 1;
|
|
|
|
/* Timeout period for connections, in seconds. */
|
|
|
|
static unsigned int tcp_retry_limit = 15;
|
|
|
|
/* How many times per second to poll deprecated_ui_loop_hook. */
|
|
|
|
#define POLL_INTERVAL 5
|
|
|
|
/* Helper function to wait a while. If SCB is non-null, wait on its
|
|
file descriptor. Otherwise just wait on a timeout, updating *POLLS.
|
|
Returns -1 on timeout or interrupt, otherwise the value of select. */
|
|
|
|
static int
|
|
wait_for_connect (struct serial *scb, unsigned int *polls)
|
|
{
|
|
struct timeval t;
|
|
int n;
|
|
|
|
/* While we wait for the connect to complete,
|
|
poll the UI so it can update or the user can
|
|
interrupt. */
|
|
if (deprecated_ui_loop_hook && deprecated_ui_loop_hook (0))
|
|
{
|
|
errno = EINTR;
|
|
return -1;
|
|
}
|
|
|
|
/* Check for timeout. */
|
|
if (*polls > tcp_retry_limit * POLL_INTERVAL)
|
|
{
|
|
errno = ETIMEDOUT;
|
|
return -1;
|
|
}
|
|
|
|
/* Back off to polling once per second after the first POLL_INTERVAL
|
|
polls. */
|
|
if (*polls < POLL_INTERVAL)
|
|
{
|
|
t.tv_sec = 0;
|
|
t.tv_usec = 1000000 / POLL_INTERVAL;
|
|
}
|
|
else
|
|
{
|
|
t.tv_sec = 1;
|
|
t.tv_usec = 0;
|
|
}
|
|
|
|
if (scb)
|
|
{
|
|
fd_set rset, wset, eset;
|
|
|
|
FD_ZERO (&rset);
|
|
FD_SET (scb->fd, &rset);
|
|
wset = rset;
|
|
eset = rset;
|
|
|
|
/* POSIX systems return connection success or failure by signalling
|
|
wset. Windows systems return success in wset and failure in
|
|
eset.
|
|
|
|
We must call select here, rather than gdb_select, because
|
|
the serial structure has not yet been initialized - the
|
|
MinGW select wrapper will not know that this FD refers
|
|
to a socket. */
|
|
n = select (scb->fd + 1, &rset, &wset, &eset, &t);
|
|
}
|
|
else
|
|
/* Use gdb_select here, since we have no file descriptors, and on
|
|
Windows, plain select doesn't work in that case. */
|
|
n = gdb_select (0, NULL, NULL, NULL, &t);
|
|
|
|
/* If we didn't time out, only count it as one poll. */
|
|
if (n > 0 || *polls < POLL_INTERVAL)
|
|
(*polls)++;
|
|
else
|
|
(*polls) += POLL_INTERVAL;
|
|
|
|
return n;
|
|
}
|
|
|
|
/* Open a tcp socket. */
|
|
|
|
int
|
|
net_open (struct serial *scb, const char *name)
|
|
{
|
|
char *port_str, hostname[100];
|
|
int n, port, tmp;
|
|
int use_udp;
|
|
struct hostent *hostent;
|
|
struct sockaddr_in sockaddr;
|
|
#ifdef USE_WIN32API
|
|
u_long ioarg;
|
|
#else
|
|
int ioarg;
|
|
#endif
|
|
unsigned int polls = 0;
|
|
|
|
use_udp = 0;
|
|
if (strncmp (name, "udp:", 4) == 0)
|
|
{
|
|
use_udp = 1;
|
|
name = name + 4;
|
|
}
|
|
else if (strncmp (name, "tcp:", 4) == 0)
|
|
name = name + 4;
|
|
|
|
port_str = strchr (name, ':');
|
|
|
|
if (!port_str)
|
|
error (_("net_open: No colon in host name!")); /* Shouldn't ever
|
|
happen. */
|
|
|
|
tmp = min (port_str - name, (int) sizeof hostname - 1);
|
|
strncpy (hostname, name, tmp); /* Don't want colon. */
|
|
hostname[tmp] = '\000'; /* Tie off host name. */
|
|
port = atoi (port_str + 1);
|
|
|
|
/* Default hostname is localhost. */
|
|
if (!hostname[0])
|
|
strcpy (hostname, "localhost");
|
|
|
|
hostent = gethostbyname (hostname);
|
|
if (!hostent)
|
|
{
|
|
fprintf_unfiltered (gdb_stderr, "%s: unknown host\n", hostname);
|
|
errno = ENOENT;
|
|
return -1;
|
|
}
|
|
|
|
sockaddr.sin_family = PF_INET;
|
|
sockaddr.sin_port = htons (port);
|
|
memcpy (&sockaddr.sin_addr.s_addr, hostent->h_addr,
|
|
sizeof (struct in_addr));
|
|
|
|
retry:
|
|
|
|
if (use_udp)
|
|
scb->fd = socket (PF_INET, SOCK_DGRAM, 0);
|
|
else
|
|
scb->fd = socket (PF_INET, SOCK_STREAM, 0);
|
|
|
|
if (scb->fd == -1)
|
|
return -1;
|
|
|
|
/* Set socket nonblocking. */
|
|
ioarg = 1;
|
|
ioctl (scb->fd, FIONBIO, &ioarg);
|
|
|
|
/* Use Non-blocking connect. connect() will return 0 if connected
|
|
already. */
|
|
n = connect (scb->fd, (struct sockaddr *) &sockaddr, sizeof (sockaddr));
|
|
|
|
if (n < 0)
|
|
{
|
|
#ifdef USE_WIN32API
|
|
int err = WSAGetLastError();
|
|
#else
|
|
int err = errno;
|
|
#endif
|
|
|
|
/* Maybe we're waiting for the remote target to become ready to
|
|
accept connections. */
|
|
if (tcp_auto_retry
|
|
#ifdef USE_WIN32API
|
|
&& err == WSAECONNREFUSED
|
|
#else
|
|
&& err == ECONNREFUSED
|
|
#endif
|
|
&& wait_for_connect (NULL, &polls) >= 0)
|
|
{
|
|
close (scb->fd);
|
|
goto retry;
|
|
}
|
|
|
|
if (
|
|
#ifdef USE_WIN32API
|
|
/* Under Windows, calling "connect" with a non-blocking socket
|
|
results in WSAEWOULDBLOCK, not WSAEINPROGRESS. */
|
|
err != WSAEWOULDBLOCK
|
|
#else
|
|
err != EINPROGRESS
|
|
#endif
|
|
)
|
|
{
|
|
errno = err;
|
|
net_close (scb);
|
|
return -1;
|
|
}
|
|
|
|
/* Looks like we need to wait for the connect. */
|
|
do
|
|
{
|
|
n = wait_for_connect (scb, &polls);
|
|
}
|
|
while (n == 0);
|
|
if (n < 0)
|
|
{
|
|
net_close (scb);
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
/* Got something. Is it an error? */
|
|
{
|
|
int res, err;
|
|
socklen_t len;
|
|
|
|
len = sizeof (err);
|
|
/* On Windows, the fourth parameter to getsockopt is a "char *";
|
|
on UNIX systems it is generally "void *". The cast to "void *"
|
|
is OK everywhere, since in C "void *" can be implicitly
|
|
converted to any pointer type. */
|
|
res = getsockopt (scb->fd, SOL_SOCKET, SO_ERROR, (void *) &err, &len);
|
|
if (res < 0 || err)
|
|
{
|
|
/* Maybe the target still isn't ready to accept the connection. */
|
|
if (tcp_auto_retry
|
|
#ifdef USE_WIN32API
|
|
&& err == WSAECONNREFUSED
|
|
#else
|
|
&& err == ECONNREFUSED
|
|
#endif
|
|
&& wait_for_connect (NULL, &polls) >= 0)
|
|
{
|
|
close (scb->fd);
|
|
goto retry;
|
|
}
|
|
if (err)
|
|
errno = err;
|
|
net_close (scb);
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
/* Turn off nonblocking. */
|
|
ioarg = 0;
|
|
ioctl (scb->fd, FIONBIO, &ioarg);
|
|
|
|
if (use_udp == 0)
|
|
{
|
|
/* Disable Nagle algorithm. Needed in some cases. */
|
|
tmp = 1;
|
|
setsockopt (scb->fd, IPPROTO_TCP, TCP_NODELAY,
|
|
(char *)&tmp, sizeof (tmp));
|
|
}
|
|
|
|
#ifdef SIGPIPE
|
|
/* If we don't do this, then GDB simply exits
|
|
when the remote side dies. */
|
|
signal (SIGPIPE, SIG_IGN);
|
|
#endif
|
|
|
|
return 0;
|
|
}
|
|
|
|
void
|
|
net_close (struct serial *scb)
|
|
{
|
|
if (scb->fd == -1)
|
|
return;
|
|
|
|
close (scb->fd);
|
|
scb->fd = -1;
|
|
}
|
|
|
|
int
|
|
net_read_prim (struct serial *scb, size_t count)
|
|
{
|
|
return recv (scb->fd, scb->buf, count, 0);
|
|
}
|
|
|
|
int
|
|
net_write_prim (struct serial *scb, const void *buf, size_t count)
|
|
{
|
|
return send (scb->fd, buf, count, 0);
|
|
}
|
|
|
|
int
|
|
ser_tcp_send_break (struct serial *scb)
|
|
{
|
|
/* Send telnet IAC and BREAK characters. */
|
|
return (serial_write (scb, "\377\363", 2));
|
|
}
|
|
|
|
/* Support for "set tcp" and "show tcp" commands. */
|
|
|
|
static void
|
|
set_tcp_cmd (char *args, int from_tty)
|
|
{
|
|
help_list (tcp_set_cmdlist, "set tcp ", -1, gdb_stdout);
|
|
}
|
|
|
|
static void
|
|
show_tcp_cmd (char *args, int from_tty)
|
|
{
|
|
help_list (tcp_show_cmdlist, "show tcp ", -1, gdb_stdout);
|
|
}
|
|
|
|
|
|
void
|
|
_initialize_ser_tcp (void)
|
|
{
|
|
#ifdef USE_WIN32API
|
|
/* Do nothing; the TCP serial operations will be initialized in
|
|
ser-mingw.c. */
|
|
#else
|
|
struct serial_ops *ops;
|
|
|
|
ops = XMALLOC (struct serial_ops);
|
|
memset (ops, 0, sizeof (struct serial_ops));
|
|
ops->name = "tcp";
|
|
ops->next = 0;
|
|
ops->open = net_open;
|
|
ops->close = net_close;
|
|
ops->readchar = ser_base_readchar;
|
|
ops->write = ser_base_write;
|
|
ops->flush_output = ser_base_flush_output;
|
|
ops->flush_input = ser_base_flush_input;
|
|
ops->send_break = ser_tcp_send_break;
|
|
ops->go_raw = ser_base_raw;
|
|
ops->get_tty_state = ser_base_get_tty_state;
|
|
ops->copy_tty_state = ser_base_copy_tty_state;
|
|
ops->set_tty_state = ser_base_set_tty_state;
|
|
ops->print_tty_state = ser_base_print_tty_state;
|
|
ops->noflush_set_tty_state = ser_base_noflush_set_tty_state;
|
|
ops->setbaudrate = ser_base_setbaudrate;
|
|
ops->setstopbits = ser_base_setstopbits;
|
|
ops->drain_output = ser_base_drain_output;
|
|
ops->async = ser_base_async;
|
|
ops->read_prim = net_read_prim;
|
|
ops->write_prim = net_write_prim;
|
|
serial_add_interface (ops);
|
|
#endif /* USE_WIN32API */
|
|
|
|
add_prefix_cmd ("tcp", class_maintenance, set_tcp_cmd, _("\
|
|
TCP protocol specific variables\n\
|
|
Configure variables specific to remote TCP connections"),
|
|
&tcp_set_cmdlist, "set tcp ",
|
|
0 /* allow-unknown */, &setlist);
|
|
add_prefix_cmd ("tcp", class_maintenance, show_tcp_cmd, _("\
|
|
TCP protocol specific variables\n\
|
|
Configure variables specific to remote TCP connections"),
|
|
&tcp_show_cmdlist, "show tcp ",
|
|
0 /* allow-unknown */, &showlist);
|
|
|
|
add_setshow_boolean_cmd ("auto-retry", class_obscure,
|
|
&tcp_auto_retry, _("\
|
|
Set auto-retry on socket connect"), _("\
|
|
Show auto-retry on socket connect"),
|
|
NULL, NULL, NULL,
|
|
&tcp_set_cmdlist, &tcp_show_cmdlist);
|
|
|
|
add_setshow_uinteger_cmd ("connect-timeout", class_obscure,
|
|
&tcp_retry_limit, _("\
|
|
Set timeout limit in seconds for socket connection"), _("\
|
|
Show timeout limit in seconds for socket connection"), _("\
|
|
If set to \"unlimited\", GDB will keep attempting to establish a\n\
|
|
connection forever, unless interrupted with Ctrl-c.\n\
|
|
The default is 15 seconds."),
|
|
NULL, NULL,
|
|
&tcp_set_cmdlist, &tcp_show_cmdlist);
|
|
}
|