mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-12 03:43:33 +08:00
01d3dedf60
Right after a fork is detected, we detach breakpoints from the child (detach_breakpoints), which calls into target_remove_breakpoint with inferior_ptid pointing at the child process, but leaves the breakpoint marked inserted (in the parent). The problem is that record-full.c always deletes all knowledge of the breakpoint. Then when we later really delete the breakpoint from the parent, we fail the assertion, since the breakpoint is unexpectedly not found in the record-full.c breakpoint table. The fix is simply to not forget about the breakpoint if we're detaching it from a fork child. gdb/ChangeLog: 2016-08-10 Pedro Alves <palves@redhat.com> PR gdb/19187 * record-full.c (record_full_remove_breakpoint): Don't remove the breakpoint from the record_full_breakpoints VEC if we're detaching the breakpoint from a fork child. gdb/testsuite/ChangeLog: 2016-08-10 Pedro Alves <palves@redhat.com> PR gdb/19187 * gdb.reverse/waitpid-reverse.exp: Add comment and remove setup_kfails.
58 lines
1.7 KiB
Plaintext
58 lines
1.7 KiB
Plaintext
# Copyright 2015-2016 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the gdb testsuite.
|
|
|
|
#
|
|
# This test tests waitpid syscall for reverse execution.
|
|
#
|
|
# Also serves as regression test for gdb/19187 (recording across a
|
|
# fork).
|
|
|
|
if ![supports_reverse] {
|
|
return
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
|
|
return -1
|
|
}
|
|
|
|
runto main
|
|
|
|
if [supports_process_record] {
|
|
# Activate process record/replay
|
|
gdb_test_no_output "record" "Turn on process record"
|
|
}
|
|
|
|
gdb_test "break marker2" \
|
|
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
|
|
"set breakpoint at marker2"
|
|
|
|
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
|
|
|
|
gdb_test "break marker1" \
|
|
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
|
|
"set breakpoint at marker1"
|
|
|
|
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
|
|
|
|
# If the variable was recorded properly on syscall, the old contents (-1)
|
|
# will be remembered. If not, new contents (status) will be used, and
|
|
# the test will fail.
|
|
|
|
gdb_test "print status" ".* = -1" "check waitpid record"
|