binutils-gdb/gdbserver
Simon Marchi 3295ff3bfb gdbserver: switch to right process in find_one_thread
New in this version: add a dedicated test.

When I do this:

    $ ./gdb -nx --data-directory=data-directory -q \
        /bin/sleep \
	-ex "maint set target-non-stop on" \
	-ex "tar ext :1234" \
	-ex "set remote exec-file /bin/sleep" \
	-ex "run 1231 &" \
	-ex add-inferior \
	-ex "inferior 2"
    Reading symbols from /bin/sleep...
    (No debugging symbols found in /bin/sleep)
    Remote debugging using :1234
    Starting program: /bin/sleep 1231
    Reading /lib64/ld-linux-x86-64.so.2 from remote target...
    warning: File transfers from remote targets can be slow. Use "set sysroot" to access files locally instead.
    Reading /lib64/ld-linux-x86-64.so.2 from remote target...
    Reading /usr/lib/debug/.build-id/a6/7a1408f18db3576757eea210d07ba3fc560dff.debug from remote target...
    [New inferior 2]
    Added inferior 2 on connection 1 (extended-remote :1234)
    [Switching to inferior 2 [<null>] (<noexec>)]
    (gdb) Reading /lib/x86_64-linux-gnu/libc.so.6 from remote target...
    attach 3659848
    Attaching to process 3659848
    /home/smarchi/src/binutils-gdb/gdb/thread.c:85: internal-error: inferior_thread: Assertion `current_thread_ != nullptr' failed.

Note the "attach" command just above.  When doing it on the command-line
with a -ex switch, the bug doesn't trigger.

The internal error of GDB is actually caused by GDBserver crashing, and
the error recovery of GDB is not on point.  This patch aims to fix just
the GDBserver crash, not the GDB problem.

GDBserver crashes with a segfault here:

    (gdb) bt
    #0  0x00005555557fb3f4 in find_one_thread (ptid=...) at /home/smarchi/src/binutils-gdb/gdbserver/thread-db.cc:177
    #1  0x00005555557fd5cf in thread_db_thread_handle (ptid=<error reading variable: Cannot access memory at address 0xffffffffffffffa0>, handle=0x7fffffffc400, handle_len=0x7fffffffc3f0)
        at /home/smarchi/src/binutils-gdb/gdbserver/thread-db.cc:461
    #2  0x000055555578a0b6 in linux_process_target::thread_handle (this=0x5555558a64c0 <the_x86_target>, ptid=<error reading variable: Cannot access memory at address 0xffffffffffffffa0>, handle=0x7fffffffc400,
        handle_len=0x7fffffffc3f0) at /home/smarchi/src/binutils-gdb/gdbserver/linux-low.cc:6905
    #3  0x00005555556dfcc6 in handle_qxfer_threads_worker (thread=0x60b000000510, buffer=0x7fffffffc8a0) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:1645
    #4  0x00005555556e00e6 in operator() (__closure=0x7fffffffc5e0, thread=0x60b000000510) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:1696
    #5  0x00005555556f54be in for_each_thread<handle_qxfer_threads_proper(buffer*)::<lambda(thread_info*)> >(struct {...}) (func=...) at /home/smarchi/src/binutils-gdb/gdbserver/gdbthread.h:159
    #6  0x00005555556e0242 in handle_qxfer_threads_proper (buffer=0x7fffffffc8a0) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:1694
    #7  0x00005555556e04ba in handle_qxfer_threads (annex=0x629000000213 "", readbuf=0x621000019100 '\276' <repeats 200 times>..., writebuf=0x0, offset=0, len=4097)
        at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:1732
    #8  0x00005555556e1989 in handle_qxfer (own_buf=0x629000000200 "qXfer:threads", packet_len=26, new_packet_len_p=0x7fffffffd630) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:2045
    #9  0x00005555556e720a in handle_query (own_buf=0x629000000200 "qXfer:threads", packet_len=26, new_packet_len_p=0x7fffffffd630) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:2685
    #10 0x00005555556f1a01 in process_serial_event () at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:4176
    #11 0x00005555556f4457 in handle_serial_event (err=0, client_data=0x0) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:4514
    #12 0x0000555555820f56 in handle_file_event (file_ptr=0x607000000250, ready_mask=1) at /home/smarchi/src/binutils-gdb/gdbsupport/event-loop.cc:573
    #13 0x0000555555821895 in gdb_wait_for_event (block=1) at /home/smarchi/src/binutils-gdb/gdbsupport/event-loop.cc:694
    #14 0x000055555581f533 in gdb_do_one_event (mstimeout=-1) at /home/smarchi/src/binutils-gdb/gdbsupport/event-loop.cc:264
    #15 0x00005555556ec9fb in start_event_loop () at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:3512
    #16 0x00005555556f0769 in captured_main (argc=4, argv=0x7fffffffe0d8) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:3992
    #17 0x00005555556f0e3f in main (argc=4, argv=0x7fffffffe0d8) at /home/smarchi/src/binutils-gdb/gdbserver/server.cc:4078

The reason is a wrong current process when find_one_thread is called.
The current process is the 2nd one, which was just attached.  It does
not yet have thread_db data (proc->priv->thread_db is nullptr).  As we
iterate on all threads of all process to fulfull the qxfer:threads:read
request, we get to a thread of process 1 for which we haven't read
thread_db information yet (lwp_info::thread_known is false), so we get
into find_one_thread.  find_one_thread uses
`current_process ()->priv->thread_db`, assuming the current process
matches the ptid passed as a parameter, which is wrong.  A segfault
happens when trying to dereference that thread_db pointer.

Fix this by making find_one_thread not assume what the current process /
current thread is.  If it needs to call into libthread_db, which we know
will try to read memory from the current process, then temporarily set
the current process.

In the case where the thread is already know and we return early, we
don't need to switch process.

Add a test to reproduce this specific situation.

Change-Id: I09b00883e8b73b7e5f89d0f47cb4e9c0f3d6caaa
Approved-By: Andrew Burgess <aburgess@redhat.com>
2022-11-28 09:13:30 -05:00
..
.dir-locals.el Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
.gitattributes gdb, gdbserver, gdbsupport: add .gitattributes files 2020-03-05 15:59:22 +01:00
.gitignore
acinclude.m4 gdb: don't use -Wmissing-prototypes with g++ 2022-01-13 10:25:45 +00:00
aclocal.m4 gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
ax.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
ax.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
ChangeLog-2002-2021 gdb: move remaining ChangeLogs to legacy files 2021-07-26 12:20:33 +01:00
config.in Fix build on rhES5 2021-11-09 08:21:18 -07:00
configure Renenerate {gdb,gdbserver}/configure 2022-09-28 13:06:06 +01:00
configure.ac gdb: don't use -Wmissing-prototypes with g++ 2022-01-13 10:25:45 +00:00
configure.srv gdbserver/csky add csky gdbserver support 2022-09-13 11:20:54 +08:00
debug.cc gdbserver: introduce remote_debug_printf 2022-01-18 13:44:38 -05:00
debug.h gdbserver: introduce remote_debug_printf 2022-01-18 13:44:38 -05:00
dll.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
dll.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
fork-child.cc Fix GDBserver regression due to change to avoid reading shell registers 2022-06-29 19:32:07 +01:00
gdb_proc_service.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
gdbreplay.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
gdbthread.h gdbserver: track current process as well as current thread 2022-05-03 15:10:22 +01:00
hostio.cc gdbsupport: move include/gdb/fileio.h contents to fileio.h 2022-09-21 14:11:03 -04:00
hostio.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
i387-fp.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
i387-fp.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
inferiors.cc gdbserver: track current process as well as current thread 2022-05-03 15:10:22 +01:00
inferiors.h gdb+gdbserver/Linux: avoid reading registers while going through shell 2022-06-28 18:11:29 +01:00
linux-aarch32-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-aarch32-low.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-aarch32-tdesc.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-aarch32-tdesc.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-aarch64-ipa.cc Use aarch64_features to describe register features in target descriptions. 2022-05-18 13:32:04 -07:00
linux-aarch64-low.cc Use aarch64_features to describe register features in target descriptions. 2022-05-18 13:32:04 -07:00
linux-aarch64-tdesc.cc Use aarch64_features to describe register features in target descriptions. 2022-05-18 13:32:04 -07:00
linux-aarch64-tdesc.h Use aarch64_features to describe register features in target descriptions. 2022-05-18 13:32:04 -07:00
linux-amd64-ipa.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
linux-arc-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-arm-low.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
linux-arm-tdesc.cc gdbserver: Fix build after adding tls feature to arm tdesc. 2022-05-03 21:38:12 -07:00
linux-arm-tdesc.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-csky-low.cc gdbserver/csky add csky gdbserver support 2022-09-13 11:20:54 +08:00
linux-i386-ipa.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
linux-ia64-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-loongarch-low.cc gdb/gdbserver: LoongArch: Improve implementation of fcc registers 2022-08-09 22:22:23 +08:00
linux-low.cc [gdb/server] Emit warning for SIGINT failure 2022-11-27 10:31:50 +01:00
linux-low.h gdbserver: do not report btrace support if target does not announce it 2022-11-09 17:46:21 +01:00
linux-m68k-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-mips-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-nios2-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-or1k-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-ppc-ipa.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
linux-ppc-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-ppc-tdesc-init.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-riscv-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-s390-ipa.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
linux-s390-low.cc gdbserver: introduce threads_debug_printf, THREADS_SCOPED_DEBUG_ENTER_EXIT 2022-01-18 13:44:32 -05:00
linux-s390-tdesc.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-sh-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-sparc-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-tic6x-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-x86-low.cc gdbserver/linux-x86: move lwp declaration out of __x86_64__ region 2022-11-18 12:18:53 -05:00
linux-x86-tdesc.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-x86-tdesc.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
linux-xtensa-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
Makefile.in gdbserver/csky add csky gdbserver support 2022-09-13 11:20:54 +08:00
mem-break.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
mem-break.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
netbsd-aarch64-low.cc Use aarch64_features to describe register features in target descriptions. 2022-05-18 13:32:04 -07:00
netbsd-amd64-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
netbsd-i386-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
netbsd-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
netbsd-low.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
notif.cc gdbserver: introduce remote_debug_printf 2022-01-18 13:44:38 -05:00
notif.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
proc-service.cc gdbserver: use current_process in ps_getpid 2022-11-18 11:21:22 -05:00
proc-service.list Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
README gdbserver: small cleanup of README file 2020-06-12 16:01:35 -04:00
regcache.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
regcache.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
remote-utils.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
remote-utils.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
server.cc gdbserver: do not report btrace support if target does not announce it 2022-11-09 17:46:21 +01:00
server.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
symbol.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
target.cc gdbserver: do not report btrace support if target does not announce it 2022-11-09 17:46:21 +01:00
target.h gdbserver: do not report btrace support if target does not announce it 2022-11-09 17:46:21 +01:00
tdesc.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tdesc.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
thread-db.cc gdbserver: switch to right process in find_one_thread 2022-11-28 09:13:30 -05:00
tracepoint.cc internal_error: remove need to pass __FILE__/__LINE__ 2022-10-19 15:32:36 +01:00
tracepoint.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
utils.cc Make GDBserver abort on internal error in development mode 2022-06-27 13:55:36 +01:00
utils.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
win32-i386-low.cc Fix gdbserver build for x86-64 Windows 2022-04-27 10:45:10 -06:00
win32-low.cc gdbsupport: move include/gdb/fileio.h contents to fileio.h 2022-09-21 14:11:03 -04:00
win32-low.h Use strwinerror in gdb/windows-nat.c 2022-08-16 08:04:37 -06:00
x86-low.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
x86-low.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
x86-tdesc.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
xtensa-xtregs.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.