mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-25 10:13:33 +08:00
d9ebdab754
GDB uses the 'current_top_target' when displaying the description of an inferior. This leads to same target being used for each inferior and, in turn, yields incorrect output when the inferior has a target that is supposed to give a specialized output. For instance, the remote target outputs "Remote target" instead of "process XYZ" as the description if the multi-process feature is not supported or turned off. E.g.: Suppose we have a native and a remote target, and the native is the current inferior. The remote target does not support multi-process. For "info inferiors", we would expect to see: ~~~ (gdb) i inferiors Num Description Connection Executable * 1 process 29060 1 (native) /a/path 2 Remote target 2 (remote ...) ~~~ but instead we get ~~~ (gdb) i inferiors Num Description Connection Executable * 1 process 29060 1 (native) /a/path 2 process 42000 2 (remote ...) ~~~ Similarly, if the current inferior is the remote one, we would expect to see ~~~ (gdb) i inferiors Num Description Connection Executable 1 process 29060 1 (native) /a/path * 2 Remote target 2 (remote ...) ~~~ but we get ~~~ (gdb) i inferiors Num Description Connection Executable * 1 Remote target 1 (native) /a/path 2 Remote target 2 (remote ...) ~~~ With this patch, we switch to the inferior when outputting its description, so that the current_top_target will be aligned to the inferior we are displaying. For testing, this patch expands the "info inferiors" test for the multi-target feature. The test was checking for the output of the info commands after setup, only when the current inferior is the last added inferior. This patch does the following to the testcase: 1. The "info inferiors" and "info connections" test is extracted out from the "setup" procedure to a separate procedure. 2. The test is enriched to check the output after switching to each inferior, not just the last one. 3. The test is performed twice; one for when the multi-process feature is turned on, one for off. gdb/ChangeLog: 2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> * inferior.c (print_inferior): Switch inferior before printing it. gdb/testsuite/ChangeLog: 2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> * gdb.multi/multi-target.exp (setup): Factor out "info connections" and "info inferiors" tests to ... (test_info_inferiors): ... this new procedure. (top level): Run new "info-inferiors" tests. |
||
|---|---|---|
| .. | ||
| base.exp | ||
| bkpt-multi-exec.c | ||
| bkpt-multi-exec.exp | ||
| crashme.c | ||
| dummy-frame-restore.c | ||
| dummy-frame-restore.exp | ||
| goodbye.c | ||
| hangout.c | ||
| hello.c | ||
| info-threads.exp | ||
| multi-arch-exec.c | ||
| multi-arch-exec.exp | ||
| multi-arch.exp | ||
| multi-attach.c | ||
| multi-attach.exp | ||
| multi-target.c | ||
| multi-target.exp | ||
| multi-term-settings.c | ||
| multi-term-settings.exp | ||
| remove-inferiors.c | ||
| remove-inferiors.exp | ||
| tids-gid-reset.c | ||
| tids-gid-reset.exp | ||
| tids.c | ||
| tids.exp | ||
| watchpoint-multi-exit.c | ||
| watchpoint-multi-exit.exp | ||
| watchpoint-multi.c | ||
| watchpoint-multi.exp | ||