mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-24 18:44:20 +08:00
6cdd651fda
The current code checks for the presence of a SVE target description by comparing the number of registers. This is a bit fragile since the number of registers can change whenever we add new sets. Like PAC, for example. If the comparison breaks, then we're left with SVE registers in the description, but gdbserver doesn't send the registers to GDB, which in turn displays stale information to the user. The following patch changes the check to use the SVE feature string instead, which hopefully should be more stable. gdb/gdbserver/ChangeLog: 2019-11-20 Luis Machado <luis.machado@linaro.org> * linux-aarch64-low.c (is_sve_tdesc): Check against target feature instead of register count. * tdesc.c (tdesc_contains_feature): New function. * tdesc.h (tdesc_contains_feature): New prototype. Change-Id: I28b782cb1677560ca9a06a1be442974b25aabae4
102 lines
3.1 KiB
C++
102 lines
3.1 KiB
C++
/* Target description definitions for remote server for GDB.
|
|
Copyright (C) 2012-2019 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDBSERVER_TDESC_H
|
|
#define GDBSERVER_TDESC_H
|
|
|
|
#include "gdbsupport/tdesc.h"
|
|
|
|
#include "regdef.h"
|
|
#include <vector>
|
|
|
|
/* A target description. Inherit from tdesc_feature so that target_desc
|
|
can be used as tdesc_feature. */
|
|
|
|
struct target_desc : tdesc_element
|
|
{
|
|
/* A vector of elements of register definitions that
|
|
describe the inferior's register set. */
|
|
std::vector<struct reg> reg_defs;
|
|
|
|
/* The register cache size, in bytes. */
|
|
int registers_size;
|
|
|
|
/* XML features in this target description. */
|
|
std::vector<tdesc_feature_up> features;
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
/* An array of register names. These are the "expedite" registers:
|
|
registers whose values are sent along with stop replies. */
|
|
const char **expedite_regs = NULL;
|
|
|
|
/* Defines what to return when looking for the "target.xml" file in
|
|
response to qXfer:features:read. Its contents can either be
|
|
verbatim XML code (prefixed with a '@') or else the name of the
|
|
actual XML file to be used in place of "target.xml".
|
|
|
|
If NULL then its content will be generated by parsing the target
|
|
description into xml. */
|
|
mutable const char *xmltarget = NULL;
|
|
|
|
/* The value of <architecture> element in the XML, replying GDB. */
|
|
const char *arch = NULL;
|
|
|
|
/* The value of <osabi> element in the XML, replying GDB. */
|
|
const char *osabi = NULL;
|
|
|
|
public:
|
|
target_desc ()
|
|
: registers_size (0)
|
|
{}
|
|
|
|
~target_desc ();
|
|
|
|
bool operator== (const target_desc &other) const;
|
|
|
|
bool operator!= (const target_desc &other) const
|
|
{
|
|
return !(*this == other);
|
|
}
|
|
#endif
|
|
|
|
void accept (tdesc_element_visitor &v) const override;
|
|
};
|
|
|
|
/* Copy target description SRC to DEST. */
|
|
|
|
void copy_target_description (struct target_desc *dest,
|
|
const struct target_desc *src);
|
|
|
|
/* Initialize TDESC, and then set its expedite_regs field to
|
|
EXPEDITE_REGS. */
|
|
|
|
void init_target_desc (struct target_desc *tdesc,
|
|
const char **expedite_regs);
|
|
|
|
/* Return the current inferior's target description. Never returns
|
|
NULL. */
|
|
|
|
const struct target_desc *current_target_desc (void);
|
|
|
|
/* Return true if TDESC contains the feature described by string FEATURE.
|
|
Return false otherwise. */
|
|
bool tdesc_contains_feature (const target_desc *tdesc,
|
|
const std::string &feature);
|
|
|
|
#endif /* GDBSERVER_TDESC_H */
|