mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 20:14:06 +08:00
6a053cb1ff
This changes section_offsets to be specialization of a std::vector and updates all the users. It also removes the ANOFFSET and SIZEOF_N_SECTION_OFFSETS macros. Most of this is just a generic sort of cleanup, that reduces the number of lines of code. However, a couple spots were doing weird things. objfile_relocate did: - std::vector<struct section_offsets> - new_debug_offsets (SIZEOF_N_SECTION_OFFSETS (debug_objfile->num_sections)); ... which seems to greatly over-estimate the number of elements needed. This appeared in set_objfile_default_section_offset: - std::vector<struct section_offsets> offsets (objf->num_sections, - { { offset } }); ... which makes sense due to type safety, but is also actively confusing given that section_offsets was previously also a kind of vector type. Tested on x86-64 Fedora 30. gdb/ChangeLog 2020-01-08 Tom Tromey <tromey@adacore.com> * xcoffread.c (enter_line_range, read_xcoff_symtab) (process_xcoff_symbol, xcoff_symfile_offsets): Update. * symtab.h (MSYMBOL_VALUE_ADDRESS): Update. (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS): Remove. (section_offsets): New typedef. * symtab.c (fixup_section, get_msymbol_address): Update. * symmisc.c (dump_msymbols): Update. * symfile.h (relative_addr_info_to_section_offsets) (symfile_map_offsets_to_segments): Update. * symfile.c (build_section_addr_info_from_objfile) (init_objfile_sect_indices): Update. (struct place_section_arg): Change type of "offsets". (place_section): Update. (relative_addr_info_to_section_offsets): Change type of "section_offsets". Remove "num_sections" parameter. (default_symfile_offsets, syms_from_objfile_1) (set_objfile_default_section_offset): Update. (reread_symbols): No need to preserve section offsets by hand. (symfile_map_offsets_to_segments): Change type of "offsets". * stap-probe.c (relocate_address): Update. * stabsread.h (process_one_symbol): Update. * solib-target.c (struct lm_info_target) <offsets>: Change type. (solib_target_relocate_section_addresses): Update. * solib-svr4.c (enable_break, svr4_relocate_main_executable): Update. * solib-frv.c (frv_relocate_main_executable): Update. * solib-dsbt.c (dsbt_relocate_main_executable): Update. * solib-aix.c (solib_aix_get_section_offsets): Change return type. (solib_aix_solib_create_inferior_hook): Update. * remote.c (remote_target::get_offsets): Update. * psymtab.c (find_pc_sect_psymtab): Update. * psympriv.h (struct partial_symbol) <address, text_low, text_high>: Update. * objfiles.h (obj_section_offset): Update. (struct objfile) <section_offsets>: Change type. <num_sections>: Remove. (objfile_relocate): Update. * objfiles.c (entry_point_address_query): Update (relocate_one_symbol): Change type of "section_offsets". (objfile_relocate1, objfile_relocate1): Change type of "new_offsets". (objfile_rebase1): Update. * mipsread.c (mipscoff_symfile_read): Update. (read_alphacoff_dynamic_symtab): Remove "section_offsets" parameter. * mdebugread.c (parse_symbol): Change type of "section_offsets". (parse_external, psymtab_to_symtab_1): Update. * machoread.c (macho_symfile_offsets): Update. * ia64-tdep.c (ia64_find_unwind_table): Update. * hppa-tdep.c (read_unwind_info): Update. * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update. * dwarf2read.c (create_addrmap_from_index) (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab) (process_psymtab_comp_unit_reader, add_partial_symbol) (add_partial_subprogram, process_full_comp_unit) (read_file_scope, read_func_scope, read_lexical_block_scope) (read_call_site_scope, dwarf2_rnglists_process) (dwarf2_ranges_process, dwarf2_ranges_read) (dwarf_decode_lines_1, var_decode_location, new_symbol) (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset): Update. * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde): Update. * dtrace-probe.c (dtrace_probe::get_relocated_address): Update. * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update. (process_one_symbol): Change type of "section_offsets". * ctfread.c (get_objfile_text_range): Update. * coffread.c (coff_symtab_read, enter_linenos) (process_coff_symbol): Update. * coff-pe-read.c (add_pe_forwarded_sym): Update. * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update. Change-Id: I147eb967e9b44d82f4048039de7bb44b80cd72fb
376 lines
12 KiB
C++
376 lines
12 KiB
C++
/* Private partial symbol table definitions.
|
|
|
|
Copyright (C) 2009-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef PSYMPRIV_H
|
|
#define PSYMPRIV_H
|
|
|
|
#include "psymtab.h"
|
|
#include "objfiles.h"
|
|
#include "gdbsupport/gdb_string_view.h"
|
|
|
|
/* A partial_symbol records the name, domain, and address class of
|
|
symbols whose types we have not parsed yet. For functions, it also
|
|
contains their memory address, so we can find them from a PC value.
|
|
Each partial_symbol sits in a partial_symtab, all of which are chained
|
|
on a partial symtab list and which points to the corresponding
|
|
normal symtab once the partial_symtab has been referenced. */
|
|
|
|
/* This structure is space critical. See space comments at the top of
|
|
symtab.h. */
|
|
|
|
struct partial_symbol
|
|
{
|
|
/* Return the section for this partial symbol, or nullptr if no
|
|
section has been set. */
|
|
struct obj_section *obj_section (struct objfile *objfile) const
|
|
{
|
|
if (ginfo.section >= 0)
|
|
return &objfile->sections[ginfo.section];
|
|
return nullptr;
|
|
}
|
|
|
|
/* Return the unrelocated address of this partial symbol. */
|
|
CORE_ADDR unrelocated_address () const
|
|
{
|
|
return ginfo.value.address;
|
|
}
|
|
|
|
/* Return the address of this partial symbol, relocated according to
|
|
the offsets provided in OBJFILE. */
|
|
CORE_ADDR address (const struct objfile *objfile) const
|
|
{
|
|
return ginfo.value.address + objfile->section_offsets[ginfo.section];
|
|
}
|
|
|
|
/* Set the address of this partial symbol. The address must be
|
|
unrelocated. */
|
|
void set_unrelocated_address (CORE_ADDR addr)
|
|
{
|
|
ginfo.value.address = addr;
|
|
}
|
|
|
|
/* Note that partial_symbol does not derive from general_symbol_info
|
|
due to the bcache. See add_psymbol_to_bcache. */
|
|
|
|
struct general_symbol_info ginfo;
|
|
|
|
/* Name space code. */
|
|
|
|
ENUM_BITFIELD(domain_enum_tag) domain : SYMBOL_DOMAIN_BITS;
|
|
|
|
/* Address class (for info_symbols). Note that we don't allow
|
|
synthetic "aclass" values here at present, simply because there's
|
|
no need. */
|
|
|
|
ENUM_BITFIELD(address_class) aclass : SYMBOL_ACLASS_BITS;
|
|
};
|
|
|
|
/* A convenience enum to give names to some constants used when
|
|
searching psymtabs. This is internal to psymtab and should not be
|
|
used elsewhere. */
|
|
|
|
enum psymtab_search_status
|
|
{
|
|
PST_NOT_SEARCHED,
|
|
PST_SEARCHED_AND_FOUND,
|
|
PST_SEARCHED_AND_NOT_FOUND
|
|
};
|
|
|
|
/* Each source file that has not been fully read in is represented by
|
|
a partial_symtab. This contains the information on where in the
|
|
executable the debugging symbols for a specific file are, and a
|
|
list of names of global symbols which are located in this file.
|
|
They are all chained on partial symtab lists.
|
|
|
|
Even after the source file has been read into a symtab, the
|
|
partial_symtab remains around. They are allocated on an obstack,
|
|
objfile_obstack. */
|
|
|
|
struct partial_symtab
|
|
{
|
|
/* Return the raw low text address of this partial_symtab. */
|
|
CORE_ADDR raw_text_low () const
|
|
{
|
|
return m_text_low;
|
|
}
|
|
|
|
/* Return the raw high text address of this partial_symtab. */
|
|
CORE_ADDR raw_text_high () const
|
|
{
|
|
return m_text_high;
|
|
}
|
|
|
|
/* Return the relocated low text address of this partial_symtab. */
|
|
CORE_ADDR text_low (struct objfile *objfile) const
|
|
{
|
|
return m_text_low + objfile->section_offsets[SECT_OFF_TEXT (objfile)];
|
|
}
|
|
|
|
/* Return the relocated high text address of this partial_symtab. */
|
|
CORE_ADDR text_high (struct objfile *objfile) const
|
|
{
|
|
return m_text_high + objfile->section_offsets[SECT_OFF_TEXT (objfile)];
|
|
}
|
|
|
|
/* Set the low text address of this partial_symtab. */
|
|
void set_text_low (CORE_ADDR addr)
|
|
{
|
|
m_text_low = addr;
|
|
text_low_valid = 1;
|
|
}
|
|
|
|
/* Set the hight text address of this partial_symtab. */
|
|
void set_text_high (CORE_ADDR addr)
|
|
{
|
|
m_text_high = addr;
|
|
text_high_valid = 1;
|
|
}
|
|
|
|
|
|
/* Chain of all existing partial symtabs. */
|
|
|
|
struct partial_symtab *next;
|
|
|
|
/* Name of the source file which this partial_symtab defines,
|
|
or if the psymtab is anonymous then a descriptive name for
|
|
debugging purposes, or "". It must not be NULL. */
|
|
|
|
const char *filename;
|
|
|
|
/* Full path of the source file. NULL if not known. */
|
|
|
|
char *fullname;
|
|
|
|
/* Directory in which it was compiled, or NULL if we don't know. */
|
|
|
|
const char *dirname;
|
|
|
|
/* Range of text addresses covered by this file; texthigh is the
|
|
beginning of the next section. Do not use if PSYMTABS_ADDRMAP_SUPPORTED
|
|
is set. Do not refer directly to these fields. Instead, use the
|
|
accessors. The validity of these fields is determined by the
|
|
text_low_valid and text_high_valid fields; these are located later
|
|
in this structure for better packing. */
|
|
|
|
CORE_ADDR m_text_low;
|
|
CORE_ADDR m_text_high;
|
|
|
|
/* If NULL, this is an ordinary partial symbol table.
|
|
|
|
If non-NULL, this holds a single includer of this partial symbol
|
|
table, and this partial symbol table is a shared one.
|
|
|
|
A shared psymtab is one that is referenced by multiple other
|
|
psymtabs, and which conceptually has its contents directly
|
|
included in those.
|
|
|
|
Shared psymtabs have special semantics. When a search finds a
|
|
symbol in a shared table, we instead return one of the non-shared
|
|
tables that include this one.
|
|
|
|
A shared psymtabs can be referred to by other shared ones.
|
|
|
|
The psymtabs that refer to a shared psymtab will list the shared
|
|
psymtab in their 'dependencies' array.
|
|
|
|
In DWARF terms, a shared psymtab is a DW_TAG_partial_unit; but
|
|
of course using a name based on that would be too confusing, so
|
|
"shared" was chosen instead.
|
|
|
|
Only a single user is needed because, when expanding a shared
|
|
psymtab, we only need to expand its "canonical" non-shared user.
|
|
The choice of which one should be canonical is left to the
|
|
debuginfo reader; it can be arbitrary. */
|
|
|
|
struct partial_symtab *user;
|
|
|
|
/* Array of pointers to all of the partial_symtab's which this one
|
|
depends on. Since this array can only be set to previous or
|
|
the current (?) psymtab, this dependency tree is guaranteed not
|
|
to have any loops. "depends on" means that symbols must be read
|
|
for the dependencies before being read for this psymtab; this is
|
|
for type references in stabs, where if foo.c includes foo.h, declarations
|
|
in foo.h may use type numbers defined in foo.c. For other debugging
|
|
formats there may be no need to use dependencies. */
|
|
|
|
struct partial_symtab **dependencies;
|
|
|
|
int number_of_dependencies;
|
|
|
|
/* Global symbol list. This list will be sorted after readin to
|
|
improve access. Binary search will be the usual method of
|
|
finding a symbol within it. globals_offset is an integer offset
|
|
within global_psymbols[]. */
|
|
|
|
int globals_offset;
|
|
int n_global_syms;
|
|
|
|
/* Static symbol list. This list will *not* be sorted after readin;
|
|
to find a symbol in it, exhaustive search must be used. This is
|
|
reasonable because searches through this list will eventually
|
|
lead to either the read in of a files symbols for real (assumed
|
|
to take a *lot* of time; check) or an error (and we don't care
|
|
how long errors take). This is an offset and size within
|
|
static_psymbols[]. */
|
|
|
|
int statics_offset;
|
|
int n_static_syms;
|
|
|
|
/* Non-zero if the symtab corresponding to this psymtab has been
|
|
readin. This is located here so that this structure packs better
|
|
on 64-bit systems. */
|
|
|
|
unsigned char readin;
|
|
|
|
/* True iff objfile->psymtabs_addrmap is properly populated for this
|
|
partial_symtab. For discontiguous overlapping psymtabs is the only usable
|
|
info in PSYMTABS_ADDRMAP. */
|
|
|
|
unsigned char psymtabs_addrmap_supported;
|
|
|
|
/* True if the name of this partial symtab is not a source file name. */
|
|
|
|
unsigned char anonymous;
|
|
|
|
/* A flag that is temporarily used when searching psymtabs. */
|
|
|
|
ENUM_BITFIELD (psymtab_search_status) searched_flag : 2;
|
|
|
|
/* Validity of the m_text_low and m_text_high fields. */
|
|
|
|
unsigned int text_low_valid : 1;
|
|
unsigned int text_high_valid : 1;
|
|
|
|
/* Pointer to compunit eventually allocated for this source file, 0 if
|
|
!readin or if we haven't looked for the symtab after it was readin. */
|
|
|
|
struct compunit_symtab *compunit_symtab;
|
|
|
|
/* Pointer to function which will read in the symtab corresponding to
|
|
this psymtab. */
|
|
|
|
void (*read_symtab) (struct partial_symtab *, struct objfile *);
|
|
|
|
/* Information that lets read_symtab() locate the part of the symbol table
|
|
that this psymtab corresponds to. This information is private to the
|
|
format-dependent symbol reading routines. For further detail examine
|
|
the various symbol reading modules. */
|
|
|
|
void *read_symtab_private;
|
|
};
|
|
|
|
/* Specify whether a partial psymbol should be allocated on the global
|
|
list or the static list. */
|
|
|
|
enum class psymbol_placement
|
|
{
|
|
STATIC,
|
|
GLOBAL
|
|
};
|
|
|
|
/* Add a symbol to the partial symbol table of OBJFILE.
|
|
|
|
If COPY_NAME is true, make a copy of NAME, otherwise use the passed
|
|
reference.
|
|
|
|
THECLASS is the type of symbol.
|
|
|
|
SECTION is the index of the section of OBJFILE in which the symbol is found.
|
|
|
|
WHERE determines whether the symbol goes in the list of static or global
|
|
partial symbols of OBJFILE.
|
|
|
|
COREADDR is the address of the symbol. For partial symbols that don't have
|
|
an address, zero is passed.
|
|
|
|
LANGUAGE is the language from which the symbol originates. This will
|
|
influence, amongst other things, how the symbol name is demangled. */
|
|
|
|
extern void add_psymbol_to_list (gdb::string_view name,
|
|
bool copy_name, domain_enum domain,
|
|
enum address_class theclass,
|
|
short section,
|
|
psymbol_placement where,
|
|
CORE_ADDR coreaddr,
|
|
enum language language,
|
|
struct objfile *objfile);
|
|
|
|
/* Initialize storage for partial symbols. If partial symbol storage
|
|
has already been initialized, this does nothing. TOTAL_SYMBOLS is
|
|
an estimate of how many symbols there will be. */
|
|
|
|
extern void init_psymbol_list (struct objfile *objfile, int total_symbols);
|
|
|
|
extern struct partial_symtab *start_psymtab_common (struct objfile *,
|
|
const char *, CORE_ADDR);
|
|
|
|
extern void end_psymtab_common (struct objfile *, struct partial_symtab *);
|
|
|
|
/* Allocate a new partial symbol table associated with OBJFILE.
|
|
FILENAME (which must be non-NULL) is the filename of this partial
|
|
symbol table; it is copied into the appropriate storage. A new
|
|
partial symbol table is returned; aside from "next" and "filename",
|
|
its fields are initialized to zero. */
|
|
|
|
extern struct partial_symtab *allocate_psymtab (const char *filename,
|
|
struct objfile *objfile)
|
|
ATTRIBUTE_NONNULL (1);
|
|
|
|
static inline void
|
|
discard_psymtab (struct objfile *objfile, struct partial_symtab *pst)
|
|
{
|
|
objfile->partial_symtabs->discard_psymtab (pst);
|
|
}
|
|
|
|
/* Used when recording partial symbol tables. On destruction,
|
|
discards any partial symbol tables that have been built. However,
|
|
the tables can be kept by calling the "keep" method. */
|
|
class psymtab_discarder
|
|
{
|
|
public:
|
|
|
|
psymtab_discarder (struct objfile *objfile)
|
|
: m_objfile (objfile),
|
|
m_psymtab (objfile->partial_symtabs->psymtabs)
|
|
{
|
|
}
|
|
|
|
~psymtab_discarder ()
|
|
{
|
|
if (m_objfile != NULL)
|
|
m_objfile->partial_symtabs->discard_psymtabs_to (m_psymtab);
|
|
}
|
|
|
|
/* Keep any partial symbol tables that were built. */
|
|
void keep ()
|
|
{
|
|
m_objfile = NULL;
|
|
}
|
|
|
|
private:
|
|
|
|
/* The objfile. If NULL this serves as a sentinel to indicate that
|
|
the psymtabs should be kept. */
|
|
struct objfile *m_objfile;
|
|
/* How far back to free. */
|
|
struct partial_symtab *m_psymtab;
|
|
};
|
|
|
|
#endif /* PSYMPRIV_H */
|