mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-01 14:03:56 +08:00
1526853e34
With the growing number of selftests, I think it would be useful to be able to run only a subset of the tests. This patch associates a name to each registered selftest. It then allows doing something like: (gdb) maintenance selftest aarch64 Running self-tests. Running selftest aarch64-analyze-prologue. Running selftest aarch64-process-record. Ran 2 unit tests, 0 failed or with gdbserver: ./gdbserver --selftest=aarch64 In both cases, only the tests that contain "aarch64" in their name are ran. To help validate that the tests you want to run were actually ran, it also prints a message with the test name before running each test. Right now, all the arch-dependent tests are registered as a single test of the selftests. To be able to filter those too, I made them "first-class citizen" selftests. The selftest type is an interface, with different implementations for "simple selftests" and "arch selftests". The run_tests function simply iterates on that an invokes operator() on each test. I changed the tests data structure from a vector to a map, because - it allows iterating in a stable (alphabetical) order - it allows to easily verify if a test with a given name has been registered, to avoid duplicates There's also a new command "maintenance info selftests" that lists the registered selftests. gdb/ChangeLog: * common/selftest.h (selftest): New struct/interface. (register_test): Add name parameter, add new overload. (run_tests): Add filter parameter. (for_each_selftest_ftype): New typedef. (for_each_selftest): New declaration. * common/selftest.c (tests): Change type to map<string, unique_ptr<selftest>>. (simple_selftest): New struct. (register_test): New function. (register_test): Add name parameter and use it. (run_tests): Add filter parameter and use it. Add prints. Adjust to vector -> map change. * aarch64-tdep.c (_initialize_aarch64_tdep): Add names when registering selftests. * arm-tdep.c (_initialize_arm_tdep): Likewise. * disasm-selftests.c (_initialize_disasm_selftests): Likewise. * dwarf2-frame.c (_initialize_dwarf2_frame): Likewise. * dwarf2loc.c (_initialize_dwarf2loc): Likewise. * findvar.c (_initialize_findvar): Likewise. * gdbarch-selftests.c (_initialize_gdbarch_selftests): Likewise. * maint.c (maintenance_selftest): Update call to run_tests. (maintenance_info_selftests): New function. (_initialize_maint_cmds): Register "maintenance info selftests" command. Update "maintenance selftest" doc. * regcache.c (_initialize_regcache): Add names when registering selftests. * rust-exp.y (_initialize_rust_exp): Likewise. * selftest-arch.c (gdbarch_selftest): New struct. (gdbarch_tests): Remove. (register_test_foreach_arch): Add name parameter. Call register_test. (tests_with_arch): Remove, move most content to gdbarch_selftest::operator(). (_initialize_selftests_foreach_arch): Remove. * selftest-arch.h (register_test_foreach_arch): Add name parameter. (run_tests_with_arch): New declaration. * utils-selftests.c (_initialize_utils_selftests): Add names when registering selftests. * utils.c (_initialize_utils): Likewise. * unittests/array-view-selftests.c (_initialize_array_view_selftests): Likewise. * unittests/environ-selftests.c (_initialize_environ_selftests): Likewise. * unittests/function-view-selftests.c (_initialize_function_view_selftests): Likewise. * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Likewise. * unittests/optional-selftests.c (_initialize_optional_selftests): Likewise. * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Likewise. * NEWS: Document "maintenance selftest" and "maint info selftests". gdb/gdbserver/ChangeLog: * server.c (captured_main): Accept argument for --selftest. Update run_tests call. * linux-x86-tdesc-selftest.c (initialize_low_tdesc): Add names when registering selftests. gdb/doc/ChangeLog: * gdb.texinfo (Maintenance Commands): Document filter parameter of "maint selftest". Document "maint info selftests" command.
307 lines
9.1 KiB
C
307 lines
9.1 KiB
C
/* Self tests for gdb_environ for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "selftest.h"
|
|
#include "common/environ.h"
|
|
#include "common/diagnostics.h"
|
|
|
|
static const char gdb_selftest_env_var[] = "GDB_SELFTEST_ENVIRON";
|
|
|
|
static bool
|
|
set_contains (const std::set<std::string> &set, std::string key)
|
|
{
|
|
return set.find (key) != set.end ();
|
|
}
|
|
|
|
namespace selftests {
|
|
namespace gdb_environ_tests {
|
|
|
|
/* Test if the vector is initialized in a correct way. */
|
|
|
|
static void
|
|
test_vector_initialization ()
|
|
{
|
|
gdb_environ env;
|
|
|
|
/* When the vector is initialized, there should always be one NULL
|
|
element in it. */
|
|
SELF_CHECK (env.envp ()[0] == NULL);
|
|
SELF_CHECK (env.user_set_env ().size () == 0);
|
|
SELF_CHECK (env.user_unset_env ().size () == 0);
|
|
|
|
/* Make sure that there is no other element. */
|
|
SELF_CHECK (env.get ("PWD") == NULL);
|
|
}
|
|
|
|
/* Test initialization using the host's environ. */
|
|
|
|
static void
|
|
test_init_from_host_environ ()
|
|
{
|
|
/* Initialize the environment vector using the host's environ. */
|
|
gdb_environ env = gdb_environ::from_host_environ ();
|
|
|
|
/* The user-set and user-unset lists must be empty. */
|
|
SELF_CHECK (env.user_set_env ().size () == 0);
|
|
SELF_CHECK (env.user_unset_env ().size () == 0);
|
|
|
|
/* Our test environment variable should be present at the
|
|
vector. */
|
|
SELF_CHECK (strcmp (env.get (gdb_selftest_env_var), "1") == 0);
|
|
}
|
|
|
|
/* Test reinitialization using the host's environ. */
|
|
|
|
static void
|
|
test_reinit_from_host_environ ()
|
|
{
|
|
/* Reinitialize our environ vector using the host environ. We
|
|
should be able to see one (and only one) instance of the test
|
|
variable. */
|
|
gdb_environ env = gdb_environ::from_host_environ ();
|
|
env = gdb_environ::from_host_environ ();
|
|
char **envp = env.envp ();
|
|
int num_found = 0;
|
|
|
|
for (size_t i = 0; envp[i] != NULL; ++i)
|
|
if (strcmp (envp[i], "GDB_SELFTEST_ENVIRON=1") == 0)
|
|
++num_found;
|
|
SELF_CHECK (num_found == 1);
|
|
}
|
|
|
|
/* Test the case when we set a variable A, then set a variable B,
|
|
then unset A, and make sure that we cannot find A in the environ
|
|
vector, but can still find B. */
|
|
|
|
static void
|
|
test_set_A_unset_B_unset_A_cannot_find_A_can_find_B ()
|
|
{
|
|
gdb_environ env;
|
|
|
|
env.set ("GDB_SELFTEST_ENVIRON_1", "aaa");
|
|
SELF_CHECK (strcmp (env.get ("GDB_SELFTEST_ENVIRON_1"), "aaa") == 0);
|
|
/* User-set environ var list must contain one element. */
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
SELF_CHECK (set_contains (env.user_set_env (),
|
|
std::string ("GDB_SELFTEST_ENVIRON_1=aaa")));
|
|
|
|
env.set ("GDB_SELFTEST_ENVIRON_2", "bbb");
|
|
SELF_CHECK (strcmp (env.get ("GDB_SELFTEST_ENVIRON_2"), "bbb") == 0);
|
|
|
|
env.unset ("GDB_SELFTEST_ENVIRON_1");
|
|
SELF_CHECK (env.get ("GDB_SELFTEST_ENVIRON_1") == NULL);
|
|
SELF_CHECK (strcmp (env.get ("GDB_SELFTEST_ENVIRON_2"), "bbb") == 0);
|
|
|
|
/* The user-set environ var list must contain only one element
|
|
now. */
|
|
SELF_CHECK (set_contains (env.user_set_env (),
|
|
std::string ("GDB_SELFTEST_ENVIRON_2=bbb")));
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
}
|
|
|
|
/* Check if unset followed by a set in an empty vector works. */
|
|
|
|
static void
|
|
test_unset_set_empty_vector ()
|
|
{
|
|
gdb_environ env;
|
|
|
|
env.set ("PWD", "test");
|
|
SELF_CHECK (strcmp (env.get ("PWD"), "test") == 0);
|
|
SELF_CHECK (set_contains (env.user_set_env (), std::string ("PWD=test")));
|
|
SELF_CHECK (env.user_unset_env ().size () == 0);
|
|
/* The second element must be NULL. */
|
|
SELF_CHECK (env.envp ()[1] == NULL);
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
env.unset ("PWD");
|
|
SELF_CHECK (env.envp ()[0] == NULL);
|
|
SELF_CHECK (env.user_set_env ().size () == 0);
|
|
SELF_CHECK (env.user_unset_env ().size () == 1);
|
|
SELF_CHECK (set_contains (env.user_unset_env (), std::string ("PWD")));
|
|
}
|
|
|
|
/* When we clear our environ vector, there should be only one
|
|
element on it (NULL), and we shouldn't be able to get our test
|
|
variable. */
|
|
|
|
static void
|
|
test_vector_clear ()
|
|
{
|
|
gdb_environ env;
|
|
|
|
env.set (gdb_selftest_env_var, "1");
|
|
|
|
env.clear ();
|
|
SELF_CHECK (env.envp ()[0] == NULL);
|
|
SELF_CHECK (env.user_set_env ().size () == 0);
|
|
SELF_CHECK (env.user_unset_env ().size () == 0);
|
|
SELF_CHECK (env.get (gdb_selftest_env_var) == NULL);
|
|
}
|
|
|
|
/* Test that after a std::move the moved-from object is left at a
|
|
valid state (i.e., its only element is NULL). */
|
|
|
|
static void
|
|
test_std_move ()
|
|
{
|
|
gdb_environ env;
|
|
gdb_environ env2;
|
|
|
|
env.set ("A", "1");
|
|
SELF_CHECK (strcmp (env.get ("A"), "1") == 0);
|
|
SELF_CHECK (set_contains (env.user_set_env (), std::string ("A=1")));
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
|
|
env2 = std::move (env);
|
|
SELF_CHECK (env.envp ()[0] == NULL);
|
|
SELF_CHECK (strcmp (env2.get ("A"), "1") == 0);
|
|
SELF_CHECK (env2.envp ()[1] == NULL);
|
|
SELF_CHECK (env.user_set_env ().size () == 0);
|
|
SELF_CHECK (set_contains (env2.user_set_env (), std::string ("A=1")));
|
|
SELF_CHECK (env2.user_set_env ().size () == 1);
|
|
env.set ("B", "2");
|
|
SELF_CHECK (strcmp (env.get ("B"), "2") == 0);
|
|
SELF_CHECK (env.envp ()[1] == NULL);
|
|
}
|
|
|
|
/* Test that the move constructor leaves everything at a valid
|
|
state. */
|
|
|
|
static void
|
|
test_move_constructor ()
|
|
{
|
|
gdb_environ env;
|
|
|
|
env.set ("A", "1");
|
|
SELF_CHECK (strcmp (env.get ("A"), "1") == 0);
|
|
SELF_CHECK (set_contains (env.user_set_env (), std::string ("A=1")));
|
|
|
|
gdb_environ env2 = std::move (env);
|
|
SELF_CHECK (env.envp ()[0] == NULL);
|
|
SELF_CHECK (env.user_set_env ().size () == 0);
|
|
SELF_CHECK (strcmp (env2.get ("A"), "1") == 0);
|
|
SELF_CHECK (env2.envp ()[1] == NULL);
|
|
SELF_CHECK (set_contains (env2.user_set_env (), std::string ("A=1")));
|
|
SELF_CHECK (env2.user_set_env ().size () == 1);
|
|
|
|
env.set ("B", "2");
|
|
SELF_CHECK (strcmp (env.get ("B"), "2") == 0);
|
|
SELF_CHECK (env.envp ()[1] == NULL);
|
|
SELF_CHECK (set_contains (env.user_set_env (), std::string ("B=2")));
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
}
|
|
|
|
/* Test that self-moving works. */
|
|
|
|
static void
|
|
test_self_move ()
|
|
{
|
|
gdb_environ env;
|
|
|
|
/* Test self-move. */
|
|
env.set ("A", "1");
|
|
SELF_CHECK (strcmp (env.get ("A"), "1") == 0);
|
|
SELF_CHECK (set_contains (env.user_set_env (), std::string ("A=1")));
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
|
|
/* Some compilers warn about moving to self, but that's precisely what we want
|
|
to test here, so turn this warning off. */
|
|
DIAGNOSTIC_PUSH
|
|
DIAGNOSTIC_IGNORE_SELF_MOVE
|
|
env = std::move (env);
|
|
DIAGNOSTIC_POP
|
|
|
|
SELF_CHECK (strcmp (env.get ("A"), "1") == 0);
|
|
SELF_CHECK (strcmp (env.envp ()[0], "A=1") == 0);
|
|
SELF_CHECK (env.envp ()[1] == NULL);
|
|
SELF_CHECK (set_contains (env.user_set_env (), std::string ("A=1")));
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
}
|
|
|
|
/* Test if set/unset/reset works. */
|
|
|
|
static void
|
|
test_set_unset_reset ()
|
|
{
|
|
gdb_environ env = gdb_environ::from_host_environ ();
|
|
|
|
/* Our test variable should already be present in the host's environment. */
|
|
SELF_CHECK (env.get ("GDB_SELFTEST_ENVIRON") != NULL);
|
|
|
|
/* Set our test variable to another value. */
|
|
env.set ("GDB_SELFTEST_ENVIRON", "test");
|
|
SELF_CHECK (strcmp (env.get ("GDB_SELFTEST_ENVIRON"), "test") == 0);
|
|
SELF_CHECK (env.user_set_env ().size () == 1);
|
|
SELF_CHECK (env.user_unset_env ().size () == 0);
|
|
|
|
/* And unset our test variable. The variable still exists in the
|
|
host's environment, but doesn't exist in our vector. */
|
|
env.unset ("GDB_SELFTEST_ENVIRON");
|
|
SELF_CHECK (env.get ("GDB_SELFTEST_ENVIRON") == NULL);
|
|
SELF_CHECK (env.user_set_env ().size () == 0);
|
|
SELF_CHECK (env.user_unset_env ().size () == 1);
|
|
SELF_CHECK (set_contains (env.user_unset_env (),
|
|
std::string ("GDB_SELFTEST_ENVIRON")));
|
|
|
|
/* Re-set the test variable. */
|
|
env.set ("GDB_SELFTEST_ENVIRON", "1");
|
|
SELF_CHECK (strcmp (env.get ("GDB_SELFTEST_ENVIRON"), "1") == 0);
|
|
}
|
|
|
|
static void
|
|
run_tests ()
|
|
{
|
|
/* Set a test environment variable. */
|
|
if (setenv ("GDB_SELFTEST_ENVIRON", "1", 1) != 0)
|
|
error (_("Could not set environment variable for testing."));
|
|
|
|
test_vector_initialization ();
|
|
|
|
test_unset_set_empty_vector ();
|
|
|
|
test_init_from_host_environ ();
|
|
|
|
test_set_unset_reset ();
|
|
|
|
test_vector_clear ();
|
|
|
|
test_reinit_from_host_environ ();
|
|
|
|
/* Get rid of our test variable. We won't need it anymore. */
|
|
unsetenv ("GDB_SELFTEST_ENVIRON");
|
|
|
|
test_set_A_unset_B_unset_A_cannot_find_A_can_find_B ();
|
|
|
|
test_std_move ();
|
|
|
|
test_move_constructor ();
|
|
|
|
test_self_move ();
|
|
}
|
|
} /* namespace gdb_environ */
|
|
} /* namespace selftests */
|
|
|
|
void
|
|
_initialize_environ_selftests ()
|
|
{
|
|
selftests::register_test ("gdb_environ",
|
|
selftests::gdb_environ_tests::run_tests);
|
|
}
|