mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-18 05:54:26 +08:00
798a7429f9
This patch removes some unused variables, found with -Wunused. I have not removed everything reported by -Wunused, because some expressions such as struct type *arg_type = check_typedef (value_type); in bfin-tdep.c could have an unexpected but important side-effect. I removed others that I considered more low-risk, such as: struct gdbarch *gdbarch = get_objfile_arch (objfile); I tested building with Python 2/Python 3/no Python, with/without expat, with/without libipt and with/without babeltrace. gdb/ChangeLog: * ada-lang.c (ada_collect_symbol_completion_matches): Remove unused variables. (ada_is_redundant_range_encoding): Likewise. * ada-varobj.c (ada_varobj_get_value_of_array_variable): Likewise. * alpha-tdep.c (alpha_software_single_step): Likewise. * arm-tdep.c (_initialize_arm_tdep): Likewise. * auto-load.c (info_auto_load_cmd): Likewise. * break-catch-syscall.c (insert_catch_syscall): Likewise. (remove_catch_syscall): Likewise. * breakpoint.c (condition_completer): Likewise. (clear_command): Likewise. (update_breakpoint_locations): Likewise. * btrace.c (btrace_disable): Likewise. (btrace_teardown): Likewise. (btrace_maint_update_pt_packets): Likewise. (maint_btrace_clear_cmd): Likewise. * cli/cli-decode.c (lookup_cmd_1): Likewise. (lookup_cmd_composition): Likewise. * cli/cli-dump.c (scan_filename): Likewise. (restore_command): Likewise. * compile/compile-loc2c.c (compute_stack_depth): Likewise. * compile/compile-object-load.c (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * compile/compile.c (compile_to_object): Likewise. * completer.c (filename_completer): Likewise. (complete_files_symbols): Likewise. (complete_expression): Likewise. * corelow.c (core_open): Likewise. * ctf.c (ctf_start): Likewise. (ctf_write_status): Likewise. (ctf_write_uploaded_tsv): Likewise. (ctf_write_definition_end): Likewise. (ctf_open_dir): Likewise. (ctf_xfer_partial): Likewise. (ctf_trace_find): Likewise. * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Likewise. * dwarf2loc.c (allocate_piece_closure): Likewise. (indirect_pieced_value): Likewise. (dwarf2_evaluate_loc_desc_full): Likewise. * dwarf2read.c (dw2_expand_marked_cus): Likewise. (dw2_expand_symtabs_matching): Likewise. (dw2_map_symbol_filenames): Likewise. (read_and_check_comp_unit_head): Likewise. (read_cutu_die_from_dwo): Likewise. (lookup_dwo_unit): Likewise. (read_comp_units_from_section): Likewise. (dwarf2_compute_name): Likewise. (handle_DW_AT_stmt_list): Likewise. (create_cus_hash_table): Likewise. (create_dwp_v2_section): Likewise. (dwarf2_rnglists_process): Likewise. (dwarf2_ranges_process): Likewise. (dwarf2_record_block_ranges): Likewise. (is_vtable_name): Likewise. (read_formatted_entries): Likewise. (skip_form_bytes): Likewise. * elfread.c (elf_symtab_read): Likewise. * exec.c (exec_file_command): Likewise. * f-valprint.c (f_val_print): Likewise. (info_common_command_for_block): Likewise. * guile/guile.c (initialize_scheme_side): Likewise. * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Likewise. * guile/scm-cmd.c (cmdscm_completer): Likewise. (gdbscm_register_command_x): Likewise. * guile/scm-frame.c (gdbscm_frame_read_var): Likewise. * guile/scm-param.c (gdbscm_parameter_value): Likewise. * guile/scm-ports.c (file_port_magic): Likewise. * guile/scm-pretty-print.c (ppscm_search_pp_list): Likewise. (ppscm_pretty_print_one_value): Likewise. (ppscm_print_children): Likewise. * guile/scm-string.c (gdbscm_string_to_argv): Likewise. * guile/scm-symtab.c (gdbscm_sal_symtab): Likewise. * guile/scm-type.c (gdbscm_type_next_field_x): Likewise. * guile/scm-utils.c (gdbscm_parse_function_args): Likewise. * i386-tdep.c (i386_register_reggroup_p): Likewise. * infcmd.c (run_command_1): Likewise. (until_next_fsm_clean_up): Likewise. * linespec.c (linespec_complete): Likewise. (find_label_symbols): Likewise. * m2-valprint.c (m2_val_print): Likewise. * memattr.c (require_user_regions): Likewise. (lookup_mem_region): Likewise. (disable_mem_command): Likewise. (mem_delete): Likewise. * mep-tdep.c (mep_register_name): Likewise. (mep_analyze_prologue): Likewise. * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Likewise. * mi/mi-interp.c (mi_on_sync_execution_done): Likewise. * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise. * microblaze-linux-tdep.c (microblaze_linux_init_abi): Likewise. * minidebug.c (lzma_open): Likewise. * minsyms.c (lookup_minimal_symbol): Likewise. * mips-linux-tdep.c (mips64_fill_fpregset): Likewise. * mips-tdep.c (mips_stub_frame_sniffer): Likewise. (mips_o64_return_value): Likewise. (mips_single_step_through_delay): Likewise. (_initialize_mips_tdep): Likewise. * nios2-tdep.c (nios2_push_dummy_call): Likewise. (nios2_software_single_step): Likewise. * parse.c (find_minsym_type_and_address): Likewise. * psymtab.c (psym_relocate): Likewise. * python/py-breakpoint.c (bppy_get_commands): Likewise. (gdbpy_breakpoint_modified): Likewise. * python/py-infevents.c (create_inferior_call_event_object): Likewise. * python/py-record-btrace.c (btpy_list_item): Likewise. * python/py-type.c (typy_str): Likewise. * python/py-value.c (valpy_call): Likewise. * python/python.c (do_start_initialization): Likewise. * record-btrace.c (record_btrace_insn_history_range): Likewise. (record_btrace_call_history_range): Likewise. (record_btrace_record_method): Likewise. (record_btrace_xfer_partial): Likewise. (btrace_get_frame_function): Likewise. * record-full.c (record_full_open): Likewise. * record.c (get_context_size): Likewise. * registry.h (DEFINE_REGISTRY): Likewise. * remote-fileio.c (remote_fileio_request): Likewise. * remote.c (remote_update_thread_list): Likewise. (remote_check_symbols): Likewise. (remote_commit_resume): Likewise. (remote_interrupt): Likewise. (remote_insert_breakpoint): Likewise. (compare_sections_command): Likewise. * rust-exp.y (super_name): Likewise. (lex_string): Likewise. (convert_ast_to_type): Likewise. (convert_ast_to_expression): Likewise. * rust-lang.c (rust_print_struct_def): Likewise. (rust_print_type): Likewise. (rust_evaluate_subexp): Likewise. * rx-tdep.c (rx_register_type): Likewise. * ser-event.c (serial_event_clear): Likewise. * serial.c (serial_open): Likewise. * spu-tdep.c (spu_overlay_new_objfile): Likewise. * symfile.c (section_is_overlay): Likewise. (overlay_unmapped_address): Likewise. (overlay_mapped_address): Likewise. (simple_overlay_update_1): Likewise. (simple_overlay_update): Likewise. * symtab.c (symbol_find_demangled_name): Likewise. (search_symbols): Likewise. * target-descriptions.c (tdesc_predefined_type): Likewise. * target.c (target_commit_resume): Likewise. * thread.c (print_selected_thread_frame): Likewise. * top.c (new_ui_command): Likewise. (gdb_readline_no_editing): Likewise. * tracefile-tfile.c (tfile_open): Likewise. * tracepoint.c (create_tsv_from_upload): Likewise. * utils.c (quit): Likewise. (defaulted_query): Likewise. * valarith.c (value_concat): Likewise. * xml-syscall.c (xml_list_syscalls_by_group): Likewise. * xml-tdesc.c (target_fetch_description_xml): Likewise. * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise. (xtensa_pseudo_register_write): Likewise. gdb/gdbserver/ChangeLog: * regcache.c (registers_to_string): Remove unused variable.
474 lines
11 KiB
C
474 lines
11 KiB
C
/* Register support routines for the remote server for GDB.
|
|
Copyright (C) 2001-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "server.h"
|
|
#include "regdef.h"
|
|
#include "gdbthread.h"
|
|
#include "tdesc.h"
|
|
#include "rsp-low.h"
|
|
#ifndef IN_PROCESS_AGENT
|
|
|
|
struct regcache *
|
|
get_thread_regcache (struct thread_info *thread, int fetch)
|
|
{
|
|
struct regcache *regcache;
|
|
|
|
regcache = thread_regcache_data (thread);
|
|
|
|
/* Threads' regcaches are created lazily, because biarch targets add
|
|
the main thread/lwp before seeing it stop for the first time, and
|
|
it is only after the target sees the thread stop for the first
|
|
time that the target has a chance of determining the process's
|
|
architecture. IOW, when we first add the process's main thread
|
|
we don't know which architecture/tdesc its regcache should
|
|
have. */
|
|
if (regcache == NULL)
|
|
{
|
|
struct process_info *proc = get_thread_process (thread);
|
|
|
|
gdb_assert (proc->tdesc != NULL);
|
|
|
|
regcache = new_register_cache (proc->tdesc);
|
|
set_thread_regcache_data (thread, regcache);
|
|
}
|
|
|
|
if (fetch && regcache->registers_valid == 0)
|
|
{
|
|
struct thread_info *saved_thread = current_thread;
|
|
|
|
current_thread = thread;
|
|
/* Invalidate all registers, to prevent stale left-overs. */
|
|
memset (regcache->register_status, REG_UNAVAILABLE,
|
|
regcache->tdesc->reg_defs.size ());
|
|
fetch_inferior_registers (regcache, -1);
|
|
current_thread = saved_thread;
|
|
regcache->registers_valid = 1;
|
|
}
|
|
|
|
return regcache;
|
|
}
|
|
|
|
/* See common/common-regcache.h. */
|
|
|
|
struct regcache *
|
|
get_thread_regcache_for_ptid (ptid_t ptid)
|
|
{
|
|
return get_thread_regcache (find_thread_ptid (ptid), 1);
|
|
}
|
|
|
|
void
|
|
regcache_invalidate_thread (struct thread_info *thread)
|
|
{
|
|
struct regcache *regcache;
|
|
|
|
regcache = thread_regcache_data (thread);
|
|
|
|
if (regcache == NULL)
|
|
return;
|
|
|
|
if (regcache->registers_valid)
|
|
{
|
|
struct thread_info *saved_thread = current_thread;
|
|
|
|
current_thread = thread;
|
|
store_inferior_registers (regcache, -1);
|
|
current_thread = saved_thread;
|
|
}
|
|
|
|
regcache->registers_valid = 0;
|
|
}
|
|
|
|
/* See regcache.h. */
|
|
|
|
void
|
|
regcache_invalidate_pid (int pid)
|
|
{
|
|
/* Only invalidate the regcaches of threads of this process. */
|
|
for_each_thread (pid, regcache_invalidate_thread);
|
|
}
|
|
|
|
/* See regcache.h. */
|
|
|
|
void
|
|
regcache_invalidate (void)
|
|
{
|
|
/* Only update the threads of the current process. */
|
|
int pid = current_thread->id.pid ();
|
|
|
|
regcache_invalidate_pid (pid);
|
|
}
|
|
|
|
#endif
|
|
|
|
struct regcache *
|
|
init_register_cache (struct regcache *regcache,
|
|
const struct target_desc *tdesc,
|
|
unsigned char *regbuf)
|
|
{
|
|
if (regbuf == NULL)
|
|
{
|
|
#ifndef IN_PROCESS_AGENT
|
|
/* Make sure to zero-initialize the register cache when it is
|
|
created, in case there are registers the target never
|
|
fetches. This way they'll read as zero instead of
|
|
garbage. */
|
|
regcache->tdesc = tdesc;
|
|
regcache->registers
|
|
= (unsigned char *) xcalloc (1, tdesc->registers_size);
|
|
regcache->registers_owned = 1;
|
|
regcache->register_status
|
|
= (unsigned char *) xmalloc (tdesc->reg_defs.size ());
|
|
memset ((void *) regcache->register_status, REG_UNAVAILABLE,
|
|
tdesc->reg_defs.size ());
|
|
#else
|
|
gdb_assert_not_reached ("can't allocate memory from the heap");
|
|
#endif
|
|
}
|
|
else
|
|
{
|
|
regcache->tdesc = tdesc;
|
|
regcache->registers = regbuf;
|
|
regcache->registers_owned = 0;
|
|
#ifndef IN_PROCESS_AGENT
|
|
regcache->register_status = NULL;
|
|
#endif
|
|
}
|
|
|
|
regcache->registers_valid = 0;
|
|
|
|
return regcache;
|
|
}
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
|
|
struct regcache *
|
|
new_register_cache (const struct target_desc *tdesc)
|
|
{
|
|
struct regcache *regcache = XCNEW (struct regcache);
|
|
|
|
gdb_assert (tdesc->registers_size != 0);
|
|
|
|
return init_register_cache (regcache, tdesc, NULL);
|
|
}
|
|
|
|
void
|
|
free_register_cache (struct regcache *regcache)
|
|
{
|
|
if (regcache)
|
|
{
|
|
if (regcache->registers_owned)
|
|
free (regcache->registers);
|
|
free (regcache->register_status);
|
|
free (regcache);
|
|
}
|
|
}
|
|
|
|
#endif
|
|
|
|
void
|
|
regcache_cpy (struct regcache *dst, struct regcache *src)
|
|
{
|
|
gdb_assert (src != NULL && dst != NULL);
|
|
gdb_assert (src->tdesc == dst->tdesc);
|
|
gdb_assert (src != dst);
|
|
|
|
memcpy (dst->registers, src->registers, src->tdesc->registers_size);
|
|
#ifndef IN_PROCESS_AGENT
|
|
if (dst->register_status != NULL && src->register_status != NULL)
|
|
memcpy (dst->register_status, src->register_status,
|
|
src->tdesc->reg_defs.size ());
|
|
#endif
|
|
dst->registers_valid = src->registers_valid;
|
|
}
|
|
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
|
|
void
|
|
registers_to_string (struct regcache *regcache, char *buf)
|
|
{
|
|
unsigned char *registers = regcache->registers;
|
|
const struct target_desc *tdesc = regcache->tdesc;
|
|
|
|
for (int i = 0; i < tdesc->reg_defs.size (); ++i)
|
|
{
|
|
if (regcache->register_status[i] == REG_VALID)
|
|
{
|
|
bin2hex (registers, buf, register_size (tdesc, i));
|
|
buf += register_size (tdesc, i) * 2;
|
|
}
|
|
else
|
|
{
|
|
memset (buf, 'x', register_size (tdesc, i) * 2);
|
|
buf += register_size (tdesc, i) * 2;
|
|
}
|
|
registers += register_size (tdesc, i);
|
|
}
|
|
*buf = '\0';
|
|
}
|
|
|
|
void
|
|
registers_from_string (struct regcache *regcache, char *buf)
|
|
{
|
|
int len = strlen (buf);
|
|
unsigned char *registers = regcache->registers;
|
|
const struct target_desc *tdesc = regcache->tdesc;
|
|
|
|
if (len != tdesc->registers_size * 2)
|
|
{
|
|
warning ("Wrong sized register packet (expected %d bytes, got %d)",
|
|
2 * tdesc->registers_size, len);
|
|
if (len > tdesc->registers_size * 2)
|
|
len = tdesc->registers_size * 2;
|
|
}
|
|
hex2bin (buf, registers, len / 2);
|
|
}
|
|
|
|
int
|
|
find_regno (const struct target_desc *tdesc, const char *name)
|
|
{
|
|
for (int i = 0; i < tdesc->reg_defs.size (); ++i)
|
|
{
|
|
struct reg *reg = tdesc->reg_defs[i];
|
|
|
|
if (strcmp (name, reg->name) == 0)
|
|
return i;
|
|
}
|
|
internal_error (__FILE__, __LINE__, "Unknown register %s requested",
|
|
name);
|
|
}
|
|
|
|
#endif
|
|
|
|
struct reg *
|
|
find_register_by_number (const struct target_desc *tdesc, int n)
|
|
{
|
|
return tdesc->reg_defs[n];
|
|
}
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
static void
|
|
free_register_cache_thread (struct thread_info *thread)
|
|
{
|
|
struct regcache *regcache = thread_regcache_data (thread);
|
|
|
|
if (regcache != NULL)
|
|
{
|
|
regcache_invalidate_thread (thread);
|
|
free_register_cache (regcache);
|
|
set_thread_regcache_data (thread, NULL);
|
|
}
|
|
}
|
|
|
|
void
|
|
regcache_release (void)
|
|
{
|
|
/* Flush and release all pre-existing register caches. */
|
|
for_each_thread (free_register_cache_thread);
|
|
}
|
|
#endif
|
|
|
|
int
|
|
register_cache_size (const struct target_desc *tdesc)
|
|
{
|
|
return tdesc->registers_size;
|
|
}
|
|
|
|
int
|
|
register_size (const struct target_desc *tdesc, int n)
|
|
{
|
|
return find_register_by_number (tdesc, n)->size / 8;
|
|
}
|
|
|
|
/* See common/common-regcache.h. */
|
|
|
|
int
|
|
regcache_register_size (const struct regcache *regcache, int n)
|
|
{
|
|
return register_size (regcache->tdesc, n);
|
|
}
|
|
|
|
static unsigned char *
|
|
register_data (struct regcache *regcache, int n, int fetch)
|
|
{
|
|
return (regcache->registers
|
|
+ find_register_by_number (regcache->tdesc, n)->offset / 8);
|
|
}
|
|
|
|
/* Supply register N, whose contents are stored in BUF, to REGCACHE.
|
|
If BUF is NULL, the register's value is recorded as
|
|
unavailable. */
|
|
|
|
void
|
|
supply_register (struct regcache *regcache, int n, const void *buf)
|
|
{
|
|
if (buf)
|
|
{
|
|
memcpy (register_data (regcache, n, 0), buf,
|
|
register_size (regcache->tdesc, n));
|
|
#ifndef IN_PROCESS_AGENT
|
|
if (regcache->register_status != NULL)
|
|
regcache->register_status[n] = REG_VALID;
|
|
#endif
|
|
}
|
|
else
|
|
{
|
|
memset (register_data (regcache, n, 0), 0,
|
|
register_size (regcache->tdesc, n));
|
|
#ifndef IN_PROCESS_AGENT
|
|
if (regcache->register_status != NULL)
|
|
regcache->register_status[n] = REG_UNAVAILABLE;
|
|
#endif
|
|
}
|
|
}
|
|
|
|
/* Supply register N with value zero to REGCACHE. */
|
|
|
|
void
|
|
supply_register_zeroed (struct regcache *regcache, int n)
|
|
{
|
|
memset (register_data (regcache, n, 0), 0,
|
|
register_size (regcache->tdesc, n));
|
|
#ifndef IN_PROCESS_AGENT
|
|
if (regcache->register_status != NULL)
|
|
regcache->register_status[n] = REG_VALID;
|
|
#endif
|
|
}
|
|
|
|
/* Supply the whole register set whose contents are stored in BUF, to
|
|
REGCACHE. If BUF is NULL, all the registers' values are recorded
|
|
as unavailable. */
|
|
|
|
void
|
|
supply_regblock (struct regcache *regcache, const void *buf)
|
|
{
|
|
if (buf)
|
|
{
|
|
const struct target_desc *tdesc = regcache->tdesc;
|
|
|
|
memcpy (regcache->registers, buf, tdesc->registers_size);
|
|
#ifndef IN_PROCESS_AGENT
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < tdesc->reg_defs.size (); i++)
|
|
regcache->register_status[i] = REG_VALID;
|
|
}
|
|
#endif
|
|
}
|
|
else
|
|
{
|
|
const struct target_desc *tdesc = regcache->tdesc;
|
|
|
|
memset (regcache->registers, 0, tdesc->registers_size);
|
|
#ifndef IN_PROCESS_AGENT
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < tdesc->reg_defs.size (); i++)
|
|
regcache->register_status[i] = REG_UNAVAILABLE;
|
|
}
|
|
#endif
|
|
}
|
|
}
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
|
|
void
|
|
supply_register_by_name (struct regcache *regcache,
|
|
const char *name, const void *buf)
|
|
{
|
|
supply_register (regcache, find_regno (regcache->tdesc, name), buf);
|
|
}
|
|
|
|
#endif
|
|
|
|
void
|
|
collect_register (struct regcache *regcache, int n, void *buf)
|
|
{
|
|
memcpy (buf, register_data (regcache, n, 1),
|
|
register_size (regcache->tdesc, n));
|
|
}
|
|
|
|
enum register_status
|
|
regcache_raw_read_unsigned (struct regcache *regcache, int regnum,
|
|
ULONGEST *val)
|
|
{
|
|
int size;
|
|
|
|
gdb_assert (regcache != NULL);
|
|
gdb_assert (regnum >= 0
|
|
&& regnum < regcache->tdesc->reg_defs.size ());
|
|
|
|
size = register_size (regcache->tdesc, regnum);
|
|
|
|
if (size > (int) sizeof (ULONGEST))
|
|
error (_("That operation is not available on integers of more than"
|
|
"%d bytes."),
|
|
(int) sizeof (ULONGEST));
|
|
|
|
*val = 0;
|
|
collect_register (regcache, regnum, val);
|
|
|
|
return REG_VALID;
|
|
}
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
|
|
void
|
|
collect_register_as_string (struct regcache *regcache, int n, char *buf)
|
|
{
|
|
bin2hex (register_data (regcache, n, 1), buf,
|
|
register_size (regcache->tdesc, n));
|
|
}
|
|
|
|
void
|
|
collect_register_by_name (struct regcache *regcache,
|
|
const char *name, void *buf)
|
|
{
|
|
collect_register (regcache, find_regno (regcache->tdesc, name), buf);
|
|
}
|
|
|
|
/* Special handling for register PC. */
|
|
|
|
CORE_ADDR
|
|
regcache_read_pc (struct regcache *regcache)
|
|
{
|
|
CORE_ADDR pc_val;
|
|
|
|
if (the_target->read_pc)
|
|
pc_val = the_target->read_pc (regcache);
|
|
else
|
|
internal_error (__FILE__, __LINE__,
|
|
"regcache_read_pc: Unable to find PC");
|
|
|
|
return pc_val;
|
|
}
|
|
|
|
void
|
|
regcache_write_pc (struct regcache *regcache, CORE_ADDR pc)
|
|
{
|
|
if (the_target->write_pc)
|
|
the_target->write_pc (regcache, pc);
|
|
else
|
|
internal_error (__FILE__, __LINE__,
|
|
"regcache_write_pc: Unable to update PC");
|
|
}
|
|
|
|
#endif
|