mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-24 18:44:20 +08:00
6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
916 lines
28 KiB
C
916 lines
28 KiB
C
/* DTrace probe support for GDB.
|
|
|
|
Copyright (C) 2014-2020 Free Software Foundation, Inc.
|
|
|
|
Contributed by Oracle, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "probe.h"
|
|
#include "elf-bfd.h"
|
|
#include "gdbtypes.h"
|
|
#include "obstack.h"
|
|
#include "objfiles.h"
|
|
#include "complaints.h"
|
|
#include "value.h"
|
|
#include "ax.h"
|
|
#include "ax-gdb.h"
|
|
#include "language.h"
|
|
#include "parser-defs.h"
|
|
#include "inferior.h"
|
|
|
|
/* The type of the ELF sections where we will find the DOF programs
|
|
with information about probes. */
|
|
|
|
#ifndef SHT_SUNW_dof
|
|
# define SHT_SUNW_dof 0x6ffffff4
|
|
#endif
|
|
|
|
/* The following structure represents a single argument for the
|
|
probe. */
|
|
|
|
struct dtrace_probe_arg
|
|
{
|
|
dtrace_probe_arg (struct type *type_, std::string &&type_str_,
|
|
expression_up &&expr_)
|
|
: type (type_), type_str (std::move (type_str_)),
|
|
expr (std::move (expr_))
|
|
{}
|
|
|
|
/* The type of the probe argument. */
|
|
struct type *type;
|
|
|
|
/* A string describing the type. */
|
|
std::string type_str;
|
|
|
|
/* The argument converted to an internal GDB expression. */
|
|
expression_up expr;
|
|
};
|
|
|
|
/* The following structure represents an enabler for a probe. */
|
|
|
|
struct dtrace_probe_enabler
|
|
{
|
|
/* Program counter where the is-enabled probe is installed. The
|
|
contents (nops, whatever...) stored at this address are
|
|
architecture dependent. */
|
|
CORE_ADDR address;
|
|
};
|
|
|
|
/* Class that implements the static probe methods for "stap" probes. */
|
|
|
|
class dtrace_static_probe_ops : public static_probe_ops
|
|
{
|
|
public:
|
|
/* See probe.h. */
|
|
bool is_linespec (const char **linespecp) const override;
|
|
|
|
/* See probe.h. */
|
|
void get_probes (std::vector<std::unique_ptr<probe>> *probesp,
|
|
struct objfile *objfile) const override;
|
|
|
|
/* See probe.h. */
|
|
const char *type_name () const override;
|
|
|
|
/* See probe.h. */
|
|
bool can_enable () const override
|
|
{
|
|
return true;
|
|
}
|
|
|
|
/* See probe.h. */
|
|
std::vector<struct info_probe_column> gen_info_probes_table_header
|
|
() const override;
|
|
};
|
|
|
|
/* DTrace static_probe_ops. */
|
|
|
|
const dtrace_static_probe_ops dtrace_static_probe_ops {};
|
|
|
|
/* The following structure represents a dtrace probe. */
|
|
|
|
class dtrace_probe : public probe
|
|
{
|
|
public:
|
|
/* Constructor for dtrace_probe. */
|
|
dtrace_probe (std::string &&name_, std::string &&provider_, CORE_ADDR address_,
|
|
struct gdbarch *arch_,
|
|
std::vector<struct dtrace_probe_arg> &&args_,
|
|
std::vector<struct dtrace_probe_enabler> &&enablers_)
|
|
: probe (std::move (name_), std::move (provider_), address_, arch_),
|
|
m_args (std::move (args_)),
|
|
m_enablers (std::move (enablers_)),
|
|
m_args_expr_built (false)
|
|
{}
|
|
|
|
/* See probe.h. */
|
|
CORE_ADDR get_relocated_address (struct objfile *objfile) override;
|
|
|
|
/* See probe.h. */
|
|
unsigned get_argument_count (struct gdbarch *gdbarch) override;
|
|
|
|
/* See probe.h. */
|
|
bool can_evaluate_arguments () const override;
|
|
|
|
/* See probe.h. */
|
|
struct value *evaluate_argument (unsigned n,
|
|
struct frame_info *frame) override;
|
|
|
|
/* See probe.h. */
|
|
void compile_to_ax (struct agent_expr *aexpr,
|
|
struct axs_value *axs_value,
|
|
unsigned n) override;
|
|
|
|
/* See probe.h. */
|
|
const static_probe_ops *get_static_ops () const override;
|
|
|
|
/* See probe.h. */
|
|
std::vector<const char *> gen_info_probes_table_values () const override;
|
|
|
|
/* See probe.h. */
|
|
void enable () override;
|
|
|
|
/* See probe.h. */
|
|
void disable () override;
|
|
|
|
/* Return the Nth argument of the probe. */
|
|
struct dtrace_probe_arg *get_arg_by_number (unsigned n,
|
|
struct gdbarch *gdbarch);
|
|
|
|
/* Build the GDB internal expression that, once evaluated, will
|
|
calculate the values of the arguments of the probe. */
|
|
void build_arg_exprs (struct gdbarch *gdbarch);
|
|
|
|
/* Determine whether the probe is "enabled" or "disabled". A
|
|
disabled probe is a probe in which one or more enablers are
|
|
disabled. */
|
|
bool is_enabled () const;
|
|
|
|
private:
|
|
/* A probe can have zero or more arguments. */
|
|
std::vector<struct dtrace_probe_arg> m_args;
|
|
|
|
/* A probe can have zero or more "enablers" associated with it. */
|
|
std::vector<struct dtrace_probe_enabler> m_enablers;
|
|
|
|
/* Whether the expressions for the arguments have been built. */
|
|
bool m_args_expr_built;
|
|
};
|
|
|
|
/* DOF programs can contain an arbitrary number of sections of 26
|
|
different types. In order to support DTrace USDT probes we only
|
|
need to handle a subset of these section types, fortunately. These
|
|
section types are defined in the following enumeration.
|
|
|
|
See linux/dtrace/dof_defines.h for a complete list of section types
|
|
along with their values. */
|
|
|
|
enum dtrace_dof_sect_type
|
|
{
|
|
/* Null section. */
|
|
DTRACE_DOF_SECT_TYPE_NONE = 0,
|
|
/* A dof_ecbdesc_t. */
|
|
DTRACE_DOF_SECT_TYPE_ECBDESC = 3,
|
|
/* A string table. */
|
|
DTRACE_DOF_SECT_TYPE_STRTAB = 8,
|
|
/* A dof_provider_t */
|
|
DTRACE_DOF_SECT_TYPE_PROVIDER = 15,
|
|
/* Array of dof_probe_t */
|
|
DTRACE_DOF_SECT_TYPE_PROBES = 16,
|
|
/* An array of probe arg mappings. */
|
|
DTRACE_DOF_SECT_TYPE_PRARGS = 17,
|
|
/* An array of probe arg offsets. */
|
|
DTRACE_DOF_SECT_TYPE_PROFFS = 18,
|
|
/* An array of probe is-enabled offsets. */
|
|
DTRACE_DOF_SECT_TYPE_PRENOFFS = 26
|
|
};
|
|
|
|
/* The following collection of data structures map the structure of
|
|
DOF entities. Again, we only cover the subset of DOF used to
|
|
implement USDT probes.
|
|
|
|
See linux/dtrace/dof.h header for a complete list of data
|
|
structures. */
|
|
|
|
/* Offsets to index the dofh_ident[] array defined below. */
|
|
|
|
enum dtrace_dof_ident
|
|
{
|
|
/* First byte of the magic number. */
|
|
DTRACE_DOF_ID_MAG0 = 0,
|
|
/* Second byte of the magic number. */
|
|
DTRACE_DOF_ID_MAG1 = 1,
|
|
/* Third byte of the magic number. */
|
|
DTRACE_DOF_ID_MAG2 = 2,
|
|
/* Fourth byte of the magic number. */
|
|
DTRACE_DOF_ID_MAG3 = 3,
|
|
/* An enum_dof_encoding value. */
|
|
DTRACE_DOF_ID_ENCODING = 5
|
|
};
|
|
|
|
/* Possible values for dofh_ident[DOF_ID_ENCODING]. */
|
|
|
|
enum dtrace_dof_encoding
|
|
{
|
|
/* The DOF program is little-endian. */
|
|
DTRACE_DOF_ENCODE_LSB = 1,
|
|
/* The DOF program is big-endian. */
|
|
DTRACE_DOF_ENCODE_MSB = 2
|
|
};
|
|
|
|
/* A DOF header, which describes the contents of a DOF program: number
|
|
of sections, size, etc. */
|
|
|
|
struct dtrace_dof_hdr
|
|
{
|
|
/* Identification bytes (see above). */
|
|
uint8_t dofh_ident[16];
|
|
/* File attribute flags (if any). */
|
|
uint32_t dofh_flags;
|
|
/* Size of file header in bytes. */
|
|
uint32_t dofh_hdrsize;
|
|
/* Size of section header in bytes. */
|
|
uint32_t dofh_secsize;
|
|
/* Number of section headers. */
|
|
uint32_t dofh_secnum;
|
|
/* File offset of section headers. */
|
|
uint64_t dofh_secoff;
|
|
/* File size of loadable portion. */
|
|
uint64_t dofh_loadsz;
|
|
/* File size of entire DOF file. */
|
|
uint64_t dofh_filesz;
|
|
/* Reserved for future use. */
|
|
uint64_t dofh_pad;
|
|
};
|
|
|
|
/* A DOF section, whose contents depend on its type. The several
|
|
supported section types are described in the enum
|
|
dtrace_dof_sect_type above. */
|
|
|
|
struct dtrace_dof_sect
|
|
{
|
|
/* Section type (see the define above). */
|
|
uint32_t dofs_type;
|
|
/* Section data memory alignment. */
|
|
uint32_t dofs_align;
|
|
/* Section flags (if any). */
|
|
uint32_t dofs_flags;
|
|
/* Size of section entry (if table). */
|
|
uint32_t dofs_entsize;
|
|
/* DOF + offset points to the section data. */
|
|
uint64_t dofs_offset;
|
|
/* Size of section data in bytes. */
|
|
uint64_t dofs_size;
|
|
};
|
|
|
|
/* A DOF provider, which is the provider of a probe. */
|
|
|
|
struct dtrace_dof_provider
|
|
{
|
|
/* Link to a DTRACE_DOF_SECT_TYPE_STRTAB section. */
|
|
uint32_t dofpv_strtab;
|
|
/* Link to a DTRACE_DOF_SECT_TYPE_PROBES section. */
|
|
uint32_t dofpv_probes;
|
|
/* Link to a DTRACE_DOF_SECT_TYPE_PRARGS section. */
|
|
uint32_t dofpv_prargs;
|
|
/* Link to a DTRACE_DOF_SECT_TYPE_PROFFS section. */
|
|
uint32_t dofpv_proffs;
|
|
/* Provider name string. */
|
|
uint32_t dofpv_name;
|
|
/* Provider attributes. */
|
|
uint32_t dofpv_provattr;
|
|
/* Module attributes. */
|
|
uint32_t dofpv_modattr;
|
|
/* Function attributes. */
|
|
uint32_t dofpv_funcattr;
|
|
/* Name attributes. */
|
|
uint32_t dofpv_nameattr;
|
|
/* Args attributes. */
|
|
uint32_t dofpv_argsattr;
|
|
/* Link to a DTRACE_DOF_SECT_PRENOFFS section. */
|
|
uint32_t dofpv_prenoffs;
|
|
};
|
|
|
|
/* A set of DOF probes and is-enabled probes sharing a base address
|
|
and several attributes. The particular locations and attributes of
|
|
each probe are maintained in arrays in several other DOF sections.
|
|
See the comment in dtrace_process_dof_probe for details on how
|
|
these attributes are stored. */
|
|
|
|
struct dtrace_dof_probe
|
|
{
|
|
/* Probe base address or offset. */
|
|
uint64_t dofpr_addr;
|
|
/* Probe function string. */
|
|
uint32_t dofpr_func;
|
|
/* Probe name string. */
|
|
uint32_t dofpr_name;
|
|
/* Native argument type strings. */
|
|
uint32_t dofpr_nargv;
|
|
/* Translated argument type strings. */
|
|
uint32_t dofpr_xargv;
|
|
/* Index of first argument mapping. */
|
|
uint32_t dofpr_argidx;
|
|
/* Index of first offset entry. */
|
|
uint32_t dofpr_offidx;
|
|
/* Native argument count. */
|
|
uint8_t dofpr_nargc;
|
|
/* Translated argument count. */
|
|
uint8_t dofpr_xargc;
|
|
/* Number of offset entries for probe. */
|
|
uint16_t dofpr_noffs;
|
|
/* Index of first is-enabled offset. */
|
|
uint32_t dofpr_enoffidx;
|
|
/* Number of is-enabled offsets. */
|
|
uint16_t dofpr_nenoffs;
|
|
/* Reserved for future use. */
|
|
uint16_t dofpr_pad1;
|
|
/* Reserved for future use. */
|
|
uint32_t dofpr_pad2;
|
|
};
|
|
|
|
/* DOF supports two different encodings: MSB (big-endian) and LSB
|
|
(little-endian). The encoding is itself encoded in the DOF header.
|
|
The following function returns an unsigned value in the host
|
|
endianness. */
|
|
|
|
#define DOF_UINT(dof, field) \
|
|
extract_unsigned_integer ((gdb_byte *) &(field), \
|
|
sizeof ((field)), \
|
|
(((dof)->dofh_ident[DTRACE_DOF_ID_ENCODING] \
|
|
== DTRACE_DOF_ENCODE_MSB) \
|
|
? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE))
|
|
|
|
/* The following macro applies a given byte offset to a DOF (a pointer
|
|
to a dtrace_dof_hdr structure) and returns the resulting
|
|
address. */
|
|
|
|
#define DTRACE_DOF_PTR(dof, offset) (&((char *) (dof))[(offset)])
|
|
|
|
/* The following macro returns a pointer to the beginning of a given
|
|
section in a DOF object. The section is referred to by its index
|
|
in the sections array. */
|
|
|
|
#define DTRACE_DOF_SECT(dof, idx) \
|
|
((struct dtrace_dof_sect *) \
|
|
DTRACE_DOF_PTR ((dof), \
|
|
DOF_UINT ((dof), (dof)->dofh_secoff) \
|
|
+ ((idx) * DOF_UINT ((dof), (dof)->dofh_secsize))))
|
|
|
|
/* Helper function to examine the probe described by the given PROBE
|
|
and PROVIDER data structures and add it to the PROBESP vector.
|
|
STRTAB, OFFTAB, EOFFTAB and ARGTAB are pointers to tables in the
|
|
DOF program containing the attributes for the probe. */
|
|
|
|
static void
|
|
dtrace_process_dof_probe (struct objfile *objfile,
|
|
struct gdbarch *gdbarch,
|
|
std::vector<std::unique_ptr<probe>> *probesp,
|
|
struct dtrace_dof_hdr *dof,
|
|
struct dtrace_dof_probe *probe,
|
|
struct dtrace_dof_provider *provider,
|
|
char *strtab, char *offtab, char *eofftab,
|
|
char *argtab, uint64_t strtab_size)
|
|
{
|
|
int i, j, num_probes, num_enablers;
|
|
char *p;
|
|
|
|
/* Each probe section can define zero or more probes of two
|
|
different types:
|
|
|
|
- probe->dofpr_noffs regular probes whose program counters are
|
|
stored in 32bit words starting at probe->dofpr_addr +
|
|
offtab[probe->dofpr_offidx].
|
|
|
|
- probe->dofpr_nenoffs is-enabled probes whose program counters
|
|
are stored in 32bit words starting at probe->dofpr_addr +
|
|
eofftab[probe->dofpr_enoffidx].
|
|
|
|
However is-enabled probes are not probes per-se, but an
|
|
optimization hack that is implemented in the kernel in a very
|
|
similar way than normal probes. This is how we support
|
|
is-enabled probes on GDB:
|
|
|
|
- Our probes are always DTrace regular probes.
|
|
|
|
- Our probes can be associated with zero or more "enablers". The
|
|
list of enablers is built from the is-enabled probes defined in
|
|
the Probe section.
|
|
|
|
- Probes having a non-empty list of enablers can be enabled or
|
|
disabled using the `enable probe' and `disable probe' commands
|
|
respectively. The `Enabled' column in the output of `info
|
|
probes' will read `yes' if the enablers are activated, `no'
|
|
otherwise.
|
|
|
|
- Probes having an empty list of enablers are always enabled.
|
|
The `Enabled' column in the output of `info probes' will
|
|
read `always'.
|
|
|
|
It follows that if there are DTrace is-enabled probes defined for
|
|
some provider/name but no DTrace regular probes defined then the
|
|
GDB user wont be able to enable/disable these conditionals. */
|
|
|
|
num_probes = DOF_UINT (dof, probe->dofpr_noffs);
|
|
if (num_probes == 0)
|
|
return;
|
|
|
|
/* Build the list of enablers for the probes defined in this Probe
|
|
DOF section. */
|
|
std::vector<struct dtrace_probe_enabler> enablers;
|
|
num_enablers = DOF_UINT (dof, probe->dofpr_nenoffs);
|
|
for (i = 0; i < num_enablers; i++)
|
|
{
|
|
struct dtrace_probe_enabler enabler;
|
|
uint32_t enabler_offset
|
|
= ((uint32_t *) eofftab)[DOF_UINT (dof, probe->dofpr_enoffidx) + i];
|
|
|
|
enabler.address = DOF_UINT (dof, probe->dofpr_addr)
|
|
+ DOF_UINT (dof, enabler_offset);
|
|
enablers.push_back (enabler);
|
|
}
|
|
|
|
for (i = 0; i < num_probes; i++)
|
|
{
|
|
uint32_t probe_offset
|
|
= ((uint32_t *) offtab)[DOF_UINT (dof, probe->dofpr_offidx) + i];
|
|
|
|
/* Set the provider and the name of the probe. */
|
|
const char *probe_provider
|
|
= strtab + DOF_UINT (dof, provider->dofpv_name);
|
|
const char *name = strtab + DOF_UINT (dof, probe->dofpr_name);
|
|
|
|
/* The probe address. */
|
|
CORE_ADDR address
|
|
= DOF_UINT (dof, probe->dofpr_addr) + DOF_UINT (dof, probe_offset);
|
|
|
|
/* Number of arguments in the probe. */
|
|
int probe_argc = DOF_UINT (dof, probe->dofpr_nargc);
|
|
|
|
/* Store argument type descriptions. A description of the type
|
|
of the argument is in the (J+1)th null-terminated string
|
|
starting at 'strtab' + 'probe->dofpr_nargv'. */
|
|
std::vector<struct dtrace_probe_arg> args;
|
|
p = strtab + DOF_UINT (dof, probe->dofpr_nargv);
|
|
for (j = 0; j < probe_argc; j++)
|
|
{
|
|
expression_up expr;
|
|
|
|
/* Set arg.expr to ensure all fields in expr are initialized and
|
|
the compiler will not warn when arg is used. */
|
|
std::string type_str (p);
|
|
|
|
/* Use strtab_size as a sentinel. */
|
|
while (*p++ != '\0' && p - strtab < strtab_size)
|
|
;
|
|
|
|
/* Try to parse a type expression from the type string. If
|
|
this does not work then we set the type to `long
|
|
int'. */
|
|
struct type *type = builtin_type (gdbarch)->builtin_long;
|
|
|
|
try
|
|
{
|
|
expr = parse_expression_with_language (type_str.c_str (),
|
|
language_c);
|
|
}
|
|
catch (const gdb_exception_error &ex)
|
|
{
|
|
}
|
|
|
|
if (expr != NULL && expr.get ()->elts[0].opcode == OP_TYPE)
|
|
type = expr.get ()->elts[1].type;
|
|
|
|
args.emplace_back (type, std::move (type_str), std::move (expr));
|
|
}
|
|
|
|
std::vector<struct dtrace_probe_enabler> enablers_copy = enablers;
|
|
dtrace_probe *ret = new dtrace_probe (std::string (name),
|
|
std::string (probe_provider),
|
|
address, gdbarch,
|
|
std::move (args),
|
|
std::move (enablers_copy));
|
|
|
|
/* Successfully created probe. */
|
|
probesp->emplace_back (ret);
|
|
}
|
|
}
|
|
|
|
/* Helper function to collect the probes described in the DOF program
|
|
whose header is pointed by DOF and add them to the PROBESP vector.
|
|
SECT is the ELF section containing the DOF program and OBJFILE is
|
|
its containing object file. */
|
|
|
|
static void
|
|
dtrace_process_dof (asection *sect, struct objfile *objfile,
|
|
std::vector<std::unique_ptr<probe>> *probesp,
|
|
struct dtrace_dof_hdr *dof)
|
|
{
|
|
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
|
struct dtrace_dof_sect *section;
|
|
int i;
|
|
|
|
/* The first step is to check for the DOF magic number. If no valid
|
|
DOF data is found in the section then a complaint is issued to
|
|
the user and the section skipped. */
|
|
if (dof->dofh_ident[DTRACE_DOF_ID_MAG0] != 0x7F
|
|
|| dof->dofh_ident[DTRACE_DOF_ID_MAG1] != 'D'
|
|
|| dof->dofh_ident[DTRACE_DOF_ID_MAG2] != 'O'
|
|
|| dof->dofh_ident[DTRACE_DOF_ID_MAG3] != 'F')
|
|
goto invalid_dof_data;
|
|
|
|
/* Make sure the encoding mark is either DTRACE_DOF_ENCODE_LSB or
|
|
DTRACE_DOF_ENCODE_MSB. */
|
|
if (dof->dofh_ident[DTRACE_DOF_ID_ENCODING] != DTRACE_DOF_ENCODE_LSB
|
|
&& dof->dofh_ident[DTRACE_DOF_ID_ENCODING] != DTRACE_DOF_ENCODE_MSB)
|
|
goto invalid_dof_data;
|
|
|
|
/* Make sure this DOF is not an enabling DOF, i.e. there are no ECB
|
|
Description sections. */
|
|
section = (struct dtrace_dof_sect *) DTRACE_DOF_PTR (dof,
|
|
DOF_UINT (dof, dof->dofh_secoff));
|
|
for (i = 0; i < DOF_UINT (dof, dof->dofh_secnum); i++, section++)
|
|
if (section->dofs_type == DTRACE_DOF_SECT_TYPE_ECBDESC)
|
|
return;
|
|
|
|
/* Iterate over any section of type Provider and extract the probe
|
|
information from them. If there are no "provider" sections on
|
|
the DOF then we just return. */
|
|
section = (struct dtrace_dof_sect *) DTRACE_DOF_PTR (dof,
|
|
DOF_UINT (dof, dof->dofh_secoff));
|
|
for (i = 0; i < DOF_UINT (dof, dof->dofh_secnum); i++, section++)
|
|
if (DOF_UINT (dof, section->dofs_type) == DTRACE_DOF_SECT_TYPE_PROVIDER)
|
|
{
|
|
struct dtrace_dof_provider *provider = (struct dtrace_dof_provider *)
|
|
DTRACE_DOF_PTR (dof, DOF_UINT (dof, section->dofs_offset));
|
|
struct dtrace_dof_sect *strtab_s
|
|
= DTRACE_DOF_SECT (dof, DOF_UINT (dof, provider->dofpv_strtab));
|
|
struct dtrace_dof_sect *probes_s
|
|
= DTRACE_DOF_SECT (dof, DOF_UINT (dof, provider->dofpv_probes));
|
|
struct dtrace_dof_sect *args_s
|
|
= DTRACE_DOF_SECT (dof, DOF_UINT (dof, provider->dofpv_prargs));
|
|
struct dtrace_dof_sect *offsets_s
|
|
= DTRACE_DOF_SECT (dof, DOF_UINT (dof, provider->dofpv_proffs));
|
|
struct dtrace_dof_sect *eoffsets_s
|
|
= DTRACE_DOF_SECT (dof, DOF_UINT (dof, provider->dofpv_prenoffs));
|
|
char *strtab = DTRACE_DOF_PTR (dof, DOF_UINT (dof, strtab_s->dofs_offset));
|
|
char *offtab = DTRACE_DOF_PTR (dof, DOF_UINT (dof, offsets_s->dofs_offset));
|
|
char *eofftab = DTRACE_DOF_PTR (dof, DOF_UINT (dof, eoffsets_s->dofs_offset));
|
|
char *argtab = DTRACE_DOF_PTR (dof, DOF_UINT (dof, args_s->dofs_offset));
|
|
unsigned int entsize = DOF_UINT (dof, probes_s->dofs_entsize);
|
|
int num_probes;
|
|
|
|
if (DOF_UINT (dof, section->dofs_size)
|
|
< sizeof (struct dtrace_dof_provider))
|
|
{
|
|
/* The section is smaller than expected, so do not use it.
|
|
This has been observed on x86-solaris 10. */
|
|
goto invalid_dof_data;
|
|
}
|
|
|
|
/* Very, unlikely, but could crash gdb if not handled
|
|
properly. */
|
|
if (entsize == 0)
|
|
goto invalid_dof_data;
|
|
|
|
num_probes = DOF_UINT (dof, probes_s->dofs_size) / entsize;
|
|
|
|
for (i = 0; i < num_probes; i++)
|
|
{
|
|
struct dtrace_dof_probe *probe = (struct dtrace_dof_probe *)
|
|
DTRACE_DOF_PTR (dof, DOF_UINT (dof, probes_s->dofs_offset)
|
|
+ (i * DOF_UINT (dof, probes_s->dofs_entsize)));
|
|
|
|
dtrace_process_dof_probe (objfile,
|
|
gdbarch, probesp,
|
|
dof, probe,
|
|
provider, strtab, offtab, eofftab, argtab,
|
|
DOF_UINT (dof, strtab_s->dofs_size));
|
|
}
|
|
}
|
|
|
|
return;
|
|
|
|
invalid_dof_data:
|
|
complaint (_("skipping section '%s' which does not contain valid DOF data."),
|
|
sect->name);
|
|
}
|
|
|
|
/* Implementation of 'build_arg_exprs' method. */
|
|
|
|
void
|
|
dtrace_probe::build_arg_exprs (struct gdbarch *gdbarch)
|
|
{
|
|
size_t argc = 0;
|
|
m_args_expr_built = true;
|
|
|
|
/* Iterate over the arguments in the probe and build the
|
|
corresponding GDB internal expression that will generate the
|
|
value of the argument when executed at the PC of the probe. */
|
|
for (dtrace_probe_arg &arg : m_args)
|
|
{
|
|
/* Initialize the expression builder. The language does not
|
|
matter, since we are using our own parser. */
|
|
expr_builder builder (current_language, gdbarch);
|
|
|
|
/* The argument value, which is ABI dependent and casted to
|
|
`long int'. */
|
|
gdbarch_dtrace_parse_probe_argument (gdbarch, &builder, argc);
|
|
|
|
/* Casting to the expected type, but only if the type was
|
|
recognized at probe load time. Otherwise the argument will
|
|
be evaluated as the long integer passed to the probe. */
|
|
if (arg.type != NULL)
|
|
{
|
|
write_exp_elt_opcode (&builder, UNOP_CAST);
|
|
write_exp_elt_type (&builder, arg.type);
|
|
write_exp_elt_opcode (&builder, UNOP_CAST);
|
|
}
|
|
|
|
arg.expr = builder.release ();
|
|
prefixify_expression (arg.expr.get ());
|
|
++argc;
|
|
}
|
|
}
|
|
|
|
/* Implementation of 'get_arg_by_number' method. */
|
|
|
|
struct dtrace_probe_arg *
|
|
dtrace_probe::get_arg_by_number (unsigned n, struct gdbarch *gdbarch)
|
|
{
|
|
if (!m_args_expr_built)
|
|
this->build_arg_exprs (gdbarch);
|
|
|
|
if (n > m_args.size ())
|
|
internal_error (__FILE__, __LINE__,
|
|
_("Probe '%s' has %d arguments, but GDB is requesting\n"
|
|
"argument %u. This should not happen. Please\n"
|
|
"report this bug."),
|
|
this->get_name ().c_str (),
|
|
(int) m_args.size (), n);
|
|
|
|
return &m_args[n];
|
|
}
|
|
|
|
/* Implementation of the probe is_enabled method. */
|
|
|
|
bool
|
|
dtrace_probe::is_enabled () const
|
|
{
|
|
struct gdbarch *gdbarch = this->get_gdbarch ();
|
|
|
|
for (const dtrace_probe_enabler &enabler : m_enablers)
|
|
if (!gdbarch_dtrace_probe_is_enabled (gdbarch, enabler.address))
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
/* Implementation of the get_probe_address method. */
|
|
|
|
CORE_ADDR
|
|
dtrace_probe::get_relocated_address (struct objfile *objfile)
|
|
{
|
|
return (this->get_address ()
|
|
+ objfile->section_offsets[SECT_OFF_DATA (objfile)]);
|
|
}
|
|
|
|
/* Implementation of the get_argument_count method. */
|
|
|
|
unsigned
|
|
dtrace_probe::get_argument_count (struct gdbarch *gdbarch)
|
|
{
|
|
return m_args.size ();
|
|
}
|
|
|
|
/* Implementation of the can_evaluate_arguments method. */
|
|
|
|
bool
|
|
dtrace_probe::can_evaluate_arguments () const
|
|
{
|
|
struct gdbarch *gdbarch = this->get_gdbarch ();
|
|
|
|
return gdbarch_dtrace_parse_probe_argument_p (gdbarch);
|
|
}
|
|
|
|
/* Implementation of the evaluate_argument method. */
|
|
|
|
struct value *
|
|
dtrace_probe::evaluate_argument (unsigned n,
|
|
struct frame_info *frame)
|
|
{
|
|
struct gdbarch *gdbarch = this->get_gdbarch ();
|
|
struct dtrace_probe_arg *arg;
|
|
int pos = 0;
|
|
|
|
arg = this->get_arg_by_number (n, gdbarch);
|
|
return evaluate_subexp_standard (arg->type, arg->expr.get (), &pos,
|
|
EVAL_NORMAL);
|
|
}
|
|
|
|
/* Implementation of the compile_to_ax method. */
|
|
|
|
void
|
|
dtrace_probe::compile_to_ax (struct agent_expr *expr, struct axs_value *value,
|
|
unsigned n)
|
|
{
|
|
struct dtrace_probe_arg *arg;
|
|
union exp_element *pc;
|
|
|
|
arg = this->get_arg_by_number (n, expr->gdbarch);
|
|
|
|
pc = arg->expr->elts;
|
|
gen_expr (arg->expr.get (), &pc, expr, value);
|
|
|
|
require_rvalue (expr, value);
|
|
value->type = arg->type;
|
|
}
|
|
|
|
/* Implementation of the 'get_static_ops' method. */
|
|
|
|
const static_probe_ops *
|
|
dtrace_probe::get_static_ops () const
|
|
{
|
|
return &dtrace_static_probe_ops;
|
|
}
|
|
|
|
/* Implementation of the gen_info_probes_table_values method. */
|
|
|
|
std::vector<const char *>
|
|
dtrace_probe::gen_info_probes_table_values () const
|
|
{
|
|
const char *val = NULL;
|
|
|
|
if (m_enablers.empty ())
|
|
val = "always";
|
|
else if (!gdbarch_dtrace_probe_is_enabled_p (this->get_gdbarch ()))
|
|
val = "unknown";
|
|
else if (this->is_enabled ())
|
|
val = "yes";
|
|
else
|
|
val = "no";
|
|
|
|
return std::vector<const char *> { val };
|
|
}
|
|
|
|
/* Implementation of the enable method. */
|
|
|
|
void
|
|
dtrace_probe::enable ()
|
|
{
|
|
struct gdbarch *gdbarch = this->get_gdbarch ();
|
|
|
|
/* Enabling a dtrace probe implies patching the text section of the
|
|
running process, so make sure the inferior is indeed running. */
|
|
if (inferior_ptid == null_ptid)
|
|
error (_("No inferior running"));
|
|
|
|
/* Fast path. */
|
|
if (this->is_enabled ())
|
|
return;
|
|
|
|
/* Iterate over all defined enabler in the given probe and enable
|
|
them all using the corresponding gdbarch hook. */
|
|
for (const dtrace_probe_enabler &enabler : m_enablers)
|
|
if (gdbarch_dtrace_enable_probe_p (gdbarch))
|
|
gdbarch_dtrace_enable_probe (gdbarch, enabler.address);
|
|
}
|
|
|
|
|
|
/* Implementation of the disable_probe method. */
|
|
|
|
void
|
|
dtrace_probe::disable ()
|
|
{
|
|
struct gdbarch *gdbarch = this->get_gdbarch ();
|
|
|
|
/* Disabling a dtrace probe implies patching the text section of the
|
|
running process, so make sure the inferior is indeed running. */
|
|
if (inferior_ptid == null_ptid)
|
|
error (_("No inferior running"));
|
|
|
|
/* Fast path. */
|
|
if (!this->is_enabled ())
|
|
return;
|
|
|
|
/* Are we trying to disable a probe that does not have any enabler
|
|
associated? */
|
|
if (m_enablers.empty ())
|
|
error (_("Probe %s:%s cannot be disabled: no enablers."),
|
|
this->get_provider ().c_str (), this->get_name ().c_str ());
|
|
|
|
/* Iterate over all defined enabler in the given probe and disable
|
|
them all using the corresponding gdbarch hook. */
|
|
for (dtrace_probe_enabler &enabler : m_enablers)
|
|
if (gdbarch_dtrace_disable_probe_p (gdbarch))
|
|
gdbarch_dtrace_disable_probe (gdbarch, enabler.address);
|
|
}
|
|
|
|
/* Implementation of the is_linespec method. */
|
|
|
|
bool
|
|
dtrace_static_probe_ops::is_linespec (const char **linespecp) const
|
|
{
|
|
static const char *const keywords[] = { "-pdtrace", "-probe-dtrace", NULL };
|
|
|
|
return probe_is_linespec_by_keyword (linespecp, keywords);
|
|
}
|
|
|
|
/* Implementation of the get_probes method. */
|
|
|
|
void
|
|
dtrace_static_probe_ops::get_probes
|
|
(std::vector<std::unique_ptr<probe>> *probesp,
|
|
struct objfile *objfile) const
|
|
{
|
|
bfd *abfd = objfile->obfd;
|
|
asection *sect = NULL;
|
|
|
|
/* Do nothing in case this is a .debug file, instead of the objfile
|
|
itself. */
|
|
if (objfile->separate_debug_objfile_backlink != NULL)
|
|
return;
|
|
|
|
/* Iterate over the sections in OBJFILE looking for DTrace
|
|
information. */
|
|
for (sect = abfd->sections; sect != NULL; sect = sect->next)
|
|
{
|
|
if (elf_section_data (sect)->this_hdr.sh_type == SHT_SUNW_dof)
|
|
{
|
|
bfd_byte *dof;
|
|
|
|
/* Read the contents of the DOF section and then process it to
|
|
extract the information of any probe defined into it. */
|
|
if (bfd_malloc_and_get_section (abfd, sect, &dof) && dof != NULL)
|
|
dtrace_process_dof (sect, objfile, probesp,
|
|
(struct dtrace_dof_hdr *) dof);
|
|
else
|
|
complaint (_("could not obtain the contents of"
|
|
"section '%s' in objfile `%s'."),
|
|
sect->name, abfd->filename);
|
|
|
|
xfree (dof);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Implementation of the type_name method. */
|
|
|
|
const char *
|
|
dtrace_static_probe_ops::type_name () const
|
|
{
|
|
return "dtrace";
|
|
}
|
|
|
|
/* Implementation of the gen_info_probes_table_header method. */
|
|
|
|
std::vector<struct info_probe_column>
|
|
dtrace_static_probe_ops::gen_info_probes_table_header () const
|
|
{
|
|
struct info_probe_column dtrace_probe_column;
|
|
|
|
dtrace_probe_column.field_name = "enabled";
|
|
dtrace_probe_column.print_name = _("Enabled");
|
|
|
|
return std::vector<struct info_probe_column> { dtrace_probe_column };
|
|
}
|
|
|
|
/* Implementation of the `info probes dtrace' command. */
|
|
|
|
static void
|
|
info_probes_dtrace_command (const char *arg, int from_tty)
|
|
{
|
|
info_probes_for_spops (arg, from_tty, &dtrace_static_probe_ops);
|
|
}
|
|
|
|
void _initialize_dtrace_probe ();
|
|
void
|
|
_initialize_dtrace_probe ()
|
|
{
|
|
all_static_probe_ops.push_back (&dtrace_static_probe_ops);
|
|
|
|
add_cmd ("dtrace", class_info, info_probes_dtrace_command,
|
|
_("\
|
|
Show information about DTrace static probes.\n\
|
|
Usage: info probes dtrace [PROVIDER [NAME [OBJECT]]]\n\
|
|
Each argument is a regular expression, used to select probes.\n\
|
|
PROVIDER matches probe provider names.\n\
|
|
NAME matches the probe names.\n\
|
|
OBJECT matches the executable or shared library name."),
|
|
info_probes_cmdlist_get ());
|
|
}
|